99789 2012-10-18 18:20:37 -0700 Deque can use std::reverse_iterator for its reverse iterators 2012-10-19 10:43:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin darin webkit.review.bot oldest_to_newest 745844 0 andersca 2012-10-18 18:20:37 -0700 Deque can use std::reverse_iterator for its reverse iterators 745845 1 169526 andersca 2012-10-18 18:22:24 -0700 Created attachment 169526 Patch 745851 2 webkit.review.bot 2012-10-18 18:25:29 -0700 Attachment 169526 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/De..." exit_code: 1 Source/WTF/wtf/Deque.h:52: reverse_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:53: const_reverse_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:160: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:164: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:191: difference_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/Deque.h:195: iterator_category is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 746436 3 169526 webkit.review.bot 2012-10-19 10:43:15 -0700 Comment on attachment 169526 Patch Clearing flags on attachment: 169526 Committed r131920: <http://trac.webkit.org/changeset/131920> 746437 4 webkit.review.bot 2012-10-19 10:43:18 -0700 All reviewed patches have been landed. Closing bug. 169526 2012-10-18 18:22:24 -0700 2012-10-19 10:43:15 -0700 Patch bug-99789-20121018182109.patch text/plain 10394 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdiMTg1OTdlMDNhZDk4OTU3NmY3MmQw NGJkZmFhMWEwM2M2YTRjZTMuLmNiMmVmZjc0MGNmNTM2MzNjYTg3NDMyMWIzYWFhY2JmMjAzNTRi MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTItMTAtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBEZXF1ZSBjYW4gdXNlIHN0ZDo6cmV2ZXJzZV9p dGVyYXRvciBmb3IgaXRzIHJldmVyc2UgaXRlcmF0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBEZXF1ZVJldmVyc2VJdGVyYXRvciBhbmQg RGVxdWVDb25zdFJldmVyc2VJdGVyYXRvciBhbmQganVzdCB1c2Ugc3RkOjpyZXZlcnNlX2l0ZXJh dG9yIGRpcmVjdGx5LgorICAgICAgICBBbHNvLCByZW1vdmUgdGhlIERlcXVlSXRlcmF0b3JCYXNl PFQsIGlubGluZUNhcGFjaXR5PiB0byBCYXNlIHR5cGVkZWYgLSBXZSBjYW4gYWxyZWFkeSB1c2Ug RGVxdWVJdGVyYXRvckJhc2Ugc2luY2UgaXQncworICAgICAgICBlcXVpdmFsZW50IHRvIHRoZSBm dWxsIGNsYXNzIHRlbXBsYXRlIHR5cGUuCisKKyAgICAgICAgKiB3dGYvRGVxdWUuaDoKKyAgICAg ICAgKFdURjo6RGVxdWU6OnJiZWdpbik6CisgICAgICAgIChXVEY6OkRlcXVlOjpyZW5kKToKKyAg ICAgICAgKERlcXVlSXRlcmF0b3JCYXNlKToKKyAgICAgICAgKFdURjo6RGVxdWVJdGVyYXRvckJh c2U6OmFzc2lnbik6CisgICAgICAgIChEZXF1ZUl0ZXJhdG9yKToKKyAgICAgICAgKERlcXVlQ29u c3RJdGVyYXRvcik6CisgICAgICAgIChXVEY6Ojo6Y2hlY2tWYWxpZGl0eSk6CisgICAgICAgIChX VEY6Ojo6RGVxdWVJdGVyYXRvckJhc2UpOgorICAgICAgICAoV1RGOjo9KToKKyAgICAgICAgKFdU Rjo6Ojppc0VxdWFsKToKKwogMjAxMi0xMC0xOCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICBNYWMgV1RGIGJ1aWxkIGNoZWNrcyBkZXBlbmRlbmNpZXMgYmVm b3JlIGNvcHlpbmcgaGVhZGVyIGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9EZXF1 ZS5oIGIvU291cmNlL1dURi93dGYvRGVxdWUuaAppbmRleCBiZTY5YzgxZGIzYzhlNDgzZGJhNGUw OWE1NjU0NTAzNjg3ZTNlYzgxLi5lNWM0N2I2M2UxZGJiYTI0YjIxYTVlZjRhNjY4YWI0YTFkNWYz OWIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9EZXF1ZS5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL0RlcXVlLmgKQEAgLTMzLDYgKzMzLDcgQEAKIC8vIEZJWE1FOiBDb3VsZCBtb3ZlIHdoYXQg VmVjdG9yIGFuZCBEZXF1ZSBzaGFyZSBpbnRvIGEgc2VwYXJhdGUgZmlsZS4KIC8vIERlcXVlIGRv ZXNuJ3QgYWN0dWFsbHkgdXNlIFZlY3Rvci4KIAorI2luY2x1ZGUgPGl0ZXJhdG9yPgogI2luY2x1 ZGUgPHd0Zi9QYXNzVHJhaXRzLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCkBAIC00MSw4 ICs0Miw2IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVf dCBpbmxpbmVDYXBhY2l0eT4gY2xhc3MgRGVxdWVJdGVyYXRvckJhc2U7CiAgICAgdGVtcGxhdGU8 dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PiBjbGFzcyBEZXF1ZUl0ZXJhdG9yOwog ICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0eT4gY2xhc3MgRGVx dWVDb25zdEl0ZXJhdG9yOwotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVD YXBhY2l0eT4gY2xhc3MgRGVxdWVSZXZlcnNlSXRlcmF0b3I7Ci0gICAgdGVtcGxhdGU8dHlwZW5h bWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5PiBjbGFzcyBEZXF1ZUNvbnN0UmV2ZXJzZUl0ZXJh dG9yOwogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFjaXR5ID0g MD4KICAgICBjbGFzcyBEZXF1ZSB7CkBAIC01MCw4ICs0OSw4IEBAIG5hbWVzcGFjZSBXVEYgewog ICAgIHB1YmxpYzoKICAgICAgICAgdHlwZWRlZiBEZXF1ZUl0ZXJhdG9yPFQsIGlubGluZUNhcGFj aXR5PiBpdGVyYXRvcjsKICAgICAgICAgdHlwZWRlZiBEZXF1ZUNvbnN0SXRlcmF0b3I8VCwgaW5s aW5lQ2FwYWNpdHk+IGNvbnN0X2l0ZXJhdG9yOwotICAgICAgICB0eXBlZGVmIERlcXVlUmV2ZXJz ZUl0ZXJhdG9yPFQsIGlubGluZUNhcGFjaXR5PiByZXZlcnNlX2l0ZXJhdG9yOwotICAgICAgICB0 eXBlZGVmIERlcXVlQ29uc3RSZXZlcnNlSXRlcmF0b3I8VCwgaW5saW5lQ2FwYWNpdHk+IGNvbnN0 X3JldmVyc2VfaXRlcmF0b3I7CisgICAgICAgIHR5cGVkZWYgc3RkOjpyZXZlcnNlX2l0ZXJhdG9y PGl0ZXJhdG9yPiByZXZlcnNlX2l0ZXJhdG9yOworICAgICAgICB0eXBlZGVmIHN0ZDo6cmV2ZXJz ZV9pdGVyYXRvcjxjb25zdF9pdGVyYXRvcj4gY29uc3RfcmV2ZXJzZV9pdGVyYXRvcjsKICAgICAg ICAgdHlwZWRlZiBQYXNzVHJhaXRzPFQ+IFBhc3M7CiAgICAgICAgIHR5cGVkZWYgdHlwZW5hbWUg UGFzc1RyYWl0czxUPjo6UGFzc1R5cGUgUGFzc1R5cGU7CiAKQEAgLTY5LDEwICs2OCwxMCBAQCBu YW1lc3BhY2UgV1RGIHsKICAgICAgICAgaXRlcmF0b3IgZW5kKCkgeyByZXR1cm4gaXRlcmF0b3Io dGhpcywgbV9lbmQpOyB9CiAgICAgICAgIGNvbnN0X2l0ZXJhdG9yIGJlZ2luKCkgY29uc3QgeyBy ZXR1cm4gY29uc3RfaXRlcmF0b3IodGhpcywgbV9zdGFydCk7IH0KICAgICAgICAgY29uc3RfaXRl cmF0b3IgZW5kKCkgY29uc3QgeyByZXR1cm4gY29uc3RfaXRlcmF0b3IodGhpcywgbV9lbmQpOyB9 Ci0gICAgICAgIHJldmVyc2VfaXRlcmF0b3IgcmJlZ2luKCkgeyByZXR1cm4gcmV2ZXJzZV9pdGVy YXRvcih0aGlzLCBtX2VuZCk7IH0KLSAgICAgICAgcmV2ZXJzZV9pdGVyYXRvciByZW5kKCkgeyBy ZXR1cm4gcmV2ZXJzZV9pdGVyYXRvcih0aGlzLCBtX3N0YXJ0KTsgfQotICAgICAgICBjb25zdF9y ZXZlcnNlX2l0ZXJhdG9yIHJiZWdpbigpIGNvbnN0IHsgcmV0dXJuIGNvbnN0X3JldmVyc2VfaXRl cmF0b3IodGhpcywgbV9lbmQpOyB9Ci0gICAgICAgIGNvbnN0X3JldmVyc2VfaXRlcmF0b3IgcmVu ZCgpIGNvbnN0IHsgcmV0dXJuIGNvbnN0X3JldmVyc2VfaXRlcmF0b3IodGhpcywgbV9zdGFydCk7 IH0KKyAgICAgICAgcmV2ZXJzZV9pdGVyYXRvciByYmVnaW4oKSB7IHJldHVybiByZXZlcnNlX2l0 ZXJhdG9yKGVuZCgpKTsgfQorICAgICAgICByZXZlcnNlX2l0ZXJhdG9yIHJlbmQoKSB7IHJldHVy biByZXZlcnNlX2l0ZXJhdG9yKGJlZ2luKCkpOyB9CisgICAgICAgIGNvbnN0X3JldmVyc2VfaXRl cmF0b3IgcmJlZ2luKCkgY29uc3QgeyByZXR1cm4gY29uc3RfcmV2ZXJzZV9pdGVyYXRvcihlbmQo KSk7IH0KKyAgICAgICAgY29uc3RfcmV2ZXJzZV9pdGVyYXRvciByZW5kKCkgY29uc3QgeyByZXR1 cm4gY29uc3RfcmV2ZXJzZV9pdGVyYXRvcihiZWdpbigpKTsgfQogCiAgICAgICAgIFQmIGZpcnN0 KCkgeyBBU1NFUlQobV9zdGFydCAhPSBtX2VuZCk7IHJldHVybiBtX2J1ZmZlci5idWZmZXIoKVtt X3N0YXJ0XTsgfQogICAgICAgICBjb25zdCBUJiBmaXJzdCgpIGNvbnN0IHsgQVNTRVJUKG1fc3Rh cnQgIT0gbV9lbmQpOyByZXR1cm4gbV9idWZmZXIuYnVmZmVyKClbbV9zdGFydF07IH0KQEAgLTEx NywxNyArMTE2LDE0IEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUg VCwgc2l6ZV90IGlubGluZUNhcGFjaXR5ID0gMD4KICAgICBjbGFzcyBEZXF1ZUl0ZXJhdG9yQmFz ZSB7Ci0gICAgcHJpdmF0ZToKLSAgICAgICAgdHlwZWRlZiBEZXF1ZUl0ZXJhdG9yQmFzZTxULCBp bmxpbmVDYXBhY2l0eT4gQmFzZTsKLQogICAgIHByb3RlY3RlZDoKICAgICAgICAgRGVxdWVJdGVy YXRvckJhc2UoKTsKICAgICAgICAgRGVxdWVJdGVyYXRvckJhc2UoY29uc3QgRGVxdWU8VCwgaW5s aW5lQ2FwYWNpdHk+Kiwgc2l6ZV90KTsKLSAgICAgICAgRGVxdWVJdGVyYXRvckJhc2UoY29uc3Qg QmFzZSYpOwotICAgICAgICBCYXNlJiBvcGVyYXRvcj0oY29uc3QgQmFzZSYpOworICAgICAgICBE ZXF1ZUl0ZXJhdG9yQmFzZShjb25zdCBEZXF1ZUl0ZXJhdG9yQmFzZSYpOworICAgICAgICBEZXF1 ZUl0ZXJhdG9yQmFzZSYgb3BlcmF0b3I9KGNvbnN0IERlcXVlSXRlcmF0b3JCYXNlJik7CiAgICAg ICAgIH5EZXF1ZUl0ZXJhdG9yQmFzZSgpOwogCi0gICAgICAgIHZvaWQgYXNzaWduKGNvbnN0IEJh c2UmIG90aGVyKSB7ICp0aGlzID0gb3RoZXI7IH0KKyAgICAgICAgdm9pZCBhc3NpZ24oY29uc3Qg RGVxdWVJdGVyYXRvckJhc2UmIG90aGVyKSB7ICp0aGlzID0gb3RoZXI7IH0KIAogICAgICAgICB2 b2lkIGluY3JlbWVudCgpOwogICAgICAgICB2b2lkIGRlY3JlbWVudCgpOwpAQCAtMTM1LDEzICsx MzEsMTMgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIFQqIGJlZm9yZSgpIGNvbnN0OwogICAg ICAgICBUKiBhZnRlcigpIGNvbnN0OwogCi0gICAgICAgIGJvb2wgaXNFcXVhbChjb25zdCBCYXNl JikgY29uc3Q7CisgICAgICAgIGJvb2wgaXNFcXVhbChjb25zdCBEZXF1ZUl0ZXJhdG9yQmFzZSYp IGNvbnN0OwogCiAgICAgcHJpdmF0ZToKICAgICAgICAgdm9pZCBhZGRUb0l0ZXJhdG9yc0xpc3Qo KTsKICAgICAgICAgdm9pZCByZW1vdmVGcm9tSXRlcmF0b3JzTGlzdCgpOwogICAgICAgICB2b2lk IGNoZWNrVmFsaWRpdHkoKSBjb25zdDsKLSAgICAgICAgdm9pZCBjaGVja1ZhbGlkaXR5KGNvbnN0 IEJhc2UmKSBjb25zdDsKKyAgICAgICAgdm9pZCBjaGVja1ZhbGlkaXR5KGNvbnN0IERlcXVlSXRl cmF0b3JCYXNlJikgY29uc3Q7CiAKICAgICAgICAgRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+KiBt X2RlcXVlOwogICAgICAgICBzaXplX3QgbV9pbmRleDsKQEAgLTE2MSw2ICsxNTcsMTIgQEAgbmFt ZXNwYWNlIFdURiB7CiAgICAgICAgIHR5cGVkZWYgRGVxdWVJdGVyYXRvcjxULCBpbmxpbmVDYXBh Y2l0eT4gSXRlcmF0b3I7CiAKICAgICBwdWJsaWM6CisgICAgICAgIHR5cGVkZWYgcHRyZGlmZl90 IGRpZmZlcmVuY2VfdHlwZTsKKyAgICAgICAgdHlwZWRlZiBUIHZhbHVlX3R5cGU7CisgICAgICAg IHR5cGVkZWYgVCogcG9pbnRlcjsKKyAgICAgICAgdHlwZWRlZiBUJiByZWZlcmVuY2U7CisgICAg ICAgIHR5cGVkZWYgc3RkOjpiaWRpcmVjdGlvbmFsX2l0ZXJhdG9yX3RhZyBpdGVyYXRvcl9jYXRl Z29yeTsKKwogICAgICAgICBEZXF1ZUl0ZXJhdG9yKERlcXVlPFQsIGlubGluZUNhcGFjaXR5Piog ZGVxdWUsIHNpemVfdCBpbmRleCkgOiBCYXNlKGRlcXVlLCBpbmRleCkgeyB9CiAKICAgICAgICAg RGVxdWVJdGVyYXRvcihjb25zdCBJdGVyYXRvciYgb3RoZXIpIDogQmFzZShvdGhlcikgeyB9CkBA IC0xODYsNiArMTg4LDEyIEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICB0eXBlZGVmIERlcXVl SXRlcmF0b3I8VCwgaW5saW5lQ2FwYWNpdHk+IE5vbkNvbnN0SXRlcmF0b3I7CiAKICAgICBwdWJs aWM6CisgICAgICAgIHR5cGVkZWYgcHRyZGlmZl90IGRpZmZlcmVuY2VfdHlwZTsKKyAgICAgICAg dHlwZWRlZiBUIHZhbHVlX3R5cGU7CisgICAgICAgIHR5cGVkZWYgY29uc3QgVCogcG9pbnRlcjsK KyAgICAgICAgdHlwZWRlZiBjb25zdCBUJiByZWZlcmVuY2U7CisgICAgICAgIHR5cGVkZWYgc3Rk OjpiaWRpcmVjdGlvbmFsX2l0ZXJhdG9yX3RhZyBpdGVyYXRvcl9jYXRlZ29yeTsKKwogICAgICAg ICBEZXF1ZUNvbnN0SXRlcmF0b3IoY29uc3QgRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+KiBkZXF1 ZSwgc2l6ZV90IGluZGV4KSA6IEJhc2UoZGVxdWUsIGluZGV4KSB7IH0KIAogICAgICAgICBEZXF1 ZUNvbnN0SXRlcmF0b3IoY29uc3QgSXRlcmF0b3ImIG90aGVyKSA6IEJhc2Uob3RoZXIpIHsgfQpA QCAtMjA1LDU3ICsyMTMsNiBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgLy8gcG9zdGZpeCAt LSBpbnRlbnRpb25hbGx5IG9taXR0ZWQKICAgICB9OwogCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUg VCwgc2l6ZV90IGlubGluZUNhcGFjaXR5ID0gMD4KLSAgICBjbGFzcyBEZXF1ZVJldmVyc2VJdGVy YXRvciA6IHB1YmxpYyBEZXF1ZUl0ZXJhdG9yQmFzZTxULCBpbmxpbmVDYXBhY2l0eT4gewotICAg IHByaXZhdGU6Ci0gICAgICAgIHR5cGVkZWYgRGVxdWVJdGVyYXRvckJhc2U8VCwgaW5saW5lQ2Fw YWNpdHk+IEJhc2U7Ci0gICAgICAgIHR5cGVkZWYgRGVxdWVSZXZlcnNlSXRlcmF0b3I8VCwgaW5s aW5lQ2FwYWNpdHk+IEl0ZXJhdG9yOwotCi0gICAgcHVibGljOgotICAgICAgICBEZXF1ZVJldmVy c2VJdGVyYXRvcihjb25zdCBEZXF1ZTxULCBpbmxpbmVDYXBhY2l0eT4qIGRlcXVlLCBzaXplX3Qg aW5kZXgpIDogQmFzZShkZXF1ZSwgaW5kZXgpIHsgfQotCi0gICAgICAgIERlcXVlUmV2ZXJzZUl0 ZXJhdG9yKGNvbnN0IEl0ZXJhdG9yJiBvdGhlcikgOiBCYXNlKG90aGVyKSB7IH0KLSAgICAgICAg RGVxdWVSZXZlcnNlSXRlcmF0b3ImIG9wZXJhdG9yPShjb25zdCBJdGVyYXRvciYgb3RoZXIpIHsg QmFzZTo6YXNzaWduKG90aGVyKTsgcmV0dXJuICp0aGlzOyB9Ci0KLSAgICAgICAgVCYgb3BlcmF0 b3IqKCkgY29uc3QgeyByZXR1cm4gKkJhc2U6OmJlZm9yZSgpOyB9Ci0gICAgICAgIFQqIG9wZXJh dG9yLT4oKSBjb25zdCB7IHJldHVybiBCYXNlOjpiZWZvcmUoKTsgfQotCi0gICAgICAgIGJvb2wg b3BlcmF0b3I9PShjb25zdCBJdGVyYXRvciYgb3RoZXIpIGNvbnN0IHsgcmV0dXJuIEJhc2U6Omlz RXF1YWwob3RoZXIpOyB9Ci0gICAgICAgIGJvb2wgb3BlcmF0b3IhPShjb25zdCBJdGVyYXRvciYg b3RoZXIpIGNvbnN0IHsgcmV0dXJuICFCYXNlOjppc0VxdWFsKG90aGVyKTsgfQotCi0gICAgICAg IEl0ZXJhdG9yJiBvcGVyYXRvcisrKCkgeyBCYXNlOjpkZWNyZW1lbnQoKTsgcmV0dXJuICp0aGlz OyB9Ci0gICAgICAgIC8vIHBvc3RmaXggKysgaW50ZW50aW9uYWxseSBvbWl0dGVkCi0gICAgICAg IEl0ZXJhdG9yJiBvcGVyYXRvci0tKCkgeyBCYXNlOjppbmNyZW1lbnQoKTsgcmV0dXJuICp0aGlz OyB9Ci0gICAgICAgIC8vIHBvc3RmaXggLS0gaW50ZW50aW9uYWxseSBvbWl0dGVkCi0gICAgfTsK LQotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0eSA9IDA+Ci0g ICAgY2xhc3MgRGVxdWVDb25zdFJldmVyc2VJdGVyYXRvciA6IHB1YmxpYyBEZXF1ZUl0ZXJhdG9y QmFzZTxULCBpbmxpbmVDYXBhY2l0eT4gewotICAgIHByaXZhdGU6Ci0gICAgICAgIHR5cGVkZWYg RGVxdWVJdGVyYXRvckJhc2U8VCwgaW5saW5lQ2FwYWNpdHk+IEJhc2U7Ci0gICAgICAgIHR5cGVk ZWYgRGVxdWVDb25zdFJldmVyc2VJdGVyYXRvcjxULCBpbmxpbmVDYXBhY2l0eT4gSXRlcmF0b3I7 Ci0gICAgICAgIHR5cGVkZWYgRGVxdWVSZXZlcnNlSXRlcmF0b3I8VCwgaW5saW5lQ2FwYWNpdHk+ IE5vbkNvbnN0SXRlcmF0b3I7Ci0KLSAgICBwdWJsaWM6Ci0gICAgICAgIERlcXVlQ29uc3RSZXZl cnNlSXRlcmF0b3IoY29uc3QgRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+KiBkZXF1ZSwgc2l6ZV90 IGluZGV4KSA6IEJhc2UoZGVxdWUsIGluZGV4KSB7IH0KLQotICAgICAgICBEZXF1ZUNvbnN0UmV2 ZXJzZUl0ZXJhdG9yKGNvbnN0IEl0ZXJhdG9yJiBvdGhlcikgOiBCYXNlKG90aGVyKSB7IH0KLSAg ICAgICAgRGVxdWVDb25zdFJldmVyc2VJdGVyYXRvcihjb25zdCBOb25Db25zdEl0ZXJhdG9yJiBv dGhlcikgOiBCYXNlKG90aGVyKSB7IH0KLSAgICAgICAgRGVxdWVDb25zdFJldmVyc2VJdGVyYXRv ciYgb3BlcmF0b3I9KGNvbnN0IEl0ZXJhdG9yJiBvdGhlcikgeyBCYXNlOjphc3NpZ24ob3RoZXIp OyByZXR1cm4gKnRoaXM7IH0KLSAgICAgICAgRGVxdWVDb25zdFJldmVyc2VJdGVyYXRvciYgb3Bl cmF0b3I9KGNvbnN0IE5vbkNvbnN0SXRlcmF0b3ImIG90aGVyKSB7IEJhc2U6OmFzc2lnbihvdGhl cik7IHJldHVybiAqdGhpczsgfQotCi0gICAgICAgIGNvbnN0IFQmIG9wZXJhdG9yKigpIGNvbnN0 IHsgcmV0dXJuICpCYXNlOjpiZWZvcmUoKTsgfQotICAgICAgICBjb25zdCBUKiBvcGVyYXRvci0+ KCkgY29uc3QgeyByZXR1cm4gQmFzZTo6YmVmb3JlKCk7IH0KLQotICAgICAgICBib29sIG9wZXJh dG9yPT0oY29uc3QgSXRlcmF0b3ImIG90aGVyKSBjb25zdCB7IHJldHVybiBCYXNlOjppc0VxdWFs KG90aGVyKTsgfQotICAgICAgICBib29sIG9wZXJhdG9yIT0oY29uc3QgSXRlcmF0b3ImIG90aGVy KSBjb25zdCB7IHJldHVybiAhQmFzZTo6aXNFcXVhbChvdGhlcik7IH0KLQotICAgICAgICBJdGVy YXRvciYgb3BlcmF0b3IrKygpIHsgQmFzZTo6ZGVjcmVtZW50KCk7IHJldHVybiAqdGhpczsgfQot ICAgICAgICAvLyBwb3N0Zml4ICsrIGludGVudGlvbmFsbHkgb21pdHRlZAotICAgICAgICBJdGVy YXRvciYgb3BlcmF0b3ItLSgpIHsgQmFzZTo6aW5jcmVtZW50KCk7IHJldHVybiAqdGhpczsgfQot ICAgICAgICAvLyBwb3N0Zml4IC0tIGludGVudGlvbmFsbHkgb21pdHRlZAotICAgIH07Ci0KICNp ZmRlZiBOREVCVUcKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXplX3QgaW5saW5lQ2FwYWNp dHk+IGlubGluZSB2b2lkIERlcXVlPFQsIGlubGluZUNhcGFjaXR5Pjo6Y2hlY2tWYWxpZGl0eSgp IGNvbnN0IHsgfQogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0 eT4gaW5saW5lIHZvaWQgRGVxdWU8VCwgaW5saW5lQ2FwYWNpdHk+OjpjaGVja0luZGV4VmFsaWRp dHkoc2l6ZV90KSBjb25zdCB7IH0KQEAgLTU0MCw3ICs0OTcsNyBAQCBuYW1lc3BhY2UgV1RGIHsK ICAgICB9CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXplX3QgaW5saW5lQ2FwYWNpdHk+ Ci0gICAgdm9pZCBEZXF1ZUl0ZXJhdG9yQmFzZTxULCBpbmxpbmVDYXBhY2l0eT46OmNoZWNrVmFs aWRpdHkoY29uc3QgQmFzZSYgb3RoZXIpIGNvbnN0CisgICAgdm9pZCBEZXF1ZUl0ZXJhdG9yQmFz ZTxULCBpbmxpbmVDYXBhY2l0eT46OmNoZWNrVmFsaWRpdHkoY29uc3QgRGVxdWVJdGVyYXRvckJh c2UmIG90aGVyKSBjb25zdAogICAgIHsKICAgICAgICAgY2hlY2tWYWxpZGl0eSgpOwogICAgICAg ICBvdGhlci5jaGVja1ZhbGlkaXR5KCk7CkBAIC02MDIsNyArNTU5LDcgQEAgbmFtZXNwYWNlIFdU RiB7CiAgICAgfQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVCwgc2l6ZV90IGlubGluZUNhcGFj aXR5PgotICAgIGlubGluZSBEZXF1ZUl0ZXJhdG9yQmFzZTxULCBpbmxpbmVDYXBhY2l0eT46OkRl cXVlSXRlcmF0b3JCYXNlKGNvbnN0IEJhc2UmIG90aGVyKQorICAgIGlubGluZSBEZXF1ZUl0ZXJh dG9yQmFzZTxULCBpbmxpbmVDYXBhY2l0eT46OkRlcXVlSXRlcmF0b3JCYXNlKGNvbnN0IERlcXVl SXRlcmF0b3JCYXNlJiBvdGhlcikKICAgICAgICAgOiBtX2RlcXVlKG90aGVyLm1fZGVxdWUpCiAg ICAgICAgICwgbV9pbmRleChvdGhlci5tX2luZGV4KQogICAgIHsKQEAgLTYxMSw3ICs1NjgsNyBA QCBuYW1lc3BhY2UgV1RGIHsKICAgICB9CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBULCBzaXpl X3QgaW5saW5lQ2FwYWNpdHk+Ci0gICAgaW5saW5lIERlcXVlSXRlcmF0b3JCYXNlPFQsIGlubGlu ZUNhcGFjaXR5PiYgRGVxdWVJdGVyYXRvckJhc2U8VCwgaW5saW5lQ2FwYWNpdHk+OjpvcGVyYXRv cj0oY29uc3QgQmFzZSYgb3RoZXIpCisgICAgaW5saW5lIERlcXVlSXRlcmF0b3JCYXNlPFQsIGlu bGluZUNhcGFjaXR5PiYgRGVxdWVJdGVyYXRvckJhc2U8VCwgaW5saW5lQ2FwYWNpdHk+OjpvcGVy YXRvcj0oY29uc3QgRGVxdWVJdGVyYXRvckJhc2UmIG90aGVyKQogICAgIHsKICAgICAgICAgb3Ro ZXIuY2hlY2tWYWxpZGl0eSgpOwogICAgICAgICByZW1vdmVGcm9tSXRlcmF0b3JzTGlzdCgpOwpA QCAtNjMzLDcgKzU5MCw3IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIH0KIAogICAgIHRlbXBsYXRl PHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0eT4KLSAgICBpbmxpbmUgYm9vbCBEZXF1 ZUl0ZXJhdG9yQmFzZTxULCBpbmxpbmVDYXBhY2l0eT46OmlzRXF1YWwoY29uc3QgQmFzZSYgb3Ro ZXIpIGNvbnN0CisgICAgaW5saW5lIGJvb2wgRGVxdWVJdGVyYXRvckJhc2U8VCwgaW5saW5lQ2Fw YWNpdHk+Ojppc0VxdWFsKGNvbnN0IERlcXVlSXRlcmF0b3JCYXNlJiBvdGhlcikgY29uc3QKICAg ICB7CiAgICAgICAgIGNoZWNrVmFsaWRpdHkob3RoZXIpOwogICAgICAgICByZXR1cm4gbV9pbmRl eCA9PSBvdGhlci5tX2luZGV4Owo=