99781 2012-10-18 17:43:52 -0700 Skia ImageDecoder doesn't set m_hasAlpha in copyBitmapData() 2012-10-18 18:02:39 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pkasting pkasting webkit.review.bot oldest_to_newest 745787 0 pkasting 2012-10-18 17:43:52 -0700 The underlying SkBitmap has the "is opaque" bit set correctly, but the ImageFrame member isn't updated correctly. This leads to occasional glitchiness like http://crbug.com/156526 . This wasn't exposed until recently because Skia used to erroneously treat all images as non-opaque. 745791 1 169516 pkasting 2012-10-18 17:45:05 -0700 Created attachment 169516 patch v1 745800 2 169516 abarth 2012-10-18 17:48:10 -0700 Comment on attachment 169516 patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=169516&action=review > Source/WebCore/ChangeLog:9 > + No tests, since the actual effects of this bug are fickle and it's not > + clear how to extract and check particular subframes of an animated GIF. Frowns. 745801 3 webkit.review.bot 2012-10-18 17:49:06 -0700 Attachment 169516 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 745808 4 169520 pkasting 2012-10-18 17:54:25 -0700 Created attachment 169520 patch v1.1 If I have to update the patch anyway, I'll just go ahead and land... 745817 5 pkasting 2012-10-18 18:02:39 -0700 Fixed in r131831. 169516 2012-10-18 17:45:05 -0700 2012-10-18 17:54:25 -0700 patch v1 patch text/plain 1492 pkasting SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTgyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE4ICBQZXRlciBL YXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KKworICAgICAgICBbU2tpYV0gU2V0IG1faGFz QWxwaGEgY29ycmVjdGx5IGluIEltYWdlRnJhbWU6OmNvcHlCaXRtYXBEYXRhLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk3ODEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0cywgc2luY2UgdGhl IGFjdHVhbCBlZmZlY3RzIG9mIHRoaXMgYnVnIGFyZSBmaWNrbGUgYW5kIGl0J3Mgbm90CisJCWNs ZWFyIGhvdyB0byBleHRyYWN0IGFuZCBjaGVjayBwYXJ0aWN1bGFyIHN1YmZyYW1lcyBvZiBhbiBh bmltYXRlZCBHSUYuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9za2lhL0lt YWdlRGVjb2RlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VGcmFtZTo6Y29weUJp dG1hcERhdGEpOgorCiAyMDEyLTEwLTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEzMDQxMSk6IENvcHlpbmcgJiBwYXN0aW5nIHRoZSBm aXJzdCBsaW5lIG9mIHRleHQgY2FuIG1vdmUgY2FyZXQgdG8gdGhlIGVuZCBvZiB0ZXh0IGFyZWEK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3NraWEvSW1hZ2VE ZWNvZGVyU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvc2tpYS9JbWFnZURlY29kZXJTa2lhLmNwcAkocmV2aXNpb24gMTMxODIzKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvc2tpYS9JbWFnZURlY29k ZXJTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODEsNiArODEsNyBAQCBib29sIEltYWdlRnJh bWU6OmNvcHlCaXRtYXBEYXRhKGNvbnN0IEltCiAgICAgaWYgKHRoaXMgPT0gJm90aGVyKQogICAg ICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIG1faGFzQWxwaGEgPSBvdGhlci5tX2hhc0FscGhhOwog ICAgIG1fYml0bWFwLmJpdG1hcCgpLnJlc2V0KCk7CiAgICAgY29uc3QgTmF0aXZlSW1hZ2VTa2lh JiBvdGhlckJpdG1hcCA9IG90aGVyLm1fYml0bWFwOwogICAgIHJldHVybiBvdGhlckJpdG1hcC5i aXRtYXAoKS5jb3B5VG8oJm1fYml0bWFwLmJpdG1hcCgpLCBvdGhlckJpdG1hcC5iaXRtYXAoKS5j b25maWcoKSk7Cg== 169520 2012-10-18 17:54:25 -0700 2012-10-18 17:54:25 -0700 patch v1.1 patch text/plain 1494 pkasting SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTgyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE4ICBQZXRlciBL YXN0aW5nICA8cGthc3RpbmdAZ29vZ2xlLmNvbT4KKworICAgICAgICBbU2tpYV0gU2V0IG1faGFz QWxwaGEgY29ycmVjdGx5IGluIEltYWdlRnJhbWU6OmNvcHlCaXRtYXBEYXRhLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk3ODEKKworICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIE5vIHRlc3RzLCBzaW5jZSB0aGUgYWN0 dWFsIGVmZmVjdHMgb2YgdGhpcyBidWcgYXJlIGZpY2tsZSBhbmQgaXQncyBub3QKKyAgICAgICAg Y2xlYXIgaG93IHRvIGV4dHJhY3QgYW5kIGNoZWNrIHBhcnRpY3VsYXIgc3ViZnJhbWVzIG9mIGFu IGFuaW1hdGVkIEdJRi4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3NraWEv SW1hZ2VEZWNvZGVyU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUZyYW1lOjpjb3B5 Qml0bWFwRGF0YSk6CisKIDIwMTItMTAtMTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTMwNDExKTogQ29weWluZyAmIHBhc3RpbmcgdGhl IGZpcnN0IGxpbmUgb2YgdGV4dCBjYW4gbW92ZSBjYXJldCB0byB0aGUgZW5kIG9mIHRleHQgYXJl YQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvc2tpYS9JbWFn ZURlY29kZXJTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3BwCShyZXZpc2lvbiAxMzE4MjMp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9za2lhL0ltYWdlRGVj b2RlclNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MSw2ICs4MSw3IEBAIGJvb2wgSW1hZ2VG cmFtZTo6Y29weUJpdG1hcERhdGEoY29uc3QgSW0KICAgICBpZiAodGhpcyA9PSAmb3RoZXIpCiAg ICAgICAgIHJldHVybiB0cnVlOwogCisgICAgbV9oYXNBbHBoYSA9IG90aGVyLm1faGFzQWxwaGE7 CiAgICAgbV9iaXRtYXAuYml0bWFwKCkucmVzZXQoKTsKICAgICBjb25zdCBOYXRpdmVJbWFnZVNr aWEmIG90aGVyQml0bWFwID0gb3RoZXIubV9iaXRtYXA7CiAgICAgcmV0dXJuIG90aGVyQml0bWFw LmJpdG1hcCgpLmNvcHlUbygmbV9iaXRtYXAuYml0bWFwKCksIG90aGVyQml0bWFwLmJpdG1hcCgp LmNvbmZpZygpKTsK