99778 2012-10-18 17:13:54 -0700 Automatically start plugins created within a user gesture, skipping snapshotting 2012-10-18 22:36:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cmuppala cmuppala beidson jonlee webkit-bug-importer webkit.review.bot oldest_to_newest 745761 0 cmuppala 2012-10-18 17:13:54 -0700 When plugin snapshotting is enabled, a snapshot of the plugin is displayed until the user clicks on the plugin. However, on some sites such as cnn.com, use an image element as a placeholder for a video and replace the image with the video when the user clicks on it. In such instances, plugin snapshotting results in the user having to click twice to watch the video. This is undesirable. Hence, plugins should start automatically when created within a user gesture, even if snapshotting is enabled. 745773 1 169512 cmuppala 2012-10-18 17:25:49 -0700 Created attachment 169512 Patch 745775 2 cmuppala 2012-10-18 17:26:19 -0700 <rdar://problem/12482210> 745788 3 jonlee 2012-10-18 17:44:28 -0700 Have you been able to test this? I am not a reviewer, but I give it an unofficial r+. 745797 4 cmuppala 2012-10-18 17:47:39 -0700 (In reply to comment #3) > Have you been able to test this? > > I am not a reviewer, but I give it an unofficial r+. Yes, I tested using cnn.com, which tends to have a "Click to Play" image element in the center, like you showed before. The video started playing right after I clicked the image, without the interim plugin snapshot. 745983 5 169512 webkit.review.bot 2012-10-18 22:36:10 -0700 Comment on attachment 169512 Patch Clearing flags on attachment: 169512 Committed r131857: <http://trac.webkit.org/changeset/131857> 745984 6 webkit.review.bot 2012-10-18 22:36:14 -0700 All reviewed patches have been landed. Closing bug. 169512 2012-10-18 17:25:49 -0700 2012-10-18 22:36:10 -0700 Patch bug-99778-20121018172433.patch text/plain 1757 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzlkZTA2NzU3MWE3NTBl ZWM1YmRmNDQzZjM4NzRkOTJhOTIyODQ1Yi4uOGE3YTc4N2M5OTMwMzNkZGQ3OGU2MmJkMDM1ODcx OGRkM2UxOTc1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTE4ICBLaXJh biBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgorCisgICAgICAgIEF1dG9tYXRpY2FsbHkg c3RhcnQgcGx1Z2lucyBjcmVhdGVkIHdpdGhpbiBhIHVzZXIgZ2VzdHVyZSwgc2tpcHBpbmcgc25h cHNob3R0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05OTc3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIGEgdXNlciBnZXN0dXJlIGlzIGJlaW5nIHByb2Nlc3NlZCwgZG8gbm90IHNldCB0aGUgZGlz cGxheSBzdGF0ZSBvZgorICAgICAgICBIVE1MUGx1Z2luSW1hZ2VFbGVtZW50IHRvIFdhaXRpbmdG b3JTbmFwc2hvdC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIGl0IG9ubHkgYWZmZWN0 cyB3aGVuIHBsdWdpbnMgc3dpdGNoIGZyb20gc25hcHNob3QgdG8gcnVubmluZworICAgICAgICBz dGF0ZS4gIERvZXMgbm90IGFmZmVjdCByZW5kZXJpbmcgb2Ygb3RoZXIgZWxlbWVudHMuCisKKyAg ICAgICAgKiBodG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTFBsdWdJbkltYWdlRWxlbWVudDo6SFRNTFBsdWdJbkltYWdlRWxlbWVudCk6CisKIDIw MTItMTAtMTEgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEV4cG9z ZSBoaWdoLXJlc29sdXRpb24gb24gcmVxdWVzdEFuaW1hdGlvbkZyYW1lIGNhbGxiYWNrCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAppbmRleCA3ZTdj Mjc1MTM4MDI2ZTY4Y2QyYWEyOWUyNzJmZTFjYjEzNzhmYTgzLi5mMTcyMGI4ZDUyNWVjNjIwOGE5 MWRmNzg4ZDNiMTg1ZDk2ODQyZTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBs dWdJbkltYWdlRWxlbWVudC5jcHAKQEAgLTUwLDcgKzUwLDkgQEAgSFRNTFBsdWdJbkltYWdlRWxl bWVudDo6SFRNTFBsdWdJbkltYWdlRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1l LCBEb2MKIHsKICAgICBzZXRIYXNDdXN0b21DYWxsYmFja3MoKTsKIAotICAgIGlmIChkb2N1bWVu dC0+cGFnZSgpICYmIGRvY3VtZW50LT5wYWdlKCktPnNldHRpbmdzKCktPnBsdWdJblNuYXBzaG90 dGluZ0VuYWJsZWQoKSkKKyAgICBpZiAoZG9jdW1lbnQtPnBhZ2UoKQorICAgICAgICAmJiBkb2N1 bWVudC0+cGFnZSgpLT5zZXR0aW5ncygpLT5wbHVnSW5TbmFwc2hvdHRpbmdFbmFibGVkKCkKKyAg ICAgICAgJiYgIVNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpKQogICAg ICAgICBzZXREaXNwbGF5U3RhdGUoV2FpdGluZ0ZvclNuYXBzaG90KTsKIH0KIAo=