99775 2012-10-18 16:38:16 -0700 Build fix after r131741 for !ENABLE(CSS_SHADERS) platforms 2012-10-19 02:43:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98733 1 dongseong.hwang webkit-unassigned noam ossy webkit.review.bot oldest_to_newest 745728 0 dongseong.hwang 2012-10-18 16:38:16 -0700 Remove "using namespace WebKit;" in CoordinatedGraphicsArgumentCoders because WebKit namespace is only used when ENABLE(CSS_SHADERS). It is because build fails when disabling CSS_SHADERS. For example, it brokes the Qt --minimal build. 745731 1 169505 dongseong.hwang 2012-10-18 16:41:37 -0700 Created attachment 169505 Patch 745981 2 169505 ap 2012-10-18 22:33:10 -0700 Comment on attachment 169505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:-66 > -using namespace WebKit; I suggest just putting this inside an ifdef, too. The namespace prefix you are adding below is quite mysterious. 746074 3 169505 ossy 2012-10-19 00:02:23 -0700 Comment on attachment 169505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:259 > + RefPtr<CustomFilterProgram> program = WebKit::WebCustomFilterProgram::create(vertexShaderString, fragmentShaderString, programType, mixSettings); If WebKit isn't valid namespace, I don't think if WebKit::WebCustomFilterProgram::create is valid function name. 746135 4 169505 ossy 2012-10-19 01:56:19 -0700 Comment on attachment 169505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169505&action=review >> Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:259 >> + RefPtr<CustomFilterProgram> program = WebKit::WebCustomFilterProgram::create(vertexShaderString, fragmentShaderString, programType, mixSettings); > > If WebKit isn't valid namespace, I don't think if WebKit::WebCustomFilterProgram::create is valid function name. I didn't say anything, this code is ENABLE(CSS_SHADERS) guarded. 746142 5 169579 dongseong.hwang 2012-10-19 02:05:29 -0700 Created attachment 169579 Patch 746144 6 dongseong.hwang 2012-10-19 02:07:07 -0700 (In reply to comment #2) > I suggest just putting this inside an ifdef, too. The namespace prefix you are adding below is quite mysterious. (In reply to comment #4) > I didn't say anything, this code is ENABLE(CSS_SHADERS) guarded. Thanks for advices. I guard this namespace code by ENABLE(CSS_SHADERS) as you suggested. 746165 7 169579 ossy 2012-10-19 02:43:30 -0700 Comment on attachment 169579 Patch Clearing flags on attachment: 169579 Committed r131878: <http://trac.webkit.org/changeset/131878> 746166 8 ossy 2012-10-19 02:43:36 -0700 All reviewed patches have been landed. Closing bug. 169505 2012-10-18 16:41:37 -0700 2012-10-19 02:05:23 -0700 Patch bug-99775-20121019084012.patch text/plain 2140 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGVlZmUzNjVjYWYwMzk2 Yjc0ZjZlNTI4NDlkNmM2ZmM4MTBkY2M0Mi4uZDYwOTc1MDI5NTQ2ZGE0NmVhZDViOGFjOWE2Njky Mzc0YzRlM2M0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIEJ1aWxkIGZp eCBhZnRlciByMTMxNzQxLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTk3NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmUgInVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7IiBpbiBDb29yZGluYXRlZEdy YXBoaWNzQXJndW1lbnRDb2RlcnMgYmVjYXVzZQorICAgICAgICBXZWJLaXQgbmFtZXNwYWNlIGlz IG9ubHkgdXNlZCB3aGVuIEVOQUJMRShDU1NfU0hBREVSUykuIEl0IGlzIHdoeSBidWlsZAorICAg ICAgICBmYWlscyB3aGVuIGRpc2FibGluZyBDU1NfU0hBREVSUy4gRm9yIGV4YW1wbGUsIGl0IGJy b2tlcyB0aGUgUXQgLS1taW5pbWFsIGJ1aWxkLgorCisgICAgICAgICogU2hhcmVkL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcDoKKyAgICAg ICAgKENvcmVJUEM6Ojo6ZGVjb2RlKToKKwogMjAxMi0xMC0xMiAgSHVhbmcgRG9uZ3N1bmcgIDxs dXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBbV0syXSBBZGQgQ3VzdG9tRmlsdGVy T3BlcmF0aW9uIHNlcmlhbGl6YXRpb24gaW4gQXJndW1lbnRDb2Rlci4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhp Y3NBcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRH cmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwCmluZGV4IGIzY2Zj NjNmOTI3M2FjMjIwNjZhZGRiYTA0YzAzNDYyOWM0MzVlNTIuLmVmNjdlZTkzZGY3Njc3ZmVmOTg0 OTM4OGFjYTU0YWQ1MTJhZTIxOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9D b29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0 ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcApAQCAtNjMsNyArNjMsNiBAQAogI2VuZGlmCiAK IHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwotdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAogbmFt ZXNwYWNlIENvcmVJUEMgewogCkBAIC0yNTcsNyArMjU2LDcgQEAgYm9vbCBBcmd1bWVudENvZGVy PFdlYkNvcmU6OkZpbHRlck9wZXJhdGlvbnM+OjpkZWNvZGUoQXJndW1lbnREZWNvZGVyKiBkZWNv ZGVyLAogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIGlmICghZGVj b2Rlci0+ZGVjb2RlRW51bShtaXhTZXR0aW5ncy5jb21wb3NpdGVPcGVyYXRvcikpCiAgICAgICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAgICAgUmVmUHRyPEN1c3RvbUZpbHRlclBy b2dyYW0+IHByb2dyYW0gPSBXZWJDdXN0b21GaWx0ZXJQcm9ncmFtOjpjcmVhdGUodmVydGV4U2hh ZGVyU3RyaW5nLCBmcmFnbWVudFNoYWRlclN0cmluZywgcHJvZ3JhbVR5cGUsIG1peFNldHRpbmdz KTsKKyAgICAgICAgICAgIFJlZlB0cjxDdXN0b21GaWx0ZXJQcm9ncmFtPiBwcm9ncmFtID0gV2Vi S2l0OjpXZWJDdXN0b21GaWx0ZXJQcm9ncmFtOjpjcmVhdGUodmVydGV4U2hhZGVyU3RyaW5nLCBm cmFnbWVudFNoYWRlclN0cmluZywgcHJvZ3JhbVR5cGUsIG1peFNldHRpbmdzKTsKIAogICAgICAg ICAgICAgdWludDMyX3QgcGFyYW1ldGVyc1NpemU7CiAgICAgICAgICAgICBpZiAoIWRlY29kZXIt PmRlY29kZVVJbnQzMihwYXJhbWV0ZXJzU2l6ZSkpCg== 169579 2012-10-19 02:05:29 -0700 2012-10-19 02:43:30 -0700 Patch bug-99775-20121019180412.patch text/plain 1516 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDlmZGE1ZDljMjViYTUy NzU4NDVhMTBmMWNlODMzNzNkOWQ4ZTc3Zi4uNWEyMWNhZTE1ZDYwNzc0YWEzYWYyODUxOGJiMzli MzUxOWJkYjZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE5ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIEJ1aWxkIGZp eCBhZnRlciByMTMxNzQxIGZvciAhRU5BQkxFKENTU19TSEFERVJTKSBwbGF0Zm9ybXMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTc3NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgY2xhc3MgaW4gV2Vi S2l0IG5hbWVzcGFjZSBpcyBvbmx5IHVzZWQgd2hlbiBFTkFCTEUoQ1NTX1NIQURFUlMpLCBzbyB3 ZQorICAgICAgICBtdXN0IGd1YXJkICJ1c2luZyBuYW1lc3BhY2UgV2ViS2l0IiBieSBFTkFCTEUo Q1NTX1NIQURFUlMpLiBPdGhlcndpc2UsCisgICAgICAgIGl0IGJyb2tlcyB0aGUgUXQgLS1taW5p bWFsIGJ1aWxkLgorCisgICAgICAgICogU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRp bmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcDoKKyAgICAgICAgKENvcmVJUEM6Ojo6ZGVj b2RlKToKKwogMjAxMi0xMC0xMiAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAw Lm5ldD4KIAogICAgICAgICBbV0syXSBBZGQgQ3VzdG9tRmlsdGVyT3BlcmF0aW9uIHNlcmlhbGl6 YXRpb24gaW4gQXJndW1lbnRDb2Rlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRl ZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwCmluZGV4IGIzY2ZjNjNmOTI3M2FjMjIwNjZhZGRi YTA0YzAzNDYyOWM0MzVlNTIuLmNkOGI4M2MyYzNhMTJjNDM1YzgzNmU1ZDRhNWI1MzBiNmFmNTFk YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50 Q29kZXJzLmNwcApAQCAtNjMsNyArNjMsOSBAQAogI2VuZGlmCiAKIHVzaW5nIG5hbWVzcGFjZSBX ZWJDb3JlOworI2lmIEVOQUJMRShDU1NfU0hBREVSUykKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7 CisjZW5kaWYKIAogbmFtZXNwYWNlIENvcmVJUEMgewogCg==