99766 2012-10-18 15:34:04 -0700 [chromium] Simplify TestInterfaces, as this class won't be directly exposed in the TestRunner library's interface 2012-10-18 16:13:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth webkit.review.bot oldest_to_newest 745644 0 jochen 2012-10-18 15:34:04 -0700 [chromium] Simplify TestInterfaces, as this class won't be directly exposed in the TestRunner library's interface 745648 1 169491 jochen 2012-10-18 15:35:29 -0700 Created attachment 169491 Patch 745704 2 169491 webkit.review.bot 2012-10-18 16:13:16 -0700 Comment on attachment 169491 Patch Clearing flags on attachment: 169491 Committed r131821: <http://trac.webkit.org/changeset/131821> 745705 3 webkit.review.bot 2012-10-18 16:13:19 -0700 All reviewed patches have been landed. Closing bug. 169491 2012-10-18 15:35:29 -0700 2012-10-18 16:13:16 -0700 Patch bug-99766-20121019003414.patch text/plain 6289 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDY3MzQ5ZDlkZGQzYzg4ZmQ2OTgyOGQyZTczOTIzZWE5 MGRhMDE3OC4uZGU3MzIxNGIzN2YyOGJhZWI5NDgyZDRiZTg1NjQ0ZWJlOWNlMDM1YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTEwLTE4ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gU2ltcGxpZnkgVGVzdEludGVyZmFjZXMsIGFzIHRoaXMgY2xh c3Mgd29uJ3QgYmUgZGlyZWN0bHkgZXhwb3NlZCBpbiB0aGUgVGVzdFJ1bm5lciBsaWJyYXJ5J3Mg aW50ZXJmYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05OTc2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgcmV2ZXJ0cyBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMjMyNDAKKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvVGVzdEludGVyZmFj ZXMuY3BwOgorICAgICAgICAoVGVzdEludGVyZmFjZXM6OlRlc3RJbnRlcmZhY2VzKToKKyAgICAg ICAgKFRlc3RJbnRlcmZhY2VzOjp+VGVzdEludGVyZmFjZXMpOgorICAgICAgICAoVGVzdEludGVy ZmFjZXM6OnNldFdlYlZpZXcpOgorICAgICAgICAoVGVzdEludGVyZmFjZXM6OnNldERlbGVnYXRl KToKKyAgICAgICAgKFRlc3RJbnRlcmZhY2VzOjpiaW5kVG8pOgorICAgICAgICAoVGVzdEludGVy ZmFjZXM6OnJlc2V0QWxsKToKKyAgICAgICAgKFRlc3RJbnRlcmZhY2VzOjphY2Nlc3NpYmlsaXR5 Q29udHJvbGxlcik6CisgICAgICAgIChUZXN0SW50ZXJmYWNlczo6ZXZlbnRTZW5kZXIpOgorICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvVGVzdEludGVyZmFjZXMu aDoKKyAgICAgICAgKFRlc3RJbnRlcmZhY2VzKToKKwogMjAxMi0xMC0xOCAgRGlyayBQcmFua2Ug IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICB3ZWJraXRweTogZml4IGNocm9taXVt IGJvdCBjb25maWdzIGluIGJ1aWxkZXJzLnB5CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL1Rlc3RJbnRlcmZhY2VzLmNwcCBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvVGVzdEludGVyZmFjZXMuY3BwCmluZGV4IGNj ZWMwODZhYTVhZjY2ZDA2NTE0YTUxNWU2YWI1ZDdiNzhmNmY4MWUuLmU2ZTYyNWZhZmVhM2M4MmUx ZjY0NGUzYTJmZjY5Nzk3NTMyMDA2NjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RSdW5uZXIvVGVzdEludGVyZmFjZXMuY3BwCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvVGVzdEludGVyZmFjZXMuY3BwCkBAIC0zNywz MyArMzcsMTEgQEAKICNpbmNsdWRlICJUZXh0SW5wdXRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAi cGxhdGZvcm0vV2ViU3RyaW5nLmgiCiAKLSNpbmNsdWRlIDx3dGYvT3duUHRyLmg+Ci0KIHVzaW5n IFdlYktpdDo6V2ViRnJhbWU7CiB1c2luZyBXZWJLaXQ6OldlYlN0cmluZzsKIHVzaW5nIFdlYktp dDo6V2ViVmlldzsKIAotY2xhc3MgVGVzdEludGVyZmFjZXM6OkludGVybmFsIHsKLXB1YmxpYzoK LSAgICBJbnRlcm5hbCgpOwotICAgIH5JbnRlcm5hbCgpOwotCi0gICAgdm9pZCBzZXRXZWJWaWV3 KFdlYlZpZXcqKTsKLSAgICB2b2lkIHNldERlbGVnYXRlKFRlc3REZWxlZ2F0ZSopOwotICAgIHZv aWQgYmluZFRvKFdlYkZyYW1lKik7Ci0gICAgdm9pZCByZXNldEFsbCgpOwotCi0gICAgQWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIqIGFjY2Vzc2liaWxpdHlDb250cm9sbGVyKCkgeyByZXR1cm4gbV9h Y2Nlc3NpYmlsaXR5Q29udHJvbGxlci5nZXQoKTsgfQotICAgIEV2ZW50U2VuZGVyKiBldmVudFNl bmRlcigpIHsgcmV0dXJuIG1fZXZlbnRTZW5kZXIuZ2V0KCk7IH0KLQotcHJpdmF0ZToKLSAgICBP d25QdHI8QWNjZXNzaWJpbGl0eUNvbnRyb2xsZXI+IG1fYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXI7 Ci0gICAgT3duUHRyPEV2ZW50U2VuZGVyPiBtX2V2ZW50U2VuZGVyOwotICAgIE93blB0cjxHYW1l cGFkQ29udHJvbGxlcj4gbV9nYW1lcGFkQ29udHJvbGxlcjsKLSAgICBPd25QdHI8VGV4dElucHV0 Q29udHJvbGxlcj4gbV90ZXh0SW5wdXRDb250cm9sbGVyOwotfTsKLQotVGVzdEludGVyZmFjZXM6 OkludGVybmFsOjpJbnRlcm5hbCgpCitUZXN0SW50ZXJmYWNlczo6VGVzdEludGVyZmFjZXMoKQog ewogICAgIG1fYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIgPSBhZG9wdFB0cihuZXcgQWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIoKSk7CiAgICAgbV9ldmVudFNlbmRlciA9IGFkb3B0UHRyKG5ldyBFdmVu dFNlbmRlcigpKTsKQEAgLTcxLDcgKzQ5LDcgQEAgVGVzdEludGVyZmFjZXM6OkludGVybmFsOjpJ bnRlcm5hbCgpCiAgICAgbV90ZXh0SW5wdXRDb250cm9sbGVyID0gYWRvcHRQdHIobmV3IFRleHRJ bnB1dENvbnRyb2xsZXIoKSk7CiB9CiAKLVRlc3RJbnRlcmZhY2VzOjpJbnRlcm5hbDo6fkludGVy bmFsKCkKK1Rlc3RJbnRlcmZhY2VzOjp+VGVzdEludGVyZmFjZXMoKQogewogICAgIG1fYWNjZXNz aWJpbGl0eUNvbnRyb2xsZXItPnNldFdlYlZpZXcoMCk7CiAgICAgbV9ldmVudFNlbmRlci0+c2V0 V2ViVmlldygwKTsKQEAgLTg0LDcgKzYyLDcgQEAgVGVzdEludGVyZmFjZXM6OkludGVybmFsOjp+ SW50ZXJuYWwoKQogICAgIC8vIG1fdGV4dElucHV0Q29udHJvbGxlciBkb2Vzbid0IGRlcGVuZCBv biBUZXN0RGVsZWdhdGUuCiB9CiAKLXZvaWQgVGVzdEludGVyZmFjZXM6OkludGVybmFsOjpzZXRX ZWJWaWV3KFdlYlZpZXcqIHdlYlZpZXcpCit2b2lkIFRlc3RJbnRlcmZhY2VzOjpzZXRXZWJWaWV3 KFdlYlZpZXcqIHdlYlZpZXcpCiB7CiAgICAgbV9hY2Nlc3NpYmlsaXR5Q29udHJvbGxlci0+c2V0 V2ViVmlldyh3ZWJWaWV3KTsKICAgICBtX2V2ZW50U2VuZGVyLT5zZXRXZWJWaWV3KHdlYlZpZXcp OwpAQCAtOTIsNyArNzAsNyBAQCB2b2lkIFRlc3RJbnRlcmZhY2VzOjpJbnRlcm5hbDo6c2V0V2Vi VmlldyhXZWJWaWV3KiB3ZWJWaWV3KQogICAgIG1fdGV4dElucHV0Q29udHJvbGxlci0+c2V0V2Vi Vmlldyh3ZWJWaWV3KTsKIH0KIAotdm9pZCBUZXN0SW50ZXJmYWNlczo6SW50ZXJuYWw6OnNldERl bGVnYXRlKFRlc3REZWxlZ2F0ZSogZGVsZWdhdGUpCit2b2lkIFRlc3RJbnRlcmZhY2VzOjpzZXRE ZWxlZ2F0ZShUZXN0RGVsZWdhdGUqIGRlbGVnYXRlKQogewogICAgIC8vIG1fYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIgZG9lc24ndCBkZXBlbmQgb24gVGVzdERlbGVnYXRlLgogICAgIG1fZXZlbnRT ZW5kZXItPnNldERlbGVnYXRlKGRlbGVnYXRlKTsKQEAgLTEwMCw3ICs3OCw3IEBAIHZvaWQgVGVz dEludGVyZmFjZXM6OkludGVybmFsOjpzZXREZWxlZ2F0ZShUZXN0RGVsZWdhdGUqIGRlbGVnYXRl KQogICAgIC8vIG1fdGV4dElucHV0Q29udHJvbGxlciBkb2Vzbid0IGRlcGVuZCBvbiBUZXN0RGVs ZWdhdGUuCiB9CiAKLXZvaWQgVGVzdEludGVyZmFjZXM6OkludGVybmFsOjpiaW5kVG8oV2ViRnJh bWUqIGZyYW1lKQordm9pZCBUZXN0SW50ZXJmYWNlczo6YmluZFRvKFdlYkZyYW1lKiBmcmFtZSkK IHsKICAgICBtX2FjY2Vzc2liaWxpdHlDb250cm9sbGVyLT5iaW5kVG9KYXZhc2NyaXB0KGZyYW1l LCBXZWJTdHJpbmc6OmZyb21VVEY4KCJhY2Nlc3NpYmlsaXR5Q29udHJvbGxlciIpKTsKICAgICBt X2V2ZW50U2VuZGVyLT5iaW5kVG9KYXZhc2NyaXB0KGZyYW1lLCBXZWJTdHJpbmc6OmZyb21VVEY4 KCJldmVudFNlbmRlciIpKTsKQEAgLTEwOCw3ICs4Niw3IEBAIHZvaWQgVGVzdEludGVyZmFjZXM6 OkludGVybmFsOjpiaW5kVG8oV2ViRnJhbWUqIGZyYW1lKQogICAgIG1fdGV4dElucHV0Q29udHJv bGxlci0+YmluZFRvSmF2YXNjcmlwdChmcmFtZSwgV2ViU3RyaW5nOjpmcm9tVVRGOCgidGV4dElu cHV0Q29udHJvbGxlciIpKTsKIH0KIAotdm9pZCBUZXN0SW50ZXJmYWNlczo6SW50ZXJuYWw6OnJl c2V0QWxsKCkKK3ZvaWQgVGVzdEludGVyZmFjZXM6OnJlc2V0QWxsKCkKIHsKICAgICBtX2FjY2Vz c2liaWxpdHlDb250cm9sbGVyLT5yZXNldCgpOwogICAgIG1fZXZlbnRTZW5kZXItPnJlc2V0KCk7 CkBAIC0xMTYsNDIgKzk0LDEyIEBAIHZvaWQgVGVzdEludGVyZmFjZXM6OkludGVybmFsOjpyZXNl dEFsbCgpCiAgICAgLy8gbV90ZXh0SW5wdXRDb250cm9sbGVyIGRvZXNuJ3QgaGF2ZSBhbnkgc3Rh dGUgdG8gcmVzZXQuCiB9CiAKLVRlc3RJbnRlcmZhY2VzOjpUZXN0SW50ZXJmYWNlcygpCi0gICAg OiBtX2ludGVybmFsKG5ldyBUZXN0SW50ZXJmYWNlczo6SW50ZXJuYWwoKSkKLXsKLX0KLQotVGVz dEludGVyZmFjZXM6On5UZXN0SW50ZXJmYWNlcygpCi17Ci0gICAgZGVsZXRlIG1faW50ZXJuYWw7 Ci19Ci0KLXZvaWQgVGVzdEludGVyZmFjZXM6OnNldFdlYlZpZXcoV2ViVmlldyogd2ViVmlldykK LXsKLSAgICBtX2ludGVybmFsLT5zZXRXZWJWaWV3KHdlYlZpZXcpOwotfQotCi12b2lkIFRlc3RJ bnRlcmZhY2VzOjpzZXREZWxlZ2F0ZShUZXN0RGVsZWdhdGUqIGRlbGVnYXRlKQotewotICAgIG1f aW50ZXJuYWwtPnNldERlbGVnYXRlKGRlbGVnYXRlKTsKLX0KLQotdm9pZCBUZXN0SW50ZXJmYWNl czo6YmluZFRvKFdlYkZyYW1lKiBmcmFtZSkKLXsKLSAgICBtX2ludGVybmFsLT5iaW5kVG8oZnJh bWUpOwotfQotCi12b2lkIFRlc3RJbnRlcmZhY2VzOjpyZXNldEFsbCgpCi17Ci0gICAgbV9pbnRl cm5hbC0+cmVzZXRBbGwoKTsKLX0KLQogQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIqIFRlc3RJbnRl cmZhY2VzOjphY2Nlc3NpYmlsaXR5Q29udHJvbGxlcigpCiB7Ci0gICAgcmV0dXJuIG1faW50ZXJu YWwtPmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKCk7CisgICAgcmV0dXJuIG1fYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuZ2V0KCk7CiB9CiAKIEV2ZW50U2VuZGVyKiBUZXN0SW50ZXJmYWNlczo6ZXZl bnRTZW5kZXIoKQogewotICAgIHJldHVybiBtX2ludGVybmFsLT5ldmVudFNlbmRlcigpOworICAg IHJldHVybiBtX2V2ZW50U2VuZGVyLmdldCgpOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9UZXN0SW50ZXJmYWNlcy5oIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9UZXN0SW50ZXJmYWNlcy5oCmluZGV4IDkx NzY5NTQ2MWZlMTMyZjE1NWRkNzMyZjhlOGE1M2E4YzZiNTUxNjguLmQ2Yjk4YWUzNGYzM2Q0Y2Jh ZTY2NTA1YjljYTY4NjAwNzAyZGRkZjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RSdW5uZXIvVGVzdEludGVyZmFjZXMuaAorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL1Rlc3RJbnRlcmZhY2VzLmgKQEAgLTMxLDYgKzMx LDggQEAKICNpZm5kZWYgVGVzdEludGVyZmFjZXNfaAogI2RlZmluZSBUZXN0SW50ZXJmYWNlc19o CiAKKyNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CisKIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3Mg V2ViRnJhbWU7CiBjbGFzcyBXZWJWaWV3OwpAQCAtMzgsNyArNDAsOSBAQCBjbGFzcyBXZWJWaWV3 OwogCiBjbGFzcyBBY2Nlc3NpYmlsaXR5Q29udHJvbGxlcjsKIGNsYXNzIEV2ZW50U2VuZGVyOwor Y2xhc3MgR2FtZXBhZENvbnRyb2xsZXI7CiBjbGFzcyBUZXN0RGVsZWdhdGU7CitjbGFzcyBUZXh0 SW5wdXRDb250cm9sbGVyOwogCiBjbGFzcyBUZXN0SW50ZXJmYWNlcyB7CiBwdWJsaWM6CkBAIC01 NCw4ICs1OCwxMCBAQCBwdWJsaWM6CiAgICAgRXZlbnRTZW5kZXIqIGV2ZW50U2VuZGVyKCk7CiAK IHByaXZhdGU6Ci0gICAgY2xhc3MgSW50ZXJuYWw7Ci0gICAgSW50ZXJuYWwqIG1faW50ZXJuYWw7 CisgICAgT3duUHRyPEFjY2Vzc2liaWxpdHlDb250cm9sbGVyPiBtX2FjY2Vzc2liaWxpdHlDb250 cm9sbGVyOworICAgIE93blB0cjxFdmVudFNlbmRlcj4gbV9ldmVudFNlbmRlcjsKKyAgICBPd25Q dHI8R2FtZXBhZENvbnRyb2xsZXI+IG1fZ2FtZXBhZENvbnRyb2xsZXI7CisgICAgT3duUHRyPFRl eHRJbnB1dENvbnRyb2xsZXI+IG1fdGV4dElucHV0Q29udHJvbGxlcjsKIH07CiAKICNlbmRpZiAv LyBUZXN0SW50ZXJmYWNlc19oCg==