99763 2012-10-18 15:16:36 -0700 [chromium] Storing the enclosing rect dimensions of the first finger for a two finger tap 2012-10-21 19:02:24 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99947 1 tdanderson tdanderson abarth allan.jensen dglazkov eric fishd jamesr rjkroege sadrul tkent+wkapi webkit.review.bot oldest_to_newest 745623 0 tdanderson 2012-10-18 15:16:36 -0700 Add a struct |twoFingerTap| inside the union |data| of a WebGestureEvent. The fields |firstFingerWidth| and |firstFingerHeight| will represent the dimensions of the enclosing rectangle corresponding to the first touch point in the gesture. These will be used in a future CL to perform target fuzzing on a two-finger tap gesture. Note: I chose not to name the two fields |width| and |height| so that they aren't confused with the width and height of the gesture's bounding box, which contains the enclosing rectangles of both touch points. My future fuzzing CL will only be concerned with the location and enclosing rectangle of the first touch point. 745634 1 169488 tdanderson 2012-10-18 15:26:01 -0700 Created attachment 169488 Patch 745638 2 webkit.review.bot 2012-10-18 15:29:02 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 745639 3 webkit.review.bot 2012-10-18 15:29:20 -0700 Attachment 169488 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebInputEvent.h:401: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/chromium/public/WebInputEvent.h:403: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 745677 4 169488 abarth 2012-10-18 15:56:44 -0700 Comment on attachment 169488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169488&action=review >> Source/WebKit/chromium/public/WebInputEvent.h:401 >> + } twoFingerTap; > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Would you be willing to fix the style in this file? I realize that you're just mimicing an existing error, but we should fix it. 747159 5 169814 tdanderson 2012-10-21 15:59:47 -0700 Created attachment 169814 Indent style fixed 747190 6 169814 webkit.review.bot 2012-10-21 19:02:19 -0700 Comment on attachment 169814 Indent style fixed Clearing flags on attachment: 169814 Committed r132021: <http://trac.webkit.org/changeset/132021> 747192 7 webkit.review.bot 2012-10-21 19:02:24 -0700 All reviewed patches have been landed. Closing bug. 169488 2012-10-18 15:26:01 -0700 2012-10-21 15:59:44 -0700 Patch bug-99763-20121018182446.patch text/plain 1965 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDRhZWFjN2UzYmZjYTRiMGNiY2EyMzQxNGFiYWQ3Y2YwYWZhNGUzNWUuLmFhOWI2MDhjZjc1NWRk N2E2MjQ3NTcyYTAwMmViZTJiMDY5M2UzNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMTAtMTggIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBTdG9yaW5nIHRoZSBlbmNsb3Npbmcg cmVjdCBkaW1lbnNpb25zIG9mIHRoZSBmaXJzdCBmaW5nZXIgZm9yIGEgdHdvIGZpbmdlciB0YXAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgc3Ry dWN0IHx0d29GaW5nZXJUYXB8IGluc2lkZSB0aGUgdW5pb24gfGRhdGF8IG9mIGEgV2ViR2VzdHVy ZUV2ZW50LiBUaGUgZmllbGRzIHxmaXJzdEZpbmdlcldpZHRofCAKKyAgICAgICAgYW5kIHxmaXJz dEZpbmdlckhlaWdodHwgd2lsbCByZXByZXNlbnQgdGhlIGRpbWVuc2lvbnMgb2YgdGhlIGVuY2xv c2luZyByZWN0YW5nbGUgY29ycmVzcG9uZGluZyB0byB0aGUgCisgICAgICAgIGZpcnN0IHRvdWNo IHBvaW50IGluIHRoZSBnZXN0dXJlLiBUaGVzZSB3aWxsIGJlIHVzZWQgaW4gYSBmdXR1cmUgQ0wg dG8gcGVyZm9ybSB0YXJnZXQgZnV6emluZyBvbiBhIAorICAgICAgICB0d28tZmluZ2VyIHRhcCBn ZXN0dXJlLgorCisgICAgICAgIE5vdGU6IEkgY2hvc2Ugbm90IHRvIG5hbWUgdGhlIHR3byBmaWVs ZHMgfHdpZHRofCBhbmQgfGhlaWdodHwgc28gdGhhdCB0aGV5IGFyZW4ndCBjb25mdXNlZCB3aXRo IHRoZSAKKyAgICAgICAgd2lkdGggYW5kIGhlaWdodCBvZiB0aGUgZ2VzdHVyZSdzIGJvdW5kaW5n IGJveCwgd2hpY2ggY29udGFpbnMgdGhlIGVuY2xvc2luZyByZWN0YW5nbGVzIG9mIGJvdGggdG91 Y2ggCisgICAgICAgIHBvaW50cy4gTXkgZnV0dXJlIGZ1enppbmcgQ0wgd2lsbCBvbmx5IGJlIGNv bmNlcm5lZCB3aXRoIHRoZSBsb2NhdGlvbiBhbmQgZW5jbG9zaW5nIHJlY3RhbmdsZSBvZiB0aGUg CisgICAgICAgIGZpcnN0IHRvdWNoIHBvaW50LgorCisgICAgICAgICogcHVibGljL1dlYklucHV0 RXZlbnQuaDoKKwogMjAxMi0xMC0xOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJvbGxlZCBERVBTLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCmluZGV4IGYzZWRhZjk1ZTA0 YTkxNzE5OWY4N2JkZGEyM2IxY2E2MTdhNjQwNDQuLjc4YjYzYjhkMTUxMmM1MzhhYTdhZGUxYzlk YTUwZThhMGJjNGJmNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYklucHV0RXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJ bnB1dEV2ZW50LmgKQEAgLTM5Niw2ICszOTYsMTEgQEAgcHVibGljOgogICAgICAgfSBsb25nUHJl c3M7CiAKICAgICAgIHN0cnVjdCB7CisgICAgICAgIGludCBmaXJzdEZpbmdlcldpZHRoOworICAg ICAgICBpbnQgZmlyc3RGaW5nZXJIZWlnaHQ7CisgICAgICB9IHR3b0ZpbmdlclRhcDsKKworICAg ICAgc3RydWN0IHsKICAgICAgICAgZmxvYXQgZGVsdGFYOwogICAgICAgICBmbG9hdCBkZWx0YVk7 CiAgICAgICAgIGZsb2F0IHZlbG9jaXR5WDsK 169814 2012-10-21 15:59:47 -0700 2012-10-21 19:02:18 -0700 Indent style fixed bug-99763-20121021185827.patch text/plain 3262 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNmYTRmMzIxMzg0MTVlMWFiZmJhYjQxYjQ1NjYxYjZiZTJkOGNkZTAuLjVmYjc3ZmY0YjYyMTY1 ZjA4ZTNkOTY3NjYyMzQ5NTg5ODBmNDQ5ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMTAtMjEgIFRlcnJ5IEFuZGVyc29uICA8dGRhbmRlcnNvbkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBTdG9yaW5nIHRoZSBlbmNsb3Npbmcg cmVjdCBkaW1lbnNpb25zIG9mIHRoZSBmaXJzdCBmaW5nZXIgZm9yIGEgdHdvIGZpbmdlciB0YXAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgc3Ry dWN0IHx0d29GaW5nZXJUYXB8IGluc2lkZSB0aGUgdW5pb24gfGRhdGF8IG9mIGEgV2ViR2VzdHVy ZUV2ZW50LiBUaGUgZmllbGRzIHxmaXJzdEZpbmdlcldpZHRofCAKKyAgICAgICAgYW5kIHxmaXJz dEZpbmdlckhlaWdodHwgd2lsbCByZXByZXNlbnQgdGhlIGRpbWVuc2lvbnMgb2YgdGhlIGVuY2xv c2luZyByZWN0YW5nbGUgY29ycmVzcG9uZGluZyB0byB0aGUgCisgICAgICAgIGZpcnN0IHRvdWNo IHBvaW50IGluIHRoZSBnZXN0dXJlLiBUaGVzZSB3aWxsIGJlIHVzZWQgaW4gYSBmdXR1cmUgQ0wg dG8gcGVyZm9ybSB0YXJnZXQgZnV6emluZyBvbiBhIAorICAgICAgICB0d28tZmluZ2VyIHRhcCBn ZXN0dXJlLgorCisgICAgICAgIE5vdGU6IEkgY2hvc2Ugbm90IHRvIG5hbWUgdGhlIHR3byBmaWVs ZHMgfHdpZHRofCBhbmQgfGhlaWdodHwgc28gdGhhdCB0aGV5IGFyZW4ndCBjb25mdXNlZCB3aXRo IHRoZSAKKyAgICAgICAgd2lkdGggYW5kIGhlaWdodCBvZiB0aGUgZ2VzdHVyZSdzIGJvdW5kaW5n IGJveCwgd2hpY2ggY29udGFpbnMgdGhlIGVuY2xvc2luZyByZWN0YW5nbGVzIG9mIGJvdGggdG91 Y2ggCisgICAgICAgIHBvaW50cy4gTXkgZnV0dXJlIGZ1enppbmcgQ0wgd2lsbCBvbmx5IGJlIGNv bmNlcm5lZCB3aXRoIHRoZSBsb2NhdGlvbiBhbmQgZW5jbG9zaW5nIHJlY3RhbmdsZSBvZiB0aGUg CisgICAgICAgIGZpcnN0IHRvdWNoIHBvaW50LgorCisgICAgICAgICogcHVibGljL1dlYklucHV0 RXZlbnQuaDoKKwogMjAxMi0xMC0xOSAgWXVzdWYgT3p1eXNhbCAgPHl1c3Vmb0Bnb29nbGUuY29t PgogCiAgICAgICAgIFtjaHJvbWl1bV0gRG91YmxlLXRhcCBkZWZhdWx0cyB0byB6b29tIChzaG91 bGQgb25seSBkbyB0aGlzIG9uIEFuZHJvaWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnB1dEV2ZW50LmgKaW5kZXggZjNlZGFmOTVlMDRhOTE3MTk5Zjg3YmRkYTIzYjFj YTYxN2E2NDA0NC4uMzI4YzAzMzdlNmZiNmI4MTE5NTM3MDQyNzgwNDFhZjZmNGZiMWJhNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCisr KyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaApAQCAtMzc5 LDM4ICszNzksNDMgQEAgcHVibGljOgogICAgIGludCBnbG9iYWxZOwogCiAgICAgdW5pb24gewot ICAgICAgc3RydWN0IHsKLSAgICAgICAgaW50IHRhcENvdW50OwotICAgICAgICBpbnQgd2lkdGg7 Ci0gICAgICAgIGludCBoZWlnaHQ7Ci0gICAgICB9IHRhcDsKLQotICAgICAgc3RydWN0IHsKLSAg ICAgICAgaW50IHdpZHRoOwotICAgICAgICBpbnQgaGVpZ2h0OwotICAgICAgfSB0YXBEb3duOwot Ci0gICAgICBzdHJ1Y3QgewotICAgICAgICBpbnQgd2lkdGg7Ci0gICAgICAgIGludCBoZWlnaHQ7 Ci0gICAgICB9IGxvbmdQcmVzczsKLQotICAgICAgc3RydWN0IHsKLSAgICAgICAgZmxvYXQgZGVs dGFYOwotICAgICAgICBmbG9hdCBkZWx0YVk7Ci0gICAgICAgIGZsb2F0IHZlbG9jaXR5WDsKLSAg ICAgICAgZmxvYXQgdmVsb2NpdHlZOwotICAgICAgfSBzY3JvbGxVcGRhdGU7Ci0KLSAgICAgIHN0 cnVjdCB7Ci0gICAgICAgIGZsb2F0IHZlbG9jaXR5WDsKLSAgICAgICAgZmxvYXQgdmVsb2NpdHlZ OwotICAgICAgICBTb3VyY2VEZXZpY2Ugc291cmNlRGV2aWNlOwotICAgICAgfSBmbGluZ1N0YXJ0 OwotCi0gICAgICBzdHJ1Y3QgewotICAgICAgICBmbG9hdCBzY2FsZTsKLSAgICAgIH0gcGluY2hV cGRhdGU7CisgICAgICAgIHN0cnVjdCB7CisgICAgICAgICAgICBpbnQgdGFwQ291bnQ7CisgICAg ICAgICAgICBpbnQgd2lkdGg7CisgICAgICAgICAgICBpbnQgaGVpZ2h0OworICAgICAgICB9IHRh cDsKKworICAgICAgICBzdHJ1Y3QgeworICAgICAgICAgICAgaW50IHdpZHRoOworICAgICAgICAg ICAgaW50IGhlaWdodDsKKyAgICAgICAgfSB0YXBEb3duOworCisgICAgICAgIHN0cnVjdCB7Cisg ICAgICAgICAgICBpbnQgd2lkdGg7CisgICAgICAgICAgICBpbnQgaGVpZ2h0OworICAgICAgICB9 IGxvbmdQcmVzczsKKworICAgICAgICBzdHJ1Y3QgeworICAgICAgICAgICAgaW50IGZpcnN0Rmlu Z2VyV2lkdGg7CisgICAgICAgICAgICBpbnQgZmlyc3RGaW5nZXJIZWlnaHQ7CisgICAgICAgIH0g dHdvRmluZ2VyVGFwOworCisgICAgICAgIHN0cnVjdCB7CisgICAgICAgICAgICBmbG9hdCBkZWx0 YVg7CisgICAgICAgICAgICBmbG9hdCBkZWx0YVk7CisgICAgICAgICAgICBmbG9hdCB2ZWxvY2l0 eVg7CisgICAgICAgICAgICBmbG9hdCB2ZWxvY2l0eVk7CisgICAgICAgIH0gc2Nyb2xsVXBkYXRl OworCisgICAgICAgIHN0cnVjdCB7CisgICAgICAgICAgICBmbG9hdCB2ZWxvY2l0eVg7CisgICAg ICAgICAgICBmbG9hdCB2ZWxvY2l0eVk7CisgICAgICAgICAgICBTb3VyY2VEZXZpY2Ugc291cmNl RGV2aWNlOworICAgICAgICB9IGZsaW5nU3RhcnQ7CisKKyAgICAgICAgc3RydWN0IHsKKyAgICAg ICAgICAgIGZsb2F0IHNjYWxlOworICAgICAgICB9IHBpbmNoVXBkYXRlOwogICAgIH0gZGF0YTsg CiAKICAgICBXZWJHZXN0dXJlRXZlbnQodW5zaWduZWQgc2l6ZVBhcmFtID0gc2l6ZW9mKFdlYkdl c3R1cmVFdmVudCkpCg==