99760 2012-10-18 15:06:02 -0700 [BlackBerry] Page viewport aspect ratio not kept on navigating back 2012-10-19 11:10:07 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jkjiang jkjiang manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 745605 0 jkjiang 2012-10-18 15:06:02 -0700 PR: 222437 745627 1 169486 jkjiang 2012-10-18 15:19:49 -0700 Created attachment 169486 Patch 745630 2 169486 rwlbuis 2012-10-18 15:22:04 -0700 Comment on attachment 169486 Patch LGTM. 745640 3 169486 jkjiang 2012-10-18 15:29:56 -0700 Comment on attachment 169486 Patch Committed manually http://trac.webkit.org/changeset/131816. 746423 4 jkjiang 2012-10-19 10:28:21 -0700 Reopen this to fix more issues found. 746428 5 169646 jkjiang 2012-10-19 10:37:20 -0700 Created attachment 169646 Patch 746458 6 169646 jkjiang 2012-10-19 11:09:58 -0700 Comment on attachment 169646 Patch Committed manually http://trac.webkit.org/changeset/131923. 169486 2012-10-18 15:19:49 -0700 2012-10-18 15:29:56 -0700 Patch bug-99760-20121018181834.patch text/plain 2711 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxODA1ZWUwM2Y4MDEyNzNkYTAxMTFkZjlhNzU2YWYyZmYxZDEzNTA2Li5hYTU3MDhkMzlm NTU1ZjU0OGZmN2I5ODYwYjk1YzJkYzgyYTkwMzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMi0xMC0xOCAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBQYWdlIHZpZXdwb3J0IGFzcGVjdCBy YXRpbyBub3Qga2VwdCBvbiBuYXZpZ2F0aW5nIGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgS29ucmFkIFBpYXNj aWsKKworICAgICAgICBQUjogMTkwNDY5CisgICAgICAgIFRoaXMgd2FzIGFkZGVkIGluIHIxMjc2 Mjggd2hpY2ggd2FzIHRyeWluZyB0byBmaXggc29tZSByZW5kZXJpbmcKKyAgICAgICAgZGVmZWN0 cyBvbiBtYXBzLmdvb2dsZS5jb20gYW5kIG5ld3MucXEuY29tLCBob3dldmVyIGl0IHdhcyB2ZXJ5 IGhhcm1mdWwKKyAgICAgICAgYW5kIGNhdXNlZCByZWdyZXNzaW9ucy4KKyAgICAgICAgem9vbVRv Rml0U2NhbGUoKSBkZXBlbmRzIG9uIHRoZSBjdXJyZW50IGNvbnRlbnRzIHNpemUuIER1cmluZyBo aXN0b3J5CisgICAgICAgIG5hdmlnYXRpb24gYW5kIGRldmljZSByb3RhdGlvbiwgaWYgem9vbVRv Rml0U2NhbGUoKSBpcyBiYXNlZCBvbiB0aGUKKyAgICAgICAgZmluYWwgY29udGVudHMgc2l6ZSB3 aGljaCBpcyBleHBlY3RlZCwgdGhlcmUgd2lsbCBzdGlsbCBiZSBhIHNjYWxlCisgICAgICAgIGNh bGN1bGF0aW9uIGxpa2UgdGhpcyBhZnRlcndhcmRzCisgICAgICAgIHNjcmVlblNpemUud2lkdGgo KS9zY3JlZW5TaXplLmhlaWdodCgpKnpvb21Ub0ZpdFNjYWxlKCkgd2hpY2ggd2lsbAorICAgICAg ICByZXN1bHQgaW4gYSB3cm9uZyBzY2FsZS4gRHVyaW5nIHRoZSBoaXN0b3J5IG5hdmlnYXRpb24s IGlmCisgICAgICAgIHpvb21Ub0ZpdFNjYWxlKCkgaXNuJ3QgYmFzZWQgb24gdGhlIGZpbmFsIGNv bnRlbnRzIHNpemUsIHRoZW4gd2Ugd2lsbAorICAgICAgICBnZXQgdGhlIHdyb25nIHNjYWxlIGFz IHdlbGwgZm9yIHN1cmUuCisgICAgICAgIFRoaXMgaXNzdWUgd2lsbCBiZSBmaXhlZCBieSByZW1v dmluZyB0aGUgd3JvbmcgY2FsY3VsYXRpb24uCisgICAgICAgIFRoZSBvcmlnaW5hbCBpc3N1ZSBv ZiByMTI3NjI4IHdhcyBmaXhlZCBieSB0aGUgcGF0Y2ggb2YgUFIyMjU5ODEuCisKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpyZXN0b3JlVmlld1N0YXRl KToKKwogMjAxMi0xMC0xOCAgSm9obiBHcmlnZ3MgIDxqZ3JpZ2dzQHJpbS5jb20+CiAKICAgICAg ICAgMjAxMi0xMC0xOCAgSm9obiBHcmlnZ3MgIDxqZ3JpZ2dzQHJpbS5jb20+CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9y dC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IDg2YjQxODk4NTA5MWVhMTU3 NDc3ZWY2MjA2OWUyMWVlYTQ1OGRjYzQuLmViYzk4MGNhOTYzM2QxMGUyMGQ4MjE1ODhhYzkzYTYz ZjQ5M2IwNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3Bw CkBAIC0xMDgzLDEyICsxMDgzLDYgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6 OnJlc3RvcmVWaWV3U3RhdGUoKQogICAgIC8vIEFsc28sIHRyeSB0byBrZWVwIHRoZSB1c2VycyB6 b29tIGlmIGFueS4KICAgICBkb3VibGUgc2NhbGUgPSB2aWV3U3RhdGUuc2NhbGU7CiAKLSAgICAv LyBJZiBpdCB3YXMgem9vbVRvRml0U2NhbGUgdXNlIHRoZSBuZXcgem9vbVRvRml0U2NhbGUgYmVj YXVzZQotICAgIC8vIHRoZSBuZXcgb25lIG1heSBiZSBkaWZmZXJlbnQgdG8gdGhlIG9sZCBvbmUg ZHVlIHRvIGNvbnRlbnRzCi0gICAgLy8gc2l6ZSBjaGFuZ2UgKGUuZy4gYWZ0ZXIgcmVsb2FkZWQp LgotICAgIGlmICh2aWV3U3RhdGUuaXNab29tVG9GaXRTY2FsZSkKLSAgICAgICAgc2NhbGUgPSBt X3dlYlBhZ2VQcml2YXRlLT56b29tVG9GaXRTY2FsZSgpOwotCiAgICAgYm9vbCBzaG91bGRSZWZs b3dCbG9jayA9IHZpZXdTdGF0ZS5zaG91bGRSZWZsb3dCbG9jazsKICAgICBpZiAobV93ZWJQYWdl UHJpdmF0ZS0+bV91c2VyUGVyZm9ybWVkTWFudWFsWm9vbSkgewogICAgICAgICBzY2FsZSA9IG1f d2ViUGFnZVByaXZhdGUtPmN1cnJlbnRTY2FsZSgpOwo= 169646 2012-10-19 10:37:20 -0700 2012-10-19 11:09:58 -0700 Patch bug-99760-20121019133604.patch text/plain 2989 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxOTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBkMTIyODliMmY4Zjg4OWU5M2UwMTQ2NjRjMjUxNjA1OGZlY2IzNTc3Li4xYjNmODQxOGNh ZDkwOGE2ZWEzMWNiM2IyZTkxOWM5YjQ5YjQzMTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMi0xMC0xOSAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBQYWdlIHZpZXdwb3J0IGFzcGVjdCBy YXRpbyBub3Qga2VwdCBvbiBuYXZpZ2F0aW5nIGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgS29ucmFkIFBpYXNj aWsKKworICAgICAgICBQUjogMjIyNDM3CisgICAgICAgIFRoaXMgaXMgdG8gZml4IHRoZSBzZWNv bmQgaXNzdWUgb24gUFIyMjI0MzcgdGhhdCB0aGUgdmlld3BvcnQgbm90IGtlcHQKKyAgICAgICAg d2hlbiBuYXZpZ2F0aW5nIGJhY2sgZnJvbSBnb29nbGUgYWZ0ZXIgcm90YXRpb24gdG8gYmxvb21i ZXJnLgorICAgICAgICBXZSB3ZXJlIHRyeWluZyB0byByZXN0b3JlIHRoZSBoaXN0b3J5IGNvbnRl bnRzIHNpemUgYW5kIHNjYWxlIG9mCisgICAgICAgIGJsb29tYmVyZyB3aGljaCBoYXMgdmlydHVh bCB2aWV3cG9ydC4gVGhlIHNjYWxlIHdvdWxkIGJlIHJlY2FsY3VsYXRlZAorICAgICAgICBiYXNl ZCBvbiB0aGUgbmV3IHNjcmVlbiBzaXplLiBIb3dldmVyLCB3ZSB3b3VsZCBzdGlsbCB1c2UgdGhl IGN1cnJlbnQKKyAgICAgICAgY29udGVudHMgc2l6ZSBpZiBpdCB3YXMgZ3JlYXRlciB0aGFuIHRo ZSBoaXN0b3J5IGNvbnRlbnRzIHNpemUgaW4KKyAgICAgICAgRnJhbWVWaWV3OjpzZXRDb250ZW50 c1NpemUgd2hpY2ggbWFkZSB0aGUgY29udGVudHMgc2VlbSB0byBiZSBzY2FsZWQKKyAgICAgICAg dG9vIG11Y2guCisgICAgICAgIEFjdHVhbGx5IHdoZW4gd2UgcmVsYXlvdXQgdGhlIGNvbnRlbnRz IGFmdGVyIHJvdGF0aW9uIGNoYW5nZSwgdGhlCisgICAgICAgIGN1cnJlbnQgY29udGVudHMgc2l6 ZSB3aGljaCBpcyBiYXNlZCBvbiB0aGUgdmlydHVhbCB2aWV3cG9ydCBoYXMgdGFrZW4KKyAgICAg ICAgdGhlIHNjcmVlbiBzaXplIGludG8gYWNjb3VudC4gU2hyaW5raW5nIHRoZSBjb250ZW50cyBz aXplIHdpbGwgYmUKKyAgICAgICAgZXhwZW5zaXZlLiBTbyB3ZSBjYW4gaWdub3JlIHNjcmVlbiBz aXplIGJhc2VkIHNjYWxlIGNhbGN1bGF0aW9uIGhlcmUuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpyZXN0b3JlVmlld1N0YXRlKToKKwogMjAxMi0x MC0xOSAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XSBEb24ndCBhdHRlbXB0IHRvIGF1dG8gc2Nyb2xsIG9uIGlucHV0IGZvciBGaXhlZCBQb3Np dGlvbiBlbGVtZW50cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJD b3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5j cHAKaW5kZXggZWJjOTgwY2E5NjMzZDEwZTIwZDgyMTU4OGFjOTNhNjNmNDkzYjA0ZS4uYmYxYzFl NmE1ODQ1YjY5MDg1MGE3ZDQxOWI4NDhiZDZhYzhlNWU2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJy eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTEwOTcsOCArMTA5Nyw4IEBAIHZvaWQgRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpyZXN0b3JlVmlld1N0YXRlKCkKICAgICBpZiAoIXNj cm9sbENoYW5nZWQgJiYgIXNjYWxlQ2hhbmdlZCAmJiAhcmVmbG93Q2hhbmdlZCAmJiAhb3JpZW50 YXRpb25DaGFuZ2VkKQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBXaGVuIHJvdGF0ZSBoYXBw ZW5zLCBvbmx5IHpvb20gd2hlbiBwcmV2aW91cyBwYWdlIHdhcyB6b29tVG9GaXRTY2FsZSwgb3Ro ZXJ3aXNlIGtlZXAgb2xkIHNjYWxlLgotICAgIGlmIChvcmllbnRhdGlvbkNoYW5nZWQgJiYgdmll d1N0YXRlLmlzWm9vbVRvRml0U2NhbGUpCisgICAgLy8gV2hlbiByb3RhdGUgaGFwcGVucywgb25s eSB6b29tIHdoZW4gcHJldmlvdXMgcGFnZSB3YXMgem9vbVRvRml0U2NhbGUgYW5kIGRpZG4ndCBo YXZlIHZpcnR1YWwgdmlld3BvcnQsIG90aGVyd2lzZSBrZWVwIG9sZCBzY2FsZS4KKyAgICBpZiAo b3JpZW50YXRpb25DaGFuZ2VkICYmIHZpZXdTdGF0ZS5pc1pvb21Ub0ZpdFNjYWxlICYmICFtX3dl YlBhZ2VQcml2YXRlLT5oYXNWaXJ0dWFsVmlld3BvcnQoKSkKICAgICAgICAgc2NhbGUgPSBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OlNjcmVlbjo6cHJpbWFyeVNjcmVlbigpLT53aWR0 aCgpICogc2NhbGUgLyBzdGF0aWNfY2FzdDxkb3VibGU+KEJsYWNrQmVycnk6OlBsYXRmb3JtOjpH cmFwaGljczo6U2NyZWVuOjpwcmltYXJ5U2NyZWVuKCktPmhlaWdodCgpKTsKIAogICAgIC8vIERv bid0IGZsYXNoIGNoZWNrZXJib2FyZCBiZWZvcmUgV2ViUGFnZVByaXZhdGU6OnJlc3RvcmVIaXN0 b3J5Vmlld1N0YXRlKCkgZmluaXNoZWQuCg==