99757 2012-10-18 14:07:38 -0700 [EFL] Buildfix if Netscape plugin support is disabled 2012-10-19 00:36:59 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned gyuyoung.kim kbalazs lucas.de.marchi mariusz.g ostap73 rakuco webkit.review.bot oldest_to_newest 745556 0 laszlo.gombos 2012-10-18 14:07:38 -0700 "build-webkit --no-netscape-plugin-api --efl" does not build. 745567 1 169475 laszlo.gombos 2012-10-18 14:18:07 -0700 Created attachment 169475 proposed patch 745587 2 rakuco 2012-10-18 14:34:21 -0700 If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. 745613 3 ostap73 2012-10-18 15:09:31 -0700 (In reply to comment #2) > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. No, it fixes build if plugins are disabled. By default they are enabled. 745645 4 rakuco 2012-10-18 15:34:39 -0700 (In reply to comment #3) > (In reply to comment #2) > > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. > > No, it fixes build if plugins are disabled. By default they are enabled. Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then? 745651 5 ostap73 2012-10-18 15:37:44 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > If this one fixes the current build break (as in <http://build.webkit.org/builders/EFL Linux 32-bit Release (Build)/builds/8502/steps/compile-webkit/logs/stdio>), I'd go as far as just committing it as unreviewed build fix. > > > > No, it fixes build if plugins are disabled. By default they are enabled. > > Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then? Yes, it should fix --no-netscape-plugin-api build. 745701 6 rakuco 2012-10-18 16:11:08 -0700 (In reply to comment #5) > > Does this fix https://bugs.webkit.org/show_bug.cgi?id=91844#c66 and its follow-up response then? > > Yes, it should fix --no-netscape-plugin-api build. Right. If it addresses Mariusz's concerns in that bug report, I guess it should be fine. Once it lands, please comment on that bug so that everyone knows the issue has been fixed. 745890 7 169475 gyuyoung.kim 2012-10-18 19:12:55 -0700 Comment on attachment 169475 proposed patch It would be good if you say this is fixed on the Rafael's comment. :-) 745908 8 169475 webkit.review.bot 2012-10-18 19:35:57 -0700 Comment on attachment 169475 proposed patch Clearing flags on attachment: 169475 Committed r131843: <http://trac.webkit.org/changeset/131843> 745909 9 webkit.review.bot 2012-10-18 19:36:02 -0700 All reviewed patches have been landed. Closing bug. 746098 10 mariusz.g 2012-10-19 00:36:59 -0700 This is a part of bigger problem. See following bug: https://bugs.webkit.org/show_bug.cgi?id=98401 169475 2012-10-18 14:18:07 -0700 2012-10-18 19:35:57 -0700 proposed patch 99757.patch text/plain 2263 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTc5 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEw LTE4ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gQnVpbGRmaXggaWYgTmV0c2NhcGUgcGx1Z2luIHN1cHBvcnQgaXMgZGlzYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzU3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IEVOQUJMRV9QTFVH SU5fUFJPQ0VTUyBvbmx5IGlmIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJIGlzIHNldC4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorCiAyMDEyLTEwLTE4ICBQ YWJsbyBGbG91cmV0ICA8cGFibG9mQG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQg Y3NzMy1jb25kaXRpb25hbCdzIEBzdXBwb3J0cyBydWxlCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lv biAxMzE3OTgpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNCBAQAorMjAxMi0xMC0xOCAgTGFzemxvIEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIEJ1aWxkZml4IGlmIE5ldHNjYXBlIHBsdWdpbiBzdXBw b3J0IGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTc1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEd1YXJkIFBsdWdpblByb2Nlc3NNYWluVW5peC5jcHAgd2l0aCBFTkFCTEUoUExVR0lO X1BST0NFU1MpLgorCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NN YWluVW5peC5jcHA6CisKIDIwMTItMTAtMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbHVn aW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc01haW5Vbml4LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc01haW5Vbml4LmNw cAkocmV2aXNpb24gMTMxNzM1KQorKysgU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4 L1BsdWdpblByb2Nlc3NNYWluVW5peC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4LDYgKzI4LDgg QEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJQbHVnaW5Qcm9jZXNzTWFpblVuaXgu aCIKIAorI2lmIEVOQUJMRShQTFVHSU5fUFJPQ0VTUykKKwogI2luY2x1ZGUgIkxvZ2dpbmcuaCIK ICNpbmNsdWRlICJOZXRzY2FwZVBsdWdpbi5oIgogI2luY2x1ZGUgIlBsdWdpblByb2Nlc3MuaCIK QEAgLTExMSwzICsxMTMsNSBAQCBXS19FWFBPUlQgaW50IFBsdWdpblByb2Nlc3NNYWluVW5peChp bnQKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CisKKyNlbmRpZgpJbmRleDogU291cmNlL2Nt YWtlL09wdGlvbnNFZmwuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2NtYWtlL09wdGlvbnNF ZmwuY21ha2UJKHJldmlzaW9uIDEzMTczNSkKKysrIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNt YWtlCSh3b3JraW5nIGNvcHkpCkBAIC0xMjUsNyArMTI1LDcgQEAgU0VUKFdURl9VU0VfSEFSRkJV WlpfTkcgMSkKIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0VfRlJFRVRZUEU9MSkKIEFERF9ERUZJ TklUSU9OUygtRFdURl9VU0VfSEFSRkJVWlpfTkc9MSkKIAotSUYgKEVOQUJMRV9XRUJLSVQyKQor SUYgKEVOQUJMRV9XRUJLSVQyIEFORCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBT RVQoRU5BQkxFX1BMVUdJTl9QUk9DRVNTIDEpCiBFTkRJRiAoKQogCg==