99752 2012-10-18 13:44:31 -0700 [skia] Handle if we fail to allocate nonPlatformCanvas in ImageBuffer constructor 2012-10-18 16:04:43 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed junov senorblanco webkit.review.bot oldest_to_newest 745522 0 reed 2012-10-18 13:44:31 -0700 Handle if we fail to allocate nonPlatformCanvas in ImageBuffer constructor 745530 1 169464 reed 2012-10-18 13:48:43 -0700 Created attachment 169464 Patch 745564 2 169464 senorblanco 2012-10-18 14:16:41 -0700 Comment on attachment 169464 Patch Looks good. r=me. I wonder if we should have some kind of SkDevice::hasValidBackingStore() utility function in Skia? Or SkBitmap::isValid()? 745568 3 reed 2012-10-18 14:18:44 -0700 we don't have such a utility, but might be a good thing to add. 745578 4 169464 webkit.review.bot 2012-10-18 14:28:07 -0700 Comment on attachment 169464 Patch Clearing flags on attachment: 169464 Committed r131805: <http://trac.webkit.org/changeset/131805> 745579 5 webkit.review.bot 2012-10-18 14:28:10 -0700 All reviewed patches have been landed. Closing bug. 169464 2012-10-18 13:48:43 -0700 2012-10-18 14:28:07 -0700 Patch bug-99752-20121018164728.patch text/plain 2127 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTc5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTE4ICBNaWtlIFJl ZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAgSGFuZGxlIGlmIHdlIGZhaWwgdG8gYWxs b2NhdGUgbm9uUGxhdGZvcm1DYW52YXMgaW4gSW1hZ2VCdWZmZXIgY29uc3RydWN0b3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzUyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudCBjb2RlIGRv ZXMgbm90IGNoZWNrIGlmIHdlIHdlcmUgYWJsZSB0byBhbGxvY2F0ZSB0aGUgcGl4ZWxzLCBidXQg c3RpbGwgcmV0dXJucyB0aGUgY2FudmFzLgorICAgICAgICBIb3dldmVyLCB0aGUgY2FsbGVyIGV4 cGxpY2l0bHkgaXMgY2hlY2tpbmcgZm9yIG51bGwgb24gZmFpbHVyZSwgc28gaXQgd2lsbCBjb250 aW51ZSAoYW5kIHBvc3NpYmx5CisgICAgICAgIGNyYXNoIGxhdGVyIG9uKS4KKyAgICAgICAgVGhp cyBjaGFuZ2UgYnJpbmdzIHRoZSBub25QbGF0Zm9ybUNhbnZhcyBiZWhhdmlvciBpbmxpbmUgd2l0 aCBjcmVhdGVBY2NlbGVyYXRlZENhbnZhcyBhbmQKKyAgICAgICAgVHJ5Q3JlYXRlQml0bWFwQ2Fu dmFzLCBib3RoIG9mIHdoaWNoIGFyZSBhbHNvIGNhbGxlZCBieSBJbWFnZUJ1ZmZlcidzIGNvbnN0 cnVjdG9yLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhpc3RpbmcgdGVzdHMgZXhlcmNpc2Ug SW1hZ2VCdWZmZXIgY29uc3RydWN0b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVOb25QbGF0 Zm9ybUNhbnZhcyk6CisKIDIwMTItMTAtMTggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50 ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIEdyYXBoaWNzQ29udGV4dDNEOjptX3JlbmRlclN0eWxl IGlzIG5vdCBpbml0aWFsaXplZApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAkocmV2aXNpb24gMTMx Nzk3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZl clNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsOSArMTA0LDkgQEAgc3RhdGljIFNrQ2Fu dmFzKiBjcmVhdGVBY2NlbGVyYXRlZENhbnZhcwogCiBzdGF0aWMgU2tDYW52YXMqIGNyZWF0ZU5v blBsYXRmb3JtQ2FudmFzKGNvbnN0IEludFNpemUmIHNpemUpCiB7Ci0gICAgU2tDYW52YXMqIGNh bnZhcyA9IG5ldyBTa0NhbnZhcygpOwotICAgIGNhbnZhcy0+c2V0RGV2aWNlKG5ldyBTa0Rldmlj ZShTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcsIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQo KSkpLT51bnJlZigpOwotICAgIHJldHVybiBjYW52YXM7CisgICAgU2tBdXRvVFVucmVmPFNrRGV2 aWNlPiBkZXZpY2UobmV3IFNrRGV2aWNlKFNrQml0bWFwOjprQVJHQl84ODg4X0NvbmZpZywgc2l6 ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKSk7CisgICAgU2tQaXhlbFJlZiogcGl4ZWxSZWYgPSBk ZXZpY2UtPmFjY2Vzc0JpdG1hcChmYWxzZSkucGl4ZWxSZWYoKTsKKyAgICByZXR1cm4gcGl4ZWxS ZWYgPyBuZXcgU2tDYW52YXMoZGV2aWNlKSA6IDA7CiB9CiAKIEltYWdlQnVmZmVyOjpJbWFnZUJ1 ZmZlcihjb25zdCBJbnRTaXplJiBzaXplLCBmbG9hdCByZXNvbHV0aW9uU2NhbGUsIENvbG9yU3Bh Y2UsIFJlbmRlcmluZ01vZGUgcmVuZGVyaW5nTW9kZSwgRGVmZXJyYWxNb2RlIGRlZmVycmFsTW9k ZSwgYm9vbCYgc3VjY2VzcykK