99747 2012-10-18 12:50:40 -0700 prepare-ChangeLog is confused by non-function properties in prototypes 2012-10-18 13:59:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 1 timothy timothy darin joepeck oldest_to_newest 745481 0 timothy 2012-10-18 12:50:40 -0700 Take: Foo.Bar = function() {} Foo.Bar.prototype = { constructor: Foo.Bar, baz: function() { // Changes here. } }; prepare-ChangeLog will output for the changes function: (Foo.Bar.prototype.constructor.Foo.Bar.baz): It should be: (Foo.Bar.prototype.baz): 745488 1 169452 timothy 2012-10-18 12:56:37 -0700 Created attachment 169452 Proposed Change 745520 2 169452 joepeck 2012-10-18 13:42:15 -0700 Comment on attachment 169452 Proposed Change r=me 745542 3 timothy 2012-10-18 13:59:06 -0700 r131798 169452 2012-10-18 12:56:37 -0700 2012-10-18 13:42:15 -0700 Proposed Change 0001-Teach-prepare-ChangeLog-how-to-handle-non-function-p.patch text/plain 2221 timothy RnJvbSA0MmMwOGU4OTI4Zjg4NmZjNWYzY2JjZjM4OTUzNTMxNmVhZTI2NDdhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUaHUsIDE4IE9jdCAyMDEyIDEyOjU0OjIxIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gVGVh Y2ggcHJlcGFyZS1DaGFuZ2VMb2cgaG93IHRvIGhhbmRsZSBub24tZnVuY3Rpb24KIHByb3BlcnRp ZXMgaW4gSmF2YVNjcmlwdCBwcm90b3R5cGVzLgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk5NzQ3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogU2NyaXB0 cy9wcmVwYXJlLUNoYW5nZUxvZzoKKGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfamF2YXNj cmlwdCk6IENsZWFyIGN1cnJlbnRJZGVudGlmaWVycyB3aGVuIGNvbW1hIGlzIGVuY291bnRlcmVk CnNvIGl0IGRvZXMgbm90IHRhY2sgdGhvc2UgaWRlbnRpZmllcnMgb250byB0aGUgbmV4dCBjaGFu Z2VkIGZ1bmN0aW9uLgotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZyB8ICAgIDYgKysr LS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGFmMGUx ZjUuLjFkOTIzMzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMC0xOCAgVGltb3RoeSBIYXRjaGVyICA8dGlt b3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgVGVhY2ggcHJlcGFyZS1DaGFuZ2VMb2cgaG93IHRv IGhhbmRsZSBub24tZnVuY3Rpb24gcHJvcGVydGllcyBpbiBKYXZhU2NyaXB0IHByb3RvdHlwZXMu CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzQ3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp cHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAoZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2Vz X2Zvcl9qYXZhc2NyaXB0KTogQ2xlYXIgY3VycmVudElkZW50aWZpZXJzIHdoZW4gY29tbWEgaXMg ZW5jb3VudGVyZWQKKyAgICAgICAgc28gaXQgZG9lcyBub3QgdGFjayB0aG9zZSBpZGVudGlmaWVy cyBvbnRvIHRoZSBuZXh0IGNoYW5nZWQgZnVuY3Rpb24uCisKIDIwMTItMTAtMTcgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHdhdGNo bGlzdCBlbWFpbCBjaGFuZ2UuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hh bmdlTG9nIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwppbmRleCBjYjkxYzU5Li5h MzgxNmUyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKQEAgLTEyMTgsNyArMTIxOCw3IEBAIHN1 YiBnZXRfZnVuY3Rpb25fbGluZV9yYW5nZXNfZm9yX2phdmFzY3JpcHQoJCQpCiAgICAgICAgIH0K IAogICAgICAgICAjIEZpbmQgZnVuY3Rpb24gbmFtZXMuCi0gICAgICAgIHdoaWxlIChtLShcdyt8 Wygpe309OjtdKS1nKSB7CisgICAgICAgIHdoaWxlIChtLShcdyt8Wygpe309OjssXSktZykgewog ICAgICAgICAgICAgIyBPcGVuIHBhcmVudGhlc2lzLgogICAgICAgICAgICAgaWYgKCQxIGVxICco JykgewogICAgICAgICAgICAgICAgICRwYXJlbnRoZXNlc0RlcHRoKys7CkBAIC0xMjU5LDggKzEy NTksOCBAQCBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9qYXZhc2NyaXB0KCQkKQog ICAgICAgICAgICAgICAgIG5leHQ7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgICMgU2Vt aWNvbG9uLgotICAgICAgICAgICAgaWYgKCQxIGVxICc7JykgeworICAgICAgICAgICAgIyBTZW1p Y29sb24gb3IgY29tbWEuCisgICAgICAgICAgICBpZiAoJDEgZXEgJzsnIG9yICQxIGVxICcsJykg ewogICAgICAgICAgICAgICAgIEBjdXJyZW50SWRlbnRpZmllcnMgPSAoKTsKICAgICAgICAgICAg ICAgICBuZXh0OwogICAgICAgICAgICAgfQotLSAKMS43LjEwLjIgKEFwcGxlIEdpdC0zMykKCg==