99737 2012-10-18 11:20:53 -0700 Page should be removed from the cache right after restore was called 2012-11-02 11:53:25 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 dgorbik webkit-unassigned abarth ap ddkilzer japhet simon.fraser webkit.review.bot oldest_to_newest 745410 0 dgorbik 2012-10-18 11:20:53 -0700 The pageCache is inconsistent after the restoration because the cachedFrame is being nulled, but the page is still in the Cache. We should remove the page from the cache faster. 745768 1 169511 dgorbik 2012-10-18 17:20:22 -0700 Created attachment 169511 Proposed fix 0.1 745776 2 169511 abarth 2012-10-18 17:29:13 -0700 Comment on attachment 169511 Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=169511&action=review > Source/WebCore/ChangeLog:11 > + No new tests. Can we write a test for this issue? FrameLoader, especially interactions with PageCache, are woefully under tested. 746718 3 dgorbik 2012-10-19 15:47:41 -0700 Unfortunately this was noticed in a custom application and we have no reasonable way to test its behavior in LayoutTests. But the current tests that exercise the page cache do pass. 746719 4 169714 dgorbik 2012-10-19 15:48:20 -0700 Created attachment 169714 Proposed fix 0.2 746720 5 169714 beidson 2012-10-19 15:52:33 -0700 Comment on attachment 169714 Proposed fix 0.2 It's unfortunately we can't get a targeted test here... But I think this is a good change worth taking. No regressions on existing tests is good enough for me here. 746725 6 abarth 2012-10-19 15:59:40 -0700 Despite the discussion in <http://lists.webkit.org/pipermail/webkit-dev/2009-October/010303.html>, I agree that this is the right course of action here. 746731 7 169714 webkit.review.bot 2012-10-19 16:13:15 -0700 Comment on attachment 169714 Proposed fix 0.2 Clearing flags on attachment: 169714 Committed r131953: <http://trac.webkit.org/changeset/131953> 746732 8 webkit.review.bot 2012-10-19 16:13:19 -0700 All reviewed patches have been landed. Closing bug. 757419 9 ddkilzer 2012-11-02 11:53:25 -0700 <rdar://problem/12438412> 169511 2012-10-18 17:20:22 -0700 2012-10-19 15:48:44 -0700 Proposed fix 0.1 patch text/plain 2522 dgorbik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NzkzMGJiLi5hNjI5OTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMTggIERpbWEgR29yYmlrICA8ZGdvcmJpa0BhcHBsZS5jb20+CisKKyAgICAg ICAgUGFnZSBzaG91bGQgYmUgcmVtb3ZlZCBmcm9tIHRoZSBjYWNoZSByaWdodCBhZnRlciByZXN0 b3JlIHdhcyBjYWxsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTczNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBwYWdlQ2FjaGUgd2FzIGluY29uc2lzdGVudCBhZnRlciB0aGUgcmVzdG9yYXRp b24gZm9yIGEgcGVyaW9kIG9mIHRpbWUgYmVjYXVzZSB0aGUgY2FjaGVkRnJhbWUgaXMgYmVpbmcg bnVsbGVkLAorICAgICAgICBidXQgdGhlIHBhZ2UgaXMgc3RpbGwgaW4gdGhlIENhY2hlLiBOb3cg dGhlIHBhZ2UgaXMgYmVpbmcgcmVtb3ZlZCBmcm9tIHRoZSBjYWNoZSByaWdodCBhZnRlciB0aGUg cmVzdG9yYXRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpjb21taXRQ cm92aXNpb25hbExvYWQpOgorCiAyMDEyLTEwLTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCBkaWFnbm9zdGljIGxvZ2dpbmcgdG8gdHJhY2sgcGVyLXBh Z2UgbWVkaWEgZW5naW5lIHVzYWdlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAK aW5kZXggYmVmYWE5Mi4uYjA0MjU3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCkBAIC0xNjg5LDYgKzE2ODksOSBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjb21taXRQcm92aXNp b25hbExvYWQoKQogICAgICAgICBwcmVwYXJlRm9yQ2FjaGVkUGFnZVJlc3RvcmUoKTsKICAgICAg ICAgY2FjaGVkUGFnZS0+cmVzdG9yZShtX2ZyYW1lLT5wYWdlKCkpOwogCisgICAgICAgIC8vIFRo ZSBwYWdlIHNob3VsZCBiZSByZW1vdmVkIGZyb20gdGhlIGNhY2hlIGltbWVkaWF0ZWx5IGFmdGVy IGEgcmVzdG9yYXRpb24gaW4gb3JkZXIgZm9yIHRoZSBQYWdlQ2FjaGUgdG8gYmUgY29uc2lzdGVu dC4KKyAgICAgICAgcGFnZUNhY2hlKCktPnJlbW92ZShoaXN0b3J5KCktPmN1cnJlbnRJdGVtKCkp OworCiAgICAgICAgIGRpc3BhdGNoRGlkQ29tbWl0TG9hZCgpOwogCiAgICAgICAgIC8vIElmIHdl IGhhdmUgYSB0aXRsZSBsZXQgdGhlIFdlYlZpZXcga25vdyBhYm91dCBpdC4gCkBAIC0xNjk3LDgg KzE3MDAsMTEgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y29tbWl0UHJvdmlzaW9uYWxMb2FkKCkKICAg ICAgICAgICAgIG1fY2xpZW50LT5kaXNwYXRjaERpZFJlY2VpdmVUaXRsZSh0aXRsZSk7CiAKICAg ICAgICAgY2hlY2tDb21wbGV0ZWQoKTsKLSAgICB9IGVsc2UKKyAgICB9IGVsc2UgeworICAgICAg ICBpZiAoY2FjaGVkUGFnZSkKKyAgICAgICAgICAgIHBhZ2VDYWNoZSgpLT5yZW1vdmUoaGlzdG9y eSgpLT5jdXJyZW50SXRlbSgpKTsKICAgICAgICAgZGlkT3BlblVSTCgpOworICAgIH0KIAogICAg IExPRyhMb2FkaW5nLCAiV2ViQ29yZUxvYWRpbmcgJXM6IEZpbmlzaGVkIGNvbW1pdHRpbmcgcHJv dmlzaW9uYWwgbG9hZCB0byBVUkwgJXMiLCBtX2ZyYW1lLT50cmVlKCktPnVuaXF1ZU5hbWUoKS5z dHJpbmcoKS51dGY4KCkuZGF0YSgpLAogICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpID8gbV9m cmFtZS0+ZG9jdW1lbnQoKS0+dXJsKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSA6ICIiKTsKQEAg LTE3MjYsOCArMTczMiw2IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFsTG9h ZCgpCiAgICAgICAgICAgICAvLyBDb3VsZCBiZSBhbiBpc3N1ZSB3aXRoIGEgZ2lhbnQgbG9jYWwg ZmlsZS4KICAgICAgICAgICAgIG5vdGlmaWVyKCktPnNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3Nh Z2VzKG1fZG9jdW1lbnRMb2FkZXIuZ2V0KCksIGlkZW50aWZpZXIsIHJlc3BvbnNlLCAwLCBzdGF0 aWNfY2FzdDxpbnQ+KHJlc3BvbnNlLmV4cGVjdGVkQ29udGVudExlbmd0aCgpKSwgMCwgZXJyb3Ip OwogICAgICAgICB9Ci0gICAgICAgIAotICAgICAgICBwYWdlQ2FjaGUoKS0+cmVtb3ZlKGhpc3Rv cnkoKS0+Y3VycmVudEl0ZW0oKSk7CiAKICAgICAgICAgLy8gRklYTUU6IFdoeSBvbmx5IHRoaXMg ZnJhbWUgYW5kIG5vdCBwYXJlbnQgZnJhbWVzPwogICAgICAgICBjaGVja0xvYWRDb21wbGV0ZUZv clRoaXNGcmFtZSgpOwo= 169714 2012-10-19 15:48:20 -0700 2012-10-19 16:13:15 -0700 Proposed fix 0.2 patch text/plain 2738 dgorbik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NzkzMGJiLi4zMGEzZDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMTAtMTggIERpbWEgR29yYmlrICA8ZGdvcmJpa0BhcHBsZS5jb20+CisKKyAgICAg ICAgUGFnZSBzaG91bGQgYmUgcmVtb3ZlZCBmcm9tIHRoZSBjYWNoZSByaWdodCBhZnRlciByZXN0 b3JlIHdhcyBjYWxsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTczNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBwYWdlQ2FjaGUgd2FzIGluY29uc2lzdGVudCBhZnRlciB0aGUgcmVzdG9yYXRp b24gZm9yIGEgcGVyaW9kIG9mIHRpbWUgYmVjYXVzZSB0aGUgY2FjaGVkRnJhbWUgaXMgYmVpbmcg bnVsbGVkLAorICAgICAgICBidXQgdGhlIHBhZ2UgaXMgc3RpbGwgaW4gdGhlIENhY2hlLiBOb3cg dGhlIHBhZ2UgaXMgYmVpbmcgcmVtb3ZlZCBmcm9tIHRoZSBjYWNoZSByaWdodCBhZnRlciB0aGUg cmVzdG9yYXRpb24uCisgICAgICAgIFRoaXMgaXNzdWUgd2FzIHNwb3R0ZWQgaW4gYSBjdXN0b20g YnVpbHQgYXBwbGljYXRpb24gdXNpbmcgV2ViS2l0IGFuZCB1bmZvcnR1bmF0ZWx5IHRoZXJlIGlz IG5vIHdheSB0byB0ZXN0IHRoaXMKKyAgICAgICAgYmVoYXZpb3IgaW4gTGF5b3V0VGVzdHMuIEFs bCB0aGUgY3VycmVudCB0ZXN0cyB0aGF0IGV4ZXJjaXNlIHRoZSBwYWdlIGNhY2hlIGRvIHBhc3Mu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpjb21taXRQcm92aXNpb25hbExv YWQpOgorCiAyMDEyLTEwLTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBkaWFnbm9zdGljIGxvZ2dpbmcgdG8gdHJhY2sgcGVyLXBhZ2UgbWVkaWEgZW5n aW5lIHVzYWdlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggYmVmYWE5 Mi4uYjA0MjU3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0xNjg5 LDYgKzE2ODksOSBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjb21taXRQcm92aXNpb25hbExvYWQoKQog ICAgICAgICBwcmVwYXJlRm9yQ2FjaGVkUGFnZVJlc3RvcmUoKTsKICAgICAgICAgY2FjaGVkUGFn ZS0+cmVzdG9yZShtX2ZyYW1lLT5wYWdlKCkpOwogCisgICAgICAgIC8vIFRoZSBwYWdlIHNob3Vs ZCBiZSByZW1vdmVkIGZyb20gdGhlIGNhY2hlIGltbWVkaWF0ZWx5IGFmdGVyIGEgcmVzdG9yYXRp b24gaW4gb3JkZXIgZm9yIHRoZSBQYWdlQ2FjaGUgdG8gYmUgY29uc2lzdGVudC4KKyAgICAgICAg cGFnZUNhY2hlKCktPnJlbW92ZShoaXN0b3J5KCktPmN1cnJlbnRJdGVtKCkpOworCiAgICAgICAg IGRpc3BhdGNoRGlkQ29tbWl0TG9hZCgpOwogCiAgICAgICAgIC8vIElmIHdlIGhhdmUgYSB0aXRs ZSBsZXQgdGhlIFdlYlZpZXcga25vdyBhYm91dCBpdC4gCkBAIC0xNjk3LDggKzE3MDAsMTEgQEAg dm9pZCBGcmFtZUxvYWRlcjo6Y29tbWl0UHJvdmlzaW9uYWxMb2FkKCkKICAgICAgICAgICAgIG1f Y2xpZW50LT5kaXNwYXRjaERpZFJlY2VpdmVUaXRsZSh0aXRsZSk7CiAKICAgICAgICAgY2hlY2tD b21wbGV0ZWQoKTsKLSAgICB9IGVsc2UKKyAgICB9IGVsc2UgeworICAgICAgICBpZiAoY2FjaGVk UGFnZSkKKyAgICAgICAgICAgIHBhZ2VDYWNoZSgpLT5yZW1vdmUoaGlzdG9yeSgpLT5jdXJyZW50 SXRlbSgpKTsKICAgICAgICAgZGlkT3BlblVSTCgpOworICAgIH0KIAogICAgIExPRyhMb2FkaW5n LCAiV2ViQ29yZUxvYWRpbmcgJXM6IEZpbmlzaGVkIGNvbW1pdHRpbmcgcHJvdmlzaW9uYWwgbG9h ZCB0byBVUkwgJXMiLCBtX2ZyYW1lLT50cmVlKCktPnVuaXF1ZU5hbWUoKS5zdHJpbmcoKS51dGY4 KCkuZGF0YSgpLAogICAgICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpID8gbV9mcmFtZS0+ZG9jdW1l bnQoKS0+dXJsKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSA6ICIiKTsKQEAgLTE3MjYsOCArMTcz Miw2IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFsTG9hZCgpCiAgICAgICAg ICAgICAvLyBDb3VsZCBiZSBhbiBpc3N1ZSB3aXRoIGEgZ2lhbnQgbG9jYWwgZmlsZS4KICAgICAg ICAgICAgIG5vdGlmaWVyKCktPnNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3NhZ2VzKG1fZG9jdW1l bnRMb2FkZXIuZ2V0KCksIGlkZW50aWZpZXIsIHJlc3BvbnNlLCAwLCBzdGF0aWNfY2FzdDxpbnQ+ KHJlc3BvbnNlLmV4cGVjdGVkQ29udGVudExlbmd0aCgpKSwgMCwgZXJyb3IpOwogICAgICAgICB9 Ci0gICAgICAgIAotICAgICAgICBwYWdlQ2FjaGUoKS0+cmVtb3ZlKGhpc3RvcnkoKS0+Y3VycmVu dEl0ZW0oKSk7CiAKICAgICAgICAgLy8gRklYTUU6IFdoeSBvbmx5IHRoaXMgZnJhbWUgYW5kIG5v dCBwYXJlbnQgZnJhbWVzPwogICAgICAgICBjaGVja0xvYWRDb21wbGV0ZUZvclRoaXNGcmFtZSgp Owo=