99730 2012-10-18 09:55:23 -0700 CachedResourceLoader::requestSVGDocument passes URL as charset 2012-10-18 23:54:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 marja marja abarth japhet jochen simonjam webkit.review.bot oldest_to_newest 745337 0 marja 2012-10-18 09:55:23 -0700 CachedResourceLoader::requestSVGDocument calls CachedResourceLoader::requestResource like this: CachedResourceHandle<CachedSVGDocument> CachedResourceLoader::requestSVGDocument(ResourceRequest& request) { return static_cast<CachedSVGDocument*>(requestResource(CachedResource::SVGDocumentResource, request, request.url(), defaultCachedResourceOptions()).get()); } and the requestResource signature is: CachedResourceHandle<CachedResource> requestResource(CachedResource::Type, ResourceRequest&, const String& charset, const ResourceLoaderOptions&, ResourceLoadPriority = ResourceLoadPriorityUnresolved, bool isPreload = false, DeferOption = NoDefer); So request.url() gets passed as charset. 745341 1 169428 marja 2012-10-18 09:59:09 -0700 Created attachment 169428 Patch 745423 2 169428 webkit.review.bot 2012-10-18 11:30:40 -0700 Comment on attachment 169428 Patch Clearing flags on attachment: 169428 Committed r131782: <http://trac.webkit.org/changeset/131782> 745424 3 webkit.review.bot 2012-10-18 11:30:44 -0700 All reviewed patches have been landed. Closing bug. 745993 4 ap 2012-10-18 22:44:08 -0700 This should have had an explanation of why a test case wasn't possible. 746065 5 jochen 2012-10-18 23:54:13 -0700 (In reply to comment #4) > This should have had an explanation of why a test case wasn't possible. Sorry, I had assumed that it was obvious Since the URL can't be parsed as a valid encoding, it was effectively treated as no encoding. Therefore, there's no change in functionality. Would you prefer to reland the patch with an updated ChangeLog? 169428 2012-10-18 09:59:09 -0700 2012-10-18 11:30:40 -0700 Patch bug-99730-20121018185754.patch text/plain 1639 marja U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNlYjkxMDliZGQwM2Ix Nzc3MTRmZmY1NmI2ZDVmMGEzMGZkMGJkMC4uZGRkZTk2MGZmZDkxNzc3MDVlYWQ1MTNiMDZkZWZk ZmExZDQ5OTFlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTE4ICBNYXJq YSBIw7ZsdHTDpCAgPG1hcmphQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXg6IENhY2hlZFJl c291cmNlTG9hZGVyOjpyZXF1ZXN0U1ZHRG9jdW1lbnQgd2FzIHBhc3NpbmcgYW4gVVJMIGFzIGNo YXJzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5 NzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBs b2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q2FjaGVkUmVzb3VyY2VMb2FkZXI6OnJlcXVlc3RTVkdEb2N1bWVudCk6CisKIDIwMTItMTAtMTYg IEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtQYWdl IFZpc2liaWxpdHkgQVBJXSBWaWV3LWxlc3MgZG9jdW1lbnRzIHNob3VsZCByZXBvcnQgYXMgaGlk ZGVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3Vy Y2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNl TG9hZGVyLmNwcAppbmRleCBjNmNlNDA2YjYzYTY3MDU3NGNjNWNkZDg2ZTgwOTY0ZWY5Y2U2NTc3 Li5lOTAxMTg1NmViZWU3OTc3ZWQwMWQ0NzczMmM1MjIxZjkwNDIyNGZkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAKQEAg LTIyOSw3ICsyMjksNyBAQCBDYWNoZWRSZXNvdXJjZUhhbmRsZTxDYWNoZWRYU0xTdHlsZVNoZWV0 PiBDYWNoZWRSZXNvdXJjZUxvYWRlcjo6cmVxdWVzdFhTTFN0eWxlUwogI2lmIEVOQUJMRShTVkcp CiBDYWNoZWRSZXNvdXJjZUhhbmRsZTxDYWNoZWRTVkdEb2N1bWVudD4gQ2FjaGVkUmVzb3VyY2VM b2FkZXI6OnJlcXVlc3RTVkdEb2N1bWVudChSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCiB7Ci0g ICAgcmV0dXJuIHN0YXRpY19jYXN0PENhY2hlZFNWR0RvY3VtZW50Kj4ocmVxdWVzdFJlc291cmNl KENhY2hlZFJlc291cmNlOjpTVkdEb2N1bWVudFJlc291cmNlLCByZXF1ZXN0LCByZXF1ZXN0LnVy bCgpLCBkZWZhdWx0Q2FjaGVkUmVzb3VyY2VPcHRpb25zKCkpLmdldCgpKTsKKyAgICByZXR1cm4g c3RhdGljX2Nhc3Q8Q2FjaGVkU1ZHRG9jdW1lbnQqPihyZXF1ZXN0UmVzb3VyY2UoQ2FjaGVkUmVz b3VyY2U6OlNWR0RvY3VtZW50UmVzb3VyY2UsIHJlcXVlc3QsIFN0cmluZygpLCBkZWZhdWx0Q2Fj aGVkUmVzb3VyY2VPcHRpb25zKCkpLmdldCgpKTsKIH0KICNlbmRpZgogCg==