99729 2012-10-18 09:45:55 -0700 Web Inspector: Invalid Regex in SASSSourceMapping/didRequestContent, breaks Support for Sass experiment 2012-10-19 03:09:21 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 damirz apavlov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 745330 0 damirz 2012-10-18 09:45:55 -0700 To reproduce the issue: 1. Create a Sass file with last rule on line 180 or further 1. Compile Sass with debug-info 3. Load a document that references compiled CSS — the feature will be broken. Even Sass files with less than 180 and more than100 lines will display wrong line numbers be wrong. It seems that the regex on the following line replaces too much: var line = parseInt(decodeURI(match[2].replace(/(..)/g, "%$1")), 10); see http://trac.webkit.org/browser/trunk/Source/WebCore/inspector/front-end/SASSSourceMapping.js?rev=129862#L86 The regex replaces value like "3170" with "%31%70" which decodes to "1p" whereas "170" was intended. Decoding value like "%31%83" throws URIError. A simple fix seems to be to replace "/(..)/g" with "/(.)/". 746175 1 169584 apavlov 2012-10-19 02:55:37 -0700 Created attachment 169584 Patch 746177 2 apavlov 2012-10-19 03:09:21 -0700 Committed r131883: <http://trac.webkit.org/changeset/131883> 169584 2012-10-19 02:55:37 -0700 2012-10-19 03:07:09 -0700 Patch bug-99729-20121019135421.patch text/plain 2427 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM5YTAxNzU2MzRjZjFj MWU0OTI0YjJiYTg4NDYwYzc3NjFlOTVkYi4uNTY0M2JjNDIyMjgzNmVlMjNmZDlmNmM3OTY5YWY4 YzBmMmRhNzg1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE5ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogSW52YWxpZCBSZWdleCBpbiBTQVNTU291cmNlTWFwcGluZy9kaWRSZXF1ZXN0Q29udGVu dCwgYnJlYWtzIFN1cHBvcnQgZm9yIFNhc3MgZXhwZXJpbWVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk3MjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWNvZGUgb25seSB0aGUgZmlyc3QgbGluZSBu dW1iZXIgZGlnaXQgd3JpdHRlbiBpbiBhIHNpeC1jaGFyYWN0ZXIgZXNjYXBlZCBVbmljb2RlIGZv cm1hdC4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU0FTU1NvdXJjZU1hcHBpbmcu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU0FTU1NvdXJjZU1hcHBpbmcucHJvdG90eXBlLl9y ZXNvdXJjZUFkZGVkLmRpZFJlcXVlc3RDb250ZW50KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5T QVNTU291cmNlTWFwcGluZy5wcm90b3R5cGUuX3Jlc291cmNlQWRkZWQpOgorCiAyMDEyLTEwLTE4 ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogW1N0eWxlc10gUHJvcGVydHkgY29uc2lkZXJlZCBvdmVycmlkZGVuIGlmIGl0 IGlzIG5vbi1pbmhlcml0ZWQgaW1wb3J0YW50IHByb3BlcnR5IGluIGluaGVyaXRlZCBzdHlsZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TQVNTU291cmNl TWFwcGluZy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU0FTU1NvdXJj ZU1hcHBpbmcuanMKaW5kZXggOWM3Y2FiNGU3MGM3ZTcyMmUwMTQwNWNmYWY3M2Y2ZGQwMDdhM2Rl Yy4uYTExNGRmOTAxY2FjMmJjMWFlNjI2NDQ4YWEyNGUyNDIwY2QwNzAyNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TQVNTU291cmNlTWFwcGluZy5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NBU1NTb3VyY2VNYXBwaW5n LmpzCkBAIC03NywxMyArNzcsMTMgQEAgV2ViSW5zcGVjdG9yLlNBU1NTb3VyY2VNYXBwaW5nLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIGlmICghY29udGVudCkKICAgICAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgICAgICB2YXIgbGluZXMgPSBjb250ZW50LnNwbGl0KC9ccj9cbi8pOwot ICAgICAgICAgICAgdmFyIGRlYnVnSW5mb1JlZ2V4ID0gL0BtZWRpYVxzXC1zYXNzXC1kZWJ1Z1wt aW5mb3tmaWxlbmFtZXtmb250LWZhbWlseTooW159XSspfWxpbmV7Zm9udC1mYW1pbHk6XFxbMF0r KFtefV0qKX19L2k7CisgICAgICAgICAgICB2YXIgZGVidWdJbmZvUmVnZXggPSAvQG1lZGlhXHNc LXNhc3NcLWRlYnVnXC1pbmZve2ZpbGVuYW1le2ZvbnQtZmFtaWx5OihbXn1dKyl9bGluZXtmb250 LWZhbWlseTpcXDAwMDAoXGRcZCkoW159XSopfX0vaTsKICAgICAgICAgICAgIHZhciBsaW5lTnVt YmVyc1JlZ2V4ID0gL1wvXCpccytsaW5lXHMrKFswLTldKyksXHMrKFteKlwvXSspLzsKICAgICAg ICAgICAgIGZvciAodmFyIGxpbmVOdW1iZXIgPSAwOyBsaW5lTnVtYmVyIDwgbGluZXMubGVuZ3Ro OyArK2xpbmVOdW1iZXIpIHsKICAgICAgICAgICAgICAgICB2YXIgbWF0Y2ggPSBkZWJ1Z0luZm9S ZWdleC5leGVjKGxpbmVzW2xpbmVOdW1iZXJdKTsKICAgICAgICAgICAgICAgICBpZiAobWF0Y2gp IHsKICAgICAgICAgICAgICAgICAgICAgdmFyIHVybCA9IG1hdGNoWzFdLnJlcGxhY2UoL1xcKC4p L2csICIkMSIpOwotICAgICAgICAgICAgICAgICAgICB2YXIgbGluZSA9IHBhcnNlSW50KGRlY29k ZVVSSShtYXRjaFsyXS5yZXBsYWNlKC8oLi4pL2csICIlJDEiKSksIDEwKTsKKyAgICAgICAgICAg ICAgICAgICAgdmFyIGxpbmUgPSBwYXJzZUludChkZWNvZGVVUkkoIiUiICsgbWF0Y2hbMl0pICsg bWF0Y2hbM10sIDEwKTsKICAgICAgICAgICAgICAgICAgICAgdGhpcy5fYmluZFVJU291cmNlQ29k ZSh1cmwsIGxpbmUsIHJlc291cmNlLnVybCwgbGluZU51bWJlcik7CiAgICAgICAgICAgICAgICAg ICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgIH0K