99727 2012-10-18 09:42:27 -0700 Make conversion between JSStringRef and WKStringRef work without character size conversions 2012-10-18 14:21:14 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff roger_fong webkit.review.bot oldest_to_newest 745326 0 msaboff 2012-10-18 09:42:27 -0700 The APIs WKStringRef WKStringCreateWithJSString(JSStringRef) and JSStringRef WKStringCopyJSString(WKStringRef) call the characters() method on their argument string to create the wrapped return string. This will cause 8-bit argument string to be up converted and create the results strings as 16 bit strings. Instead both of these API's should use the wrapped WTFString objects so that 8-bit strings stay that way. Due to threading, these API's need to create copies, but that is already done in OpaqueJSString. 745335 1 169427 msaboff 2012-10-18 09:54:31 -0700 Created attachment 169427 Patch 745340 2 169427 andersca 2012-10-18 09:58:36 -0700 Comment on attachment 169427 Patch Very nice! 745343 3 169427 gyuyoung.kim 2012-10-18 10:00:30 -0700 Comment on attachment 169427 Patch Attachment 169427 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14455140 745344 4 169427 webkit-ews 2012-10-18 10:01:34 -0700 Comment on attachment 169427 Patch Attachment 169427 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14461073 745357 5 169432 msaboff 2012-10-18 10:18:03 -0700 Created attachment 169432 Patch with fix to #include typo 745394 6 169432 webkit.review.bot 2012-10-18 11:07:16 -0700 Comment on attachment 169432 Patch with fix to #include typo Clearing flags on attachment: 169432 Committed r131777: <http://trac.webkit.org/changeset/131777> 745395 7 webkit.review.bot 2012-10-18 11:07:19 -0700 All reviewed patches have been landed. Closing bug. 745566 8 roger_fong 2012-10-18 14:17:11 -0700 Fixed windows build: http://trac.webkit.org/changeset/131801 745572 9 msaboff 2012-10-18 14:21:14 -0700 (In reply to comment #8) > Fixed windows build: http://trac.webkit.org/changeset/131801 Thanks. 169427 2012-10-18 09:54:31 -0700 2012-10-18 10:18:03 -0700 Patch 99727.patch text/plain 3469 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMxNzYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTEwLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIE1ha2UgY29udmVyc2lvbiBiZXR3ZWVuIEpTU3RyaW5nUmVmIGFuZCBXS1N0cmluZ1JlZiB3 b3JrIHdpdGhvdXQgY2hhcmFjdGVyIHNpemUgY29udmVyc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzI3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwb3J0IHRoZSBzdHJpbmcoKSBtZXRob2Qg Zm9yIHVzZSBpbiBXZWJLaXQuCisKKyAgICAgICAgKiBBUEkvT3BhcXVlSlNTdHJpbmcuaDoKKyAg ICAgICAgKE9wYXF1ZUpTU3RyaW5nOjpzdHJpbmcpOgorCiAyMDEyLTEwLTE4ICBSYXBoYWVsIEt1 Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgogCiAgICAgICAg IFtDTWFrZV0gQXZvaWQgdW5uZWNlc3NhcmlseSBydW5uaW5nIHRoZSBMTEludCBnZW5lcmF0aW9u IGNvbW1hbmRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9PcGFxdWVKU1N0cmlu Zy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvT3BhcXVlSlNTdHJp bmcuaAkocmV2aXNpb24gMTMxNjU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9PcGFx dWVKU1N0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw3ICs1MSw3IEBAIHN0cnVjdCBPcGFx dWVKU1N0cmluZyA6IHB1YmxpYyBUaHJlYWRTYWYKICAgICBjb25zdCBVQ2hhciogY2hhcmFjdGVy cygpIHsgcmV0dXJuICEhdGhpcyA/IG1fc3RyaW5nLmNoYXJhY3RlcnMoKSA6IDA7IH0KICAgICB1 bnNpZ25lZCBsZW5ndGgoKSB7IHJldHVybiAhIXRoaXMgPyBtX3N0cmluZy5sZW5ndGgoKSA6IDA7 IH0KIAotICAgIFN0cmluZyBzdHJpbmcoKSBjb25zdDsKKyAgICBKU19FWFBPUlRfUFJJVkFURSBT dHJpbmcgc3RyaW5nKCkgY29uc3Q7CiAgICAgSlNDOjpJZGVudGlmaWVyIGlkZW50aWZpZXIoSlND OjpKU0dsb2JhbERhdGEqKSBjb25zdDsKIAogcHJpdmF0ZToKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlz aW9uIDEzMTc2MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIE1ha2UgY29udmVyc2lvbiBiZXR3ZWVuIEpTU3RyaW5nUmVmIGFu ZCBXS1N0cmluZ1JlZiB3b3JrIHdpdGhvdXQgY2hhcmFjdGVyIHNpemUgY29udmVyc2lvbnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzI3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSB3cmFw cGVkIFdURlN0cmluZyBvYmplY3QgdG8gY29udmVydCBiZXR3ZWVuIEpTU3RyaW5nUmVmIGFuZCBX S1N0cmluZ1JlZi4KKworICAgICAgICAqIFNoYXJlZC9XZWJTdHJpbmcuaDoKKyAgICAgICAgKFdl YktpdDo6SlNTdHJpbmdDcmVhdGVXaXRoU3RyaW5nKToKKyAgICAgICAgKFdlYktpdDo6V2ViU3Ry aW5nOjpjcmVhdGUpOgorICAgICAgICAoV2ViS2l0OjpXZWJTdHJpbmc6OmNyZWF0ZUpTU3RyaW5n KToKKwogMjAxMi0xMC0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gRG9uJ3QgdXNlIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQgaW4g cHJpdmF0ZSBoZWFkZXJzIGluIFdlYktpdDIKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9X ZWJTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViU3RyaW5n LmgJKHJldmlzaW9uIDEzMTY1NikKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJTdHJpbmcu aAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsOSBAQAogI2RlZmluZSBXZWJTdHJpbmdfaAog CiAjaW5jbHVkZSAiQVBJT2JqZWN0LmgiCisjaW5jbHVkZSA8SmF2YVNDcmlwdENvcmUvSW5pdGlh bGl6ZVRocmVhZGluZy5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTU3RyaW5nUmVmLmg+ CisjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvT3BhcXVlSlNTdHJpbmcuaD4KICNpbmNsdWRlIDx3 dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogI2luY2x1 ZGUgPHd0Zi91bmljb2RlL1VURjguaD4KQEAgLTUyLDcgKzU0LDcgQEAgcHVibGljOgogCiAgICAg c3RhdGljIFBhc3NSZWZQdHI8V2ViU3RyaW5nPiBjcmVhdGUoSlNTdHJpbmdSZWYganNTdHJpbmdS ZWYpCiAgICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFdlYlN0cmluZyhTdHJpbmco SlNTdHJpbmdHZXRDaGFyYWN0ZXJzUHRyKGpzU3RyaW5nUmVmKSwgSlNTdHJpbmdHZXRMZW5ndGgo anNTdHJpbmdSZWYpKSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFdlYlN0cmluZyhT dHJpbmcoanNTdHJpbmdSZWYtPnN0cmluZygpKSkpOwogICAgIH0KIAogICAgIHN0YXRpYyBQYXNz UmVmUHRyPFdlYlN0cmluZz4gY3JlYXRlRnJvbVVURjhTdHJpbmcoY29uc3QgY2hhciogc3RyaW5n KQpAQCAtOTMsNyArOTUsMTEgQEAgcHVibGljOgogCiAgICAgY29uc3QgU3RyaW5nJiBzdHJpbmco KSBjb25zdCB7IHJldHVybiBtX3N0cmluZzsgfQogCi0gICAgSlNTdHJpbmdSZWYgY3JlYXRlSlNT dHJpbmcoKSBjb25zdCB7IHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKG1fc3Ry aW5nLmNoYXJhY3RlcnMoKSwgbV9zdHJpbmcubGVuZ3RoKCkpOyB9CisgICAgSlNTdHJpbmdSZWYg Y3JlYXRlSlNTdHJpbmcoKSBjb25zdAorICAgIHsKKyAgICAgICAgSlNDOjppbml0aWFsaXplVGhy ZWFkaW5nKCk7CisgICAgICAgIHJldHVybiBPcGFxdWVKU1N0cmluZzo6Y3JlYXRlKG1fc3RyaW5n KS5sZWFrUmVmKCk7CisgICAgfQogCiBwcml2YXRlOgogICAgIFdlYlN0cmluZygpCg== 169432 2012-10-18 10:18:03 -0700 2012-10-18 11:07:16 -0700 Patch with fix to #include typo 99727-2.patch text/plain 3469 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMxNzYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTEwLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIE1ha2UgY29udmVyc2lvbiBiZXR3ZWVuIEpTU3RyaW5nUmVmIGFuZCBXS1N0cmluZ1JlZiB3 b3JrIHdpdGhvdXQgY2hhcmFjdGVyIHNpemUgY29udmVyc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzI3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhwb3J0IHRoZSBzdHJpbmcoKSBtZXRob2Qg Zm9yIHVzZSBpbiBXZWJLaXQuCisKKyAgICAgICAgKiBBUEkvT3BhcXVlSlNTdHJpbmcuaDoKKyAg ICAgICAgKE9wYXF1ZUpTU3RyaW5nOjpzdHJpbmcpOgorCiAyMDEyLTEwLTE4ICBSYXBoYWVsIEt1 Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgogCiAgICAgICAg IFtDTWFrZV0gQXZvaWQgdW5uZWNlc3NhcmlseSBydW5uaW5nIHRoZSBMTEludCBnZW5lcmF0aW9u IGNvbW1hbmRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9PcGFxdWVKU1N0cmlu Zy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvT3BhcXVlSlNTdHJp bmcuaAkocmV2aXNpb24gMTMxNjU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9PcGFx dWVKU1N0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw3ICs1MSw3IEBAIHN0cnVjdCBPcGFx dWVKU1N0cmluZyA6IHB1YmxpYyBUaHJlYWRTYWYKICAgICBjb25zdCBVQ2hhciogY2hhcmFjdGVy cygpIHsgcmV0dXJuICEhdGhpcyA/IG1fc3RyaW5nLmNoYXJhY3RlcnMoKSA6IDA7IH0KICAgICB1 bnNpZ25lZCBsZW5ndGgoKSB7IHJldHVybiAhIXRoaXMgPyBtX3N0cmluZy5sZW5ndGgoKSA6IDA7 IH0KIAotICAgIFN0cmluZyBzdHJpbmcoKSBjb25zdDsKKyAgICBKU19FWFBPUlRfUFJJVkFURSBT dHJpbmcgc3RyaW5nKCkgY29uc3Q7CiAgICAgSlNDOjpJZGVudGlmaWVyIGlkZW50aWZpZXIoSlND OjpKU0dsb2JhbERhdGEqKSBjb25zdDsKIAogcHJpdmF0ZToKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlz aW9uIDEzMTc2MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIE1ha2UgY29udmVyc2lvbiBiZXR3ZWVuIEpTU3RyaW5nUmVmIGFu ZCBXS1N0cmluZ1JlZiB3b3JrIHdpdGhvdXQgY2hhcmFjdGVyIHNpemUgY29udmVyc2lvbnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzI3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSB3cmFw cGVkIFdURlN0cmluZyBvYmplY3QgdG8gY29udmVydCBiZXR3ZWVuIEpTU3RyaW5nUmVmIGFuZCBX S1N0cmluZ1JlZi4KKworICAgICAgICAqIFNoYXJlZC9XZWJTdHJpbmcuaDoKKyAgICAgICAgKFdl YktpdDo6SlNTdHJpbmdDcmVhdGVXaXRoU3RyaW5nKToKKyAgICAgICAgKFdlYktpdDo6V2ViU3Ry aW5nOjpjcmVhdGUpOgorICAgICAgICAoV2ViS2l0OjpXZWJTdHJpbmc6OmNyZWF0ZUpTU3RyaW5n KToKKwogMjAxMi0xMC0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gRG9uJ3QgdXNlIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQgaW4g cHJpdmF0ZSBoZWFkZXJzIGluIFdlYktpdDIKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9X ZWJTdHJpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViU3RyaW5n LmgJKHJldmlzaW9uIDEzMTY1NikKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJTdHJpbmcu aAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyArMjcsOSBAQAogI2RlZmluZSBXZWJTdHJpbmdfaAog CiAjaW5jbHVkZSAiQVBJT2JqZWN0LmgiCisjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSW5pdGlh bGl6ZVRocmVhZGluZy5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTU3RyaW5nUmVmLmg+ CisjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvT3BhcXVlSlNTdHJpbmcuaD4KICNpbmNsdWRlIDx3 dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogI2luY2x1 ZGUgPHd0Zi91bmljb2RlL1VURjguaD4KQEAgLTUyLDcgKzU0LDcgQEAgcHVibGljOgogCiAgICAg c3RhdGljIFBhc3NSZWZQdHI8V2ViU3RyaW5nPiBjcmVhdGUoSlNTdHJpbmdSZWYganNTdHJpbmdS ZWYpCiAgICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFdlYlN0cmluZyhTdHJpbmco SlNTdHJpbmdHZXRDaGFyYWN0ZXJzUHRyKGpzU3RyaW5nUmVmKSwgSlNTdHJpbmdHZXRMZW5ndGgo anNTdHJpbmdSZWYpKSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFdlYlN0cmluZyhT dHJpbmcoanNTdHJpbmdSZWYtPnN0cmluZygpKSkpOwogICAgIH0KIAogICAgIHN0YXRpYyBQYXNz UmVmUHRyPFdlYlN0cmluZz4gY3JlYXRlRnJvbVVURjhTdHJpbmcoY29uc3QgY2hhciogc3RyaW5n KQpAQCAtOTMsNyArOTUsMTEgQEAgcHVibGljOgogCiAgICAgY29uc3QgU3RyaW5nJiBzdHJpbmco KSBjb25zdCB7IHJldHVybiBtX3N0cmluZzsgfQogCi0gICAgSlNTdHJpbmdSZWYgY3JlYXRlSlNT dHJpbmcoKSBjb25zdCB7IHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKG1fc3Ry aW5nLmNoYXJhY3RlcnMoKSwgbV9zdHJpbmcubGVuZ3RoKCkpOyB9CisgICAgSlNTdHJpbmdSZWYg Y3JlYXRlSlNTdHJpbmcoKSBjb25zdAorICAgIHsKKyAgICAgICAgSlNDOjppbml0aWFsaXplVGhy ZWFkaW5nKCk7CisgICAgICAgIHJldHVybiBPcGFxdWVKU1N0cmluZzo6Y3JlYXRlKG1fc3RyaW5n KS5sZWFrUmVmKCk7CisgICAgfQogCiBwcml2YXRlOgogICAgIFdlYlN0cmluZygpCg==