99722 2012-10-18 08:14:15 -0700 [Qt][WK2] Plugins are overscaled with a custom devicePixelRatio 2013-01-27 14:21:25 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 kbalazs kbalazs abecsi allan.jensen cgarcia hausmann jturcotte oldest_to_newest 745262 0 kbalazs 2012-10-18 08:14:15 -0700 Context: bug 98518. This can be seen in MiniBrowser since we use a custom 1.5 devicePixelRatio. If I just make PluginProxy::contentsScaleFactor() return constant 1 it fixes this but we need to understand why, and where is the actual bug or the between us and mac. 753610 1 kbalazs 2012-10-29 10:52:55 -0700 I have problems with trying this on Mac. The idea of mine was to disable AC in MiniBrowser to trigger the actual code path that is causing the issue for us. Unfortunately I cannot make MiniBrowser use the PluginProcess of my build, for some reason it always use the one installed on the system. run-safari does not show any video for me (probably because I am using vnc, although MiniBrowser is playing them finely). I would appreciate if some of you who have direct access to a Mac could take a try with this ;) 777999 2 176504 kbalazs 2012-11-28 09:59:05 -0800 Created attachment 176504 Patch 783511 3 allan.jensen 2012-12-05 01:28:37 -0800 I think this important for 5.0. I am also concerned were the bug really is at. Isn't part of the point of devicePixelRatio that content such as text could be rendered at a higher resolution instead of being image scaled? Could it somehow be that we forget to report the correct size of the rendered plugin output? 783536 4 kbalazs 2012-12-05 01:50:31 -0800 (In reply to comment #3) > I think this important for 5.0. I am also concerned were the bug really is at. > > Isn't part of the point of devicePixelRatio that content such as text could be rendered at a higher resolution instead of being image scaled? Could it somehow be that we forget to report the correct size of the rendered plugin output? Although I don't have full understanding of how devicePixelRatio is and should handled, I can say this patch avoids the image scaling, and the plugin size is ok. Actually I cannot follow the logic in PluginProxy, or rather I believe it is wrong. Furthermore that code path is not tested since Mac is using the AC path for plugins, Gtk doesn't support devicePixelRatio yet, EFL doesn't support plugins yet. 783686 5 jturcotte 2012-12-05 05:59:56 -0800 The problem might be that we apply the scaling once more when we blit the already scalled plugin backing store onto our non-composited-content tiles. The real solution I think would be to get plugin backing stores rendered using AC, passed through a ShareableSurface. It is pretty innefficient to blit it again on tiles using the CPU for each update by the plugin. I think that we can live with this bug until then, I don't see any real-world use case where we would want a WebView with both plugins and a non-1.0 device pixel ratio. It just happens to be the default (for testing purposes) in MiniBrowser. 176504 2012-11-28 09:59:05 -0800 2013-01-27 14:21:25 -0800 Patch bug-99722-20121128185634.patch text/plain 1639 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2EwYjRiNzQxZjdmZjRh ODhiMzk3NDljYzhlODc0YmZhN2VhNzE0ZS4uZmMxZjgxMzVhNDdjOTdlNzdlOThjNjkxMTNkNzFk ZWRjNzkyMjE3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTI4ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdW1dLMl0gUGx1 Z2lucyBhcmUgb3ZlcnNjYWxlZCB3aXRoIGEgY3VzdG9tIGRldmljZVBpeGVsUmF0aW8KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NzIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IHNjYWxlIGNv bnNpZGVyIGNvbnRlbnRzIHNjYWxlIHdpdGggdGlsZWQgYmFja2luZyBzdG9yZS4KKyAgICAgICAg SXQncyBub3QgdmVyeSBjbGVhciBob3cgZG9lcyBpdCB3b3JrIG9uIG90aGVyIHBsYXRmb3JtcyBi dXQgYXQKKyAgICAgICAgbGVhc3Qgd2Uga25vdyB0aGF0IHRpbGVkIGJhY2tpbmcgc3RvcmUgaXMg cmVzcG9uc2libGUgZm9yCisgICAgICAgIGFwcGx5aW5nIHZpZXdwb3J0IGF0dHJpYnV0ZXMgYW5k IGluIHByYWN0aWNlIGl0IGZpeGVzIHRoZSBidWcuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1Bs dWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6OmNvbnRl bnRzU2NhbGVGYWN0b3IpOgorCiAyMDEyLTExLTI4ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0 b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgUmVncmVzc2lvbihyMTM1OTYyKTogQVNT RVJUSU9OIEZBSUxFRDogIW1fcGVkbmluZ1N5bmNCYWNraW5nU3RvcmVzLmNvbnRhaW5zKGxheWVy KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZp ZXcuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3Bw CmluZGV4IDZjNzRmNDYzM2ZiYjViMzdhYTE2NWY4ODk5NzhkMjJlMTU4ZjY1YzcuLjM2MDhhZWQ0 MmQ0YWU2ZmQxNzM3ZTk0MzI2MzUwYjg4YzJkOGQ3N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTEzNjUsOSArMTM2NSwxMCBA QCBtYWNoX3BvcnRfdCBQbHVnaW5WaWV3Ojpjb21wb3NpdGluZ1JlbmRlclNlcnZlclBvcnQoKQog CiBmbG9hdCBQbHVnaW5WaWV3Ojpjb250ZW50c1NjYWxlRmFjdG9yKCkKIHsKKyNpZiAhVVNFKFRJ TEVEX0JBQ0tJTkdfU1RPUkUpCiAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBmcmFtZSgpID8gZnJhbWUo KS0+cGFnZSgpIDogMCkKICAgICAgICAgcmV0dXJuIHBhZ2UtPmRldmljZVNjYWxlRmFjdG9yKCk7 Ci0gICAgICAgIAorI2VuZGlmCiAgICAgcmV0dXJuIDE7CiB9CiAgICAgCg==