99713 2012-10-18 06:15:43 -0700 MediaStream API: Do some cleanup in the chromium WebKit API 2012-10-19 00:33:22 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw abarth dglazkov eric.carlson feature-media-reviews fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 745196 0 tommyw 2012-10-18 06:15:43 -0700 1) Remove the deprecated version of WebMediaStreamDescriptor::initialize 2) Remove a deprecated constant from WebPeerConnection00HandlerClient 3) Make the two constructSDP functions in WebMediaStreamCenter optional to override. This is part of the preparation to remove PeerConnection00. 745207 1 169403 tommyw 2012-10-18 06:26:42 -0700 Created attachment 169403 Patch 745209 2 webkit.review.bot 2012-10-18 06:30:03 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 745212 3 tommyw 2012-10-18 06:32:18 -0700 Turns out point two could not yet be removed. 745599 4 abarth 2012-10-18 14:54:03 -0700 Can we remove webkitPeerConnection00 ? 745611 5 169403 webkit.review.bot 2012-10-18 15:08:38 -0700 Comment on attachment 169403 Patch Clearing flags on attachment: 169403 Committed r131814: <http://trac.webkit.org/changeset/131814> 745612 6 webkit.review.bot 2012-10-18 15:08:41 -0700 All reviewed patches have been landed. Closing bug. 746096 7 tommyw 2012-10-19 00:33:22 -0700 (In reply to comment #4) > Can we remove webkitPeerConnection00 ? Soon, very soon. It won't be in M24 stable for sure. 169403 2012-10-18 06:26:42 -0700 2012-10-18 15:08:38 -0700 Patch bug-99713-20121018152527.patch text/plain 5095 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA3MWM3NzNjZTE0ZmRh MTk2ZmFiYTNiZDNiOGRiMWI3OWVjZDUyOTc4Li5mMTViNzNjYTkwM2E5MzczMjIzOGVkNjJkYjdi NjRjMTZmMDRhODFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0xOCAg VG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KKworICAgICAgICBNZWRpYVN0 cmVhbSBBUEk6IERvIHNvbWUgY2xlYW51cCBpbiB0aGUgY2hyb21pdW0gV2ViS2l0IEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk3MTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmluZyB0aGUg ZGVwcmVjYXRlZCB2ZXJzaW9uIG9mIFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvcjo6aW5pdGlhbGl6 ZSBhbmQgbWFraW5nCisgICAgICAgIHRoZSB0d28gY29uc3RydWN0U0RQIGZ1bmN0aW9ucyBpbiBX ZWJNZWRpYVN0cmVhbUNlbnRlciBvcHRpb25hbCB0byBvdmVycmlkZS4KKyAgICAgICAgVGhpcyBp cyBwYXJ0IG9mIHRoZSBwcmVwYXJhdGlvbiB0byByZW1vdmUgUGVlckNvbm5lY3Rpb24wMC4KKwor ICAgICAgICAqIGNocm9taXVtL3B1YmxpYy9XZWJNZWRpYVN0cmVhbUNlbnRlci5oOgorICAgICAg ICAoV2ViS2l0OjpXZWJNZWRpYVN0cmVhbUNlbnRlcjo6Y29uc3RydWN0U0RQKToKKyAgICAgICAg KiBjaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmg6CisgICAgICAgIChX ZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IpOgorCiAyMDEyLTEwLTE3ICBBZHJpZW5uZSBXYWxrZXIg IDxlbm5lQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIE1ha2UgV2ViQ29udGVu dExheWVyIGluY2x1ZGUgd2hhdCBpdCB1c2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTk1NGU3MGE0ZTQ2ODVh MjJkMDQ0MDViZWFlYzgxZTkzMjg0MmQwNy4uYTRkMzhlNzM1NmRmMWMyMjNkMjM5NTExZmVmZWJl OTUyZDQ4MWQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE4ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogRG8gc29tZSBjbGVhbnVwIGluIHRoZSBjaHJvbWl1bSBXZWJLaXQgQVBJCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTcxMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92aW5nIHRoZSBkZXBy ZWNhdGVkIHZlcnNpb24gb2YgV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjppbml0aWFsaXplLgor CisgICAgICAgIE5vIHRlc3RpbmcgbmVlZGVkIHNpbmNlIG9ubHkgYW4gdW51c2VkIGZ1bmN0aW9u IGlzIHJlbW92ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1l ZGlhU3RyZWFtRGVzY3JpcHRvci5jcHA6CisKIDIwMTItMTAtMTggIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNldCBtaW4td2lkdGggcHJvcGVydHkgaW5zdGVh ZCBvZiB3aWR0aCBwcm9wZXJ0eSBmb3IgZGF0ZS90aW1lIGZpZWxkcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVN0cmVhbUNlbnRlci5oIGIvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVN0cmVhbUNlbnRlci5oCmluZGV4 IDJjZWE1ZTYyMjk4MTllZjE3NmZmZGNlZWY5ZGQ1NjdhMGQ3MWI3ODEuLmIzOTkxMDVhNzEyOWU3 ZmJkNDA2NTQ3NmM1ZDllYWQ1N2VlZjFlZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFTdHJlYW1DZW50ZXIuaAorKysgYi9Tb3VyY2UvUGxhdGZv cm0vY2hyb21pdW0vcHVibGljL1dlYk1lZGlhU3RyZWFtQ2VudGVyLmgKQEAgLTUxLDggKzUxLDgg QEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBkaWRSZW1vdmVNZWRpYVN0cmVhbVRyYWNrKGNv bnN0IFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYsIGNvbnN0IFdlYk1lZGlhU3RyZWFtQ29tcG9u ZW50JikgeyByZXR1cm4gZmFsc2U7IH07CiAgICAgdmlydHVhbCB2b2lkIGRpZFN0b3BMb2NhbE1l ZGlhU3RyZWFtKGNvbnN0IFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYpID0gMDsKICAgICB2aXJ0 dWFsIHZvaWQgZGlkQ3JlYXRlTWVkaWFTdHJlYW0oV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yJikg PSAwOwotICAgIHZpcnR1YWwgV2ViU3RyaW5nIGNvbnN0cnVjdFNEUChjb25zdCBXZWJJQ0VDYW5k aWRhdGVEZXNjcmlwdG9yJikgPSAwOwotICAgIHZpcnR1YWwgV2ViU3RyaW5nIGNvbnN0cnVjdFNE UChjb25zdCBXZWJTZXNzaW9uRGVzY3JpcHRpb25EZXNjcmlwdG9yJikgPSAwOworICAgIHZpcnR1 YWwgV2ViU3RyaW5nIGNvbnN0cnVjdFNEUChjb25zdCBXZWJJQ0VDYW5kaWRhdGVEZXNjcmlwdG9y JikgeyByZXR1cm4gV2ViU3RyaW5nKCk7IH0KKyAgICB2aXJ0dWFsIFdlYlN0cmluZyBjb25zdHJ1 Y3RTRFAoY29uc3QgV2ViU2Vzc2lvbkRlc2NyaXB0aW9uRGVzY3JpcHRvciYpIHsgcmV0dXJuIFdl YlN0cmluZygpOyB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmgg Yi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYk1lZGlhU3RyZWFtRGVzY3JpcHRv ci5oCmluZGV4IGQxYjM4NTM2N2Q5ODdkNTY0MmEwYWI3Y2UzOGM3ZWFhYTUzYzUxMzQuLjM0NTc1 Y2VjNTFiZWVjZGMzYmQ0MGFjMTE3NjdmOTU0MTgwNTBmNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmgKKysrIGIv U291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3Iu aApAQCAtNTksOSArNTksNiBAQCBwdWJsaWM6CiAKICAgICBXRUJLSVRfRVhQT1JUIHZvaWQgYXNz aWduKGNvbnN0IFdlYk1lZGlhU3RyZWFtRGVzY3JpcHRvciYpOwogCi0gICAgLy8gREVQUkVDQVRF RAotICAgIFdFQktJVF9FWFBPUlQgdm9pZCBpbml0aWFsaXplKGNvbnN0IFdlYlN0cmluZyYgbGFi ZWwsIGNvbnN0IFdlYlZlY3RvcjxXZWJNZWRpYVN0cmVhbVNvdXJjZT4mKTsKLQogICAgIFdFQktJ VF9FWFBPUlQgdm9pZCBpbml0aWFsaXplKGNvbnN0IFdlYlN0cmluZyYgbGFiZWwsIGNvbnN0IFdl YlZlY3RvcjxXZWJNZWRpYVN0cmVhbVNvdXJjZT4mIGF1ZGlvU291cmNlcywgY29uc3QgV2ViVmVj dG9yPFdlYk1lZGlhU3RyZWFtU291cmNlPiYgdmlkZW9Tb3VyY2VzKTsKICAgICBXRUJLSVRfRVhQ T1JUIHZvaWQgcmVzZXQoKTsKICAgICBib29sIGlzTnVsbCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJp dmF0ZS5pc051bGwoKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vc3VwcG9ydC9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IuY3Bw CmluZGV4IDM2Y2NlNzQzOTEzOTViNjBkZTNmODcwMDcyODI4MWRlNTMyZWQxNmUuLjk2YmFkN2Ix ZWFhYWM0MzZkMjNmZWM3ZjFjZTFjODE0MjIxZGRjNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYk1lZGlh U3RyZWFtRGVzY3JpcHRvci5jcHAKQEAgLTEyNSwyMCArMTI1LDYgQEAgV2ViTWVkaWFTdHJlYW1E ZXNjcmlwdG9yOjpvcGVyYXRvciBXZWJDb3JlOjpNZWRpYVN0cmVhbURlc2NyaXB0b3IqKCkgY29u c3QKICAgICByZXR1cm4gbV9wcml2YXRlLmdldCgpOwogfQogCi0vLyBGSVhNRTogQ2xlYW51cCB3 aGVuIHRoZSBjaHJvbWl1bSBjb2RlIGhhcyBzd2l0Y2hlZCB0byB0aGUgc3BsaXQgc291cmNlcyBp bXBsZW1lbnRhdGlvbi4KLXZvaWQgV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjppbml0aWFsaXpl KGNvbnN0IFdlYlN0cmluZyYgbGFiZWwsIGNvbnN0IFdlYlZlY3RvcjxXZWJNZWRpYVN0cmVhbVNv dXJjZT4mIHNvdXJjZXMpCi17Ci0gICAgTWVkaWFTdHJlYW1Tb3VyY2VWZWN0b3IgYXVkaW8sIHZp ZGVvOwotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgc291cmNlcy5zaXplKCk7ICsraSkgewot ICAgICAgICBNZWRpYVN0cmVhbVNvdXJjZSogY3VyciA9IHNvdXJjZXNbaV07Ci0gICAgICAgIGlm IChjdXJyLT50eXBlKCkgPT0gTWVkaWFTdHJlYW1Tb3VyY2U6OlR5cGVBdWRpbykKLSAgICAgICAg ICAgIGF1ZGlvLmFwcGVuZChjdXJyKTsKLSAgICAgICAgZWxzZSBpZiAoY3Vyci0+dHlwZSgpID09 IE1lZGlhU3RyZWFtU291cmNlOjpUeXBlVmlkZW8pCi0gICAgICAgICAgICB2aWRlby5hcHBlbmQo Y3Vycik7Ci0gICAgfQotICAgIG1fcHJpdmF0ZSA9IE1lZGlhU3RyZWFtRGVzY3JpcHRvcjo6Y3Jl YXRlKGxhYmVsLCBhdWRpbywgdmlkZW8pOwotfQotCiB2b2lkIFdlYk1lZGlhU3RyZWFtRGVzY3Jp cHRvcjo6aW5pdGlhbGl6ZShjb25zdCBXZWJTdHJpbmcmIGxhYmVsLCBjb25zdCBXZWJWZWN0b3I8 V2ViTWVkaWFTdHJlYW1Tb3VyY2U+JiBhdWRpb1NvdXJjZXMsIGNvbnN0IFdlYlZlY3RvcjxXZWJN ZWRpYVN0cmVhbVNvdXJjZT4mIHZpZGVvU291cmNlcykKIHsKICAgICBNZWRpYVN0cmVhbVNvdXJj ZVZlY3RvciBhdWRpbywgdmlkZW87Cg==