99684 2012-10-17 22:30:24 -0700 [EFL][WK2] Change the title of inspector window when inspected page is changed 2012-10-19 23:28:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 seokju.kwon webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco tmpsantos webkit.review.bot oldest_to_newest 744986 0 seokju.kwon 2012-10-17 22:30:24 -0700 Implement function to change the title of inspector window. 745007 1 169350 seokju.kwon 2012-10-17 23:30:18 -0700 Created attachment 169350 Patch 746170 2 169350 tmpsantos 2012-10-19 02:45:58 -0700 Comment on attachment 169350 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169350&action=review LGTM. > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:141 > + String title = "Web Inspector-" + url; Nit, maybe I would add a space before and after the dash. 746204 3 169595 seokju.kwon 2012-10-19 04:05:05 -0700 Created attachment 169595 Patch 746205 4 seokju.kwon 2012-10-19 04:06:09 -0700 (In reply to comment #2) > (From update of attachment 169350 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169350&action=review > > LGTM. > > > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:141 > > + String title = "Web Inspector-" + url; > > Nit, maybe I would add a space before and after the dash. Done. Thanks. 746916 5 169595 webkit.review.bot 2012-10-19 23:28:53 -0700 Comment on attachment 169595 Patch Clearing flags on attachment: 169595 Committed r131980: <http://trac.webkit.org/changeset/131980> 746917 6 webkit.review.bot 2012-10-19 23:28:57 -0700 All reviewed patches have been landed. Closing bug. 169350 2012-10-17 23:30:18 -0700 2012-10-19 04:04:59 -0700 Patch bug-99684-20121018152905.patch text/plain 1649 seokju.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2M1OGVhNTA4OWE2OWZl OWIzMTU0NDE5NTIyZmY1MzVlNmJmZThjZS4uZjdjMWNlYTMyOWFlMzM1ZTI0NDQ4YWM1ODVkMDBi MmZmYmVmNWEzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE3ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g Q2hhbmdlIHRoZSB0aXRsZSBvZiBpbnNwZWN0b3Igd2luZG93IHdoZW4gaW5zcGVjdGVkIHBhZ2Ug aXMgY2hhbmdlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTk2ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbXBsZW1lbnQgcGxhdGZvcm1JbnNwZWN0ZWRVUkxDaGFuZ2VkKCkgdG8gY2hhbmdlIHRoZSB0 aXRsZSBvZiBpbnNwZWN0b3Igd2luZG93CisgICAgICAgIHdoZW4gaW5zcGVjdGVkIHBhZ2UgaXMg Y2hhbmdlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1JbnNwZWN0 ZWRVUkxDaGFuZ2VkKToKKwogMjAxMi0xMC0xNyAgQnl1bmd3b28gTGVlICA8Ync4MC5sZWVAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW1dLMl0gRml4IGJ1aWxkIGJyZWFrCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkluc3BlY3RvclByb3h5RWZsLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwCmluZGV4 IGEyNGRjMzQzMDVmZWI2YWNiNTY4M2Q5YTZkNWQ1MjcyNmU0MTJiN2QuLjk5MzYxNTlmOGFiZTdi ODM2NTBjMGQ1ZGJjODk2ZWE4YTFmYTA2ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwCkBAIC0xMzMsOSArMTMzLDEz IEBAIGJvb2wgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtSXNGcm9udCgpCiAgICAgcmV0dXJu IGZhbHNlOwogfQogCi12b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUluc3BlY3RlZFVS TENoYW5nZWQoY29uc3QgU3RyaW5nJikKK3ZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3Jt SW5zcGVjdGVkVVJMQ2hhbmdlZChjb25zdCBTdHJpbmcmIHVybCkKIHsKLSAgICBub3RJbXBsZW1l bnRlZCgpOworICAgIGlmICghbV9pbnNwZWN0b3JXaW5kb3cpCisgICAgICAgIHJldHVybjsKKwor ICAgIFN0cmluZyB0aXRsZSA9ICJXZWIgSW5zcGVjdG9yLSIgKyB1cmw7CisgICAgZWNvcmVfZXZh c190aXRsZV9zZXQobV9pbnNwZWN0b3JXaW5kb3csIHRpdGxlLnV0ZjgoKS5kYXRhKCkpOwogfQog CiBTdHJpbmcgV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RvclBhZ2VVUkwoKSBjb25zdAo= 169595 2012-10-19 04:05:05 -0700 2012-10-19 23:28:53 -0700 Patch bug-99684-20121019200351.patch text/plain 1721 seokju.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDExYzViZWQzMmY0YTFl ZDZlYzlkMGUzMmJlMDkxM2RjODQwYmEzNy4uZWU2YzZjZWMyZjk0OGVhOGE2NTJmZmYxM2I5NDY5 ZmUzOGEwZjVkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE5ICBTZW9r anUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0g Q2hhbmdlIHRoZSB0aXRsZSBvZiBpbnNwZWN0b3Igd2luZG93IHdoZW4gaW5zcGVjdGVkIHBhZ2Ug aXMgY2hhbmdlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTk2ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbXBsZW1lbnQgcGxhdGZvcm1JbnNwZWN0ZWRVUkxDaGFuZ2VkKCkgdG8gY2hhbmdlIHRoZSB0 aXRsZSBvZiBpbnNwZWN0b3Igd2luZG93CisgICAgICAgIHdoZW4gaW5zcGVjdGVkIHBhZ2UgaXMg Y2hhbmdlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1JbnNwZWN0 ZWRVUkxDaGFuZ2VkKToKKwogMjAxMi0xMC0xOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViUGFnZVByb3h5OjpjYW5TaG93TUlNRVR5cGUo KSBzaG91bGQgcmV0dXJuIGZhbHNlIGZvciBwbHVnaW5zIHdoZW4gdGhleSBhcmUgZGlzYWJsZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJv eHlFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94 eUVmbC5jcHAKaW5kZXggYTI0ZGMzNDMwNWZlYjZhY2I1NjgzZDlhNmQ1ZDUyNzI2ZTQxMmI3ZC4u ZjQzMDIxODhlNzZlMWM1MzIxMTNhZjMzNmRkMjA4ZTgxMzU0NDU5YiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94eUVmbC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94eUVmbC5jcHAKQEAg LTEzMyw5ICsxMzMsMTMgQEAgYm9vbCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1Jc0Zyb250 KCkKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRm b3JtSW5zcGVjdGVkVVJMQ2hhbmdlZChjb25zdCBTdHJpbmcmKQordm9pZCBXZWJJbnNwZWN0b3JQ cm94eTo6cGxhdGZvcm1JbnNwZWN0ZWRVUkxDaGFuZ2VkKGNvbnN0IFN0cmluZyYgdXJsKQogewot ICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgaWYgKCFtX2luc3BlY3RvcldpbmRvdykKKyAgICAg ICAgcmV0dXJuOworCisgICAgU3RyaW5nIHRpdGxlID0gIldlYkluc3BlY3RvciAtICIgKyB1cmw7 CisgICAgZWNvcmVfZXZhc190aXRsZV9zZXQobV9pbnNwZWN0b3JXaW5kb3csIHRpdGxlLnV0Zjgo KS5kYXRhKCkpOwogfQogCiBTdHJpbmcgV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RvclBhZ2VV UkwoKSBjb25zdAo=