99683 2012-10-17 22:27:45 -0700 JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN) 2014-01-18 11:37:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126492 0 jeremyhu webkit-unassigned barraclough berto cgarcia ggaren oldest_to_newest 744985 0 jeremyhu 2012-10-17 22:27:45 -0700 Source/JavaScriptCore/heap/VTableSpectrum.cpp uses PLATFORM(MAC) for some dladdr-foo, but that is valid based on OS(DARWIN) rather than PLATFORM(MAC) ... ie, it's valid for darwin/qt, darwin/gtk, etc. 744987 1 jeremyhu 2012-10-17 22:31:11 -0700 It looks like the same mis-use is occurring in: Source/JavaScriptCore/jit/ThunkGenerators.cpp Source/JavaScriptCore/tools/CodeProfile.cpp 964105 2 berto 2014-01-03 08:24:11 -0800 (In reply to comment #0) > Source/JavaScriptCore/heap/VTableSpectrum.cpp uses PLATFORM(MAC) for > some dladdr-foo, but that is valid based on OS(DARWIN) rather than > PLATFORM(MAC) ... ie, it's valid for darwin/qt, darwin/gtk, etc. That file does not exist anymore, I would propose to close this bug but you mention other files that might be affected by the same problem. Is this still relevant? Are there other files to take care of? 964111 3 jeremyhu 2014-01-03 08:42:59 -0800 (In reply to comment #2) > (In reply to comment #0) > > Source/JavaScriptCore/heap/VTableSpectrum.cpp uses PLATFORM(MAC) for > > some dladdr-foo, but that is valid based on OS(DARWIN) rather than > > PLATFORM(MAC) ... ie, it's valid for darwin/qt, darwin/gtk, etc. > > That file does not exist anymore, I would propose to close this bug > but you mention other files that might be affected by the same > problem. > > Is this still relevant? Are there other files to take care of? It still exists in the latest released version of webkit-gtk (2.2.3). I'll try updating our Portfile to use 2.3.x to see if anything else falls out with that beta release. As of 2.2.3, we still needed to do the following changes: # https://bugs.webkit.org/show_bug.cgi?id=99683 reinplace "s:PLATFORM(MAC):OS(DARWIN):g" \ ${worksrcpath}/Source/JavaScriptCore/heap/VTableSpectrum.cpp \ ${worksrcpath}/Source/JavaScriptCore/jit/ThunkGenerators.cpp \ ${worksrcpath}/Source/JavaScriptCore/tools/CodeProfile.cpp # https://bugs.webkit.org/show_bug.cgi?id=58737 reinplace "s:OS(MAC_OS_X):PLATFORM(MAC):" \ ${worksrcpath}/Source/WTF/wtf/ThreadingPthreads.cpp 968618 4 221336 berto 2014-01-15 22:59:00 -0800 Created attachment 221336 Patch (In reply to comment #3) > As of 2.2.3, we still needed to do the following changes: > > # https://bugs.webkit.org/show_bug.cgi?id=99683 > reinplace "s:PLATFORM(MAC):OS(DARWIN):g" \ > ${worksrcpath}/Source/JavaScriptCore/heap/VTableSpectrum.cpp \ > ${worksrcpath}/Source/JavaScriptCore/jit/ThunkGenerators.cpp \ > ${worksrcpath}/Source/JavaScriptCore/tools/CodeProfile.cpp VTableSpectrum.cpp no longer exists, but else it's fine. Here's the updated patch. 969487 5 berto 2014-01-18 11:37:48 -0800 Committed r162266: <http://trac.webkit.org/changeset/162266> 221336 2014-01-15 22:59:00 -0800 2014-01-18 11:21:32 -0800 Patch 99683.diff text/plain 2581 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDJiMjA1ZTMuLmExODNhMDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTE1ICBBbGJlcnRvIEdhcmNp YSAgPGJlcnRvQGlnYWxpYS5jb20+CisKKyAgICAgICAgSmF2YVNjcmlwdENvcmUgdXNlcyBQTEFU Rk9STShNQUMpIHdoZW4gaXQgbWVhbnMgT1MoREFSV0lOKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk2ODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMuY3BwOgorICAg ICAgICAqIHRvb2xzL0NvZGVQcm9maWxlLmNwcDoKKyAgICAgICAgKEpTQzo6c3ltYm9sTmFtZSk6 CisgICAgICAgIChKU0M6OkNvZGVQcm9maWxlOjpzYW1wbGUpOgorCiAyMDE0LTAxLTE1ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQ2xlYW4g dXAgUkVNT1RFX0lOU1BFQ1RPUiBjb2RlIGluIE9wZW5Tb3VyY2UgYWZ0ZXIgdGhlIGlPUyBtZXJn ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCmluZGV4 IDVhMjk0MzIuLjExODc1Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv VGh1bmtHZW5lcmF0b3JzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5r R2VuZXJhdG9ycy5jcHAKQEAgLTYwMyw3ICs2MDMsNyBAQCBkb3VibGUganNSb3VuZChkb3VibGUg ZCkKIAogfQogCi0jaWYgQ1BVKFg4Nl82NCkgJiYgQ09NUElMRVIoR0NDKSAmJiAoUExBVEZPUk0o TUFDKSB8fCBPUyhMSU5VWCkpCisjaWYgQ1BVKFg4Nl82NCkgJiYgQ09NUElMRVIoR0NDKSAmJiAo T1MoREFSV0lOKSB8fCBPUyhMSU5VWCkpCiAKICNkZWZpbmUgZGVmaW5lVW5hcnlEb3VibGVPcFdy YXBwZXIoZnVuY3Rpb24pIFwKICAgICBhc20oIFwKQEAgLTYxOSw3ICs2MTksNyBAQCBkb3VibGUg anNSb3VuZChkb3VibGUgZCkKICAgICB9IFwKICAgICBzdGF0aWMgTWF0aFRodW5rIFVuYXJ5RG91 YmxlT3BXcmFwcGVyKGZ1bmN0aW9uKSA9ICZmdW5jdGlvbiMjVGh1bms7CiAKLSNlbGlmIENQVShY ODYpICYmIENPTVBJTEVSKEdDQykgJiYgKFBMQVRGT1JNKE1BQykgfHwgT1MoTElOVVgpKQorI2Vs aWYgQ1BVKFg4NikgJiYgQ09NUElMRVIoR0NDKSAmJiAoT1MoREFSV0lOKSB8fCBPUyhMSU5VWCkp CiAjZGVmaW5lIGRlZmluZVVuYXJ5RG91YmxlT3BXcmFwcGVyKGZ1bmN0aW9uKSBcCiAgICAgYXNt KCBcCiAgICAgICAgICIudGV4dFxuIiBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvdG9vbHMvQ29kZVByb2ZpbGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0Nv ZGVQcm9maWxlLmNwcAppbmRleCA1OTllZmZhLi5iOTlkZjJjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvdG9vbHMvQ29kZVByb2ZpbGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS90b29scy9Db2RlUHJvZmlsZS5jcHAKQEAgLTMzLDcgKzMzLDcgQEAKICNpbmNsdWRl IDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKLSNpZiBQ TEFURk9STShNQUMpCisjaWYgT1MoREFSV0lOKQogI2luY2x1ZGUgPGN4eGFiaS5oPgogI2luY2x1 ZGUgPGRsZmNuLmg+CiAjaW5jbHVkZSA8ZXhlY2luZm8uaD4KQEAgLTU2LDcgKzU2LDcgQEAgY29u c3QgY2hhciogQ29kZVByb2ZpbGU6OnNfY29kZVR5cGVOYW1lc1tDb2RlUHJvZmlsZTo6TnVtYmVy T2ZDb2RlVHlwZXNdID0gewogLy8gSGVscGVyIGZ1bmN0aW9uLCBmaW5kIHRoZSBzeW1ib2wgbmFt ZSBmb3IgYSBwYyBpbiBKU0MuCiBzdGF0aWMgY29uc3QgY2hhciogc3ltYm9sTmFtZSh2b2lkKiBh ZGRyZXNzKQogewotI2lmIFBMQVRGT1JNKE1BQykKKyNpZiBPUyhEQVJXSU4pCiAgICAgRGxfaW5m byBpbmZvOwogICAgIGlmICghZGxhZGRyKGFkZHJlc3MsICZpbmZvKSB8fCAhaW5mby5kbGlfc25h bWUpCiAgICAgICAgIHJldHVybiAiPHVua25vd24+IjsKQEAgLTEyMyw3ICsxMjMsNyBAQCB2b2lk IENvZGVQcm9maWxlOjpzYW1wbGUodm9pZCogcGMsIHZvaWQqKiBmcmFtZVBvaW50ZXIpCiAgICAg ICAgIGlmICh0eXBlICE9IEVuZ2luZUZyYW1lKQogICAgICAgICAgICAgcmV0dXJuOwogCi0jaWYg UExBVEZPUk0oTUFDKSAmJiBDUFUoWDg2XzY0KQorI2lmIE9TKERBUldJTikgJiYgQ1BVKFg4Nl82 NCkKICAgICAgICAgLy8gV2FsayB1cCB0aGUgc3RhY2suCiAgICAgICAgIHBjID0gZnJhbWVQb2lu dGVyWzFdOwogICAgICAgICBmcmFtZVBvaW50ZXIgPSByZWludGVycHJldF9jYXN0PHZvaWQqKj4o KmZyYW1lUG9pbnRlcik7Cg==