99681 2012-10-17 21:57:32 -0700 [EFL][WK2] Move ewk_{init,shutdown}() to the main() function of EFL API test. 2012-10-18 21:13:32 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97173 1 enmi.lee enmi.lee gyuyoung.kim lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 744958 0 enmi.lee 2012-10-17 21:57:32 -0700 The ewk_{init,shutdown} is called whenever processing the each test (i.e. creating and deleting ewk_view), so tests can be failed if EFL libraries functions are called between ewk_shutdown() and next ewk_init(). In the current codes, initializing and shutdown are done in the RunLoop() and RunLoop() is created only one time during testing, so there is no problem. However, the problem appears when we move initializing and shutdown of EFL libraries to the ewk_{init, shutdown}() by https://bugs.webkit.org/show_bug.cgi?id=97173. The initializing and shutdown codes have to be in the ewk_{init,shutdown} not RunLoop(). So, I fix the EFL API test codes firstly to prevent before failing tests by https://bugs.webkit.org/show_bug.cgi?id=97173. 745131 1 169384 enmi.lee 2012-10-18 03:29:27 -0700 Created attachment 169384 Patch 745910 2 169384 gyuyoung.kim 2012-10-18 19:41:04 -0700 Comment on attachment 169384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169384&action=review > Source/WebKit2/ChangeLog:9 > + so tests can be failed if EFL libraries APIs are called between Is it possible EFL API is called between ewk_shutdown and next ewk_init ? 745917 3 enmi.lee 2012-10-18 19:46:48 -0700 (In reply to comment #2) > (From update of attachment 169384 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169384&action=review > > > Source/WebKit2/ChangeLog:9 > > + so tests can be failed if EFL libraries APIs are called between > > Is it possible EFL API is called between ewk_shutdown and next ewk_init ? Sure, that is the problem of API tests. The ecore_pipe_write() can be called to send/receive between ui process and web process, and ecore_timer APIs can be called to test with url loading. They are failed with Bug 97173 because RunLoop does not cover their fault anymore. 745920 4 169384 gyuyoung.kim 2012-10-18 19:53:26 -0700 Comment on attachment 169384 Patch Looks make sense. Please landing this after verifying there is no problem in both release and debug API test. 745947 5 ryuan.choi 2012-10-18 21:12:31 -0700 Committed r131851: <http://trac.webkit.org/changeset/131851> 745948 6 ryuan.choi 2012-10-18 21:13:18 -0700 (In reply to comment #4) > (From update of attachment 169384 [details]) > Looks make sense. Please landing this after verifying there is no problem in both release and debug API test. I verified API tests of both release and debug. It works fine in my local. 169384 2012-10-18 03:29:27 -0700 2012-10-18 21:13:32 -0700 Patch bug-99681-20121018192813.patch text/plain 2845 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmNkMzE0NDhiOTJiYTIx MTcxYzg5OTg2YjRhNDkzYzNlYWI3N2UzMS4uODNjZTk0ZjFlNmU3ZTgzODNkZjIxNzJlYjBjZGVl Yjk4OTYyNDE4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTE4ICBFdW5t aSBMZWUgIDxldW5taTE1LmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIE1v dmUgZXdrX3tpbml0LHNodXRkb3dufSgpIHRvIHRoZSBtYWluKCkgZnVuY3Rpb24gb2YgRUZMIEFQ SSB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTk2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgZXdrX3tpbml0LHNodXRkb3dufSgpIGlzIGNhbGxlZCB3aGVuZXZlciBwcm9jZXNzaW5nIHRo ZSBlYWNoIHRlc3QsCisgICAgICAgIHNvIHRlc3RzIGNhbiBiZSBmYWlsZWQgaWYgRUZMIGxpYnJh cmllcyBBUElzIGFyZSBjYWxsZWQgYmV0d2VlbgorICAgICAgICBld2tfc2h1dGRvd24oKSBhbmQg bmV4dCBld2tfaW5pdCgpLgorICAgICAgICBUaGUgZXdrX3tpbml0LHNodXRkb3dufSgpIHNob3Vs ZCBiZSBjYWxsZWQgb25jZSBwZXIgYXBwbGljYXRpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwOgorICAgICAg ICAoRVdLMlVuaXRUZXN0OjpFV0syVW5pdFRlc3RCYXNlOjpTZXRVcCk6CisgICAgICAgIChFV0sy VW5pdFRlc3Q6OkVXSzJVbml0VGVzdEJhc2U6OlRlYXJEb3duKToKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdE1haW4uY3BwOgorICAg ICAgICAobWFpbik6CisKIDIwMTItMTAtMTggIEJ5dW5nd29vIExlZSAgPGJ3ODAubGVlQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFtXSzJdIFVwZGF0ZSB0ZXN0IGV4cGVjdGF0aW9uIGZvciB0aGUg cHl0aG9uIG1lc3NhZ2UgdGVzdCBhZnRlciByMTMxNzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJh c2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RV dGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcAppbmRleCBlMDJmMDExY2FkYjNmZTFmNzVjMWQxOThl YmUxNjc3NTAzNTUyMGY4Li42M2QzMTUwNTBhMTliZWI0YzFhODk3MThkMDQyYmYwNDJkM2IwOTBk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0 VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKQEAg LTQ1LDggKzQ1LDYgQEAgRVdLMlVuaXRUZXN0QmFzZTo6RVdLMlVuaXRUZXN0QmFzZSgpCiAKIHZv aWQgRVdLMlVuaXRUZXN0QmFzZTo6U2V0VXAoKQogewotICAgIGV3a19pbml0KCk7Ci0KICAgICB1 bnNpZ25lZCBpbnQgd2lkdGggPSBlbnZpcm9ubWVudC0+ZGVmYXVsdFdpZHRoKCk7CiAgICAgdW5z aWduZWQgaW50IGhlaWdodCA9IGVudmlyb25tZW50LT5kZWZhdWx0SGVpZ2h0KCk7CiAKQEAgLTY4 LDcgKzY2LDYgQEAgdm9pZCBFV0syVW5pdFRlc3RCYXNlOjpUZWFyRG93bigpCiB7CiAgICAgZXZh c19vYmplY3RfZGVsKG1fd2ViVmlldyk7CiAgICAgZWNvcmVfZXZhc19mcmVlKG1fZWNvcmVFdmFz KTsKLSAgICBld2tfc2h1dGRvd24oKTsKIH0KIAogYm9vbCBFV0syVW5pdFRlc3RCYXNlOjpsb2Fk VXJsU3luYyhjb25zdCBjaGFyKiB1cmwsIGRvdWJsZSB0aW1lb3V0U2Vjb25kcykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMv RVdLMlVuaXRUZXN0TWFpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90 ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdE1haW4uY3BwCmluZGV4IDc3OGQyNjFlODFj MWQzYTFiMmI2NDc4MTE5MjI5N2NhNmRlM2ZhMzkuLjRmNjA3NTZlMTc0ZWRjZDVhOWY5YTRiNzgx NTkyMmMzYjY5ZDk5M2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0TWFpbi5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRl c3RNYWluLmNwcApAQCAtMjgsMTAgKzI4LDE2IEBAIEVXSzJVbml0VGVzdEVudmlyb25tZW50KiBl bnZpcm9ubWVudCA9IDA7CiAKIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKIHsKKyAg ICBld2tfaW5pdCgpOworCiAgICAgOjp0ZXN0aW5nOjpJbml0R29vZ2xlVGVzdCgmYXJnYywgYXJn dik7CiAKICAgICBlbnZpcm9ubWVudCA9IG5ldyBFV0syVW5pdFRlc3RFbnZpcm9ubWVudCgpOwog ICAgIHRlc3Rpbmc6OkFkZEdsb2JhbFRlc3RFbnZpcm9ubWVudChlbnZpcm9ubWVudCk7CiAKLSAg ICByZXR1cm4gUlVOX0FMTF9URVNUUygpOworICAgIGludCByZXN1bHQgPSBSVU5fQUxMX1RFU1RT KCk7CisKKyAgICBld2tfc2h1dGRvd24oKTsKKworICAgIHJldHVybiByZXN1bHQ7CiB9Cg==