99654 2012-10-17 16:29:45 -0700 REGRESSION (r95391): ComplexTextController is unnecessarily slow with characters with combining marks when the base character is not covered by any font 2012-10-17 22:02:16 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz psolanki oldest_to_newest 744766 0 mitz 2012-10-17 16:29:45 -0700 REGRESSION (r95391): ComplexTextController is unnecessarily slow with characters with combining marks when the base character is not covered by any font 744767 1 mitz 2012-10-17 16:30:14 -0700 <rdar://problem/12402300> 744778 2 169297 mitz 2012-10-17 16:42:56 -0700 Created attachment 169297 Patch 744964 3 mitz 2012-10-17 22:02:16 -0700 Fixed in <http://trac.webkit.org/r131703>. 169297 2012-10-17 16:42:56 -0700 2012-10-17 21:57:11 -0700 Patch bug-99654-20121017164143.patch text/plain 7083 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTY2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBACisyMDEyLTEwLTE3ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjk1MzkxKTog Q29tcGxleFRleHRDb250cm9sbGVyIGlzIHVubmVjZXNzYXJpbHkgc2xvdyB3aXRoIGNoYXJhY3Rl cnMgd2l0aCBjb21iaW5pbmcgbWFya3Mgd2hlbiB0aGUgYmFzZSBjaGFyYWN0ZXIgaXMgbm90IGNv dmVyZWQgYnkgYW55IGZvbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk5NjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiB0aGUgYmFzZSBjaGFyYWN0ZXIgb2YgYSBjb21iaW5pbmcgY2hhcmFjdGVy IHNlcXVlbmNlIGlzIG5vdCBjb3ZlcmVkIGJ5IGFueSBvbmUgb2YgdGhlCisgICAgICAgIGF2YWls YWJsZSBmb250cywgdGhlcmUgaXMgbm8gcG9pbnQgbG9va2luZyBmb3IgYSBmb250IHRoYXQgY292 ZXJzIHRoZSBlbnRpcmUgc2VxdWVuY2UsIG5vcgorICAgICAgICB0byB0cnkgdG8gdXNlIGEgY29t YmluYXRpb24gb2YgZmFsbGJhY2sgZm9udHMgZm9yIHRoZSBlbnRpcmUgc2VxdWVuY2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVGb250RGF0YS5oOgorICAgICAgICAoV2Vi Q29yZTo6U2ltcGxlRm9udERhdGE6OnN5c3RlbUZhbGxiYWNrKTogTW92ZWQgQ29tcGxleFRleHRD b250cm9sbGVyOjpzeXN0ZW1GYWxsYmFja0ZvbnREYXRhCisgICAgICAgIGhlcmUgYW5kIHJlbmFt ZWQgaXQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJv bGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNvbGxl Y3RDb21wbGV4VGV4dFJ1bnMpOiBUaGlzIGZ1bmN0aW9uIHVzZWQgdG8gdXNlCisgICAgICAgIHN5 c3RlbUZhbGxiYWNrRm9udERhdGEoKSB3aGVuZXZlciBGb250Ojpmb250RGF0YUZvckNvbWJpbmlu Z0NoYXJhY3RlclNlcXVlbmNlIHJldHVybmVkIDAKKyAgICAgICAgZm9yIGEgYmFzZSBjaGFyYWN0 ZXIgd2l0aCBjb21iaW5pbmcgbWFya3MsIHJlZ2FyZGxlc3Mgb2Ygd2hldGhlciB0aGUgYmFzZSBj aGFyYWN0ZXIgd2FzCisgICAgICAgIGNvdmVyZWQgYnkgYW55IGZvbnQuIENoYW5nZWQgaXQgdG8g cHJlc2VydmUgdGhlIHJldHVybiB2YWx1ZSBvZgorICAgICAgICBmb250RGF0YUZvckNvbWJpbmlu Z0NoYXJhY3RlclNlcXVlbmNlLCB3aGljaCBpcyBub3cgMCBvbmx5IGlmIHRoZSBiYXNlIGNoYXJj YXRlciBpcyBub3QgaW4KKyAgICAgICAgYW55IGZvbnQsIHdoaWxlIHN5c3RlbUZhbGxiYWNrRm9u dERhdGEoKSBpcyB1c2VkIHRvIGluZGljYXRlIHRoYXQgbm8gc2luZ2xlIGZvbnQgaW4gdGhlCisg ICAgICAgIGZhbGxiYWNrIGxpc3QgY292ZXJzIGFsbCBjaGFyYWN0ZXJzIGluIHRoZSBzZXF1ZW5j ZSwgYnV0IHRoZSBiYXNlIGNoYXJhY3RlciBpcyBpbiBzb21lIGZvbnQuCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5oOgorICAgICAgICAoQ29t cGxleFRleHRDb250cm9sbGVyKTogTW92ZWQgc3lzdGVtRmFsbGJhY2tGb250RGF0YSBmcm9tIGhl cmUgdG8gU2ltcGxlRm9udERhdGEuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0Nv bXBsZXhUZXh0Q29udHJvbGxlckNvcmVUZXh0Lm1tOgorICAgICAgICAoV2ViQ29yZTo6Q29tcGxl eFRleHRDb250cm9sbGVyOjpjb2xsZWN0Q29tcGxleFRleHRSdW5zRm9yQ2hhcmFjdGVycyk6IFVw ZGF0ZWQgZm9yIHRoZSBhYm92ZQorICAgICAgICBtb3ZlLgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL21hYy9Gb250Q29tcGxleFRleHRNYWMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9u dDo6Zm9udERhdGFGb3JDb21iaW5pbmdDaGFyYWN0ZXJTZXF1ZW5jZSk6IENoYW5nZWQgdG8gcmV0 dXJuCisgICAgICAgIHN5c3RlbUZhbGxiYWNrRm9udERhdGEoKSBpZiBubyBzaW5nbGUgZm9udCBp biB0aGUgZmFsbGJhY2sgbGlzdCBjb3ZlcnMgYWxsIGNoYXJhY3RlcnMgaW4gdGhlCisgICAgICAg IHNlcXVlbmNlLCB3aGlsZSB1c2luZyAwIHRvIHNpZ25hbCB0aGUgYmFzZSBjaGFyYWN0ZXIgZG9l cyBub3QgZXhpc3QgaW4gYW55IGZvbnQuCisKIDIwMTItMTAtMTcgIEFsbGFuIFNhbmRmZWxkIEpl bnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBDZXJ0YWluIFNW RyBjb250ZW50IGZyZWV6ZXMgUXRXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaAkocmV2aXNpb24gMTMxNTM2KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU2ltcGxlRm9udERhdGEuaAkod29ya2lu ZyBjb3B5KQpAQCAtOTgsNiArOTgsOCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5TaW1wbGVG b250RGF0YSgpOwogCisgICAgc3RhdGljIGNvbnN0IFNpbXBsZUZvbnREYXRhKiBzeXN0ZW1GYWxs YmFjaygpIHsgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgU2ltcGxlRm9udERhdGEqPigt MSk7IH0KKwogICAgIGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIHBsYXRmb3JtRGF0YSgpIGNvbnN0 IHsgcmV0dXJuIG1fcGxhdGZvcm1EYXRhOyB9CiAjaWYgRU5BQkxFKE9QRU5UWVBFX1ZFUlRJQ0FM KQogICAgIGNvbnN0IE9wZW5UeXBlVmVydGljYWxEYXRhKiB2ZXJ0aWNhbERhdGEoKSBjb25zdCB7 IHJldHVybiBtX3ZlcnRpY2FsRGF0YTsgfQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5j cHAJKHJldmlzaW9uIDEzMTUzNikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjksMTIg KzMyOSw4IEBAIHZvaWQgQ29tcGxleFRleHRDb250cm9sbGVyOjpjb2xsZWN0Q29tcGwKICAgICBu ZXh0SXNNaXNzaW5nR2x5cGggPSBmYWxzZTsKICNpZiAhUExBVEZPUk0oV1gpCiAgICAgbmV4dEZv bnREYXRhID0gbV9mb250LmZvbnREYXRhRm9yQ29tYmluaW5nQ2hhcmFjdGVyU2VxdWVuY2Uoc2Vx dWVuY2VTdGFydCwgY3VyciAtIHNlcXVlbmNlU3RhcnQsIG5leHRJc1NtYWxsQ2FwcyA/IFNtYWxs Q2Fwc1ZhcmlhbnQgOiBOb3JtYWxWYXJpYW50KTsKLSAgICBpZiAoIW5leHRGb250RGF0YSkgewot ICAgICAgICBpZiAobWFya0NvdW50KQotICAgICAgICAgICAgbmV4dEZvbnREYXRhID0gc3lzdGVt RmFsbGJhY2tGb250RGF0YSgpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBuZXh0SXNNaXNz aW5nR2x5cGggPSB0cnVlOwotICAgIH0KKyAgICBpZiAoIW5leHRGb250RGF0YSkKKyAgICAgICAg bmV4dElzTWlzc2luZ0dseXBoID0gdHJ1ZTsKICNlbmRpZgogCiAgICAgd2hpbGUgKGN1cnIgPCBl bmQpIHsKQEAgLTM2MSwxMiArMzU3LDggQEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNv bGxlY3RDb21wbAogI2lmICFQTEFURk9STShXWCkKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAg ICBuZXh0Rm9udERhdGEgPSBtX2ZvbnQuZm9udERhdGFGb3JDb21iaW5pbmdDaGFyYWN0ZXJTZXF1 ZW5jZShjcCArIGluZGV4LCBjdXJyIC0gY3AgLSBpbmRleCwgbmV4dElzU21hbGxDYXBzID8gU21h bGxDYXBzVmFyaWFudCA6IE5vcm1hbFZhcmlhbnQpOwotICAgICAgICAgICAgaWYgKCFuZXh0Rm9u dERhdGEpIHsKLSAgICAgICAgICAgICAgICBpZiAobWFya0NvdW50KQotICAgICAgICAgICAgICAg ICAgICBuZXh0Rm9udERhdGEgPSBzeXN0ZW1GYWxsYmFja0ZvbnREYXRhKCk7Ci0gICAgICAgICAg ICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICBuZXh0SXNNaXNzaW5nR2x5cGggPSB0cnVl OwotICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKCFuZXh0Rm9udERhdGEpCisgICAgICAg ICAgICAgICAgbmV4dElzTWlzc2luZ0dseXBoID0gdHJ1ZTsKICAgICAgICAgfQogI2VuZGlmCiAK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENv bnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyLmgJKHJldmlzaW9uIDEzMTUzNikKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuaAko d29ya2luZyBjb3B5KQpAQCAtNzIsOCArNzIsNiBAQCBwdWJsaWM6CiAgICAgZmxvYXQgbWF4R2x5 cGhCb3VuZGluZ0JveFkoKSBjb25zdCB7IHJldHVybiBtX21heEdseXBoQm91bmRpbmdCb3hZOyB9 CiAgICAgCiBwcml2YXRlOgotICAgIHN0YXRpYyBjb25zdCBTaW1wbGVGb250RGF0YSogc3lzdGVt RmFsbGJhY2tGb250RGF0YSgpIHsgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgU2ltcGxl Rm9udERhdGEqPigtMSk7IH0KLQogICAgIGNsYXNzIENvbXBsZXhUZXh0UnVuIDogcHVibGljIFJl ZkNvdW50ZWQ8Q29tcGxleFRleHRSdW4+IHsKICAgICBwdWJsaWM6CiAgICAgICAgIHN0YXRpYyBQ YXNzUmVmUHRyPENvbXBsZXhUZXh0UnVuPiBjcmVhdGUoQ1RSdW5SZWYgY3RSdW4sIGNvbnN0IFNp bXBsZUZvbnREYXRhKiBmb250RGF0YSwgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHVuc2lnbmVk IHN0cmluZ0xvY2F0aW9uLCBzaXplX3Qgc3RyaW5nTGVuZ3RoLCBDRlJhbmdlIHJ1blJhbmdlKQpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29u dHJvbGxlckNvcmVUZXh0Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXJDb3JlVGV4dC5tbQkocmV2aXNpb24g MTMxNTM2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhU ZXh0Q29udHJvbGxlckNvcmVUZXh0Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMDAsNyArMjAwLDcg QEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNvbGxlY3RDb21wbAogCiAgICAgVUNoYXIz MiBiYXNlQ2hhcmFjdGVyID0gMDsKICAgICBSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiBzdHJp bmdBdHRyaWJ1dGVzOwotICAgIGlmIChmb250RGF0YSA9PSBzeXN0ZW1GYWxsYmFja0ZvbnREYXRh KCkpIHsKKyAgICBpZiAoZm9udERhdGEgPT0gU2ltcGxlRm9udERhdGE6OnN5c3RlbUZhbGxiYWNr KCkpIHsKICAgICAgICAgLy8gRklYTUU6IFRoaXMgY29kZSBwYXRoIGRvZXMgbm90IHN1cHBvcnQg c21hbGwgY2Fwcy4KICAgICAgICAgaXNTeXN0ZW1GYWxsYmFjayA9IHRydWU7CiAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q29tcGxleFRleHRNYWMuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250 Q29tcGxleFRleHRNYWMuY3BwCShyZXZpc2lvbiAxMzE1MzYpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udENvbXBsZXhUZXh0TWFjLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTc2LDggKzE3NiwxMSBAQCBjb25zdCBTaW1wbGVGb250RGF0YSogRm9udDo6Zm9udERh dGFGb3JDCiAKICAgICBHbHlwaERhdGEgYmFzZUNoYXJhY3RlckdseXBoRGF0YSA9IGdseXBoRGF0 YUZvckNoYXJhY3RlcihiYXNlQ2hhcmFjdGVyLCBmYWxzZSwgdmFyaWFudCk7CiAKKyAgICBpZiAo IWJhc2VDaGFyYWN0ZXJHbHlwaERhdGEuZ2x5cGgpCisgICAgICAgIHJldHVybiAwOworCiAgICAg aWYgKGxlbmd0aCA9PSBiYXNlQ2hhcmFjdGVyTGVuZ3RoKQotICAgICAgICByZXR1cm4gYmFzZUNo YXJhY3RlckdseXBoRGF0YS5nbHlwaCA/IGJhc2VDaGFyYWN0ZXJHbHlwaERhdGEuZm9udERhdGEg OiAwOworICAgICAgICByZXR1cm4gYmFzZUNoYXJhY3RlckdseXBoRGF0YS5mb250RGF0YTsKIAog ICAgIGJvb2wgdHJpZWRCYXNlQ2hhcmFjdGVyRm9udERhdGEgPSBmYWxzZTsKIApAQCAtMjE2LDcg KzIxOSw3IEBAIGNvbnN0IFNpbXBsZUZvbnREYXRhKiBGb250Ojpmb250RGF0YUZvckMKICAgICBp ZiAoIXRyaWVkQmFzZUNoYXJhY3RlckZvbnREYXRhICYmIGJhc2VDaGFyYWN0ZXJHbHlwaERhdGEu Zm9udERhdGEgJiYgYmFzZUNoYXJhY3RlckdseXBoRGF0YS5mb250RGF0YS0+Y2FuUmVuZGVyQ29t YmluaW5nQ2hhcmFjdGVyU2VxdWVuY2UoY2hhcmFjdGVycywgbGVuZ3RoKSkKICAgICAgICAgcmV0 dXJuIGJhc2VDaGFyYWN0ZXJHbHlwaERhdGEuZm9udERhdGE7CiAKLSAgICByZXR1cm4gMDsKKyAg ICByZXR1cm4gU2ltcGxlRm9udERhdGE6OnN5c3RlbUZhbGxiYWNrKCk7CiB9CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUK