99653 2012-10-17 16:22:42 -0700 [V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation 2012-10-18 14:29:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth cdumez eric haraken japhet roger_fong webkit.review.bot oldest_to_newest 744757 0 abarth 2012-10-17 16:22:42 -0700 [V8] Don't generate code that declares visitDOMWrapper if we're not going to generate the implementation 744759 1 169292 abarth 2012-10-17 16:22:59 -0700 Created attachment 169292 Patch 744765 2 169292 eric 2012-10-17 16:28:21 -0700 Comment on attachment 169292 Patch Ha! 744810 3 169292 webkit.review.bot 2012-10-17 17:04:02 -0700 Comment on attachment 169292 Patch Clearing flags on attachment: 169292 Committed r131673: <http://trac.webkit.org/changeset/131673> 744811 4 webkit.review.bot 2012-10-17 17:04:06 -0700 All reviewed patches have been landed. Closing bug. 744994 5 cdumez 2012-10-17 22:50:50 -0700 bindings-generation-tests are failing after this patch. They probably need to be rebaselined: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio 744995 6 haraken 2012-10-17 22:56:16 -0700 (In reply to comment #5) > bindings-generation-tests are failing after this patch. They probably need to be rebaselined: > http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/7350/steps/bindings-generation-tests/logs/stdio Fixed in r131706. Sorry for the trouble. 745001 7 abarth 2012-10-17 23:08:22 -0700 Thanks Kentaro. It's me who should be apologizing. 745199 8 roger_fong 2012-10-18 06:17:59 -0700 Windows is still failing. Are there Windows specific results for the binding tests? 745448 9 roger_fong 2012-10-18 12:00:59 -0700 (In reply to comment #8) > Windows is still failing. Are there Windows specific results for the binding tests? http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044 I'll try just rebaselining locally to see what happens. 745580 10 roger_fong 2012-10-18 14:29:02 -0700 (In reply to comment #9) > (In reply to comment #8) > > Windows is still failing. Are there Windows specific results for the binding tests? > > http://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/29044 > > I'll try just rebaselining locally to see what happens. Oops, that's from before the fix landing...my bad. Windows bots went down/stopped testing just before the fix it seems. 169292 2012-10-17 16:22:59 -0700 2012-10-17 17:04:01 -0700 Patch bug-99653-20121017162146.patch text/plain 1765 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ5ZTNmODZiZTY4YTJi YmFmYWMyZjU0ZWY5N2QyNzg5MmMxZmU1MC4uYjc5YzNiYjA1MTA0ZTgxODFlNjU1OTI3ZTRiNjM0 YTkyYmMxZTYxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTE3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBEb24ndCBnZW5lcmF0 ZSBjb2RlIHRoYXQgZGVjbGFyZXMgdmlzaXRET01XcmFwcGVyIGlmIHdlJ3JlIG5vdCBnb2luZyB0 byBnZW5lcmF0ZSB0aGUgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bToKKyAgICAgICAgKEdlbmVyYXRlSGVhZGVyKToKKwogMjAxMi0xMC0xNyAgQ2hyaXN0b3BoZSBE dW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIHhzcy1ERU5JRUQt eHNsLWRvY3VtZW50LXNlY3VyaXR5T3JpZ2luLnhtbCBjcmFzaGVzIHdpdGggaWNvbiBhc3NlcnRp b24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG0KaW5kZXggZWQxNDIyMTc4MzBiMTAyMDMwMDU1NDVlYjAyMTAwZmZkMjNhMmE4OS4uOGM5 ZDg2OGRlNDc0Y2VlZDg4ZTNkMWZkNDZkODk4MDZiZDQ1MTYxNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTM4Miw5ICsz ODIsMTMgQEAgRU5ECiAgICAgfQogICAgIGlubGluZSBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6T2Jq ZWN0PiB3cmFwKCR7bmF0aXZlVHlwZX0qLCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGNyZWF0aW9u Q29udGV4dCA9IHY4OjpIYW5kbGU8djg6Ok9iamVjdD4oKSwgdjg6Oklzb2xhdGUqID0gMCk7CiAg ICAgc3RhdGljIHZvaWQgZGVyZWZPYmplY3Qodm9pZCopOwotICAgIHN0YXRpYyB2b2lkIHZpc2l0 RE9NV3JhcHBlcihET01EYXRhU3RvcmUqLCB2b2lkKiwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVj dD4pOwogICAgIHN0YXRpYyBXcmFwcGVyVHlwZUluZm8gaW5mbzsKIEVORAorCisgICAgaWYgKE5l ZWRzVG9WaXNpdERPTVdyYXBwZXIoJGRhdGFOb2RlKSkgeworICAgICAgICBwdXNoKEBoZWFkZXJD b250ZW50LCAiICAgIHN0YXRpYyB2b2lkIHZpc2l0RE9NV3JhcHBlcihET01EYXRhU3RvcmUqLCB2 b2lkKiwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4pO1xuIik7CisgICAgfQorCiAgICAgaWYg KCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkFjdGl2ZURPTU9iamVjdCJ9KSB7CiAg ICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgc3RhdGljIEFjdGl2ZURPTU9iamVjdCog dG9BY3RpdmVET01PYmplY3Qodjg6OkhhbmRsZTx2ODo6T2JqZWN0Pik7XG4iKTsKICAgICB9Cg==