<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>99652</bug_id>
          
          <creation_ts>2012-10-17 16:22:28 -0700</creation_ts>
          <short_desc>Make dom-query.html slightly faster by removing unnecessary ref-churn in StringTraits</short_desc>
          <delta_ts>2012-10-17 17:24:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Eric Seidel (no email)">eric</assigned_to>
          <cc>abarth</cc>
    
    <cc>haraken</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>744755</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-17 16:22:28 -0700</bug_when>
    <thetext>Make dom-query.html slightly faster by removing unnecessary ref-churn in StringTraits</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>744758</commentid>
    <comment_count>1</comment_count>
      <attachid>169291</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-17 16:22:48 -0700</bug_when>
    <thetext>Created attachment 169291
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>744760</commentid>
    <comment_count>2</comment_count>
      <attachid>169293</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-17 16:24:44 -0700</bug_when>
    <thetext>Created attachment 169293
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>744774</commentid>
    <comment_count>3</comment_count>
      <attachid>169293</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-17 16:37:55 -0700</bug_when>
    <thetext>Comment on attachment 169293
Patch

Rejecting attachment 169293 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://queues.webkit.org/results/14391753</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>744837</commentid>
    <comment_count>4</comment_count>
      <attachid>169293</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-17 17:24:08 -0700</bug_when>
    <thetext>Comment on attachment 169293
Patch

Clearing flags on attachment: 169293

Committed r131678: &lt;http://trac.webkit.org/changeset/131678&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>744838</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-17 17:24:12 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>169291</attachid>
            <date>2012-10-17 16:22:48 -0700</date>
            <delta_ts>2012-10-17 16:24:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99652-20121017162135.patch</filename>
            <type>text/plain</type>
            <size>2974</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzliZTI1NDcxNmY2OWVj
ZWE1ZGNlMTc3MjAwMjY1NGY5ZjYyYjFmNi4uZDVmMDVlODk0YWMxZjgzOTYxNjM1YTMxY2NkMTJh
ODA2Nzc2ODQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTE3ICBFcmlj
IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBNYWtlIGRvbS1xdWVyeS5odG1s
IHNsaWdodGx5IGZhc3RlciBieSByZW1vdmluZyB1bm5lY2Vzc2FyeSByZWYtY2h1cm4gaW4gU3Ry
aW5nVHJhaXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD05OTY1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkZGl0aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCBy
YXRpb25hbGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09Q
UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogYmluZGlu
Z3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5jcHA6CisgICAgICAgIChTdHJpbmdUcmFpdHMpOgorICAg
ICAgICAqIGJpbmRpbmdzL3Y4L1Y4VmFsdWVDYWNoZS5oOgorICAgICAgICAoV2ViQ29yZTo6V2Vi
Q29yZVN0cmluZ1Jlc291cmNlOjp3ZWJjb3JlU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6Oldl
YkNvcmVTdHJpbmdSZXNvdXJjZTo6YXRvbWljU3RyaW5nKToKKwogMjAxMi0xMC0xNSAgTWlrZSBX
ZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENvbnNvbGUgbWVzc2FnZXMgY29u
dGFpbmluZyBsb25nIFVSTHMgc2hvdWxkIGN1dCBhdCBzb21lIHJlYXNvbmFibGUgbGVuZ3RoLgpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5j
cHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFN0cmluZ1Jlc291cmNlLmNwcAppbmRl
eCBjN2M5NjRkZjFkZDU0NmVhMDBhMDg0M2Y1MWU2N2QyZWQ0YzczZmVkLi41OTg1NTNmZmZjZDBi
MzAzNjE1MDZiZTFjZTM5YTNjMjc2N2ZlNTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i
aW5kaW5ncy92OC9WOFN0cmluZ1Jlc291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k
aW5ncy92OC9WOFN0cmluZ1Jlc291cmNlLmNwcApAQCAtMzAsMTQgKzMwLDE0IEBACiAKIG5hbWVz
cGFjZSBXZWJDb3JlIHsKIAotdGVtcGxhdGUgPGNsYXNzIFM+IHN0cnVjdCBTdHJpbmdUcmFpdHMg
ewotICAgIHN0YXRpYyBTIGZyb21TdHJpbmdSZXNvdXJjZShXZWJDb3JlU3RyaW5nUmVzb3VyY2Uq
KTsKLSAgICBzdGF0aWMgUyBmcm9tVjhTdHJpbmcodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiwgaW50
KTsKK3RlbXBsYXRlIDxjbGFzcyBTdHJpbmdDbGFzcz4gc3RydWN0IFN0cmluZ1RyYWl0cyB7Cisg
ICAgc3RhdGljIGNvbnN0IFN0cmluZ0NsYXNzJiBmcm9tU3RyaW5nUmVzb3VyY2UoV2ViQ29yZVN0
cmluZ1Jlc291cmNlKik7CisgICAgc3RhdGljIFN0cmluZ0NsYXNzIGZyb21WOFN0cmluZyh2ODo6
SGFuZGxlPHY4OjpTdHJpbmc+LCBpbnQpOwogfTsKIAogdGVtcGxhdGU8Pgogc3RydWN0IFN0cmlu
Z1RyYWl0czxTdHJpbmc+IHsKLSAgICBzdGF0aWMgU3RyaW5nIGZyb21TdHJpbmdSZXNvdXJjZShX
ZWJDb3JlU3RyaW5nUmVzb3VyY2UqIHJlc291cmNlKQorICAgIHN0YXRpYyBjb25zdCBTdHJpbmcm
IGZyb21TdHJpbmdSZXNvdXJjZShXZWJDb3JlU3RyaW5nUmVzb3VyY2UqIHJlc291cmNlKQogICAg
IHsKICAgICAgICAgcmV0dXJuIHJlc291cmNlLT53ZWJjb3JlU3RyaW5nKCk7CiAgICAgfQpAQCAt
NTYsNyArNTYsNyBAQCBzdHJ1Y3QgU3RyaW5nVHJhaXRzPFN0cmluZz4gewogCiB0ZW1wbGF0ZTw+
CiBzdHJ1Y3QgU3RyaW5nVHJhaXRzPEF0b21pY1N0cmluZz4gewotICAgIHN0YXRpYyBBdG9taWNT
dHJpbmcgZnJvbVN0cmluZ1Jlc291cmNlKFdlYkNvcmVTdHJpbmdSZXNvdXJjZSogcmVzb3VyY2Up
CisgICAgc3RhdGljIGNvbnN0IEF0b21pY1N0cmluZyYgZnJvbVN0cmluZ1Jlc291cmNlKFdlYkNv
cmVTdHJpbmdSZXNvdXJjZSogcmVzb3VyY2UpCiAgICAgewogICAgICAgICByZXR1cm4gcmVzb3Vy
Y2UtPmF0b21pY1N0cmluZygpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp
bmRpbmdzL3Y4L1Y4VmFsdWVDYWNoZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhW
YWx1ZUNhY2hlLmgKaW5kZXggYTc0YzRhM2MzZDU0YzcyNzM4N2RkOGE1MmJlZDQ4NDMzNzg1MjA5
ZC4uNzJhMWI3MDQ1MjM2NmUwNmVmZWE4MTNkOTQwMmFlMzVkM2Q3NzU4ZSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hlLmgKKysrIGIvU291cmNlL1dl
YkNvcmUvYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hlLmgKQEAgLTExMyw5ICsxMTMsOSBAQCBwdWJs
aWM6CiAKICAgICB2aXJ0dWFsIHNpemVfdCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX3BsYWlu
U3RyaW5nLmltcGwoKS0+bGVuZ3RoKCk7IH0KIAotICAgIFN0cmluZyB3ZWJjb3JlU3RyaW5nKCkg
eyByZXR1cm4gbV9wbGFpblN0cmluZzsgfQorICAgIGNvbnN0IFN0cmluZyYgd2ViY29yZVN0cmlu
ZygpIHsgcmV0dXJuIG1fcGxhaW5TdHJpbmc7IH0KIAotICAgIEF0b21pY1N0cmluZyBhdG9taWNT
dHJpbmcoKQorICAgIGNvbnN0IEF0b21pY1N0cmluZyYgYXRvbWljU3RyaW5nKCkKICAgICB7CiAj
aWZuZGVmIE5ERUJVRwogICAgICAgICBBU1NFUlQobV90aHJlYWRJZCA9PSBXVEY6OmN1cnJlbnRU
aHJlYWQoKSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>169293</attachid>
            <date>2012-10-17 16:24:44 -0700</date>
            <delta_ts>2012-10-17 17:24:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99652-20121017162330.patch</filename>
            <type>text/plain</type>
            <size>3133</size>
            <attacher name="Eric Seidel (no email)">eric</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzliZTI1NDcxNmY2OWVj
ZWE1ZGNlMTc3MjAwMjY1NGY5ZjYyYjFmNi4uMTQ3MmU4OTJjYzhhMzQwY2I1ZjRhNDU1NjgwY2M2
ZGQ3MGRlMjkwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTE3ICBFcmlj
IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBNYWtlIGRvbS1xdWVyeS5odG1s
IHNsaWdodGx5IGZhc3RlciBieSByZW1vdmluZyB1bm5lY2Vzc2FyeSByZWYtY2h1cm4gaW4gU3Ry
aW5nVHJhaXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD05OTY1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE15IHRlc3Rpbmcgc2hvd2VkIHRoaXMgbW92ZWQgZG9tLXF1ZXJ5Lmh0bWwgZnJvbSAgNDY1NTYw
IHJ1bnMvcyB0byA0NzkwMTkKKyAgICAgICAgd2hpY2ggaXMgYWJvdXQgMiUgaWYgSSdtIGRvaW5n
IG15IG1hdGggY29ycmVjdGx5LgorCisgICAgICAgIEkgc3VzcGVjdCB0aGF0J3MgZHVlIHRvIGF2
b2lkaW5nIHRoZSByZWYtY2h1cm4gd2Ugd2VyZSBpbmN1cnJpbmcgYnkgdXNpbmcKKyAgICAgICAg
cmV0dXJuLWJ5LXZhbHVlIHN5bWFudGljcyBoZXJlLgorCisgICAgICAgIFRoaXMgaXMganVzdCB0
aGUgdGlwIG9mIHRoZSBpY2VidXJnLiA6KQorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhTdHJp
bmdSZXNvdXJjZS5jcHA6CisgICAgICAgIChTdHJpbmdUcmFpdHMpOgorICAgICAgICAqIGJpbmRp
bmdzL3Y4L1Y4VmFsdWVDYWNoZS5oOgorICAgICAgICAoV2ViQ29yZTo6V2ViQ29yZVN0cmluZ1Jl
c291cmNlOjp3ZWJjb3JlU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OldlYkNvcmVTdHJpbmdS
ZXNvdXJjZTo6YXRvbWljU3RyaW5nKToKKwogMjAxMi0xMC0xNSAgTWlrZSBXZXN0ICA8bWt3c3RA
Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIENvbnNvbGUgbWVzc2FnZXMgY29udGFpbmluZyBsb25n
IFVSTHMgc2hvdWxkIGN1dCBhdCBzb21lIHJlYXNvbmFibGUgbGVuZ3RoLgpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhTdHJpbmdSZXNvdXJjZS5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9iaW5kaW5ncy92OC9WOFN0cmluZ1Jlc291cmNlLmNwcAppbmRleCBjN2M5NjRkZjFk
ZDU0NmVhMDBhMDg0M2Y1MWU2N2QyZWQ0YzczZmVkLi41OTg1NTNmZmZjZDBiMzAzNjE1MDZiZTFj
ZTM5YTNjMjc2N2ZlNTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W
OFN0cmluZ1Jlc291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFN0
cmluZ1Jlc291cmNlLmNwcApAQCAtMzAsMTQgKzMwLDE0IEBACiAKIG5hbWVzcGFjZSBXZWJDb3Jl
IHsKIAotdGVtcGxhdGUgPGNsYXNzIFM+IHN0cnVjdCBTdHJpbmdUcmFpdHMgewotICAgIHN0YXRp
YyBTIGZyb21TdHJpbmdSZXNvdXJjZShXZWJDb3JlU3RyaW5nUmVzb3VyY2UqKTsKLSAgICBzdGF0
aWMgUyBmcm9tVjhTdHJpbmcodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiwgaW50KTsKK3RlbXBsYXRl
IDxjbGFzcyBTdHJpbmdDbGFzcz4gc3RydWN0IFN0cmluZ1RyYWl0cyB7CisgICAgc3RhdGljIGNv
bnN0IFN0cmluZ0NsYXNzJiBmcm9tU3RyaW5nUmVzb3VyY2UoV2ViQ29yZVN0cmluZ1Jlc291cmNl
Kik7CisgICAgc3RhdGljIFN0cmluZ0NsYXNzIGZyb21WOFN0cmluZyh2ODo6SGFuZGxlPHY4OjpT
dHJpbmc+LCBpbnQpOwogfTsKIAogdGVtcGxhdGU8Pgogc3RydWN0IFN0cmluZ1RyYWl0czxTdHJp
bmc+IHsKLSAgICBzdGF0aWMgU3RyaW5nIGZyb21TdHJpbmdSZXNvdXJjZShXZWJDb3JlU3RyaW5n
UmVzb3VyY2UqIHJlc291cmNlKQorICAgIHN0YXRpYyBjb25zdCBTdHJpbmcmIGZyb21TdHJpbmdS
ZXNvdXJjZShXZWJDb3JlU3RyaW5nUmVzb3VyY2UqIHJlc291cmNlKQogICAgIHsKICAgICAgICAg
cmV0dXJuIHJlc291cmNlLT53ZWJjb3JlU3RyaW5nKCk7CiAgICAgfQpAQCAtNTYsNyArNTYsNyBA
QCBzdHJ1Y3QgU3RyaW5nVHJhaXRzPFN0cmluZz4gewogCiB0ZW1wbGF0ZTw+CiBzdHJ1Y3QgU3Ry
aW5nVHJhaXRzPEF0b21pY1N0cmluZz4gewotICAgIHN0YXRpYyBBdG9taWNTdHJpbmcgZnJvbVN0
cmluZ1Jlc291cmNlKFdlYkNvcmVTdHJpbmdSZXNvdXJjZSogcmVzb3VyY2UpCisgICAgc3RhdGlj
IGNvbnN0IEF0b21pY1N0cmluZyYgZnJvbVN0cmluZ1Jlc291cmNlKFdlYkNvcmVTdHJpbmdSZXNv
dXJjZSogcmVzb3VyY2UpCiAgICAgewogICAgICAgICByZXR1cm4gcmVzb3VyY2UtPmF0b21pY1N0
cmluZygpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4
VmFsdWVDYWNoZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hlLmgK
aW5kZXggYTc0YzRhM2MzZDU0YzcyNzM4N2RkOGE1MmJlZDQ4NDMzNzg1MjA5ZC4uNzJhMWI3MDQ1
MjM2NmUwNmVmZWE4MTNkOTQwMmFlMzVkM2Q3NzU4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu
Z3MvdjgvVjhWYWx1ZUNhY2hlLmgKQEAgLTExMyw5ICsxMTMsOSBAQCBwdWJsaWM6CiAKICAgICB2
aXJ0dWFsIHNpemVfdCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX3BsYWluU3RyaW5nLmltcGwo
KS0+bGVuZ3RoKCk7IH0KIAotICAgIFN0cmluZyB3ZWJjb3JlU3RyaW5nKCkgeyByZXR1cm4gbV9w
bGFpblN0cmluZzsgfQorICAgIGNvbnN0IFN0cmluZyYgd2ViY29yZVN0cmluZygpIHsgcmV0dXJu
IG1fcGxhaW5TdHJpbmc7IH0KIAotICAgIEF0b21pY1N0cmluZyBhdG9taWNTdHJpbmcoKQorICAg
IGNvbnN0IEF0b21pY1N0cmluZyYgYXRvbWljU3RyaW5nKCkKICAgICB7CiAjaWZuZGVmIE5ERUJV
RwogICAgICAgICBBU1NFUlQobV90aHJlYWRJZCA9PSBXVEY6OmN1cnJlbnRUaHJlYWQoKSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>