99638 2012-10-17 14:01:56 -0700 webkitpy: fix chromium bot configs in builders.py 2012-10-18 14:16:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth ojan webkit.review.bot oldest_to_newest 744591 0 dpranke 2012-10-17 14:01:56 -0700 webkitpy: fix chromium bot configs in builders.py 744595 1 169258 dpranke 2012-10-17 14:03:08 -0700 Created attachment 169258 Patch 744648 2 169258 ojan 2012-10-17 14:51:08 -0700 Comment on attachment 169258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169258&action=review > Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:-94 > - self.assertEquals(extrapolator.extrapolate_test_configurations("WebKit Win7"), set([ Why is this case not needed? 744653 3 dpranke 2012-10-17 14:54:21 -0700 I don't actually know what it was originally needed for. I pinged abarth about it and he thought it was no longer needed and safe to remove. 744681 4 169258 abarth 2012-10-17 15:11:29 -0700 Comment on attachment 169258 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169258&action=review >> Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:-94 >> - self.assertEquals(extrapolator.extrapolate_test_configurations("WebKit Win7"), set([ > > Why is this case not needed? We don't use BuildCoverageExtrapolator anymore. We should probably rip it out. 744682 5 ojan 2012-10-17 15:11:50 -0700 sgtm 745565 6 dpranke 2012-10-18 14:16:49 -0700 Committed r131800: <http://trac.webkit.org/changeset/131800> 169258 2012-10-17 14:03:08 -0700 2012-10-17 15:11:29 -0700 Patch bug-99638-20121017140154.patch text/plain 3518 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNjI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmJlN2ExNGViNGYxZTE2OTY0MWFiYjJkNmRiODA4Yzgz MmFkMTYxNS4uYzc2ODJhNTVjMzJjMmQ2MzMyMzMzMzAzNjFhNDViNmM5NTQxZjYwYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEwLTE3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHdlYmtpdHB5OiBmaXggY2hyb21pdW0gYm90IGNvbmZpZ3MgaW4gYnVpbGRlcnMucHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NjM4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRpbmcg YWZ0ZXIgdGhlIGdyZWF0IGJvdC1yZW5hbWluZyBhbmQgZGVsZXRpbmcgYSB0ZXN0IGNhc2UKKyAg ICAgICAgdGhhdCBpcyBubyBsb25nZXIgbmVlZGVkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9idWlsZGVycy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdzZXJ2ZXJfdW5pdHRlc3QucHk6CisgICAgICAg IChCdWlsZENvdmVyYWdlRXh0cmFwb2xhdG9yVGVzdC50ZXN0X2V4dHJhcG9sYXRlKToKKwogMjAx Mi0xMC0xNyAgU2FkcnVsIEhhYmliIENob3dkaHVyeSAgPHNhZHJ1bEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgcGx1Z2luczogQWxsb3cgYSBwbHVnaW4gdG8gZGljdGF0ZSB3aGV0aGVyIGl0IGNh biByZWNlaXZlIGRyYWcgZXZlbnRzIG9yIG5vdC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYnVpbGRlcnMucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2J1aWxkZXJzLnB5CmluZGV4IDYwNWI4Y2NjYzI4MmYz ZDVkYzZhMTBkNDg3MmFlYzg4OWI4ZDgxMGMuLmFkZGZlMzA0NWM5MjlmZWI4OWM4Yjk2NjlhMDA2 YzMxNTI0YzIxZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvYnVpbGRlcnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9idWlsZGVycy5weQpAQCAtMzgsOSArMzgsOSBAQCBmcm9tIHdlYmtpdHB5LmNv bW1vbi5tZW1vaXplZCBpbXBvcnQgbWVtb2l6ZWQKIF9leGFjdF9tYXRjaGVzID0gewogICAgICMg VGhlc2UgYnVpbGRlcnMgYXJlIG9uIGJ1aWxkLmNocm9taXVtLm9yZy4KICAgICAiV2ViS2l0IFhQ IjogeyJwb3J0X25hbWUiOiAiY2hyb21pdW0td2luLXhwIiwgInNwZWNpZmllcnMiOiBzZXQoWyJ4 cCIsICJyZWxlYXNlIl0pfSwKLSAgICAiV2ViS2l0IFdpbjciOiB7InBvcnRfbmFtZSI6ICJjaHJv bWl1bS13aW4td2luNyIsICJzcGVjaWZpZXJzIjogc2V0KFsid2luNyJdKX0sCi0gICAgIldlYktp dCBXaW43IChkYmcpKDEpIjogeyJwb3J0X25hbWUiOiAiY2hyb21pdW0td2luLXhwIiwgInNwZWNp ZmllcnMiOiBzZXQoWyJ3aW4iLCAiZGVidWciXSl9LAotICAgICJXZWJLaXQgV2luNyAoZGJnKSgy KSI6IHsicG9ydF9uYW1lIjogImNocm9taXVtLXdpbi14cCIsICJzcGVjaWZpZXJzIjogc2V0KFsi d2luIiwgImRlYnVnIl0pfSwKKyAgICAiV2ViS2l0IFdpbjciOiB7InBvcnRfbmFtZSI6ICJjaHJv bWl1bS13aW4td2luNyIsICJzcGVjaWZpZXJzIjogc2V0KFsid2luNyIsICJyZWxlYXNlIl0pfSwK KyAgICAiV2ViS2l0IFdpbjcgKGRiZykoMSkiOiB7InBvcnRfbmFtZSI6ICJjaHJvbWl1bS13aW4t d2luNyIsICJzcGVjaWZpZXJzIjogc2V0KFsid2luNyIsICJkZWJ1ZyJdKX0sCisgICAgIldlYktp dCBXaW43IChkYmcpKDIpIjogeyJwb3J0X25hbWUiOiAiY2hyb21pdW0td2luLXdpbjciLCAic3Bl Y2lmaWVycyI6IHNldChbIndpbjciLCAiZGVidWciXSl9LAogICAgICJXZWJLaXQgTGludXgiOiB7 InBvcnRfbmFtZSI6ICJjaHJvbWl1bS1saW51eC14ODZfNjQiLCAic3BlY2lmaWVycyI6IHNldChb ImxpbnV4IiwgIng4Nl82NCIsICJyZWxlYXNlIl0pfSwKICAgICAiV2ViS2l0IExpbnV4IDMyIjog eyJwb3J0X25hbWUiOiAiY2hyb21pdW0tbGludXgteDg2IiwgInNwZWNpZmllcnMiOiBzZXQoWyJs aW51eCIsICJ4ODYiXSl9LAogICAgICJXZWJLaXQgTGludXggKGRiZykiOiB7InBvcnRfbmFtZSI6 ICJjaHJvbWl1bS1saW51eC14ODZfNjQiLCAic3BlY2lmaWVycyI6IHNldChbImxpbnV4IiwgImRl YnVnIl0pfSwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJz L2dhcmRlbmluZ3NlcnZlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlcl91bml0dGVzdC5weQppbmRleCA2YzY0YmRkN2U3Y2Yz YzNhMWYzNWJmNzk0MTM3NTE3NTlhNWMwMzI0Li4yMTIzN2I0OGE4MDgzNjVjMTMzZDg1MDBkNDE2 OTM1NTBkMjExMDUwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2Vy dmVycy9nYXJkZW5pbmdzZXJ2ZXJfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL3NlcnZlcnMvZ2FyZGVuaW5nc2VydmVyX3VuaXR0ZXN0LnB5CkBAIC05MSw5ICs5 MSw2IEBAIGNsYXNzIEJ1aWxkQ292ZXJhZ2VFeHRyYXBvbGF0b3JUZXN0KHVuaXR0ZXN0LlRlc3RD YXNlKToKICAgICAgICAgY29udmVydGVyID0gVGVzdENvbmZpZ3VyYXRpb25Db252ZXJ0ZXIocG9y dC5hbGxfdGVzdF9jb25maWd1cmF0aW9ucygpLCBwb3J0LmNvbmZpZ3VyYXRpb25fc3BlY2lmaWVy X21hY3JvcygpKQogICAgICAgICBleHRyYXBvbGF0b3IgPSBCdWlsZENvdmVyYWdlRXh0cmFwb2xh dG9yKGNvbnZlcnRlcikKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoZXh0cmFwb2xhdG9yLmV4 dHJhcG9sYXRlX3Rlc3RfY29uZmlndXJhdGlvbnMoIldlYktpdCBYUCIpLCBzZXQoW1Rlc3RDb25m aWd1cmF0aW9uKHZlcnNpb249J3hwJywgYXJjaGl0ZWN0dXJlPSd4ODYnLCBidWlsZF90eXBlPSdy ZWxlYXNlJyldKSkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoZXh0cmFwb2xhdG9yLmV4dHJh cG9sYXRlX3Rlc3RfY29uZmlndXJhdGlvbnMoIldlYktpdCBXaW43IiksIHNldChbCi0gICAgICAg ICAgICBUZXN0Q29uZmlndXJhdGlvbih2ZXJzaW9uPSd3aW43JywgYXJjaGl0ZWN0dXJlPSd4ODYn LCBidWlsZF90eXBlPSdkZWJ1ZycpLAotICAgICAgICAgICAgVGVzdENvbmZpZ3VyYXRpb24odmVy c2lvbj0nd2luNycsIGFyY2hpdGVjdHVyZT0neDg2JywgYnVpbGRfdHlwZT0ncmVsZWFzZScpXSkp CiAgICAgICAgIHNlbGYuYXNzZXJ0UmFpc2VzKEtleUVycm9yLCBleHRyYXBvbGF0b3IuZXh0cmFw b2xhdGVfdGVzdF9jb25maWd1cmF0aW9ucywgIlBvdGF0byIpCiAKIAo=