99635 2012-10-17 13:55:58 -0700 Only full-page PDFPlugins should purport to handle page scale changes 2012-10-25 12:12:41 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned mitz oldest_to_newest 744582 0 thorton 2012-10-17 13:55:58 -0700 PDFPlugin should only handle page scale factor changes itself if it's in the main frame. Subframe PDFs will act like images, zooming with the page (they currently do not respect the scale factor at all, but that is for a different patch). 744585 1 169253 thorton 2012-10-17 13:57:09 -0700 Created attachment 169253 patch 751100 2 thorton 2012-10-25 12:12:41 -0700 http://trac.webkit.org/changeset/132512 169253 2012-10-17 13:57:09 -0700 2012-10-19 17:59:56 -0700 patch psf.diff text/plain 4497 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMTI1MzIwLi41NTNmMjVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMTAtMTcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgT25seSBmdWxsLXBhZ2UgUERGUGx1Z2lucyBzaG91bGQgcHVycG9ydCB0byBoYW5k bGUgcGFnZSBzY2FsZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05OTYzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFBERlBsdWdpbiBzaG91bGQgb25seSBoYW5kbGUgcGFnZSBzY2FsZSBmYWN0 b3IgY2hhbmdlcyBpdHNlbGYgaWYgaXQncyBpbiB0aGUgbWFpbiBmcmFtZS4KKyAgICAgICAgU3Vi ZnJhbWUgUERGcyB3aWxsIGFjdCBsaWtlIGltYWdlcywgem9vbWluZyB3aXRoIHRoZSBwYWdlLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4uaDoKKyAgICAgICAg KFBERlBsdWdpbik6IE1vdmUgaW1wbGVtZW50YXRpb24gb2YgaGFuZGxlc1BhZ2VTY2FsZUZhY3Rv cigpIHRvIFBERlBsdWdpbi5tbS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BE RlBsdWdpbi5tbToKKyAgICAgICAgKFdlYktpdDo6UERGUGx1Z2luOjpwZGZEb2N1bWVudERpZExv YWQpOiBPbmx5IGNvcHkgUERGTGF5ZXJDb250cm9sbGVyJ3MgZGVmYXVsdCBhdXRvc2NhbGUgbWFn bmlmaWNhdGlvbiB0byBQbHVnaW5WaWV3J3MKKyAgICAgICAgbm90aW9uIG9mIHRoZSBjdXJyZW50 IHNjYWxlIGZhY3RvciBpZiB3ZSdyZSBzdXBwb3NlZCB0byBiZSBoYW5kbGluZyBwYWdlIHNjYWxl IGZhY3RvciBjaGFuZ2VzLgorICAgICAgICAoV2ViS2l0OjpQREZQbHVnaW46Omdlb21ldHJ5RGlk Q2hhbmdlKTogT25seSB1cGRhdGUgUERGTGF5ZXJDb250cm9sbGVyJ3MgbWFnbmlmaWNhdGlvbiBm cm9tIHRoZSBwYWdlIHNjYWxlIGZhY3RvcgorICAgICAgICBpZiB3ZSdyZSBzdXBwb3NlZCB0byBi ZSBoYW5kbGluZyBwYWdlIHNjYWxlIGZhY3RvciBjaGFuZ2VzLgorICAgICAgICAoV2ViS2l0OjpQ REZQbHVnaW46OmhhbmRsZXNQYWdlU2NhbGVGYWN0b3IpOiBXZSBzaG91bGQgb25seSBoYW5kbGUg cGFnZSBzY2FsZSBmYWN0b3IgY2hhbmdlcyBpZiB3ZSdyZSBpbiB0aGUgbWFpbiBmcmFtZS4KKwog MjAxMi0xMC0xNSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAg ICAgW0VGTF0gU2hhcmUgcmVzb3VyY2VzIGluc3RhbGxlZCBmb3IgaW5zcGVjdG9yCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5oIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4uaAppbmRleCBj ZDU4ZDg3Li40OWQwOTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvUERGL1BERlBsdWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9QREYvUERGUGx1Z2luLmgKQEAgLTc3LDcgKzc3LDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0 dWFsIGJvb2wgaGFuZGxlS2V5Ym9hcmRFdmVudChjb25zdCBXZWJLZXlib2FyZEV2ZW50JikgT1ZF UlJJREU7CiAgICAgdmlydHVhbCBib29sIGhhbmRsZUVkaXRpbmdDb21tYW5kKGNvbnN0IFN0cmlu ZyYgY29tbWFuZE5hbWUsIGNvbnN0IFN0cmluZyYgYXJndW1lbnQpIE9WRVJSSURFOwogICAgIHZp cnR1YWwgYm9vbCBpc0VkaXRpbmdDb21tYW5kRW5hYmxlZChjb25zdCBTdHJpbmcmKSBPVkVSUklE RTsKLSAgICB2aXJ0dWFsIGJvb2wgaGFuZGxlc1BhZ2VTY2FsZUZhY3RvcigpIE9WRVJSSURFIHsg cmV0dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaGFuZGxlc1BhZ2VTY2FsZUZhY3Rvcigp IE9WRVJSSURFOwogCiAgICAgLy8gU2Nyb2xsYWJsZUFyZWEgZnVuY3Rpb25zLgogICAgIHZpcnR1 YWwgdm9pZCBzZXRTY3JvbGxPZmZzZXQoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmKSBPVkVSUklE RTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERG UGx1Z2luLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVn aW4ubW0KaW5kZXggYzVhMzQ2OS4uYjhlOThiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KKysrIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KQEAgLTI5OCw3ICsyOTgsOCBAQCB2 b2lkIFBERlBsdWdpbjo6cGRmRG9jdW1lbnREaWRMb2FkKCkKICAgICBbbV9wZGZMYXllckNvbnRy b2xsZXIuZ2V0KCkgc2V0RnJhbWVTaXplOnNpemUoKV07CiAgICAgbV9wZGZMYXllckNvbnRyb2xs ZXIuZ2V0KCkuZG9jdW1lbnQgPSBkb2N1bWVudC5nZXQoKTsKICAgICAKLSAgICBwbHVnaW5WaWV3 KCktPnNldFBhZ2VTY2FsZUZhY3RvcihbbV9wZGZMYXllckNvbnRyb2xsZXIuZ2V0KCkgdGlsZVNj YWxlRmFjdG9yXSwgSW50UG9pbnQoKSk7CisgICAgaWYgKGhhbmRsZXNQYWdlU2NhbGVGYWN0b3Io KSkKKyAgICAgICAgcGx1Z2luVmlldygpLT5zZXRQYWdlU2NhbGVGYWN0b3IoW21fcGRmTGF5ZXJD b250cm9sbGVyLmdldCgpIHRpbGVTY2FsZUZhY3Rvcl0sIEludFBvaW50KCkpOwogCiAgICAgY2Fs Y3VsYXRlU2l6ZXMoKTsKICAgICB1cGRhdGVTY3JvbGxiYXJzKCk7CkBAIC00MDAsMTIgKzQwMSwx NyBAQCB2b2lkIFBERlBsdWdpbjo6Z2VvbWV0cnlEaWRDaGFuZ2UoY29uc3QgSW50U2l6ZSYgcGx1 Z2luU2l6ZSwgY29uc3QgSW50UmVjdCYsIGNvbgogICAgIFtDQVRyYW5zYWN0aW9uIGJlZ2luXTsK ICAgICBbQ0FUcmFuc2FjdGlvbiBzZXREaXNhYmxlQWN0aW9uczpZRVNdOwogICAgIENBVHJhbnNm b3JtM0QgdHJhbnNmb3JtID0gQ0FUcmFuc2Zvcm0zRE1ha2VTY2FsZSgxLCAtMSwgMSk7CisgICAg dHJhbnNmb3JtID0gQ0FUcmFuc2Zvcm0zRFRyYW5zbGF0ZSh0cmFuc2Zvcm0sIDAsIC1wbHVnaW5T aXplLmhlaWdodCgpLCAwKTsKICAgICAKLSAgICBDR0Zsb2F0IG1hZ25pZmljYXRpb24gPSBwbHVn aW5WaWV3KCktPnBhZ2VTY2FsZUZhY3RvcigpIC0gW21fcGRmTGF5ZXJDb250cm9sbGVyLmdldCgp IHRpbGVTY2FsZUZhY3Rvcl07Ci0gICAgCi0gICAgLy8gRklYTUU6IEluc3RlYWQgb2YgbV9sYXN0 TW91c2VQb2ludCwgd2Ugc2hvdWxkIHVzZSB0aGUgem9vbSBvcmlnaW4gZnJvbSBQbHVnaW5WaWV3 OjpzZXRQYWdlU2NhbGVGYWN0b3IuCi0gICAgW21fcGRmTGF5ZXJDb250cm9sbGVyLmdldCgpIG1h Z25pZnlXaXRoTWFnbmlmaWNhdGlvbjptYWduaWZpY2F0aW9uIGF0UG9pbnQ6bV9sYXN0TW91c2VQ b2ludCBpbW1lZGlhdGVseTpZRVNdOwotICAgIFttX2NvbnRlbnRMYXllci5nZXQoKSBzZXRTdWJs YXllclRyYW5zZm9ybTpDQVRyYW5zZm9ybTNEVHJhbnNsYXRlKHRyYW5zZm9ybSwgMCwgLXBsdWdp blNpemUuaGVpZ2h0KCksIDApXTsKKyAgICBpZiAoaGFuZGxlc1BhZ2VTY2FsZUZhY3RvcigpKSB7 CisgICAgICAgIENHRmxvYXQgbWFnbmlmaWNhdGlvbiA9IHBsdWdpblZpZXcoKS0+cGFnZVNjYWxl RmFjdG9yKCkgLSBbbV9wZGZMYXllckNvbnRyb2xsZXIuZ2V0KCkgdGlsZVNjYWxlRmFjdG9yXTsK KworICAgICAgICAvLyBGSVhNRTogSW5zdGVhZCBvZiBtX2xhc3RNb3VzZVBvaW50LCB3ZSBzaG91 bGQgdXNlIHRoZSB6b29tIG9yaWdpbiBmcm9tIFBsdWdpblZpZXc6OnNldFBhZ2VTY2FsZUZhY3Rv ci4KKyAgICAgICAgaWYgKG1hZ25pZmljYXRpb24pCisgICAgICAgICAgICBbbV9wZGZMYXllckNv bnRyb2xsZXIuZ2V0KCkgbWFnbmlmeVdpdGhNYWduaWZpY2F0aW9uOm1hZ25pZmljYXRpb24gYXRQ b2ludDptX2xhc3RNb3VzZVBvaW50IGltbWVkaWF0ZWx5OllFU107CisgICAgfQorCisgICAgW21f Y29udGVudExheWVyLmdldCgpIHNldFN1YmxheWVyVHJhbnNmb3JtOnRyYW5zZm9ybV07CiAgICAg W0NBVHJhbnNhY3Rpb24gY29tbWl0XTsKIAogICAgIGNhbGN1bGF0ZVNpemVzKCk7CkBAIC01Nzcs NiArNTgzLDExIEBAIHZvaWQgUERGUGx1Z2luOjppbnZhbGlkYXRlU2Nyb2xsQ29ybmVyUmVjdChj b25zdCBJbnRSZWN0JiByZWN0KQogICAgIFttX3Njcm9sbENvcm5lckxheWVyLmdldCgpIHNldE5l ZWRzRGlzcGxheV07CiB9CiAKK2Jvb2wgUERGUGx1Z2luOjpoYW5kbGVzUGFnZVNjYWxlRmFjdG9y KCkKK3sKKyAgICByZXR1cm4gd2ViRnJhbWUoKS0+aXNNYWluRnJhbWUoKTsKK30KKwogfSAvLyBu YW1lc3BhY2UgV2ViS2l0CiAKICNlbmRpZiAvLyBFTkFCTEUoUERGS0lUX1BMVUdJTikK