99613 2012-10-17 10:43:38 -0700 [EFL][WK2] Compilation warning in Ewk_View when accelerated compositing is disabled 2012-10-17 15:08:31 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot yael oldest_to_newest 744389 0 cdumez 2012-10-17 10:43:38 -0700 needsNewSurface variable in _ewk_view_smart_calculate() is defined but not used if the ACCELERATED_COMPOSITING flag is not set. 744394 1 169213 cdumez 2012-10-17 10:45:16 -0700 Created attachment 169213 Patch 744411 2 yael 2012-10-17 10:59:15 -0700 LGTM. Sorry about that. 744677 3 169213 webkit.review.bot 2012-10-17 15:08:27 -0700 Comment on attachment 169213 Patch Clearing flags on attachment: 169213 Committed r131653: <http://trac.webkit.org/changeset/131653> 744679 4 webkit.review.bot 2012-10-17 15:08:31 -0700 All reviewed patches have been landed. Closing bug. 169213 2012-10-17 10:45:16 -0700 2012-10-17 15:08:27 -0700 Patch 99613_ac_warning.patch text/plain 1479 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwNzM0N2M2Li4xMmY2NjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIENvbXBpbGF0aW9uIHdhcm5pbmcgaW4gRXdrX1Zp ZXcgd2hlbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBpcyBkaXNhYmxlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk2MTMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2Fybmlu ZyBpbiBfZXdrX3ZpZXdfc21hcnRfY2FsY3VsYXRlKCkgd2hlbgorICAgICAgICB0aGUgQUNDRUxF UkFURURfQ09NUE9TSVRJTkcgZmxhZyBpcyBub3Qgc2V0LgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X3NtYXJ0X2NhbGN1bGF0 ZSk6CisKIDIwMTItMTAtMTcgIEJ5dW5nd29vIExlZSAgPGJ3ODAubGVlQHNhbXN1bmcuY29tPgog CiAgICAgICAgIEZpeCBidWlsZCB3YXJuaW5ncyA6IC1XdW51c2VkLXBhcmFtZXRlciwgLVd1bnVz ZWQtdmFyaWFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 LmNwcAppbmRleCA5NWIwODRlLi5hOWRmODYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC02NTksMTEgKzY1OSwxNCBAQCBzdGF0aWMgdm9p ZCBfZXdrX3ZpZXdfc21hcnRfY2FsY3VsYXRlKEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAg IEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhKTsKICAgICBFV0tf VklFV19QUklWX0dFVF9PUl9SRVRVUk4oc21hcnREYXRhLCBwcml2KTsKLSAgICBFdmFzX0Nvb3Jk IHgsIHksIHdpZHRoLCBoZWlnaHQ7CisKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcp CiAgICAgYm9vbCBuZWVkc05ld1N1cmZhY2UgPSBmYWxzZTsKKyNlbmRpZgogCiAgICAgc21hcnRE YXRhLT5jaGFuZ2VkLmFueSA9IGZhbHNlOwogCisgICAgRXZhc19Db29yZCB4LCB5LCB3aWR0aCwg aGVpZ2h0OwogICAgIGV2YXNfb2JqZWN0X2dlb21ldHJ5X2dldChld2tWaWV3LCAmeCwgJnksICZ3 aWR0aCwgJmhlaWdodCk7CiAKICAgICBpZiAoc21hcnREYXRhLT5jaGFuZ2VkLnNpemUpIHsK