99611 2012-10-17 10:31:31 -0700 [EFL][WK2] Use smart pointers inside Ewk_View 2012-10-17 15:04:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco tonikitoo webkit.review.bot oldest_to_newest 744375 0 cdumez 2012-10-17 10:31:31 -0700 We are still using raw pointers in Ewk_View when we could use smart pointers instead. 744380 1 169210 cdumez 2012-10-17 10:35:46 -0700 Created attachment 169210 Patch 744672 2 169210 webkit.review.bot 2012-10-17 15:04:52 -0700 Comment on attachment 169210 Patch Clearing flags on attachment: 169210 Committed r131650: <http://trac.webkit.org/changeset/131650> 744673 3 webkit.review.bot 2012-10-17 15:04:57 -0700 All reviewed patches have been landed. Closing bug. 169210 2012-10-17 10:35:46 -0700 2012-10-17 15:04:52 -0700 Patch 99611_ewk_view_smart_pointers.patch text/plain 7186 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyN2U5MzU0Li5mMDI5NDgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMTAtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIFVzZSBzbWFydCBwb2ludGVycyBpbnNpZGUgRXdr X1ZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5 NjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHNtYXJ0IHBvaW50ZXJzIGluc3RlYWQgb2YgcmF3IG9uZXMgZm9yIHNldmVyYWwKKyAgICAgICAg RXdrX1ZpZXcgbWVtYmVycyB0byBhdm9pZCBoYW5kbGluZyBtZW1vcnkgbWFudWFsbHkuCisKKyAg ICAgICAgKiBQbGF0Zm9ybUVmbC5jbWFrZToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9l d2tfdmlldy5jcHA6CisgICAgICAgIChfRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKToKKyAgICAgICAg KF9Fd2tfVmlld19Qcml2YXRlX0RhdGE6Ol9Fd2tfVmlld19Qcml2YXRlX0RhdGEpOgorICAgICAg ICAoX0V3a19WaWV3X1ByaXZhdGVfRGF0YTo6fl9Fd2tfVmlld19Qcml2YXRlX0RhdGEpOgorICAg ICAgICAoZXdrX3ZpZXdfY3Vyc29yX3NldCk6CisgICAgICAgIChld2tfdmlld19jb2xvcl9waWNr ZXJfZGlzbWlzcyk6CisgICAgICAgIChld2tfdmlld19jb2xvcl9waWNrZXJfY29sb3Jfc2V0KToK KwogMjAxMi0xMC0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gRG9uJ3QgdXNlIHRoZSBDIEFQSSBpbnRlcm5hbGx5IGluIFdlYktp dERvd25sb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZSBi L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDZkZjVkM2EuLmQ3MzQxNDgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0xNTMsNiArMTUzLDcgQEAgTElTVChBUFBF TkQgV2ViS2l0Ml9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V0VCS0lUMl9ESVJ9L1dlYlBy b2Nlc3Mvc291cCIKICAgICAiJHtXRUJLSVQyX0RJUn0vV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9lZmwiCiAgICAgIiR7V0VCS0lUMl9ESVJ9L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvc291 cCIKKyAgICAiJHtXVEZfRElSfS93dGYvZWZsLyIKICAgICAiJHtXVEZfRElSfS93dGYvZ29iamVj dCIKICAgICAke0NBSVJPX0lOQ0xVREVfRElSU30KICAgICAke0VDT1JFX0lOQ0xVREVfRElSU30K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNw cCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCA5 NWIwODRlLi5lNTkxYTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXcuY3BwCkBAIC0yNSw2ICsyNSw3IEBACiAjaW5jbHVkZSAiTmF0aXZlV2ViTW91c2VF dmVudC5oIgogI2luY2x1ZGUgIk5hdGl2ZVdlYldoZWVsRXZlbnQuaCIKICNpbmNsdWRlICJQYWdl Q2xpZW50SW1wbC5oIgorI2luY2x1ZGUgIlJlZlB0ckVmbC5oIgogI2luY2x1ZGUgIldLQVBJQ2Fz dC5oIgogI2luY2x1ZGUgIldLQ29sb3JQaWNrZXJSZXN1bHRMaXN0ZW5lci5oIgogI2luY2x1ZGUg IldLRWluYVNoYXJlZFN0cmluZy5oIgpAQCAtMTI0LDEyICsxMjUsMTIgQEAgc3RydWN0IF9Fd2tf Vmlld19Qcml2YXRlX0RhdGEgewogICAgIFdLRWluYVNoYXJlZFN0cmluZyBjdXN0b21FbmNvZGlu ZzsKICAgICBXS0VpbmFTaGFyZWRTdHJpbmcgY3Vyc29yR3JvdXA7CiAgICAgV0tFaW5hU2hhcmVk U3RyaW5nIGZhdmljb25VUkw7Ci0gICAgRXZhc19PYmplY3QqIGN1cnNvck9iamVjdDsKKyAgICBS ZWZQdHI8RXZhc19PYmplY3Q+IGN1cnNvck9iamVjdDsKICAgICBMb2FkaW5nUmVzb3VyY2VzTWFw IGxvYWRpbmdSZXNvdXJjZXNNYXA7CiAgICAgT3duUHRyPEV3a19CYWNrX0ZvcndhcmRfTGlzdD4g YmFja0ZvcndhcmRMaXN0OwogICAgIE93blB0cjxFd2tfU2V0dGluZ3M+IHNldHRpbmdzOwogICAg IGJvb2wgYXJlTW91c2VFdmVudHNFbmFibGVkOwotICAgIFdLQ29sb3JQaWNrZXJSZXN1bHRMaXN0 ZW5lclJlZiBjb2xvclBpY2tlclJlc3VsdExpc3RlbmVyOworICAgIFdLUmV0YWluUHRyPFdLQ29s b3JQaWNrZXJSZXN1bHRMaXN0ZW5lclJlZj4gY29sb3JQaWNrZXJSZXN1bHRMaXN0ZW5lcjsKICAg ICBFd2tfQ29udGV4dCogY29udGV4dDsKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogICAgIGJv b2wgYXJlVG91Y2hFdmVudHNFbmFibGVkOwpAQCAtMTQ5LDkgKzE1MCw3IEBAIHN0cnVjdCBfRXdr X1ZpZXdfUHJpdmF0ZV9EYXRhIHsKICNlbmRpZgogCiAgICAgX0V3a19WaWV3X1ByaXZhdGVfRGF0 YSgpCi0gICAgICAgIDogY3Vyc29yT2JqZWN0KDApCi0gICAgICAgICwgYXJlTW91c2VFdmVudHNF bmFibGVkKGZhbHNlKQotICAgICAgICAsIGNvbG9yUGlja2VyUmVzdWx0TGlzdGVuZXIoMCkKKyAg ICAgICAgOiBhcmVNb3VzZUV2ZW50c0VuYWJsZWQoZmFsc2UpCiAgICAgICAgICwgY29udGV4dCgw KQogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAgICAgICAgICwgYXJlVG91Y2hFdmVudHNFbmFi bGVkKGZhbHNlKQpAQCAtMTc0LDkgKzE3Myw2IEBAIHN0cnVjdCBfRXdrX1ZpZXdfUHJpdmF0ZV9E YXRhIHsKICAgICAgICAgRXdrX0Zhdmljb25fRGF0YWJhc2UqIGljb25EYXRhYmFzZSA9IGV3a19j b250ZXh0X2Zhdmljb25fZGF0YWJhc2VfZ2V0KGNvbnRleHQpOwogICAgICAgICBld2tfZmF2aWNv bl9kYXRhYmFzZV9pY29uX2NoYW5nZV9jYWxsYmFja19kZWwoaWNvbkRhdGFiYXNlLCBfZXdrX3Zp ZXdfb25fZmF2aWNvbl9jaGFuZ2VkKTsKIAotICAgICAgICBpZiAoY3Vyc29yT2JqZWN0KQotICAg ICAgICAgICAgZXZhc19vYmplY3RfZGVsKGN1cnNvck9iamVjdCk7Ci0KICAgICAgICAgdm9pZCog aXRlbTsKICAgICAgICAgRUlOQV9MSVNUX0ZSRUUocG9wdXBNZW51SXRlbXMsIGl0ZW0pCiAgICAg ICAgICAgICBkZWxldGUgc3RhdGljX2Nhc3Q8RXdrX1BvcHVwX01lbnVfSXRlbSo+KGl0ZW0pOwpA QCAtMTI0OCwxNSArMTI0NCwxMSBAQCB2b2lkIGV3a192aWV3X2N1cnNvcl9zZXQoRXZhc19PYmpl Y3QqIGV3a1ZpZXcsIGNvbnN0IEN1cnNvciYgY3Vyc29yKQogICAgICAgICByZXR1cm47CiAKICAg ICBwcml2LT5jdXJzb3JHcm91cCA9IGdyb3VwOwotCi0gICAgaWYgKHByaXYtPmN1cnNvck9iamVj dCkKLSAgICAgICAgZXZhc19vYmplY3RfZGVsKHByaXYtPmN1cnNvck9iamVjdCk7Ci0gICAgcHJp di0+Y3Vyc29yT2JqZWN0ID0gZWRqZV9vYmplY3RfYWRkKHNtYXJ0RGF0YS0+YmFzZS5ldmFzKTsK KyAgICBwcml2LT5jdXJzb3JPYmplY3QgPSBhZG9wdFJlZihlZGplX29iamVjdF9hZGQoc21hcnRE YXRhLT5iYXNlLmV2YXMpKTsKIAogICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2 YXNfZWNvcmVfZXZhc19nZXQoc21hcnREYXRhLT5iYXNlLmV2YXMpOwotICAgIGlmICghcHJpdi0+ dGhlbWUgfHwgIWVkamVfb2JqZWN0X2ZpbGVfc2V0KHByaXYtPmN1cnNvck9iamVjdCwgcHJpdi0+ dGhlbWUsIGdyb3VwKSkgewotICAgICAgICBldmFzX29iamVjdF9kZWwocHJpdi0+Y3Vyc29yT2Jq ZWN0KTsKLSAgICAgICAgcHJpdi0+Y3Vyc29yT2JqZWN0ID0gMDsKKyAgICBpZiAoIXByaXYtPnRo ZW1lIHx8ICFlZGplX29iamVjdF9maWxlX3NldChwcml2LT5jdXJzb3JPYmplY3QuZ2V0KCksIHBy aXYtPnRoZW1lLCBncm91cCkpIHsKKyAgICAgICAgcHJpdi0+Y3Vyc29yT2JqZWN0LmNsZWFyKCk7 CiAKICAgICAgICAgZWNvcmVfZXZhc19vYmplY3RfY3Vyc29yX3NldChlY29yZUV2YXMsIDAsIDAs IDAsIDApOwogI2lmZGVmIEhBVkVfRUNPUkVfWApAQCAtMTI2NywyNyArMTI1OSwyNyBAQCB2b2lk IGV3a192aWV3X2N1cnNvcl9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IEN1cnNvciYg Y3Vyc29yKQogICAgIH0KIAogICAgIEV2YXNfQ29vcmQgd2lkdGgsIGhlaWdodDsKLSAgICBlZGpl X29iamVjdF9zaXplX21pbl9nZXQocHJpdi0+Y3Vyc29yT2JqZWN0LCAmd2lkdGgsICZoZWlnaHQp OworICAgIGVkamVfb2JqZWN0X3NpemVfbWluX2dldChwcml2LT5jdXJzb3JPYmplY3QuZ2V0KCks ICZ3aWR0aCwgJmhlaWdodCk7CiAgICAgaWYgKHdpZHRoIDw9IDAgfHwgaGVpZ2h0IDw9IDApCi0g ICAgICAgIGVkamVfb2JqZWN0X3NpemVfbWluX2NhbGMocHJpdi0+Y3Vyc29yT2JqZWN0LCAmd2lk dGgsICZoZWlnaHQpOworICAgICAgICBlZGplX29iamVjdF9zaXplX21pbl9jYWxjKHByaXYtPmN1 cnNvck9iamVjdC5nZXQoKSwgJndpZHRoLCAmaGVpZ2h0KTsKICAgICBpZiAod2lkdGggPD0gMCB8 fCBoZWlnaHQgPD0gMCkgewogICAgICAgICB3aWR0aCA9IGRlZmF1bHRDdXJzb3JTaXplOwogICAg ICAgICBoZWlnaHQgPSBkZWZhdWx0Q3Vyc29yU2l6ZTsKICAgICB9Ci0gICAgZXZhc19vYmplY3Rf cmVzaXplKHByaXYtPmN1cnNvck9iamVjdCwgd2lkdGgsIGhlaWdodCk7CisgICAgZXZhc19vYmpl Y3RfcmVzaXplKHByaXYtPmN1cnNvck9iamVjdC5nZXQoKSwgd2lkdGgsIGhlaWdodCk7CiAKICAg ICBjb25zdCBjaGFyKiBkYXRhOwogICAgIGludCBob3RzcG90WCA9IDA7Ci0gICAgZGF0YSA9IGVk amVfb2JqZWN0X2RhdGFfZ2V0KHByaXYtPmN1cnNvck9iamVjdCwgImhvdC54Iik7CisgICAgZGF0 YSA9IGVkamVfb2JqZWN0X2RhdGFfZ2V0KHByaXYtPmN1cnNvck9iamVjdC5nZXQoKSwgImhvdC54 Iik7CiAgICAgaWYgKGRhdGEpCiAgICAgICAgIGhvdHNwb3RYID0gYXRvaShkYXRhKTsKIAogICAg IGludCBob3RzcG90WSA9IDA7Ci0gICAgZGF0YSA9IGVkamVfb2JqZWN0X2RhdGFfZ2V0KHByaXYt PmN1cnNvck9iamVjdCwgImhvdC55Iik7CisgICAgZGF0YSA9IGVkamVfb2JqZWN0X2RhdGFfZ2V0 KHByaXYtPmN1cnNvck9iamVjdC5nZXQoKSwgImhvdC55Iik7CiAgICAgaWYgKGRhdGEpCiAgICAg ICAgIGhvdHNwb3RZID0gYXRvaShkYXRhKTsKIAotICAgIGVjb3JlX2V2YXNfb2JqZWN0X2N1cnNv cl9zZXQoZWNvcmVFdmFzLCBwcml2LT5jdXJzb3JPYmplY3QsIEVWQVNfTEFZRVJfTUFYLCBob3Rz cG90WCwgaG90c3BvdFkpOworICAgIGVjb3JlX2V2YXNfb2JqZWN0X2N1cnNvcl9zZXQoZWNvcmVF dmFzLCBwcml2LT5jdXJzb3JPYmplY3QuZ2V0KCksIEVWQVNfTEFZRVJfTUFYLCBob3RzcG90WCwg aG90c3BvdFkpOwogfQogCiB2b2lkIGV3a192aWV3X2Rpc3BsYXkoRXZhc19PYmplY3QqIGV3a1Zp ZXcsIGNvbnN0IEludFJlY3QmIHJlY3QpCkBAIC0xOTA5LDcgKzE5MDEsNyBAQCBXS0VpbmFTaGFy ZWRTdHJpbmcgZXdrX3ZpZXdfcnVuX2phdmFzY3JpcHRfcHJvbXB0KEV2YXNfT2JqZWN0KiBld2tW aWV3LCBjb25zdCBXSwogI2lmIEVOQUJMRShJTlBVVF9UWVBFX0NPTE9SKQogLyoqCiAgKiBAaW50 ZXJuYWwKLSAqIFJlcWV1c3RzIHRvIHNob3cgZXh0ZXJuYWwgY29sb3IgcGlja2VyLgorICogUmVx dWVzdHMgdG8gc2hvdyBleHRlcm5hbCBjb2xvciBwaWNrZXIuCiAgKi8KIHZvaWQgZXdrX3ZpZXdf Y29sb3JfcGlja2VyX3JlcXVlc3QoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGludCByLCBpbnQgZywg aW50IGIsIGludCBhLCBXS0NvbG9yUGlja2VyUmVzdWx0TGlzdGVuZXJSZWYgbGlzdGVuZXIpCiB7 CkBAIC0xOTI0LDcgKzE5MTYsNyBAQCB2b2lkIGV3a192aWV3X2NvbG9yX3BpY2tlcl9yZXF1ZXN0 KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBpbnQgciwgaW50IGcsIGludCBiLCBpbgogCiAvKioKICAq IEBpbnRlcm5hbAotICogUmVxZXVzdHMgdG8gaGlkZSBleHRlcm5hbCBjb2xvciBwaWNrZXIuCisg KiBSZXF1ZXN0cyB0byBoaWRlIGV4dGVybmFsIGNvbG9yIHBpY2tlci4KICAqLwogdm9pZCBld2tf dmlld19jb2xvcl9waWNrZXJfZGlzbWlzcyhFdmFzX09iamVjdCogZXdrVmlldykKIHsKQEAgLTE5 MzIsNyArMTkyNCw3IEBAIHZvaWQgZXdrX3ZpZXdfY29sb3JfcGlja2VyX2Rpc21pc3MoRXZhc19P YmplY3QqIGV3a1ZpZXcpCiAgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNtYXJ0RGF0 YSwgcHJpdik7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk4oc21hcnREYXRhLT5hcGkt PmlucHV0X3BpY2tlcl9jb2xvcl9kaXNtaXNzKTsKIAotICAgIHByaXYtPmNvbG9yUGlja2VyUmVz dWx0TGlzdGVuZXIgPSAwOworICAgIHByaXYtPmNvbG9yUGlja2VyUmVzdWx0TGlzdGVuZXIuY2xl YXIoKTsKIAogICAgIHNtYXJ0RGF0YS0+YXBpLT5pbnB1dF9waWNrZXJfY29sb3JfZGlzbWlzcyhz bWFydERhdGEpOwogfQpAQCAtMTk0Nyw4ICsxOTM5LDggQEAgRWluYV9Cb29sIGV3a192aWV3X2Nv bG9yX3BpY2tlcl9jb2xvcl9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGludCByLCBpbnQgZywg aW4KIAogICAgIFdlYkNvcmU6OkNvbG9yIGNvbG9yID0gV2ViQ29yZTo6Q29sb3IociwgZywgYiwg YSk7CiAgICAgY29uc3QgV0tTdHJpbmdSZWYgY29sb3JTdHJpbmcgPSBXS1N0cmluZ0NyZWF0ZVdp dGhVVEY4Q1N0cmluZyhjb2xvci5zZXJpYWxpemVkKCkudXRmOCgpLmRhdGEoKSk7Ci0gICAgV0tD b2xvclBpY2tlclJlc3VsdExpc3RlbmVyU2V0Q29sb3IocHJpdi0+Y29sb3JQaWNrZXJSZXN1bHRM aXN0ZW5lciwgY29sb3JTdHJpbmcpOwotICAgIHByaXYtPmNvbG9yUGlja2VyUmVzdWx0TGlzdGVu ZXIgPSAwOworICAgIFdLQ29sb3JQaWNrZXJSZXN1bHRMaXN0ZW5lclNldENvbG9yKHByaXYtPmNv bG9yUGlja2VyUmVzdWx0TGlzdGVuZXIuZ2V0KCksIGNvbG9yU3RyaW5nKTsKKyAgICBwcml2LT5j b2xvclBpY2tlclJlc3VsdExpc3RlbmVyLmNsZWFyKCk7CiAKICAgICByZXR1cm4gdHJ1ZTsKICNl bHNlCg==