99609 2012-10-17 10:24:07 -0700 r130956 uses legacy API and creates bogus JSGlobalDatas in all layout tests 2012-10-17 23:00:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93958 1 mhahnenberg zoltan mhahnenberg rniwa webkit.review.bot oldest_to_newest 744366 0 mhahnenberg 2012-10-17 10:24:07 -0700 While investigating another GC bug, I noticed that some tests that were calling HeapStatistics::usedJSHeap, which in turn calls into JSGlobalData::sharedInstance. sharedInstance() is a legacy API that creates a new, static JSGlobalData instance completely unrelated to the JSGlobalData that was used during the layout test. This is almost certainly not the behavior that was intended. You will need to get ahold of the JSGlobalData in a different fashion. JSDOMWindowBase::commonJSGlobalData() may be more of what you're looking for. 744392 1 zoltan 2012-10-17 10:44:59 -0700 Thanks Mark, I'm going to fix this. 744961 2 169338 zoltan 2012-10-17 22:01:22 -0700 Created attachment 169338 Patch 744966 3 zoltan 2012-10-17 22:03:25 -0700 I don't want to let the code in. I will come up with the proper solution soon separately. 744997 4 169338 webkit.review.bot 2012-10-17 23:00:03 -0700 Comment on attachment 169338 Patch Clearing flags on attachment: 169338 Committed r131707: <http://trac.webkit.org/changeset/131707> 744998 5 webkit.review.bot 2012-10-17 23:00:07 -0700 All reviewed patches have been landed. Closing bug. 169338 2012-10-17 22:01:22 -0700 2012-10-17 23:00:03 -0700 Patch bug-99609-20121017220008.patch text/plain 3469 zoltan U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj MjE1OThjOWU3YmI5N2RkMGRlOWEyOWM1YjU1MDU5NjJlYmU2Y2NiLi4yZTM0MGViODcwZjFmMTQ1 NThkYzVlZTY3Y2JkNWZiNGJiNjJlNTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMi0xMC0xNyAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9y Zz4KKworICAgICAgICBSZW1vdmUgdGhlIEpTSGVhcCBtZW1vcnkgbWVhc3VyZW1lbnQgb2YgdGhl IFBhZ2VMb2FkIHBlcmZvcm1hY2V0ZXN0cyBzaW5jZSBpdCBjcmVhdGVzIGJvZ3VzIEpTR2xvYmFs RGF0YXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5 NjA5IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bW92ZSB0aGUgaW1wbGVtZW50YXRpb24gc2luY2UgaXQgY3JlYXRlcyBib2d1cyBKU0dsb2JhbERh dGFzIGluIHRoZSBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBoZWFwL0hlYXBTdGF0aXN0aWNz LmNwcDoKKyAgICAgICAgKEpTQyk6CisgICAgICAgICogaGVhcC9IZWFwU3RhdGlzdGljcy5oOgor ICAgICAgICAoSGVhcFN0YXRpc3RpY3MpOgorCiAyMDEyLTEwLTE3ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQXR0ZW1wdCB0byBmaXggdGhlIGJ1aWxkLgpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFN0YXRpc3RpY3MuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFN0YXRpc3RpY3MuY3BwCmluZGV4IDY4MDQ0ZTBi MzNhOTMzNGYwNWU4NjdiNDQ1ZDZmMzQ5YmU5Y2E3MmYuLjgzNDBiZmEzN2M4MjcxN2JiMjQ2MGUw ZmIxODJiZTlhYTNlYTI1NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L0hlYXBTdGF0aXN0aWNzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw U3RhdGlzdGljcy5jcHAKQEAgLTEzOCwxMiArMTM4LDYgQEAgdm9pZCBIZWFwU3RhdGlzdGljczo6 cmVwb3J0U3VjY2VzcygpCiAKICNlbmRpZiAvLyBPUyhVTklYKQogCi1zaXplX3QgSGVhcFN0YXRp c3RpY3M6OnVzZWRKU0hlYXAoKQotewotICAgIEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSA9ICZK U0dsb2JhbERhdGE6OnNoYXJlZEluc3RhbmNlKCk7Ci0gICAgcmV0dXJuIGdsb2JhbERhdGEtPmhl YXAuc2l6ZSgpOwotfQotCiBzaXplX3QgSGVhcFN0YXRpc3RpY3M6OnBhcnNlTWVtb3J5QW1vdW50 KGNoYXIqIHMpCiB7CiAgICAgc2l6ZV90IG11bHRpcGxpZXIgPSAxOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFN0YXRpc3RpY3MuaCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL0hlYXBTdGF0aXN0aWNzLmgKaW5kZXggMzRkMDVhZjdjNDk0ODIwNmNmZWFk Njk4NDZjOGFhNDAwOWI1Mjc5YS4uMDgwMGYwYzE2N2E4YjBkMzkyYTU1ZGVmMmY0ODZmOWQ0Nzgw MjI3ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFN0YXRpc3Rp Y3MuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwU3RhdGlzdGljcy5oCkBA IC0zNiw3ICszNiw2IEBAIGNsYXNzIEhlYXBTdGF0aXN0aWNzIHsKIHB1YmxpYzoKICAgICBOT19S RVRVUk4gc3RhdGljIHZvaWQgZXhpdFdpdGhGYWlsdXJlKCk7CiAgICAgSlNfRVhQT1JUX1BSSVZB VEUgc3RhdGljIHZvaWQgcmVwb3J0U3VjY2VzcygpOwotICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0 YXRpYyBzaXplX3QgdXNlZEpTSGVhcCgpOwogCiAgICAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZSgp OwogICAgIHN0YXRpYyB2b2lkIHJlY29yZEdDUGF1c2VUaW1lKGRvdWJsZSBzdGFydCwgZG91Ymxl IGVuZCk7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggNGYyMWE3NjBiMWQ3NTdjMmU4OWUzZDI0NjBiMDA0MDQ3NmFhZmQ3OS4uOTBlNTU5Y2EzZmJj YmVjMDNlN2EzYWIyNTA2N2ZlZTkzZGE4M2UwZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTE3ICBab2x0 YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSB0aGUgSlNI ZWFwIG1lbW9yeSBtZWFzdXJlbWVudCBvZiB0aGUgUGFnZUxvYWQgcGVyZm9ybWFjZXRlc3RzIHNp bmNlIGl0IGNyZWF0ZXMgYm9ndXMgSlNHbG9iYWxEYXRhcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk2MDkgCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBpbXBsZW1lbnRhdGlvbiBzaW5j ZSBpdCBjcmVhdGVzIGJvZ3VzIEpTR2xvYmFsRGF0YXMgaW4gdGhlIGxheW91dCB0ZXN0cy4KKwor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbToKKyAgICAgICAg KGR1bXApOgorCiAyMDEyLTEwLTE3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gc3RvcCBmYWxsaW5nIGJhY2sgdG8gcGxhdGZvcm0vbWFj IGZvciBMYXlvdXRUZXN0IHJlc3VsdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L21hYy9EdW1wUmVuZGVyVHJlZS5tbSBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVu ZGVyVHJlZS5tbQppbmRleCBmNzBlMjYyNTlkODY5ZmU1NTEzNzJiNjAwNDA0Y2JkZmFlOGY1MDgw Li4wMjliMzU4YTA2NjgyZjJhMzhkNThlOTA5ODM2ZDcxMTFiYTc4NzFjIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCkBAIC0xMTg2LDcgKzExODYsNiBAQCB2 b2lkIGR1bXAoKQogCiAgICAgICAgIFdURjo6RmFzdE1hbGxvY1N0YXRpc3RpY3MgbWFsbG9jU3Rh dHMgPSBXVEY6OmZhc3RNYWxsb2NTdGF0aXN0aWNzKCk7CiAgICAgICAgIHByaW50ZigiRHVtcE1h bGxvYzogJWxpXG4iLCBtYWxsb2NTdGF0cy5jb21taXR0ZWRWTUJ5dGVzKTsKLSAgICAgICAgcHJp bnRmKCJEdW1wSlNIZWFwOiAlbGlcbiIsIEpTQzo6SGVhcFN0YXRpc3RpY3M6OnVzZWRKU0hlYXAo KSk7CiAKICAgICAgICAgaWYgKHJlc3VsdERhdGEpIHsKICAgICAgICAgICAgIGZ3cml0ZShbcmVz dWx0RGF0YSBieXRlc10sIDEsIFtyZXN1bHREYXRhIGxlbmd0aF0sIHN0ZG91dCk7Cg==