99602 2012-10-17 09:24:51 -0700 Web Inspector: no "delete watch expression" context menu item when clicking on the expression value 2022-03-01 03:03:15 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 744301 0 yurys 2012-10-17 09:24:51 -0700 The item is only available when you click outside of the value. 744306 1 169196 yurys 2012-10-17 09:28:18 -0700 Created attachment 169196 Patch 744307 2 169196 pfeldman 2012-10-17 09:30:18 -0700 Comment on attachment 169196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169196&action=review > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:262 > + populateContextMenu: function(contextMenu) Please annotate > Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:395 > + * @override override is not supported 744315 3 yurys 2012-10-17 09:39:06 -0700 Committed r131612: <http://trac.webkit.org/changeset/131612> 169196 2012-10-17 09:28:18 -0700 2022-03-01 03:03:15 -0800 Patch bug-99602-20121017202704.patch text/plain 3306 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGYzZDZiZWVlYWE3ODAw OGNhYjNmNDQwN2IwOGZiY2MxMGUyYzJjMy4uMmZhOGFhYTNiMjc5M2VkYmQ1M2U5NTMwMDAzNDI2 ZDU1ZGQxYTY1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTE3ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IG5vICJkZWxldGUgd2F0Y2ggZXhwcmVzc2lvbiIgY29udGV4dCBtZW51IGl0ZW0gd2hlbiBj bGlja2luZyBvbiB0aGUgZXhwcmVzc2lvbiB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk2MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgZGVsZXRlIGl0ZW1zIHRvIHRoZSB3YXRjaCBleHBy ZXNzaW9uJ3MgdmFsdWUncyBjb250ZXh0IG1lbnUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL09iamVjdFByb3BlcnRpZXNTZWN0aW9uLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y Lk9iamVjdFByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlLl9jb250ZXh0TWVudUZpcmVkKToK KyAgICAgICAgKFdlYkluc3BlY3Rvci5PYmplY3RQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlw ZS5wb3B1bGF0ZUNvbnRleHRNZW51KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1dh dGNoRXhwcmVzc2lvbnNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5XYXRj aEV4cHJlc3Npb25UcmVlRWxlbWVudC5wcm90b3R5cGUucG9wdWxhdGVDb250ZXh0TWVudSk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuV2F0Y2hFeHByZXNzaW9uVHJlZUVsZW1lbnQucHJvdG90eXBl Ll9jb250ZXh0TWVudSk6CisKIDIwMTItMTAtMTcgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1JlZ3Jlc3Npb25dIFVuZG9p bmcgc2NyaXB0IGNoYW5nZXMgZG9lcyBub3QgcmVzdG9yZSBicmVha3BvaW50cy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1Nl Y3Rpb24uanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3Bl cnRpZXNTZWN0aW9uLmpzCmluZGV4IGEyN2QzN2VmNWViZGEwMGI2ZDY0MGQwOTMwMTlkOTljNmNl Mzk2YzUuLmVmN2Y1Njg0YjM3ZmExYjEwZDBiYTFiYjAwYjczMDVkYjE1MTYxZTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1Nl Y3Rpb24uanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQ cm9wZXJ0aWVzU2VjdGlvbi5qcwpAQCAtMjU0LDEwICsyNTQsMTUgQEAgV2ViSW5zcGVjdG9yLk9i amVjdFByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogICAgIF9jb250ZXh0TWVudUZp cmVkOiBmdW5jdGlvbih2YWx1ZSwgZXZlbnQpCiAgICAgewogICAgICAgICB2YXIgY29udGV4dE1l bnUgPSBuZXcgV2ViSW5zcGVjdG9yLkNvbnRleHRNZW51KCk7CisgICAgICAgIHRoaXMucG9wdWxh dGVDb250ZXh0TWVudShjb250ZXh0TWVudSk7CiAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEFw cGxpY2FibGVJdGVtcyh2YWx1ZSk7CiAgICAgICAgIGNvbnRleHRNZW51LnNob3coZXZlbnQpOwog ICAgIH0sCiAKKyAgICBwb3B1bGF0ZUNvbnRleHRNZW51OiBmdW5jdGlvbihjb250ZXh0TWVudSkK KyAgICB7CisgICAgfSwKKwogICAgIHVwZGF0ZVNpYmxpbmdzOiBmdW5jdGlvbigpCiAgICAgewog ICAgICAgICBpZiAodGhpcy5wYXJlbnQucm9vdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvV2F0Y2hFeHByZXNzaW9uc1NpZGViYXJQYW5lLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBh bmUuanMKaW5kZXggMmM1MDg2MmJkOGUxNGM4OGJkNzcyMDZiY2FkYzMzZDlhYTI2MmI2YS4uMWY0 ZTY0MDhjZGUzNjllYWUzYmM0YmM5NWY2Mzc2YjNlZmMwOWFiYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Npb25zU2lkZWJhclBhbmUu anMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XYXRjaEV4cHJlc3Np b25zU2lkZWJhclBhbmUuanMKQEAgLTM5MSwxMiArMzkxLDIwIEBAIFdlYkluc3BlY3Rvci5XYXRj aEV4cHJlc3Npb25UcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMubGlzdEl0 ZW1FbGVtZW50Lmluc2VydEJlZm9yZShkZWxldGVCdXR0b24sIHRoaXMubGlzdEl0ZW1FbGVtZW50 LmZpcnN0Q2hpbGQpOwogICAgIH0sCiAgICAgCi0gICAgX2NvbnRleHRNZW51OiBmdW5jdGlvbihl dmVudCkKKyAgICAvKioKKyAgICAgKiBAb3ZlcnJpZGUKKyAgICAgKi8KKyAgICBwb3B1bGF0ZUNv bnRleHRNZW51OiBmdW5jdGlvbihjb250ZXh0TWVudSkKICAgICB7Ci0gICAgICAgIHZhciBjb250 ZXh0TWVudSA9IG5ldyBXZWJJbnNwZWN0b3IuQ29udGV4dE1lbnUoKTsKICAgICAgICAgY29udGV4 dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkRlbGV0ZSB3YXRjaCBleHBy ZXNzaW9uIiksIHRoaXMuX2RlbGV0ZUJ1dHRvbkNsaWNrZWQuYmluZCh0aGlzKSk7CiAgICAgICAg IGlmICh0aGlzLnRyZWVPdXRsaW5lLnNlY3Rpb24ud2F0Y2hFeHByZXNzaW9ucy5sZW5ndGggPiAx KQogICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIkRlbGV0ZSBhbGwgd2F0Y2ggZXhwcmVzc2lvbnMiKSwgdGhpcy5fZGVsZXRlQWxsQnV0dG9u Q2xpY2tlZC5iaW5kKHRoaXMpKTsKKyAgICB9LAorCisgICAgX2NvbnRleHRNZW51OiBmdW5jdGlv bihldmVudCkKKyAgICB7CisgICAgICAgIHZhciBjb250ZXh0TWVudSA9IG5ldyBXZWJJbnNwZWN0 b3IuQ29udGV4dE1lbnUoKTsKKyAgICAgICAgdGhpcy5wb3B1bGF0ZUNvbnRleHRNZW51KGNvbnRl eHRNZW51KTsKICAgICAgICAgY29udGV4dE1lbnUuc2hvdyhldmVudCk7CiAgICAgfSwKICAgICAK