99597 2012-10-17 07:52:49 -0700 [EFL][WK2] Make sure the favicon database path is set only once 2012-10-17 08:36:17 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez d-r gyuyoung.kim kenneth laszlo.gombos rakuco tonikitoo webkit.review.bot oldest_to_newest 744236 0 cdumez 2012-10-17 07:52:49 -0700 We currently don't check if the favicon database path has been set before setting it. This leads to such errors on stderr: STDERR: ERROR: Icon database already has a path and is already open. We don't currently support changing its path and reopening. 744240 1 169186 cdumez 2012-10-17 07:59:36 -0700 Created attachment 169186 Patch 744263 2 169186 webkit.review.bot 2012-10-17 08:36:12 -0700 Comment on attachment 169186 Patch Clearing flags on attachment: 169186 Committed r131602: <http://trac.webkit.org/changeset/131602> 744264 3 webkit.review.bot 2012-10-17 08:36:17 -0700 All reviewed patches have been landed. Closing bug. 169186 2012-10-17 07:59:36 -0700 2012-10-17 08:36:12 -0700 Patch 99597_iconDatabase_path.patch text/plain 2599 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5Y2M0NWNkLi45N2E2MWNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTAtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIE1ha2Ugc3VyZSB0aGUgZmF2aWNvbiBkYXRhYmFz ZSBwYXRoIGlzIHNldCBvbmx5IG9uY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk5NTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBpY29uIGRhdGFiYXNlIHBhdGggaXMgc2V0IG9u bHkgb25jZSBieSBjaGVja2luZworICAgICAgICB0aGF0IHRoZSBkYXRhYmFzZSBpcyBub3QgYWxy ZWFkeSBvcGVuIGJlZm9yZSBzZXR0aWduIHRoZSBwYXRoLgorICAgICAgICBUaGlzIGF2b2lkcyBw cmludGluZyBlcnJvciBtZXNzYWdlIG9uIHN0ZGVyci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL2V3a19jb250ZXh0LmNwcDoKKyAgICAgICAgKGV3a19jb250ZXh0X2Zhdmljb25fZGF0 YWJhc2VfZ2V0KToKKwogMjAxMi0xMC0xNyAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3phamtv d3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbV0syXVtFRkxdIEFkZCB1bml0IHRlc3RzIGZv ciBTcGVsbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX2NvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Nv bnRleHQuY3BwCmluZGV4IDYzMzhlYWMuLmYwMDJhOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dC5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKICNp bmNsdWRlICJXS1JldGFpblB0ci5oIgogI2luY2x1ZGUgIldLU3RyaW5nLmgiCiAjaW5jbHVkZSAi V2ViQ29udGV4dC5oIgorI2luY2x1ZGUgIldlYkljb25EYXRhYmFzZS5oIgogI2luY2x1ZGUgImV3 a19jb250ZXh0X2Rvd25sb2FkX2NsaWVudF9wcml2YXRlLmgiCiAjaW5jbHVkZSAiZXdrX2NvbnRl eHRfaGlzdG9yeV9jbGllbnRfcHJpdmF0ZS5oIgogI2luY2x1ZGUgImV3a19jb250ZXh0X3ByaXZh dGUuaCIKQEAgLTE2NiwxMiArMTY3LDE0IEBAIEV3a19GYXZpY29uX0RhdGFiYXNlKiBld2tfY29u dGV4dF9mYXZpY29uX2RhdGFiYXNlX2dldChjb25zdCBFd2tfQ29udGV4dCogZXdrQ29uCiAgICAg RUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKGV3a0NvbnRleHQsIDApOwogCiAgICAgaWYg KCFld2tDb250ZXh0LT5mYXZpY29uRGF0YWJhc2UpIHsKLSAgICAgICAgLy8gU2V0IGRhdGFiYXNl IHBhdGguCi0gICAgICAgIFdlYkNvbnRleHQqIHdlYkNvbnRleHQgPSB0b0ltcGwoZXdrQ29udGV4 dC0+Y29udGV4dC5nZXQoKSk7Ci0gICAgICAgIFN0cmluZyBkYXRhYmFzZVBhdGggPSB3ZWJDb250 ZXh0LT5pY29uRGF0YWJhc2VQYXRoKCkgKyAiLyIgKyBXZWJDb3JlOjpJY29uRGF0YWJhc2U6OmRl ZmF1bHREYXRhYmFzZUZpbGVuYW1lKCk7Ci0gICAgICAgIHdlYkNvbnRleHQtPnNldEljb25EYXRh YmFzZVBhdGgoZGF0YWJhc2VQYXRoKTsKLQotICAgICAgICBjb25zdF9jYXN0PEV3a19Db250ZXh0 Kj4oZXdrQ29udGV4dCktPmZhdmljb25EYXRhYmFzZSA9IEV3a19GYXZpY29uX0RhdGFiYXNlOjpj cmVhdGUoV0tDb250ZXh0R2V0SWNvbkRhdGFiYXNlKGV3a0NvbnRleHQtPmNvbnRleHQuZ2V0KCkp KTsKKyAgICAgICAgV0tSZXRhaW5QdHI8V0tJY29uRGF0YWJhc2VSZWY+IGljb25EYXRhYmFzZSA9 IFdLQ29udGV4dEdldEljb25EYXRhYmFzZShld2tDb250ZXh0LT5jb250ZXh0LmdldCgpKTsKKyAg ICAgICAgLy8gU2V0IHRoZSBkYXRhYmFzZSBwYXRoIGlmIGl0IGlzIG5vdCBvcGVuIHlldC4KKyAg ICAgICAgaWYgKCF0b0ltcGwoaWNvbkRhdGFiYXNlLmdldCgpKS0+aXNPcGVuKCkpIHsKKyAgICAg ICAgICAgIFdlYkNvbnRleHQqIHdlYkNvbnRleHQgPSB0b0ltcGwoZXdrQ29udGV4dC0+Y29udGV4 dC5nZXQoKSk7CisgICAgICAgICAgICBTdHJpbmcgZGF0YWJhc2VQYXRoID0gd2ViQ29udGV4dC0+ aWNvbkRhdGFiYXNlUGF0aCgpICsgIi8iICsgV2ViQ29yZTo6SWNvbkRhdGFiYXNlOjpkZWZhdWx0 RGF0YWJhc2VGaWxlbmFtZSgpOworICAgICAgICAgICAgd2ViQ29udGV4dC0+c2V0SWNvbkRhdGFi YXNlUGF0aChkYXRhYmFzZVBhdGgpOworICAgICAgICB9CisgICAgICAgIGNvbnN0X2Nhc3Q8RXdr X0NvbnRleHQqPihld2tDb250ZXh0KS0+ZmF2aWNvbkRhdGFiYXNlID0gRXdrX0Zhdmljb25fRGF0 YWJhc2U6OmNyZWF0ZShpY29uRGF0YWJhc2UuZ2V0KCkpOwogICAgIH0KIAogICAgIHJldHVybiBl d2tDb250ZXh0LT5mYXZpY29uRGF0YWJhc2UuZ2V0KCk7Cg==