9959 2006-07-16 10:49:26 -0700 REGRESSION: iframes stop rendering after 200th one on successive reloads 2007-06-24 12:04:44 -0700 1 1 1 Unclassified WebKit Frames 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction, Regression P1 Normal --- 1 ddkilzer andersca andersca ap darin hyatt mjs oldest_to_newest 50064 0 ddkilzer 2006-07-16 10:49:26 -0700 I was working on layout tests for Bug 9947, when I suddenly noticed that iframe content was disappearing after I reloaded the layout test too many times. Steps to reproduce: 1. Load test page. Set "count" to 1. 2. Click reload browser button 29 more times (until "count" is 30). Pause between each reload until it is complete. Expected results: The same seven iframes should appear every time the page is reloaded. Actual resutls: On the 29th reload, the bottom three iframes disappear leaving only four iframes. On the 30th reload (and all subsequent reloads), all seven iframes disappear. Note that I haven't tried reloading much beyond 35 to see if they come back. Regression: Works as expected on production Safari 2.0.4 (419.3) on Mac OS X 10.4.7 (8J135/PowerPC). Notes: Tested on locally-built WebKit r15466 (debug build) with the above versions of Safari and Mac OS X. 50065 1 9497 ddkilzer 2006-07-16 10:50:44 -0700 Created attachment 9497 Content for test case iframes 50066 2 9498 ddkilzer 2006-07-16 10:52:17 -0700 Created attachment 9498 Test case (reload 30 times) 50067 3 9499 ddkilzer 2006-07-16 10:57:02 -0700 Created attachment 9499 Local test case (much faster; reload 30 times) It's much faster to reproduce this locally. 50068 4 ddkilzer 2006-07-16 10:57:54 -0700 (In reply to comment #0) > Actual resutls: > > On the 29th reload, the bottom three iframes disappear leaving only four > iframes. On the 30th reload (and all subsequent reloads), all seven iframes > disappear. Actually, the bottom four iframes disappear leaving only the top three on the 29th reload. 50069 5 ddkilzer 2006-07-16 10:59:28 -0700 (In reply to comment #0) > Steps to reproduce: > > 1. Load test page. Set "count" to 1. > 2. Click reload browser button 29 more times (until "count" is 30). Pause > between each reload until it is complete. Where "count" is an internal counter in your brain. 50070 6 ddkilzer 2006-07-16 11:05:24 -0700 Additional testing note: This problem seems to be on a per-browser-window (or per-tab) basis since opening a new tab or a new browser window will let you continue loading the same page another 30 times until all of the content disappears. 50071 7 ddkilzer 2006-07-16 11:10:15 -0700 Tested WebKit nightly r15467 (a release build), but it doesn't exhibit this behavior. May only be reproducible on debug builds. 50072 8 sullivan 2006-07-16 11:43:13 -0700 Maybe some recursion limit gone wrong? 50080 9 ddkilzer 2006-07-16 13:52:39 -0700 Note that my history limit is currently maxed out, although I'm not sure if that would make a difference or not when reproducing this bug. I see the effects of this history limit bug when I start the production Safari after surfing with a ToT WebKit (that fix was committed in r14127) : <rdar://problem/3126419> history load enforces history limit, but deletes the newest instead of oldest items 50083 10 ddkilzer 2006-07-16 14:08:44 -0700 If you look closely, the test cases I posted start with a <thtml> element instead of an <html> element. Fixing this does not resolve the problem, though. 50087 11 9505 ddkilzer 2006-07-16 14:22:46 -0700 Created attachment 9505 Torture test (reload 3 times) This test only requires 3 reloads before iframes just stop appearing (on a debug build). I simply added a lot more iframes than the original test to make the effect happen faster. Note that Safari beach-balls while this test page loads as well. I also fixed the <thtml> tag in this upload. 50166 12 ap 2006-07-17 09:03:02 -0700 Apparently, the frame count isn't reset when reloading. HTMLIFrameElement.cpp, line 91: // FIXME: This limit could be higher, but WebKit has some // algorithms that happen while loading which appear to be N^2 or // worse in the number of frames if (w->frame()->page()->frameCount() >= 200) return false; 50168 13 9523 ap 2006-07-17 09:59:05 -0700 Created attachment 9523 reduced test case HTMLIFrameElement::willRemove() is the only place calling decrementFrameCount(), and it isn't invoked during reload. I have no idea about who is supposed to call it. 50180 14 darin 2006-07-17 11:21:56 -0700 Anders has been working in this area recently. He might be someone good to fix this. 50215 15 9534 andersca 2006-07-17 16:10:44 -0700 Created attachment 9534 Patch 50217 16 9534 darin 2006-07-17 16:52:58 -0700 Comment on attachment 9534 Patch The only thing I don't like about this is that the name disconnectOwnerElement becomes less appropriate if the function does anything else other than clearing the owner element field. r=me 50300 17 andersca 2006-07-18 13:16:36 -0700 Committed revision 15506. 50680 18 darin 2006-07-24 11:09:54 -0700 I know this sounds crazy, but the patch for this bug is causing a measurable performance regression on the iBench HTML benchmark, somewhere in the 5-15% range. 50683 19 ggaren 2006-07-24 11:49:58 -0700 I'm investigating the performance regression. 50685 20 andersca 2006-07-24 12:12:39 -0700 The only significant (well, less non-significant) change that I can see is that we always set the ownerElement to 0 in the destructor with the patch. Might be worth to investigate rolling that part out (replacing the call to disconnectOwnerElement with one that just decrements the frame count) 6460 21 ddkilzer 2007-06-24 12:04:44 -0700 Mass removal of NeedsRadar keyword from my bugs that have already been RESOLVED. 9497 2006-07-16 10:50:44 -0700 2006-07-17 09:59:05 -0700 Content for test case iframes body-dir-overrides-document-dir-content.html text/html 514 ddkilzer PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiB1cGRhdGUoKSB7CiAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnYm9keURpcicpLnZhbHVlID0gZG9jdW1lbnQuYm9keS5kaXI7CiAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZG9jdW1lbnREaXInKS52YWx1ZSA9IGRvY3VtZW50LmRp cjsKfQo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keSBvbmxvYWQ9InVwZGF0ZSgpOyI+CjxkaXYgaWQ9 ImRlc2NyaXB0aW9uIj48L2Rpdj4KPGRpdj4KZG9jdW1lbnQuZGlyID0gPGlucHV0IHR5cGU9InRl eHQiIGlkPSJkb2N1bWVudERpciIgdmFsdWU9IiIgb25jbGljaz0iZG9jdW1lbnQuZGlyID0gdGhp cy52YWx1ZTsgdXBkYXRlKCk7OyI+CjwvZGl2Pgo8ZGl2Pgpkb2N1bWVudC5ib2R5LmRpciA9IDxp bnB1dCB0eXBlPSJ0ZXh0IiBpZD0iYm9keURpciIgdmFsdWU9IiIgb25jbGljaz0iZG9jdW1lbnQu Ym9keS5kaXIgPSB0aGlzLnZhbHVlOyB1cGRhdGUoKTsiPgo8L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+ Cg== 9498 2006-07-16 10:52:17 -0700 2006-07-17 09:59:05 -0700 Test case (reload 30 times) body-dir-overrides-document-dir.html text/html 2344 ddkilzer PHRodG1sPgo8aGVhZD4KPHNjcmlwdD4KaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK ICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKCmZ1bmN0aW9uIHNldEJv ZHlEaXIoaWQsIHZhbCkgewogICAgdmFyIGJvZHlEaXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZChpZCkuY29udGVudERvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdib2R5RGlyJyk7CiAgICBib2R5 RGlyLnZhbHVlID0gdmFsOwogICAgYm9keURpci5jbGljaygpOwp9CgpmdW5jdGlvbiBzZXREb2N1 bWVudERpcihpZCwgdmFsKSB7CiAgICB2YXIgZG9jdW1lbnREaXIgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZChpZCkuY29udGVudERvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkb2N1bWVudERpcicp OwogICAgZG9jdW1lbnREaXIudmFsdWUgPSB2YWw7CiAgICBkb2N1bWVudERpci5jbGljaygpOwp9 CgpmdW5jdGlvbiBzZXREZXNjcmlwdGlvbihpZCwgZGVzY3JpcHRpb24pIHsKICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKGlkKS5jb250ZW50RG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Rlc2Ny aXB0aW9uJykuaW5uZXJIVE1MID0gJ1Rlc3Rpbmc6ICcgKyBkZXNjcmlwdGlvbjsKfQoKZnVuY3Rp b24gdGVzdEJvZHlEaXIoaWQsIHZhbCkgewogICAgc2V0RGVzY3JpcHRpb24oaWQsICJTZXR0aW5n IGRvY3VtZW50LmJvZHkuZGlyIHRvICciICsgdmFsICsgIiciKTsKICAgIHNldEJvZHlEaXIoaWQs IHZhbCk7Cn0KCmZ1bmN0aW9uIHRlc3RCb2R5RGlyQW5kRG9jdW1lbnREaXIoaWQsIHZhbEJvZHlE aXIsIHZhbERvY3VtZW50RGlyKSB7CiAgICBzZXREZXNjcmlwdGlvbihpZCwgIlNldHRpbmcgZG9j dW1lbnQuZGlyIHRvICciICsgdmFsRG9jdW1lbnREaXIgKyAiJyBhbmQgZG9jdW1lbnQuYm9keS5k aXIgdG8gJyIgKyB2YWxCb2R5RGlyICsgIiciKTsKICAgIHNldERvY3VtZW50RGlyKGlkLCB2YWxE b2N1bWVudERpcik7CiAgICBzZXRCb2R5RGlyKGlkLCB2YWxCb2R5RGlyKTsKfQoKZnVuY3Rpb24g dGVzdERvY3VtZW50RGlyKGlkLCB2YWwpIHsKICAgIHNldERlc2NyaXB0aW9uKGlkLCAiU2V0dGlu ZyBkb2N1bWVudC5kaXIgdG8gJyIgKyB2YWwgKyAiJyIpOwogICAgc2V0RG9jdW1lbnREaXIoaWQs IHZhbCk7Cn0KCmZ1bmN0aW9uIHRlc3REb25lKCkgewogICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cn0K PC9zY3JpcHQ+CjxzdHlsZT4KaWZyYW1lIHsKICAgIGJvcmRlcjogMXB4IHNvbGlkICMwMDAwMDA7 CiAgICBoZWlnaHQ6IDgwcHg7CiAgICB3aWR0aDogMTAwJTsKfQo8L3N0eWxlPgo8L2hlYWQ+Cjxi b2R5IG9ubG9hZD0ic2V0VGltZW91dCh0ZXN0RG9uZSwgNTAwMCk7Ij4KCjxpZnJhbWUgaWQ9ImRl ZmF1bHRWYWx1ZXMiCiAgICAgICAgc3JjPSJhdHRhY2htZW50LmNnaT9pZD05NDk3IgogICAgICAg IG9ubG9hZD0ic2V0RGVzY3JpcHRpb24oJ2RlZmF1bHRWYWx1ZXMnLCAnRGVmYXVsdCB2YWx1ZXMn KTsiPjwvaWZyYW1lPgoKPGRpdiBzdHlsZT0iaGVpZ2h0OiA1cHg7Ij48L2Rpdj4KCjxpZnJhbWUg aWQ9ImRvY0JsYW5rIgogICAgICAgIHNyYz0iYXR0YWNobWVudC5jZ2k/aWQ9OTQ5NyIKICAgICAg ICBvbmxvYWQ9InRlc3REb2N1bWVudERpcignZG9jQmxhbmsnLCAnJyk7Ij48L2lmcmFtZT4KPGlm cmFtZSBpZD0iZG9jTFRSIgogICAgICAgIHNyYz0iYXR0YWNobWVudC5jZ2k/aWQ9OTQ5NyIKICAg ICAgICBvbmxvYWQ9InRlc3REb2N1bWVudERpcignZG9jTFRSJywgJ2x0cicpOyI+PC9pZnJhbWU+ CjxpZnJhbWUgaWQ9ImRvY1JUTCIKICAgICAgICBzcmM9ImF0dGFjaG1lbnQuY2dpP2lkPTk0OTci CiAgICAgICAgb25sb2FkPSJ0ZXN0RG9jdW1lbnREaXIoJ2RvY1JUTCcsICdydGwnKTsiPjwvaWZy YW1lPgoKPGRpdiBzdHlsZT0iaGVpZ2h0OiA1cHg7Ij48L2Rpdj4KCjxpZnJhbWUgaWQ9ImJvZHlC bGFuayIKICAgICAgICBzcmM9ImF0dGFjaG1lbnQuY2dpP2lkPTk0OTciCiAgICAgICAgb25sb2Fk PSJ0ZXN0Qm9keURpcignYm9keUJsYW5rJywgJycpOyI+PC9pZnJhbWU+CjxpZnJhbWUgaWQ9ImJv ZHlMVFIiCiAgICAgICAgc3JjPSJhdHRhY2htZW50LmNnaT9pZD05NDk3IgogICAgICAgIG9ubG9h ZD0idGVzdEJvZHlEaXIoJ2JvZHlMVFInLCAnbHRyJyk7Ij48L2lmcmFtZT4KPGlmcmFtZSBpZD0i Ym9keVJUTCIKICAgICAgICBzcmM9ImF0dGFjaG1lbnQuY2dpP2lkPTk0OTciCiAgICAgICAgb25s b2FkPSJ0ZXN0Qm9keURpcignYm9keVJUTCcsICdydGwnKTsiPjwvaWZyYW1lPgoKPC9ib2R5Pgo8 L2h0bWw+Cg== 9499 2006-07-16 10:57:02 -0700 2006-07-17 09:59:05 -0700 Local test case (much faster; reload 30 times) bug-9959-test-case.zip application/zip 1258 ddkilzer UEsDBBQAAgAIAIxk8DTaDqM3aAIAAAgKAAAkABUAYm9keS1kaXItb3ZlcnJpZGVzLWRvY3VtZW50 LWRpci5odG1sVVQJAAMYebpEN3y6RFV4BAD1AfUBvZbBjtowEIbveQorVWWiQqCHlSo2IC2lUivR yzbtPRsbsNaxkeMEUNV37zhxliRNKC1ic4DYM/zzzYw9ItBbnfC5E2xpROArjRXb6bnD1miwZ4LI vc+jo8x0SFP9UQqtJOdUeQ6Cp8vi7yOmvwvN+FIKOvDuHWediVgzKVBK9UKS45KpASNDlEfcQz8L pTxS6Kk0oRkiMs4SKrS/ofoTp+Z1cfxC4EeeH0MkWC97XLBVwRDYCNulD7EyCtLw3TTEnMXPBvNX E7QK0ANLTuYrgWtKFXRt60/wurEXnpZ9hGUBT07rKomrkE9y2POZEFR9Dr+ugBKbw8DEZoowelcP 20TU4NVzEjro3W9UG9ETs2meT6D0WiLsQiQQgE8Xu7aCHSetl+BBkI5mW2PxXjP/E2aLsCZTwKJI kPM5WYh2ah24dcS+EthlRyXOHPb/SfQC3k4IMy9s2IvmT+8MIlmye0hDetDl5QjG1VwLUn3k1Mw3 FSXUBnuSilA1Re93B5RKzgh6MymeMoMtZZutnqIPk92h3NkzorfgP5m8tfKlajC2Y9Q0E0nBZURm LlQgZAkFzEGV5xDdgbx3784dJ7AsDFwJXUcZ1z/MpU/dlyRTFc9cRVOZqZimY6M+gpqPZE6VYnDN RlUrim17f30z2k8iNZx6R3EjJh4ivCw3UF7uGMpgXEIaXMJyVOQ7c6vK3EFhjBOY2gnJeMEj8Xyj XNqHF1fxTB4t8hbWKnx8RSiIZpC4VuepHsPVK1JBNEOlNL+uy4bs1m2uhhl+CfaXHhu/2za5gXRR h43jbVvcYDrT3yJUMbGK/3+/AVBLAwQUAAIACAAlY/A0lPml6dwAAAACAgAANgAVAHJlc291cmNl cy9ib2R5LWRpci1vdmVycmlkZXMtZG9jdW1lbnQtZGlyLWNvbnRlbnQuaHRtbFVUCQADdXa6RDd8 ukRVeAQA9QH1AX1RQW6DMBC8+xWWLwkXeACGQ9Ue8gzi3YZVHRuRdRRU9e81BgIHEl9s7ezOzI51 y1dbC91iA/G6mZ46rsV3cIbJOxk6aBiPmfwVMh7wJlzRcX5B/rI4Pj+GExwPZw/DJ/WHLL83NqCs 1tYRyoH68j3DArxgSQR/QheLRV3Mnkd+6Z31DVRq8VuqiADdJcUi4DQUF1K1LmJ5AmuxpY9qmlwX WPLQYaUYH6ym+dWakslZpVSUNJbMzwrPJNzSbfJfPuMrk59d5SWe1/Jztm+lNyy7+hv5YuxN+aWv /wdQSwECFwMUAAIACACMZPA02g6jN2gCAAAICgAAJAANAAAAAAABAAAApIEAAAAAYm9keS1kaXIt b3ZlcnJpZGVzLWRvY3VtZW50LWRpci5odG1sVVQFAAMYebpEVXgAAFBLAQIXAxQAAgAIACVj8DSU +aXp3AAAAAICAAA2AA0AAAAAAAEAAACkgb8CAAByZXNvdXJjZXMvYm9keS1kaXItb3ZlcnJpZGVz LWRvY3VtZW50LWRpci1jb250ZW50Lmh0bWxVVAUAA3V2ukRVeAAAUEsFBgAAAAACAAIA0AAAAAQE AAAAAA== 9505 2006-07-16 14:22:46 -0700 2006-07-17 09:59:05 -0700 Torture test (reload 3 times) bug-9959-torture-test.zip application/zip 1530 ddkilzer UEsDBBQAAgAIADSC8DQosH7PeAMAANFaAAAkABUAYm9keS1kaXItb3ZlcnJpZGVzLWRvY3VtZW50 LWRpci5odG1sVVQJAAPzrLpEMa26RFV4BAD1AfUB7Zxdb9owFIbv+RVWpimgtYFdVJpaqFTGpE3q blq2+zR2i1UTI8dA0bT/PjtxiKF8aXzdvFy0TZyc89jn2DxXbQ/0UNzW2gMWU/MrSxQf6dsafyb1 KU+pnEYinsmx7rNMf5WpVlIIpho1Yj6rRqJpzPWvVHPRkymrN25qtedxmmguU5Ix3ZV01uOqzukF mcSiQf7kkSaxIk/FEOkQKpPxkKU6emH6m2D2z+7sBzUvNaLEZDLXvTWPhC5KaBLbwO4yMrnGzIQ2 vxcHEsGTV4v5dxG0TLAGllbDewJ7kUpo79Z7cH9wLTwr6mguc3haXZeT2Au5Chc2Ip6mTH3v/7w3 lKFtBp6+XJOQfPLTLiJq89SaTlhBHzwybYNWzLZ4ETVLryUJA5PJBDA/gzBwK7ii094TbCjxThRb AFaF3whxl9IlaG8wv3bD+1B6IXNgEqd088K6pFvWt0TbNH3v1sqVsOeFm9pO58/aM4iOh6O7rM/e dLE52s3yXGtneiaYPd9UPGQu2ZNUlKlr8nn0RjIpOCUfWvmnmMyA8ZeBviZfWqO34s6UUz0wz7da H134Imq76Y5Ru45EpkLGtBOYxejzITOY9XKeF+TKhG/cBLe1WtuxcPMoZc/xWOjfdtNnwXySmUo6 gWKZHKuEZU0b/dJU6VJOmFLcbLPLsoL5bbd/I3u0V0E8HL9rwoWc4QUJe8UNMinuWMp2s4C0uJRP SD7fTlCuzJVZGPuQGVqekEy6Ik5fjzSX5W0clvnsPJbIl7Du+w8nhDLZLJLQajPVQ//+hFQmm6VS WuxXZUt27DKX5004T7alxva54xZ5AWmnCtsHj1viBaZD1bfcVd0T1Hn1F2L4DiGv/tZdPn/nZNt9 HbTrj51OgflLJzsO1lG7DjpUF5lFOG8P+QBlKXb5qjhnC1XpPeKtPeTeOlcHVek96EO0kIl43hby AcpJbW0h99K5WqhK7xHvIiPnbKEqvQd9sO8yGCmMFEYKI4WRwkhhpDBSGCmMFEYKI4WRwkhhpDBS GCmMFEYKI4WRwkhhpDBSGCmMFEYKI4WRwkhhpDBSGCmMFEYKI4WRwkhhpDBSGCmMFEYKI4WRwkhh pDBSGCmMFEYKI4WRwkhhpDBSGCmMFEYKI4WRwkhhpDBSGCmMFEYKI4WRwkhhpDBSGOl/GmlOkf/v 1fw/Wf8DUEsDBBQAAgAIACVj8DSU+aXp3AAAAAICAAA2ABUAcmVzb3VyY2VzL2JvZHktZGlyLW92 ZXJyaWRlcy1kb2N1bWVudC1kaXItY29udGVudC5odG1sVVQJAAN1drpEGa26RFV4BAD1AfUBfVFB boMwELz7FZYvCRd4AIZD1R7yDOLdhlUdG5F1FFT17zUGAgcSX2zt7M7MjnXLV1sL3WID8bqZnjqu xXdwhsk7GTpoGI+Z/BUyHvAmXNFxfkH+sjg+P4YTHA9nD8Mn9Ycsvzc2oKzW1hHKgfryPcMCvGBJ BH9CF4tFXcyeR37pnfUNVGrxW6qIAN0lxSLgNBQXUrUuYnkCa7Glj2qaXBdY8tBhpRgfrKb51ZqS yVmlVJQ0lszPCs8k3NJt8l8+4yuTn13lJZ7X8nO2b6U3LLv6G/li7E35pa//B1BLAQIXAxQAAgAI ADSC8DQosH7PeAMAANFaAAAkAA0AAAAAAAEAAACkgQAAAABib2R5LWRpci1vdmVycmlkZXMtZG9j dW1lbnQtZGlyLmh0bWxVVAUAA/OsukRVeAAAUEsBAhcDFAACAAgAJWPwNJT5pencAAAAAgIAADYA DQAAAAAAAQAAAKSBzwMAAHJlc291cmNlcy9ib2R5LWRpci1vdmVycmlkZXMtZG9jdW1lbnQtZGly LWNvbnRlbnQuaHRtbFVUBQADdXa6RFV4AABQSwUGAAAAAAIAAgDQAAAAFAUAAAAA 9523 2006-07-17 09:59:05 -0700 2006-07-17 09:59:05 -0700 reduced test case frames.html text/html 378 ap PGJvZHk+CjxwPkFsbCB0aGUgMTUwIElGUkFNRXMgYmVsb3cgc2hvdWxkIGJlIHN0aWxsIHByZXNl bnQgYWZ0ZXIgcmVsb2FkaW5nIHRoZSBwYWdlOjwvcD4KPHNjcmlwdD4KICBmb3IgKGkgPSAwOyBp IDwgMTUwOyBpKyspIHsKICAgIHZhciBhbklGcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImlmcmFtZSIpOwogICAgYW5JRnJhbWUuc2V0QXR0cmlidXRlKCJzcmMiLCAiZGF0YTp0ZXh0L3Bs YWluLCIgKyBpKTsKICAgIGFuSUZyYW1lLnN0eWxlLndpZHRoID0gMTAwKyJweCI7CiAgICBhbklG cmFtZS5zdHlsZS5oZWlnaHQgPSAxMDArInB4IjsKICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hp bGQoYW5JRnJhbWUpOwogIH0KPC9zY3JpcHQ+CjwvYm9keT4K 9534 2006-07-17 16:10:44 -0700 2006-07-17 16:52:58 -0700 Patch iframe-limit.txt text/plain 6238 andersca SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NDkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDctMTggIEFuZGVycyBDYXJsc3NvbiAg PGFjYXJsc3NvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD05OTU5CisgICAgICAgIFJFR1JFU1NJT046IGlmcmFtZXMgc3RvcCByZW5kZXJpbmcgYWZ0 ZXIgMjAwdGggb25lIG9uIHN1Y2Nlc3NpdmUgcmVsb2FkcworCisgICAgICAgICogZmFzdC9mcmFt ZXMvZnJhbWUtbGltaXQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2ZyYW1l cy9mcmFtZS1saW1pdC5odG1sOiBBZGRlZC4KKwogMjAwNi0wNy0xNyAgQW5kZXJzIENhcmxzc29u ICA8YWNhcmxzc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZyYW1lLWxpbWl0LWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS1saW1pdC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS1saW1pdC1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0cyB0aGF0 IGZyYW1lcyBhcmUgcHJvcGVybHkgZGVyZWdpc3RlcmVkIHdpdGggdGhlIHBhZ2UncyBjb3VudGVy IHdoZW4gcmVtb3ZlZC4gSWYgdGhpcyB0ZXN0IGlzIHN1Y2Nlc3NmdWwsIHRoZSB0ZXh0ICJTVUND RVNTIiB3aWxsIGJlIHNob3duIGJlbG93LgorU1VDQ0VTUworCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2ZyYW1lcy9mcmFtZS1saW1pdC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvZnJhbWVzL2ZyYW1lLWxpbWl0Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2ZyYW1lcy9mcmFtZS1saW1pdC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM5IEBA Cis8c2NyaXB0PgorCWZ1bmN0aW9uIGFkZEZyYW1lcygpIHsKKwkgIHZhciBwYXJlbnQgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdpZnJhbWUnKTsKKwkgIHBhcmVudC5pZCA9ICd0aGVmcmFtZSc7 CisJICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBhcmVudCk7CisJCisJICBmb3IgKGkgPSAw OyBpIDwgMTUwOyBpKyspIHsKKwkgICAgdmFyIGZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiaWZyYW1lIik7CisJICAgIGZyYW1lLnNldEF0dHJpYnV0ZSgic3JjIiwgImRhdGE6dGV4dC9w bGFpbiwiICsgaSk7CisJICAgIGZyYW1lLnN0eWxlLmRpc3BsYXkgPSAnbm9uZSc7CisJICAgIHBh cmVudC5jb250ZW50RG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChmcmFtZSk7CisJICB9CQkKKwl9 CisJCisJZnVuY3Rpb24gcnVuVGVzdCgpIHsKKwkJaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKwkJCWxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwkJCQorCQkvLyBB ZGQgMTUwIGZyYW1lcy4gCisJCWFkZEZyYW1lcygpOworCisJCS8vIFJlbW92ZSB0aGUgcGFyZW50 IGZyYW1lCisJCXZhciBwYXJlbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGhlZnJhbWUn KTsKKwkJcGFyZW50LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQocGFyZW50KTsKKworCQkvLyBBZGQg MTUwIGZyYW1lcyBhZ2Fpbi4KKwkJYWRkRnJhbWVzKCk7CisJCXZhciBwYXJlbnQgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgndGhlZnJhbWUnKTsKKworCQlpZiAocGFyZW50LmNvbnRlbnRXaW5k b3cuZnJhbWVzLmxlbmd0aCAhPSAxNTApCisJCQlyZXR1cm47CisJCQkKKwkJZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3Jlc3VsdCcpLmlubmVySFRNTCA9ICdTVUNDRVNTJzsKKwl9Cis8L3Njcmlw dD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxkaXY+VGhpcyB0ZXN0cyB0aGF0IGZyYW1l cyBhcmUgcHJvcGVybHkgZGVyZWdpc3RlcmVkIHdpdGggdGhlIHBhZ2UncyBjb3VudGVyIHdoZW4g cmVtb3ZlZC4gSWYgdGhpcyB0ZXN0IGlzIHN1Y2Nlc3NmdWwsIHRoZSB0ZXh0ICJTVUNDRVNTIiB3 aWxsIGJlIHNob3duIGJlbG93LjwvZGl2PgorPGRpdiBpZD0icmVzdWx0Ij5GQUlMVVJFPC9kaXY+ Cis8L2JvZHk+CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L0NoYW5nZUxvZwkocmV2aXNpb24gMTU0OTEpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDA2LTA3LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxh Y2FybHNzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTk1OQorICAgICAgICBSRUdSRVNTSU9OOiBpZnJhbWVzIHN0b3AgcmVuZGVyaW5nIGFmdGVy IDIwMHRoIG9uZSBvbiBzdWNjZXNzaXZlIHJlbG9hZHMKKyAgICAgICAgCisgICAgICAgICogaHRt bC9IVE1MRnJhbWVFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGcmFtZUVsZW1l bnQ6OmF0dGFjaCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRnJhbWVFbGVtZW50OjpjbG9zZSk6 CisgICAgICAgICogaHRtbC9IVE1MSUZyYW1lRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MSUZyYW1lRWxlbWVudDo6aW5zZXJ0ZWRJbnRvRG9jdW1lbnQpOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTElGcmFtZUVsZW1lbnQ6OndpbGxSZW1vdmUpOgorICAgICAgICBSZW1vdmUgY2Fs bHMgdG8gaW5jcmVtZW50RnJhbWVDb3VudCBhbmQgZGVjcmVtZW50RnJhbWVDb3VudC4KKyAgICAg ICAgCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6 RnJhbWUpOgorICAgICAgICBDYWxsIGluY3JlbWVudEZyYW1lQ291bnQgaGVyZS4KKyAgICAgICAg CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6fkZyYW1lKToKKyAgICAgICAgQ2FsbCBkaXNjb25u ZWN0T3duZXJFbGVtZW50LgorICAgICAgICAKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpkaXNj b25uZWN0T3duZXJFbGVtZW50KToKKyAgICAgICAgQ2FsbCBkZWNyZW1lbnRGcmFtZUNvdW50IGhl cmUuCisgICAgICAgIAogMjAwNi0wNy0xNyAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+ CiAKICAgICAgICAgQmFjayBvdXQgdGhlIGZpeCBmb3IgNTU2NCwgc2luY2UgaXQgdHVybnMgb3V0 IGZvbnQ6eC1zbWFsbDsgaXMgYSBwcmV0dHkKSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MRnJhbWVF bGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudC5j cHAJKHJldmlzaW9uIDE1NDkwKQorKysgV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yMTEsOCArMjExLDYgQEAgdm9pZCBIVE1MRnJhbWVFbGVtZW50 OjphdHRhY2goKQogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybjsKIAotICAgIGZyYW1l LT5wYWdlKCktPmluY3JlbWVudEZyYW1lQ291bnQoKTsKLSAgICAKICAgICBBdG9taWNTdHJpbmcg cmVsYXRpdmVVUkwgPSBtX1VSTDsKICAgICBpZiAocmVsYXRpdmVVUkwuaXNFbXB0eSgpKQogICAg ICAgICByZWxhdGl2ZVVSTCA9ICJhYm91dDpibGFuayI7CkBAIC0yMzEsNyArMjI5LDYgQEAgdm9p ZCBIVE1MRnJhbWVFbGVtZW50OjpjbG9zZSgpCiAgICAgRnJhbWUqIGZyYW1lID0gZG9jdW1lbnQo KS0+ZnJhbWUoKTsKICAgICBpZiAocmVuZGVyZXIoKSAmJiBmcmFtZSkgewogICAgICAgICBmcmFt ZS0+ZGlzY29ubmVjdE93bmVyRWxlbWVudCgpOwotICAgICAgICBmcmFtZS0+cGFnZSgpLT5kZWNy ZW1lbnRGcmFtZUNvdW50KCk7CiAgICAgICAgIGlmIChGcmFtZSogY2hpbGRGcmFtZSA9IGZyYW1l LT50cmVlKCktPmNoaWxkKG1fbmFtZSkpCiAgICAgICAgICAgICBjaGlsZEZyYW1lLT5mcmFtZURl dGFjaGVkKCk7CiAgICAgfQpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxJRnJhbWVFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTElGcmFtZUVsZW1lbnQuY3BwCShyZXZp c2lvbiAxNTQ5MCkKKysrIFdlYkNvcmUvaHRtbC9IVE1MSUZyYW1lRWxlbWVudC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTk5LDkgKzk5LDcgQEAgdm9pZCBIVE1MSUZyYW1lRWxlbWVudDo6aW5zZXJ0 ZWRJbnRvRG9jdQogICAgIGlmIChtX25hbWUuaXNOdWxsKCkpCiAgICAgICAgIG1fbmFtZSA9IGdl dEF0dHJpYnV0ZShpZEF0dHIpOwogICAgIAotICAgIEZyYW1lKiBwYXJlbnRGcmFtZSA9IGRvY3Vt ZW50KCktPmZyYW1lKCk7Ci0gICAgaWYgKHBhcmVudEZyYW1lKSB7Ci0gICAgICAgIHBhcmVudEZy YW1lLT5wYWdlKCktPmluY3JlbWVudEZyYW1lQ291bnQoKTsKKyAgICBpZiAoRnJhbWUqIHBhcmVu dEZyYW1lID0gZG9jdW1lbnQoKS0+ZnJhbWUoKSkgewogICAgICAgICBtX25hbWUgPSBwYXJlbnRG cmFtZS0+dHJlZSgpLT51bmlxdWVDaGlsZE5hbWUobV9uYW1lKTsKICAgICAgICAgCiAgICAgICAg IG9wZW5VUkwoKTsKQEAgLTExMiw3ICsxMTAsNiBAQCB2b2lkIEhUTUxJRnJhbWVFbGVtZW50Ojp3 aWxsUmVtb3ZlKCkKIHsKICAgICBpZiAoRnJhbWUqIGZyYW1lID0gY29udGVudEZyYW1lKCkpIHsK ICAgICAgICAgZnJhbWUtPmRpc2Nvbm5lY3RPd25lckVsZW1lbnQoKTsKLSAgICAgICAgZnJhbWUt PnBhZ2UoKS0+ZGVjcmVtZW50RnJhbWVDb3VudCgpOwogICAgICAgICBmcmFtZS0+ZnJhbWVEZXRh Y2hlZCgpOwogICAgICAgICBBU1NFUlQoIWNvbnRlbnRGcmFtZSgpKTsKICAgICB9CkluZGV4OiBX ZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9GcmFtZS5j cHAJKHJldmlzaW9uIDE1NDkwKQorKysgV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTYyLDYgKzE2Miw5IEBAIEZyYW1lOjpGcmFtZShQYWdlKiBwYWdlLCBFbGVtZW50 KiBvd25lckUKICAgICBYTUxOYW1lczo6aW5pdCgpOwogI2VuZGlmCiAKKyAgICBpZiAoZC0+bV9v d25lckVsZW1lbnQpCisgICAgICAgIGQtPm1fcGFnZS0+aW5jcmVtZW50RnJhbWVDb3VudCgpOwor CiAgICAgLy8gRklYTUU6IEZyYW1lcyB3ZXJlIG9yaWdpbmFsbHkgY3JlYXRlZCB3aXRoIGEgcmVm Y291bnQgb2YgMSwgbGVhdmUgdGhpcwogICAgIC8vIHJlZiBjYWxsIGhlcmUgdW50aWwgd2UgY2Fu IHN0cmFpZ2h0ZW4gdGhhdCBvdXQuCiAgICAgcmVmKCk7CkBAIC0xOTQsNiArMTk3LDggQEAgRnJh bWU6On5GcmFtZSgpCiAgICAgICAgICAgICB3ID0gMDsKICAgICAgICAgfQogCisgICAgZGlzY29u bmVjdE93bmVyRWxlbWVudCgpOworICAgIAogICAgIGlmIChkLT5tX2RvbVdpbmRvdykKICAgICAg ICAgZC0+bV9kb21XaW5kb3ctPmRpc2Nvbm5lY3RGcmFtZSgpOwogICAgICAgICAgICAgCkBAIC0z NTgzLDYgKzM1ODgsOSBAQCB2b2lkIEZyYW1lOjpzdGFydGVkKCkKIAogdm9pZCBGcmFtZTo6ZGlz Y29ubmVjdE93bmVyRWxlbWVudCgpCiB7CisgICAgaWYgKGQtPm1fb3duZXJFbGVtZW50KQorICAg ICAgICBkLT5tX3BhZ2UtPmRlY3JlbWVudEZyYW1lQ291bnQoKTsKKyAgICAgICAgCiAgICAgZC0+ bV9vd25lckVsZW1lbnQgPSAwOwogfQogCg==