99583 2012-10-17 04:33:18 -0700 Add PluginProcessProxy::platformInitializeLaunchOptions() 2012-10-18 01:51:28 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99297 1 jussi.kukkonen jussi.kukkonen abecsi ap cmarcelo menard sam webkit.review.bot oldest_to_newest 744139 0 jussi.kukkonen 2012-10-17 04:33:18 -0700 On Sam Weinigs suggestion in bug 99297 comment 3: I'd like to add PluginProcessProxy::platformInitializeLaunchOptions() So the PluginProcessProxy constructor was less of a collection of #ifdefs. 744198 1 169168 jussi.kukkonen 2012-10-17 06:01:11 -0700 Created attachment 169168 Patch 745085 2 169168 webkit.review.bot 2012-10-18 01:51:24 -0700 Comment on attachment 169168 Patch Clearing flags on attachment: 169168 Committed r131717: <http://trac.webkit.org/changeset/131717> 745086 3 webkit.review.bot 2012-10-18 01:51:28 -0700 All reviewed patches have been landed. Closing bug. 169168 2012-10-17 06:01:11 -0700 2012-10-18 01:51:24 -0700 Patch bug-99583-20121017155957.patch text/plain 5543 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTAzNDgzMTQyODQwNDcz ZDAwOTFkMWE5MDk5M2QwMWYxM2JjODZlMi4uNGE1OGQ0MTBlOWJkZTFmZjExODc4NjNmN2QzZjBl YjFmMzE2NGRjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTEwLTE3ICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBBZGQgUGx1 Z2luUHJvY2Vzc1Byb3h5OjpwbGF0Zm9ybUluaXRpYWxpemVMYXVuY2hPcHRpb25zCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTU4MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHBsYXRmb3JtIHNw ZWNpZmljIGxhdW5jaCBvcHRpb25zIGluaXRpYWxpemVyLiBUaGlzIGVuYWJsZXMKKyAgICAgICAg Zml4aW5nIGJ1ZyA5OTI5NyAiW0VGTF0gTWFrZSBwbHVnaW4gcHJvY2VzcyBkZWJ1Z2dpbmcgZWFz aWVyCisgICAgICAgIChQTFVHSU5fUFJPQ0VTU19DT01NQU5EX1BSRUZJWCkiLgorCisgICAgICAg ICogVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdl YktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpQbHVnaW5Qcm9jZXNzUHJveHkpOgorICAgICAgICAq IFVJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NQcm94eS5oOgorICAgICAgICAoUGx1Z2lu UHJvY2Vzc1Byb3h5KToKKyAgICAgICAgKiBVSVByb2Nlc3MvUGx1Z2lucy9tYWMvUGx1Z2luUHJv Y2Vzc1Byb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzUHJveHk6OnBs YXRmb3JtSW5pdGlhbGl6ZUxhdW5jaE9wdGlvbnMpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAg ICAgKiBVSVByb2Nlc3MvUGx1Z2lucy9xdC9QbHVnaW5Qcm9jZXNzUHJveHlRdC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplTGF1bmNo T3B0aW9ucyk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5z L3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdp blByb2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplTGF1bmNoT3B0aW9ucyk6CisgICAgICAg IChXZWJLaXQpOgorCiAyMDEyLTEwLTE3ICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293 c2tpQHNhbXN1bmcuY29tPiwgTWljaGFsIFJvaiA8bS5yb2pAc2Ftc3VuZy5jb20+CiAKICAgICAg ICAgSW1wbGVtZW50YXRpb24gb2Ygc3BlbGxjaGVja2luZyBmZWF0dXJlLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NQcm94eS5jcHAK aW5kZXggNzc5NmNmZTk3YTU1MjRlZDBiOThiNzU3YWE0M2NlZmQ1NjU3ZGEyNi4uMTBmNThiOWJi MzI1MjQzZjM4NjA5NDQ5MTk5MzAwZGZhNmVkZjYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuY3BwCkBAIC02Nywx MyArNjcsOCBAQCBQbHVnaW5Qcm9jZXNzUHJveHk6OlBsdWdpblByb2Nlc3NQcm94eShQbHVnaW5Q cm9jZXNzTWFuYWdlciogUGx1Z2luUHJvY2Vzc01hbmFnZQogewogICAgIFByb2Nlc3NMYXVuY2hl cjo6TGF1bmNoT3B0aW9ucyBsYXVuY2hPcHRpb25zOwogICAgIGxhdW5jaE9wdGlvbnMucHJvY2Vz c1R5cGUgPSBQcm9jZXNzTGF1bmNoZXI6OlBsdWdpblByb2Nlc3M7Ci0jaWYgUExBVEZPUk0oTUFD KQotICAgIGxhdW5jaE9wdGlvbnMuYXJjaGl0ZWN0dXJlID0gcGx1Z2luSW5mby5wbHVnaW5BcmNo aXRlY3R1cmU7Ci0gICAgbGF1bmNoT3B0aW9ucy5leGVjdXRhYmxlSGVhcCA9IFBsdWdpblByb2Nl c3NQcm94eTo6cGx1Z2luTmVlZHNFeGVjdXRhYmxlSGVhcChwbHVnaW5JbmZvKTsKLSNpZiBIQVZF KFhQQykKLSAgICBsYXVuY2hPcHRpb25zLnVzZVhQQyA9IGZhbHNlOwotI2VuZGlmCi0jZW5kaWYK KworICAgIHBsYXRmb3JtSW5pdGlhbGl6ZUxhdW5jaE9wdGlvbnMobGF1bmNoT3B0aW9ucywgcGx1 Z2luSW5mbyk7CiAKICAgICBtX3Byb2Nlc3NMYXVuY2hlciA9IFByb2Nlc3NMYXVuY2hlcjo6Y3Jl YXRlKHRoaXMsIGxhdW5jaE9wdGlvbnMpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuaAppbmRleCA0YjUwZTZiODAwNmJk OWIyYmU0OGFmZDdhYjFlODZmY2E2YTdhZWJjLi4xMzJiYjc0YmZkNWRjYTFiOWY0NzdmOTY1ODVl NjM1NzNmZGEzZGI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lu cy9QbHVnaW5Qcm9jZXNzUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1 Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuaApAQCAtMTI3LDYgKzEyNyw3IEBAIHByaXZhdGU6CiAg ICAgdm9pZCBhcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSgpOwogI2VuZGlmCiAKKyAgICBzdGF0 aWMgdm9pZCBwbGF0Zm9ybUluaXRpYWxpemVMYXVuY2hPcHRpb25zKFByb2Nlc3NMYXVuY2hlcjo6 TGF1bmNoT3B0aW9ucyYsIGNvbnN0IFBsdWdpbk1vZHVsZUluZm8mIHBsdWdpbkluZm8pOwogICAg IHZvaWQgcGxhdGZvcm1Jbml0aWFsaXplUGx1Z2luUHJvY2VzcyhQbHVnaW5Qcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKTsKIAogICAgIC8vIFRoZSBwbHVnLWluIGhvc3QgcHJv Y2VzcyBtYW5hZ2VyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdp bnMvbWFjL1BsdWdpblByb2Nlc3NQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QbHVnaW5zL21hYy9QbHVnaW5Qcm9jZXNzUHJveHlNYWMubW0KaW5kZXggMjE1MGMwNmYyNmFm N2ExYzU0ODgzODZmZjM0NWY1MGQwNzBlNDI0Yy4uMjA3ZWNhMmM5N2QzZjI0YmQ1YmYzNDM2OTli Y2Q1MzhhYjQ1ZjQwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdp bnMvbWFjL1BsdWdpblByb2Nlc3NQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvUGx1Z2lucy9tYWMvUGx1Z2luUHJvY2Vzc1Byb3h5TWFjLm1tCkBAIC0xMTgsNiArMTE4 LDE1IEBAIGJvb2wgUGx1Z2luUHJvY2Vzc1Byb3h5OjpjcmVhdGVQcm9wZXJ0eUxpc3RGaWxlKGNv bnN0IFBsdWdpbk1vZHVsZUluZm8mIHBsdWdpbikKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAordm9p ZCBQbHVnaW5Qcm9jZXNzUHJveHk6OnBsYXRmb3JtSW5pdGlhbGl6ZUxhdW5jaE9wdGlvbnMoUHJv Y2Vzc0xhdW5jaGVyOjpMYXVuY2hPcHRpb25zJiBsYXVuY2hPcHRpb25zLCBjb25zdCBQbHVnaW5N b2R1bGVJbmZvJiBwbHVnaW5JbmZvKQoreworICAgIGxhdW5jaE9wdGlvbnMuYXJjaGl0ZWN0dXJl ID0gcGx1Z2luSW5mby5wbHVnaW5BcmNoaXRlY3R1cmU7CisgICAgbGF1bmNoT3B0aW9ucy5leGVj dXRhYmxlSGVhcCA9IFBsdWdpblByb2Nlc3NQcm94eTo6cGx1Z2luTmVlZHNFeGVjdXRhYmxlSGVh cChwbHVnaW5JbmZvKTsKKyNpZiBIQVZFKFhQQykKKyAgICBsYXVuY2hPcHRpb25zLnVzZVhQQyA9 IGZhbHNlOworI2VuZGlmCit9CisKIHZvaWQgUGx1Z2luUHJvY2Vzc1Byb3h5OjpwbGF0Zm9ybUlu aXRpYWxpemVQbHVnaW5Qcm9jZXNzKFBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmIHBh cmFtZXRlcnMpCiB7CiAgICAgLy8gRm9yIGtub3cgb25seSBGbGFzaCBpcyBrbm93biB0byBiZWhh dmUgd2l0aCBhc3luY2hyb25vdXMgcGx1Zy1pbiBpbml0aWFsaXphdGlvbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3F0L1BsdWdpblByb2Nlc3NQcm94eVF0 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3F0L1BsdWdpblByb2Nlc3NQ cm94eVF0LmNwcAppbmRleCBiMGE1YjIzMGQzNmU2N2MyMjhkMjlhNWQ5Y2M2ODQ0MzY5Mjg4YWUx Li42NzljNjMzMWRjYjk5MTY4MDhlYjk4M2ViMWViY2ExYTFmZTcwY2IwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9xdC9QbHVnaW5Qcm9jZXNzUHJveHlRdC5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvcXQvUGx1Z2luUHJvY2Vz c1Byb3h5UXQuY3BwCkBAIC01MSw2ICs1MSwxMCBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogY2xh c3MgUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczsKIAordm9pZCBQbHVnaW5Qcm9jZXNz UHJveHk6OnBsYXRmb3JtSW5pdGlhbGl6ZUxhdW5jaE9wdGlvbnMoUHJvY2Vzc0xhdW5jaGVyOjpM YXVuY2hPcHRpb25zJiBsYXVuY2hPcHRpb25zLCBjb25zdCBQbHVnaW5Nb2R1bGVJbmZvJiBwbHVn aW5JbmZvKQoreworfQorCiB2b2lkIFBsdWdpblByb2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFs aXplUGx1Z2luUHJvY2VzcyhQbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJikKIHsKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2lu UHJvY2Vzc1Byb3h5VW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91 bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCmluZGV4IDNmZWJiMDY5YWMzNzA3Yjg5ZDAx ZTBlZmQyMjRmM2QyNjQ3MmU1MDguLmM3YTg5MjJlMTJlMDRlMzcyMTUzY2E4NWZhNzE3MmM2MjVm YjdhMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgv UGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcApAQCAtNDMsNiArNDMsMTAg QEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCit2b2lk IFBsdWdpblByb2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplTGF1bmNoT3B0aW9ucyhQcm9j ZXNzTGF1bmNoZXI6OkxhdW5jaE9wdGlvbnMmIGxhdW5jaE9wdGlvbnMsIGNvbnN0IFBsdWdpbk1v ZHVsZUluZm8mIHBsdWdpbkluZm8pCit7Cit9CisKIHZvaWQgUGx1Z2luUHJvY2Vzc1Byb3h5Ojpw bGF0Zm9ybUluaXRpYWxpemVQbHVnaW5Qcm9jZXNzKFBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFt ZXRlcnMmKQogewogfQo=