99566 2012-10-17 01:52:33 -0700 Assertion failed on HTMLFormControlElement.cpp: updateFromElementCallback() 2012-10-17 02:58:04 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99510 1 morrita morrita tkent webkit.review.bot oldest_to_newest 744023 0 morrita 2012-10-17 01:52:33 -0700 Reproduction and fix will come shortly. 744037 1 169131 morrita 2012-10-17 02:11:08 -0700 Created attachment 169131 Patch 744038 2 morrita 2012-10-17 02:12:29 -0700 Kent-san, could this be worth a rubberstamp? I have another bug fix which is blocked by this. 744043 3 169131 tkent 2012-10-17 02:16:07 -0700 Comment on attachment 169131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169131&action=review The code change is ok. > LayoutTests/ChangeLog:9 > + * fast/forms/textarea/remove-while-focusing.html: Added. Would you name this test "textarea-autofocus-removal-while-focusing.html" please? 744048 4 169135 morrita 2012-10-17 02:25:36 -0700 Created attachment 169135 Patch 744050 5 169135 morrita 2012-10-17 02:26:07 -0700 Comment on attachment 169135 Patch Sure. Renamed the test. 744055 6 169135 tkent 2012-10-17 02:31:36 -0700 Comment on attachment 169135 Patch Thanks 744078 7 169135 webkit.review.bot 2012-10-17 02:58:01 -0700 Comment on attachment 169135 Patch Clearing flags on attachment: 169135 Committed r131572: <http://trac.webkit.org/changeset/131572> 744079 8 webkit.review.bot 2012-10-17 02:58:04 -0700 All reviewed patches have been landed. Closing bug. 169131 2012-10-17 02:11:08 -0700 2012-10-17 02:25:33 -0700 Patch bug-99566-20121017180956.patch text/plain 3446 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ3OTlkMDIxYWI4NTc1 YjVkZTU1ZTIyMGU0MzA2Y2Q5NDU1NmM3Mi4uYjMwYzgwMGUyYWUxMGVlMzg1ZTFjODY1MjU0N2Q0 ZTJkNTFlYzJkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE3ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBmYWls ZWQgb24gSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHA6IHVwZGF0ZUZyb21FbGVtZW50Q2FsbGJh Y2soKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk1 NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBo YWQgYSB0b28gb3B0aW1pc3RpYyBhc3NlcnRpb24uIFRoaXMgY2hhbmdlIHJlbW92ZXMgaXQuCisK KyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy90ZXh0YXJlYS9yZW1vdmUtd2hpbGUtZm9jdXNpbmcu aHRtbAorCisgICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OnVwZGF0ZUZyb21FbGVtZW50Q2FsbGJhY2spOgorCiAyMDEyLTEwLTE3ICBT aGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUg c2hhZG93QW5jZXN0b3JOb2RlKCkgZnJvbSBWaXNpYmxlU2VsZWN0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCBkYjM2OGM0ODU1MmZm MjM5MjA2ZjU2MjFkYWZjZmMzMTU2ZWM0MThkLi40MzdiZTA1MWExYWE1NjYxYzAzYWQ4MTA4MjMx ZGI5Y2M3OGExMjQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29u dHJvbEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9s RWxlbWVudC5jcHAKQEAgLTI5Nyw3ICsyOTcsNiBAQCBzdGF0aWMgdm9pZCB1cGRhdGVGcm9tRWxl bWVudENhbGxiYWNrKE5vZGUqIG5vZGUsIHVuc2lnbmVkKQogewogICAgIEFTU0VSVF9BUkcobm9k ZSwgbm9kZS0+aXNFbGVtZW50Tm9kZSgpKTsKICAgICBBU1NFUlRfQVJHKG5vZGUsIHN0YXRpY19j YXN0PEVsZW1lbnQqPihub2RlKS0+aXNGb3JtQ29udHJvbEVsZW1lbnQoKSk7Ci0gICAgQVNTRVJU KG5vZGUtPnJlbmRlcmVyKCkpOwogICAgIGlmIChSZW5kZXJPYmplY3QqIHJlbmRlcmVyID0gbm9k ZS0+cmVuZGVyZXIoKSkKICAgICAgICAgcmVuZGVyZXItPnVwZGF0ZUZyb21FbGVtZW50KCk7CiB9 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZThiOTk4MmIzY2I3NGVmNTdiOGViZDA0MTY4ZDk0OTcxMDVlN2Q2Mi4uMDgyNjRh NDUyNjY0MTAxZGFhYjBkZjQ2YzQ2ZTM3MGVhZjNjMWQxNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTEwLTE3ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAg ICAgIEFzc2VydGlvbiBmYWlsZWQgb24gSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHA6IHVwZGF0 ZUZyb21FbGVtZW50Q2FsbGJhY2soKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTk1NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZhc3QvZm9ybXMvdGV4dGFyZWEvcmVtb3ZlLXdoaWxlLWZvY3VzaW5n LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy90ZXh0YXJlYS9yZW1v dmUtd2hpbGUtZm9jdXNpbmcuaHRtbDogQWRkZWQuCisKIDIwMTItMTAtMTcgIERvdWdsYXMgU3Rv Y2t3ZWxsICA8ZHN0b2Nrd2VsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ29udGVudCBvZiBy ZXBsYWNlZCBlbGVtZW50cyBzaG91bGQgYmUgdHJpbW1lZCB0byB0aGUgY29udGVudCBlZGdlIGN1 cnZlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS9yZW1vdmUt d2hpbGUtZm9jdXNpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0 YXJlYS9yZW1vdmUtd2hpbGUtZm9jdXNpbmctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQ2Y2M4 NTBjMWNmMTFkZjk5OGJiZTJkNThlMmQwNjk5ODE2MWZmZDUKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhL3JlbW92ZS13aGlsZS1mb2N1c2luZy1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUyB1bmxlc3MgY3Jhc2guCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhL3JlbW92ZS13aGlsZS1mb2N1c2luZy5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS9yZW1vdmUtd2hpbGUtZm9jdXNpbmcu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5jNTk1YTkyNDNlMzg3MDhiOWVjMzZhOWQ3NzMwY2NiMTA4OTRlODZj Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS9yZW1v dmUtd2hpbGUtZm9jdXNpbmcuaHRtbApAQCAtMCwwICsxLDE3IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGJvZHk+Cis8c2NyaXB0PgordGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cit0ZXN0 UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK3ZhciB0ZXh0YXJlYSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoInRleHRhcmVhIik7Cit0ZXh0YXJlYS5zZXRBdHRyaWJ1dGUoImF1dG9mb2N1cyIsICIi KTsKK3RleHRhcmVhLmFkZEV2ZW50TGlzdGVuZXIoIkRPTUZvY3VzSW4iLCBmdW5jdGlvbiAoKSB7 IGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5pbm5lckhUTUwgPSAiIjsgfSwgZmFsc2UpOworZG9j dW1lbnQuZG9jdW1lbnRFbGVtZW50LmFwcGVuZENoaWxkKHRleHRhcmVhKTsKK3dpbmRvdy5zZXRU aW1lb3V0KGZ1bmN0aW9uKCkgeworICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gIlBBU1Mg dW5sZXNzIGNyYXNoLiI7CisgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9LCAwKTsKKzwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo= 169135 2012-10-17 02:25:36 -0700 2012-10-17 02:58:01 -0700 Patch bug-99566-20121017182424.patch text/plain 3617 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ3OTlkMDIxYWI4NTc1 YjVkZTU1ZTIyMGU0MzA2Y2Q5NDU1NmM3Mi4uNzM4YzZkNWY4YWNmNzc4OWE4YTliMGIwZTgzYzU2 MjY2NmNjN2I3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE3ICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIEFzc2VydGlvbiBmYWls ZWQgb24gSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHA6IHVwZGF0ZUZyb21FbGVtZW50Q2FsbGJh Y2soKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk1 NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBo YWQgYSB0b28gb3B0aW1pc3RpYyBhc3NlcnRpb24uIFRoaXMgY2hhbmdlIHJlbW92ZXMgaXQuCisK KyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy90ZXh0YXJlYS90ZXh0YXJlYS1hdXRvZm9jdXMtcmVt b3ZhbC13aGlsZS1mb2N1c2luZy5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dXBkYXRlRnJvbUVsZW1lbnRDYWxsYmFj ayk6CisKIDIwMTItMTAtMTcgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJlbW92ZSBzaGFkb3dBbmNlc3Rvck5vZGUoKSBmcm9tIFZpc2libGVTZWxl Y3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxl bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3Bw CmluZGV4IGRiMzY4YzQ4NTUyZmYyMzkyMDZmNTYyMWRhZmNmYzMxNTZlYzQxOGQuLjQzN2JlMDUx YTFhYTU2NjFjMDNhZDgxMDgyMzFkYjljYzc4YTEyNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcApAQCAtMjk3LDcgKzI5Nyw2IEBAIHN0YXRp YyB2b2lkIHVwZGF0ZUZyb21FbGVtZW50Q2FsbGJhY2soTm9kZSogbm9kZSwgdW5zaWduZWQpCiB7 CiAgICAgQVNTRVJUX0FSRyhub2RlLCBub2RlLT5pc0VsZW1lbnROb2RlKCkpOwogICAgIEFTU0VS VF9BUkcobm9kZSwgc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpLT5pc0Zvcm1Db250cm9sRWxl bWVudCgpKTsKLSAgICBBU1NFUlQobm9kZS0+cmVuZGVyZXIoKSk7CiAgICAgaWYgKFJlbmRlck9i amVjdCogcmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigpKQogICAgICAgICByZW5kZXJlci0+dXBk YXRlRnJvbUVsZW1lbnQoKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlOGI5OTgyYjNjYjc0ZWY1N2I4ZWJkMDQxNjhk OTQ5NzEwNWU3ZDYyLi5jMWI4N2Y1NDQ2M2E3MjhiMmU4ZjBjNWY3NDA2NmVkOGUzOGVkNjk4IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTAtMTcgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRh QGdvb2dsZS5jb20+CisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWxlZCBvbiBIVE1MRm9ybUNvbnRy b2xFbGVtZW50LmNwcDogdXBkYXRlRnJvbUVsZW1lbnRDYWxsYmFjaygpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTU2NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9mb3Jtcy90ZXh0YXJlYS90 ZXh0YXJlYS1hdXRvZm9jdXMtcmVtb3ZhbC13aGlsZS1mb2N1c2luZy50eHQ6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvZm9ybXMvdGV4dGFyZWEvdGV4dGFyZWEtYXV0b2ZvY3VzLXJlbW92YWwtd2hp bGUtZm9jdXNpbmcuaHRtbDogQWRkZWQuCisKIDIwMTItMTAtMTcgIERvdWdsYXMgU3RvY2t3ZWxs ICA8ZHN0b2Nrd2VsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ29udGVudCBvZiByZXBsYWNl ZCBlbGVtZW50cyBzaG91bGQgYmUgdHJpbW1lZCB0byB0aGUgY29udGVudCBlZGdlIGN1cnZlLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90ZXh0YXJlYS90ZXh0YXJlYS1hdXRv Zm9jdXMtcmVtb3ZhbC13aGlsZS1mb2N1c2luZy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL3RleHRhcmVhL3RleHRhcmVhLWF1dG9mb2N1cy1yZW1vdmFsLXdoaWxlLWZvY3Vz aW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40NmNjODUwYzFjZjExZGY5OThiYmUyZDU4ZTJk MDY5OTgxNjFmZmQ1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90 ZXh0YXJlYS90ZXh0YXJlYS1hdXRvZm9jdXMtcmVtb3ZhbC13aGlsZS1mb2N1c2luZy1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUyB1bmxlc3MgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhL3RleHRhcmVhLWF1dG9mb2N1cy1yZW1vdmFsLXdo aWxlLWZvY3VzaW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RleHRhcmVhL3RleHRh cmVhLWF1dG9mb2N1cy1yZW1vdmFsLXdoaWxlLWZvY3VzaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzU5 NWE5MjQzZTM4NzA4YjllYzM2YTlkNzczMGNjYjEwODk0ZTg2YwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGV4dGFyZWEvdGV4dGFyZWEtYXV0b2ZvY3VzLXJlbW92 YWwtd2hpbGUtZm9jdXNpbmcuaHRtbApAQCAtMCwwICsxLDE3IEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGJvZHk+Cis8c2NyaXB0PgordGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cit0ZXN0 UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK3ZhciB0ZXh0YXJlYSA9IGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoInRleHRhcmVhIik7Cit0ZXh0YXJlYS5zZXRBdHRyaWJ1dGUoImF1dG9mb2N1cyIsICIi KTsKK3RleHRhcmVhLmFkZEV2ZW50TGlzdGVuZXIoIkRPTUZvY3VzSW4iLCBmdW5jdGlvbiAoKSB7 IGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5pbm5lckhUTUwgPSAiIjsgfSwgZmFsc2UpOworZG9j dW1lbnQuZG9jdW1lbnRFbGVtZW50LmFwcGVuZENoaWxkKHRleHRhcmVhKTsKK3dpbmRvdy5zZXRU aW1lb3V0KGZ1bmN0aW9uKCkgeworICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gIlBBU1Mg dW5sZXNzIGNyYXNoLiI7CisgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9LCAwKTsKKzwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=