99564 2012-10-17 01:28:02 -0700 [WK2][GTK] Unneeded GError field in internal structure in WebKitFaviconDatabase.cpp 2012-10-17 02:27:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 744000 0 mario 2012-10-17 01:28:02 -0700 The field 'error' in GetFaviconSurfaceAsyncData is not needed and we should remove it and update the code accordingly 744006 1 169121 mario 2012-10-17 01:33:33 -0700 Created attachment 169121 Patch proposal The patch 744008 2 webkit.review.bot 2012-10-17 01:35:38 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 744052 3 mario 2012-10-17 02:27:49 -0700 Committed r131569: <http://trac.webkit.org/changeset/131569> 169121 2012-10-17 01:33:33 -0700 2012-10-17 02:11:46 -0700 Patch proposal 0001-2012-10-17-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3802 mario RnJvbSA4MTI4MTk3YjMxMjJiM2JkYmMwNWJlNzM0NzQ2OGNiYzg2ODQzZTU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBXZWQsIDE3IE9jdCAyMDEyIDEwOjI4OjI2ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0xMC0xNyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtXSzJdW0dUS10gVW5uZWVkZWQgR0Vycm9yIGZpZWxkIGluIGludGVybmFsIHN0 cnVjdHVyZSBpbiBXZWJLaXRGYXZpY29uRGF0YWJhc2UuY3BwCiAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NTY0CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBSZW1vdmVkIGZpZWxkICdlcnJvcicgZnJvbSBHZXRGYXZp Y29uU3VyZmFjZUFzeW5jRGF0YSBhbmQgdXBkYXRlZAogICAgICAgIHRoZSBjb2RlIGFjY29yZGlu Z2x5LCBieSB1c2luZyBnX3NpbXBsZV9hc3luY19yZXN1bHRfdGFrZV9lcnJvcigpLgoKICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEZhdmljb25EYXRhYmFzZS5jcHA6CiAgICAgICAg KEdldEZhdmljb25TdXJmYWNlQXN5bmNEYXRhKTogUmVtb3ZlZCB1bm5lZWRlZCBmaWVsZC4KICAg ICAgICAocHJvY2Vzc1BlbmRpbmdJY29uc0ZvclBhZ2VVUkwpOiBBdm9pZCB1c2luZyBnX3Byb3Bh Z2F0ZV9lcnJvciBhbmQKICAgICAgICB1c2UgZ19zaW1wbGVfYXN5bmNfcmVzdWx0X3Rha2VfZXJy b3IgZGlyZWN0bHkgaW5zdGVhZC4KICAgICAgICAod2Via2l0X2Zhdmljb25fZGF0YWJhc2VfZ2V0 X2Zhdmljb25fZmluaXNoKTogUmVtb3ZlIHVubmVlZGVkIGNvZGUuCi0tLQogU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxNiArKysrKysr KysrKysrKysrCiAuLi4vV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRGYXZpY29uRGF0 YWJhc2UuY3BwICB8ICA4ICstLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMo KyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGE3NDA1NDMuLjRmOWZhOTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMi0xMC0xNyAgTWFyaW8gU2FuY2hleiBQcmFkYSAg PG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKKyAgICAgICAgW1dLMl1bR1RLXSBVbm5lZWRlZCBHRXJy b3IgZmllbGQgaW4gaW50ZXJuYWwgc3RydWN0dXJlIGluIFdlYktpdEZhdmljb25EYXRhYmFzZS5j cHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NTY0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zl ZCBmaWVsZCAnZXJyb3InIGZyb20gR2V0RmF2aWNvblN1cmZhY2VBc3luY0RhdGEgYW5kIHVwZGF0 ZWQKKyAgICAgICAgdGhlIGNvZGUgYWNjb3JkaW5nbHksIGJ5IHVzaW5nIGdfc2ltcGxlX2FzeW5j X3Jlc3VsdF90YWtlX2Vycm9yKCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRGYXZpY29uRGF0YWJhc2UuY3BwOgorICAgICAgICAoR2V0RmF2aWNvblN1cmZhY2VBc3luY0Rh dGEpOiBSZW1vdmVkIHVubmVlZGVkIGZpZWxkLgorICAgICAgICAocHJvY2Vzc1BlbmRpbmdJY29u c0ZvclBhZ2VVUkwpOiBBdm9pZCB1c2luZyBnX3Byb3BhZ2F0ZV9lcnJvciBhbmQKKyAgICAgICAg dXNlIGdfc2ltcGxlX2FzeW5jX3Jlc3VsdF90YWtlX2Vycm9yIGRpcmVjdGx5IGluc3RlYWQuCisg ICAgICAgICh3ZWJraXRfZmF2aWNvbl9kYXRhYmFzZV9nZXRfZmF2aWNvbl9maW5pc2gpOiBSZW1v dmUgdW5uZWVkZWQgY29kZS4KKworMjAxMi0xMC0xNyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1z YW5jaGV6QGlnYWxpYS5jb20+CisKICAgICAgICAgW1dLMl1bR1RLXSBGYXZpY29ucyBhcmUgaW5j b3JyZWN0bHkgcmVsZWFzZWQgYmVmb3JlIHJlY2VpdmluZyB0aGUgYWN0dWFsIGRhdGEKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NDkyCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEZhdmljb25EYXRh YmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRGYXZpY29u RGF0YWJhc2UuY3BwCmluZGV4IDZiYmQ1YzAuLjhmNjcxYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEZhdmljb25EYXRhYmFzZS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNw cApAQCAtMTE1LDcgKzExNSw2IEBAIHN0cnVjdCBHZXRGYXZpY29uU3VyZmFjZUFzeW5jRGF0YSB7 CiAgICAgR1JlZlB0cjxXZWJLaXRGYXZpY29uRGF0YWJhc2U+IGZhdmljb25EYXRhYmFzZTsKICAg ICBTdHJpbmcgcGFnZVVSTDsKICAgICBSZWZQdHI8Y2Fpcm9fc3VyZmFjZV90PiBpY29uOwotICAg IEdPd25QdHI8R0Vycm9yPiBlcnJvcjsKICAgICBHUmVmUHRyPEdDYW5jZWxsYWJsZT4gY2FuY2Vs bGFibGU7CiB9OwogV0VCS0lUX0RFRklORV9BU1lOQ19EQVRBX1NUUlVDVChHZXRGYXZpY29uU3Vy ZmFjZUFzeW5jRGF0YSkKQEAgLTE4MSw3ICsxODAsNyBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzUGVu ZGluZ0ljb25zRm9yUGFnZVVSTChXZWJLaXRGYXZpY29uRGF0YWJhc2UqIGRhdGFiYXNlLCBjb25z dAogICAgICAgICBHZXRGYXZpY29uU3VyZmFjZUFzeW5jRGF0YSogZGF0YSA9IHN0YXRpY19jYXN0 PEdldEZhdmljb25TdXJmYWNlQXN5bmNEYXRhKj4oZ19zaW1wbGVfYXN5bmNfcmVzdWx0X2dldF9v cF9yZXNfZ3BvaW50ZXIocmVzdWx0KSk7CiAgICAgICAgIGlmICghZ19jYW5jZWxsYWJsZV9pc19j YW5jZWxsZWQoZGF0YS0+Y2FuY2VsbGFibGUuZ2V0KCkpKSB7CiAgICAgICAgICAgICBpZiAoZXJy b3IpCi0gICAgICAgICAgICAgICAgZ19wcm9wYWdhdGVfZXJyb3IoJmRhdGEtPmVycm9yLm91dFB0 cigpLCBlcnJvci5yZWxlYXNlKCkpOworICAgICAgICAgICAgICAgIGdfc2ltcGxlX2FzeW5jX3Jl c3VsdF90YWtlX2Vycm9yKHJlc3VsdCwgZXJyb3IucmVsZWFzZSgpKTsKICAgICAgICAgICAgIGVs c2UKICAgICAgICAgICAgICAgICBkYXRhLT5pY29uID0gaWNvbjsKICAgICAgICAgfQpAQCAtMzcx LDExICszNzAsNiBAQCBjYWlyb19zdXJmYWNlX3QqIHdlYmtpdF9mYXZpY29uX2RhdGFiYXNlX2dl dF9mYXZpY29uX2ZpbmlzaChXZWJLaXRGYXZpY29uRGF0YWJhcwogCiAgICAgR2V0RmF2aWNvblN1 cmZhY2VBc3luY0RhdGEqIGRhdGEgPSBzdGF0aWNfY2FzdDxHZXRGYXZpY29uU3VyZmFjZUFzeW5j RGF0YSo+KGdfc2ltcGxlX2FzeW5jX3Jlc3VsdF9nZXRfb3BfcmVzX2dwb2ludGVyKHNpbXBsZVJl c3VsdCkpOwogICAgIEFTU0VSVChkYXRhKTsKLSAgICBpZiAoZGF0YS0+ZXJyb3IpIHsKLSAgICAg ICAgZ19wcm9wYWdhdGVfZXJyb3IoZXJyb3IsIGRhdGEtPmVycm9yLnJlbGVhc2UoKSk7Ci0gICAg ICAgIHJldHVybiAwOwotICAgIH0KLQogICAgIHJldHVybiBjYWlyb19zdXJmYWNlX3JlZmVyZW5j ZShkYXRhLT5pY29uLmdldCgpKTsKIH0KIAotLSAKMS43LjExLjcKCg==