99558 2012-10-17 00:38:53 -0700 [gyp] fix bundle resources for DumpRenderTree on mac 2012-10-17 09:55:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99023 1 jochen jochen abarth dpranke esprehn thakis tony webkit.review.bot oldest_to_newest 743959 0 jochen 2012-10-17 00:38:53 -0700 [gyp] fix bundle resources for DumpRenderTree on mac 743961 1 169108 jochen 2012-10-17 00:40:39 -0700 Created attachment 169108 Patch 743964 2 jochen 2012-10-17 00:42:36 -0700 I tested that this also gets the resources into Content Shell.app, but not into Chrome.app 744269 3 169108 abarth 2012-10-17 08:45:13 -0700 Comment on attachment 169108 Patch This looks reasonable to me. Should we have a build step somewhere that checks that we don't leak these resources into Chrome.app? I guess Chrome.app shouldn't depend on TestRunner_resources... Ideally thakis and/or tony^work would comment before we land this patch. 744322 4 169108 thakis 2012-10-17 09:46:03 -0700 Comment on attachment 169108 Patch I think this is fine. Another possible approach would be do have a gypi file with the mac_bundle_resources block and just include that into the targets that need them, but if chrome ended up depending on TestRunner_resources that'd be bad anyway. 744327 5 169108 webkit.review.bot 2012-10-17 09:55:08 -0700 Comment on attachment 169108 Patch Clearing flags on attachment: 169108 Committed r131613: <http://trac.webkit.org/changeset/131613> 744328 6 webkit.review.bot 2012-10-17 09:55:12 -0700 All reviewed patches have been landed. Closing bug. 169108 2012-10-17 00:40:39 -0700 2012-10-17 09:55:08 -0700 Patch bug-99558-20121017093926.patch text/plain 3647 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTY2OGM2YmVmNWJhYWI3YzhhOTkyOTM1MzBlYjZhMDAz MDQ0YWJhOC4uZTVjYjE5NjAzOTJmN2U5N2Q4N2RiYTc1NGI3ZGMyMmFmNjJkNzliMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEwLTE3ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtneXBdIGZpeCBidW5kbGUgcmVzb3VyY2VzIGZvciBEdW1wUmVuZGVyVHJlZSBv biBtYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5 NTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbWFj X2J1bmRsZV9yZXNvdXJjZXMgZG9lc24ndCBwcm9wYWdhdGUgdG8gdGFyZ2V0cyB0aGF0IGRlcGVu ZCBvbiBpdCwKKyAgICAgICAgc28gSSdtIHdyYXBwaW5nIGl0IGluIGFuIGFsbF9kZXBlbmRlbnRf c2V0dGluZ3MgYmxvY2suCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJl ZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwOgorCiAyMDEyLTEwLTE2ICBBbmR5IEVzdGVzICA8YWVz dGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViS2l0Ml0gQ3JlYXRlIE9iamVjdGl2ZS1DIEFQ SSBmb3IgYWRkaW5nIGFuZCByZW1vdmluZyB1c2VyIHNjcmlwdHMKZGlmZiAtLWdpdCBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lw CmluZGV4IDQxNDViOWNjMGQzMzg4OTc3MjUyYzJjMTFiNjc5YWQ5MGI0MjFjYWMuLjNmOTk4N2U1 ZTk5NjA0ZjAyYzZmOWJmMGJhM2VjZWQ5MmNiYTJmODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKKysrIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cApA QCAtMTMyLDIwICsxMzIsMjIgQEAKICAgICAgICAgICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6 IFsKICAgICAgICAgICAgICAgICAgICAgICAgICdMYXlvdXRUZXN0SGVscGVyJywKICAgICAgICAg ICAgICAgICAgICAgXSwKLSAgICAgICAgICAgICAgICAgICAgJ21hY19idW5kbGVfcmVzb3VyY2Vz JzogWwotICAgICAgICAgICAgICAgICAgICAgICAgJzwoYWhlbV9wYXRoKScsCi0gICAgICAgICAg ICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdl aWdodFdhdGNoZXIxMDAudHRmJywKLSAgICAgICAgICAgICAgICAgICAgICAgICc8KHRvb2xzX2Rp cikvRHVtcFJlbmRlclRyZWUvZm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjIwMC50dGYnLAotICAg ICAgICAgICAgICAgICAgICAgICAgJzwodG9vbHNfZGlyKS9EdW1wUmVuZGVyVHJlZS9mb250cy9X ZWJLaXRXZWlnaHRXYXRjaGVyMzAwLnR0ZicsCi0gICAgICAgICAgICAgICAgICAgICAgICAnPCh0 b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdlaWdodFdhdGNoZXI0MDAudHRm JywKLSAgICAgICAgICAgICAgICAgICAgICAgICc8KHRvb2xzX2RpcikvRHVtcFJlbmRlclRyZWUv Zm9udHMvV2ViS2l0V2VpZ2h0V2F0Y2hlcjUwMC50dGYnLAotICAgICAgICAgICAgICAgICAgICAg ICAgJzwodG9vbHNfZGlyKS9EdW1wUmVuZGVyVHJlZS9mb250cy9XZWJLaXRXZWlnaHRXYXRjaGVy NjAwLnR0ZicsCi0gICAgICAgICAgICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5k ZXJUcmVlL2ZvbnRzL1dlYktpdFdlaWdodFdhdGNoZXI3MDAudHRmJywKLSAgICAgICAgICAgICAg ICAgICAgICAgICc8KHRvb2xzX2RpcikvRHVtcFJlbmRlclRyZWUvZm9udHMvV2ViS2l0V2VpZ2h0 V2F0Y2hlcjgwMC50dGYnLAotICAgICAgICAgICAgICAgICAgICAgICAgJzwodG9vbHNfZGlyKS9E dW1wUmVuZGVyVHJlZS9mb250cy9XZWJLaXRXZWlnaHRXYXRjaGVyOTAwLnR0ZicsCi0gICAgICAg ICAgICAgICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L21pc3Np bmdJbWFnZS5wbmcnLAotICAgICAgICAgICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVE SUFURV9ESVIpL3dlYmtpdC90ZXh0QXJlYVJlc2l6ZUNvcm5lci5wbmcnLAotICAgICAgICAgICAg ICAgICAgICBdLAorICAgICAgICAgICAgICAgICAgICAnYWxsX2RlcGVuZGVudF9zZXR0aW5ncyc6 IHsKKyAgICAgICAgICAgICAgICAgICAgICAgICdtYWNfYnVuZGxlX3Jlc291cmNlcyc6IFsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAnPChhaGVtX3BhdGgpJywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdl aWdodFdhdGNoZXIxMDAudHRmJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPCh0b29s c19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdlaWdodFdhdGNoZXIyMDAudHRmJywK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVl L2ZvbnRzL1dlYktpdFdlaWdodFdhdGNoZXIzMDAudHRmJywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdlaWdodFdh dGNoZXI0MDAudHRmJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPCh0b29sc19kaXIp L0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdlaWdodFdhdGNoZXI1MDAudHRmJywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRz L1dlYktpdFdlaWdodFdhdGNoZXI2MDAudHRmJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdlaWdodFdhdGNoZXI3 MDAudHRmJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBS ZW5kZXJUcmVlL2ZvbnRzL1dlYktpdFdlaWdodFdhdGNoZXI4MDAudHRmJywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnPCh0b29sc19kaXIpL0R1bXBSZW5kZXJUcmVlL2ZvbnRzL1dlYktp dFdlaWdodFdhdGNoZXI5MDAudHRmJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPChT SEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L21pc3NpbmdJbWFnZS5wbmcnLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQv dGV4dEFyZWFSZXNpemVDb3JuZXIucG5nJywKKyAgICAgICAgICAgICAgICAgICAgICAgIF0sCisg ICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAgICAg ICAgWyd1c2VfeDExID09IDEnLCB7CiAgICAgICAgICAgICAgICAgICAgICdjb3BpZXMnOiBbewo=