99548 2012-10-16 23:31:07 -0700 Live oversize copied blocks should count toward overall heap fragmentation 2012-10-18 16:20:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg webkit.review.bot oldest_to_newest 743898 0 mhahnenberg 2012-10-16 23:31:07 -0700 The CopiedSpace uses overall heap fragmentation to determine whether or not it should do any copying. Currently it doesn't include live oversize CopiedBlocks in the calculation, but it should. We can also free any dead oversize CopiedBlocks while we're iterating over them, rather than iterating over them again at the end of the copying phase. 745609 1 169482 mhahnenberg 2012-10-18 15:07:13 -0700 Created attachment 169482 Patch 745654 2 169482 webkit.review.bot 2012-10-18 15:42:46 -0700 Comment on attachment 169482 Patch Clearing flags on attachment: 169482 Committed r131818: <http://trac.webkit.org/changeset/131818> 745655 3 webkit.review.bot 2012-10-18 15:42:49 -0700 All reviewed patches have been landed. Closing bug. 745711 4 169482 ggaren 2012-10-18 16:20:07 -0700 Comment on attachment 169482 Patch r=me 169482 2012-10-18 15:07:13 -0700 2012-10-18 16:20:06 -0700 Patch bug-99548-20121018150600.patch text/plain 6015 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMxODEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDEyLTEwLTE4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgTGl2ZSBvdmVyc2l6ZSBjb3BpZWQgYmxvY2tzIHNob3VsZCBjb3VudCB0b3dhcmQg b3ZlcmFsbCBoZWFwIGZyYWdtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk5NTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIENvcGllZFNwYWNlIHVzZXMgb3ZlcmFsbCBoZWFwIGZyYWdt ZW50YXRpb24gdG8gZGV0ZXJtaW5lIHdoZXRoZXIgb3Igbm90IGl0IHNob3VsZCBkbyBhbnkgY29w eWluZy4gCisgICAgICAgIEN1cnJlbnRseSBpdCBkb2Vzbid0IGluY2x1ZGUgbGl2ZSBvdmVyc2l6 ZSBDb3BpZWRCbG9ja3MgaW4gdGhlIGNhbGN1bGF0aW9uLCBidXQgaXQgc2hvdWxkLiBXZSBzaG91 bGQgCisgICAgICAgIHRyZWF0IHRoZW0gYXMgMTAwJSB1dGlsaXplZCwgc2luY2UgcnVubmluZyBh IGNvcHlpbmcgcGhhc2Ugd29uJ3QgYmUgYWJsZSB0byBmcmVlL2NvbXBhY3QgYW55IG9mIHRoZWly IAorICAgICAgICBtZW1vcnkuIFdlIGNhbiBhbHNvIGZyZWUgYW55IGRlYWQgb3ZlcnNpemUgQ29w aWVkQmxvY2tzIHdoaWxlIHdlJ3JlIGl0ZXJhdGluZyBvdmVyIHRoZW0sIHJhdGhlciB0aGFuIAor ICAgICAgICBpdGVyYXRpbmcgb3ZlciB0aGVtIGFnYWluIGF0IHRoZSBlbmQgb2YgdGhlIGNvcHlp bmcgcGhhc2UuCisKKyAgICAgICAgKiBoZWFwL0NvcGllZFNwYWNlLmNwcDoKKyAgICAgICAgKEpT Qzo6Q29waWVkU3BhY2U6OmRvbmVGaWxsaW5nQmxvY2spOgorICAgICAgICAoSlNDOjpDb3BpZWRT cGFjZTo6c3RhcnRlZENvcHlpbmcpOgorICAgICAgICAoSlNDOjpDb3BpZWRTcGFjZTo6ZG9uZUNv cHlpbmcpOiBBbHNvIHJlbW92ZWQgYSBicmFuY2ggd2hlbiBpdGVyYXRpbmcgb3ZlciBmcm9tLXNw YWNlIGF0IHRoZSBlbmQgb2YgCisgICAgICAgIGNvcHlpbmcuIFNpbmNlIHdlIGVhZ2VybHkgcmVj eWNsZSBibG9ja3MgYXMgc29vbiBhcyB0aGV5J3JlIGZ1bGx5IGV2YWN1YXRlZCwgd2Ugc2hvdWxk IHNlZSBubworICAgICAgICB1bnBpbm5lZCBibG9ja3MgaW4gZnJvbS1zcGFjZSBhdCB0aGUgZW5k IG9mIGNvcHlpbmcuCisgICAgICAgICogaGVhcC9Db3BpZWRTcGFjZUlubGluZU1ldGhvZHMuaDoK KyAgICAgICAgKEpTQzo6Q29waWVkU3BhY2U6OnJlY3ljbGVCb3Jyb3dlZEJsb2NrKToKKyAgICAg ICAgKiBoZWFwL0NvcHlWaXNpdG9ySW5saW5lTWV0aG9kcy5oOgorICAgICAgICAoSlNDOjpDb3B5 VmlzaXRvcjo6Y2hlY2tJZlNob3VsZENvcHkpOgorCiAyMDEyLTEwLTE4ICBSb2dlciBGb25nICA8 cm9nZXJfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQnVpbGQgZml4IGFm dGVyIHIxMzE3MDEgYW5kIHIxMzE3NzcuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9Db3BpZWRTcGFjZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvQ29waWVkU3BhY2UuY3BwCShyZXZpc2lvbiAxMzE3OTUpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9Db3BpZWRTcGFjZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3Myw2ICsxNzMs NyBAQCB2b2lkIENvcGllZFNwYWNlOjpkb25lRmlsbGluZ0Jsb2NrKENvcGllCiAgICAgewogICAg ICAgICBNdXRleExvY2tlciBsb2NrZXIobV9sb2FuZWRCbG9ja3NMb2NrKTsKICAgICAgICAgQVNT RVJUKG1fbnVtYmVyT2ZMb2FuZWRCbG9ja3MgPiAwKTsKKyAgICAgICAgQVNTRVJUKG1faW5Db3B5 aW5nUGhhc2UpOwogICAgICAgICBtX251bWJlck9mTG9hbmVkQmxvY2tzLS07CiAgICAgICAgIGlm ICghbV9udW1iZXJPZkxvYW5lZEJsb2NrcykKICAgICAgICAgICAgIG1fbG9hbmVkQmxvY2tzQ29u ZGl0aW9uLnNpZ25hbCgpOwpAQCAtMTk5LDYgKzIwMCwyMiBAQCB2b2lkIENvcGllZFNwYWNlOjpz dGFydGVkQ29weWluZygpCiAgICAgICAgIHRvdGFsVXNhYmxlQnl0ZXMgKz0gYmxvY2stPnBheWxv YWRDYXBhY2l0eSgpOwogICAgIH0KIAorICAgIENvcGllZEJsb2NrKiBibG9jayA9IG1fb3ZlcnNp emVCbG9ja3MuaGVhZCgpOworICAgIHdoaWxlIChibG9jaykgeworICAgICAgICBDb3BpZWRCbG9j ayogbmV4dCA9IGJsb2NrLT5uZXh0KCk7CisgICAgICAgIGlmIChibG9jay0+aXNQaW5uZWQoKSkg eworICAgICAgICAgICAgbV9ibG9ja0ZpbHRlci5hZGQocmVpbnRlcnByZXRfY2FzdDxCaXRzPihi bG9jaykpOworICAgICAgICAgICAgdG90YWxMaXZlQnl0ZXMgKz0gYmxvY2stPnBheWxvYWRDYXBh Y2l0eSgpOworICAgICAgICAgICAgdG90YWxVc2FibGVCeXRlcyArPSBibG9jay0+cGF5bG9hZENh cGFjaXR5KCk7CisgICAgICAgICAgICBibG9jay0+ZGlkU3Vydml2ZUdDKCk7CisgICAgICAgIH0g ZWxzZSB7CisgICAgICAgICAgICBtX292ZXJzaXplQmxvY2tzLnJlbW92ZShibG9jayk7CisgICAg ICAgICAgICBtX2Jsb2NrU2V0LnJlbW92ZShibG9jayk7CisgICAgICAgICAgICBtX2hlYXAtPmJs b2NrQWxsb2NhdG9yKCkuZGVhbGxvY2F0ZUN1c3RvbVNpemUoQ29waWVkQmxvY2s6OmRlc3Ryb3ko YmxvY2spKTsKKyAgICAgICAgfSAKKyAgICAgICAgYmxvY2sgPSBuZXh0OworICAgIH0KKwogICAg IGRvdWJsZSBtYXJrZWRTcGFjZUJ5dGVzID0gbV9oZWFwLT5vYmplY3RTcGFjZSgpLmNhcGFjaXR5 KCk7CiAgICAgZG91YmxlIHRvdGFsRnJhZ21lbnRhdGlvbiA9ICgoZG91YmxlKXRvdGFsTGl2ZUJ5 dGVzICsgbWFya2VkU3BhY2VCeXRlcykgLyAoKGRvdWJsZSl0b3RhbFVzYWJsZUJ5dGVzICsgbWFy a2VkU3BhY2VCeXRlcyk7CiAgICAgbV9zaG91bGREb0NvcHlQaGFzZSA9IHRvdGFsRnJhZ21lbnRh dGlvbiA8PSBPcHRpb25zOjptaW5IZWFwVXRpbGl6YXRpb24oKTsKQEAgLTIyNCwzMSArMjQxLDEz IEBAIHZvaWQgQ29waWVkU3BhY2U6OmRvbmVDb3B5aW5nKCkKIAogICAgIHdoaWxlICghbV9mcm9t U3BhY2UtPmlzRW1wdHkoKSkgewogICAgICAgICBDb3BpZWRCbG9jayogYmxvY2sgPSBtX2Zyb21T cGFjZS0+cmVtb3ZlSGVhZCgpOwotICAgICAgICBpZiAoYmxvY2stPmlzUGlubmVkKCkgfHwgIW1f c2hvdWxkRG9Db3B5UGhhc2UpIHsKLSAgICAgICAgICAgIGJsb2NrLT5kaWRTdXJ2aXZlR0MoKTsK LSAgICAgICAgICAgIC8vIFdlIGRvbid0IGFkZCB0aGUgYmxvY2sgdG8gdGhlIGJsb2NrU2V0IGJl Y2F1c2UgaXQgd2FzIG5ldmVyIHJlbW92ZWQuCi0gICAgICAgICAgICBBU1NFUlQobV9ibG9ja1Nl dC5jb250YWlucyhibG9jaykpOwotICAgICAgICAgICAgbV9ibG9ja0ZpbHRlci5hZGQocmVpbnRl cnByZXRfY2FzdDxCaXRzPihibG9jaykpOwotICAgICAgICAgICAgbV90b1NwYWNlLT5wdXNoKGJs b2NrKTsKLSAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICB9Ci0KLSAgICAgICAgbV9ibG9j a1NldC5yZW1vdmUoYmxvY2spOwotICAgICAgICBtX2hlYXAtPmJsb2NrQWxsb2NhdG9yKCkuZGVh bGxvY2F0ZShDb3BpZWRCbG9jazo6ZGVzdHJveShibG9jaykpOwotICAgIH0KLQotICAgIENvcGll ZEJsb2NrKiBjdXJyID0gbV9vdmVyc2l6ZUJsb2Nrcy5oZWFkKCk7Ci0gICAgd2hpbGUgKGN1cnIp IHsKLSAgICAgICAgQ29waWVkQmxvY2sqIG5leHQgPSBjdXJyLT5uZXh0KCk7Ci0gICAgICAgIGlm ICghY3Vyci0+aXNQaW5uZWQoKSkgewotICAgICAgICAgICAgbV9vdmVyc2l6ZUJsb2Nrcy5yZW1v dmUoY3Vycik7Ci0gICAgICAgICAgICBtX2Jsb2NrU2V0LnJlbW92ZShjdXJyKTsKLSAgICAgICAg ICAgIG1faGVhcC0+YmxvY2tBbGxvY2F0b3IoKS5kZWFsbG9jYXRlQ3VzdG9tU2l6ZShDb3BpZWRC bG9jazo6ZGVzdHJveShjdXJyKSk7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBtX2Js b2NrRmlsdGVyLmFkZChyZWludGVycHJldF9jYXN0PEJpdHM+KGN1cnIpKTsKLSAgICAgICAgICAg IGN1cnItPmRpZFN1cnZpdmVHQygpOwotICAgICAgICB9Ci0gICAgICAgIGN1cnIgPSBuZXh0Owor ICAgICAgICAvLyBBbGwgbm9uLXBpbm5lZCBibG9ja3MgaW4gZnJvbS1zcGFjZSBzaG91bGQgaGF2 ZSBiZWVuIHJlY2xhaW1lZCBhcyB0aGV5IHdlcmUgZXZhY3VhdGVkLgorICAgICAgICBBU1NFUlQo YmxvY2stPmlzUGlubmVkKCkgfHwgIW1fc2hvdWxkRG9Db3B5UGhhc2UpOworICAgICAgICBibG9j ay0+ZGlkU3Vydml2ZUdDKCk7CisgICAgICAgIC8vIFdlIGRvbid0IGFkZCB0aGUgYmxvY2sgdG8g dGhlIGJsb2NrU2V0IGJlY2F1c2UgaXQgd2FzIG5ldmVyIHJlbW92ZWQuCisgICAgICAgIEFTU0VS VChtX2Jsb2NrU2V0LmNvbnRhaW5zKGJsb2NrKSk7CisgICAgICAgIG1fYmxvY2tGaWx0ZXIuYWRk KHJlaW50ZXJwcmV0X2Nhc3Q8Qml0cz4oYmxvY2spKTsKKyAgICAgICAgbV90b1NwYWNlLT5wdXNo KGJsb2NrKTsKICAgICB9CiAKICAgICBpZiAoIW1fdG9TcGFjZS0+aGVhZCgpKQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2VJbmxpbmVNZXRob2RzLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2VJbmxpbmVNZXRo b2RzLmgJKHJldmlzaW9uIDEzMTc5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Nv cGllZFNwYWNlSW5saW5lTWV0aG9kcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTMsNiArMTEzLDcg QEAgaW5saW5lIHZvaWQgQ29waWVkU3BhY2U6OnJlY3ljbGVCb3Jyb3dlZAogICAgIHsKICAgICAg ICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fbG9hbmVkQmxvY2tzTG9jayk7CiAgICAgICAgIEFTU0VS VChtX251bWJlck9mTG9hbmVkQmxvY2tzID4gMCk7CisgICAgICAgIEFTU0VSVChtX2luQ29weWlu Z1BoYXNlKTsKICAgICAgICAgbV9udW1iZXJPZkxvYW5lZEJsb2Nrcy0tOwogICAgICAgICBpZiAo IW1fbnVtYmVyT2ZMb2FuZWRCbG9ja3MpCiAgICAgICAgICAgICBtX2xvYW5lZEJsb2Nrc0NvbmRp dGlvbi5zaWduYWwoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvcHlWaXNp dG9ySW5saW5lTWV0aG9kcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0NvcHlWaXNpdG9ySW5saW5lTWV0aG9kcy5oCShyZXZpc2lvbiAxMzE3OTUpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3B5VmlzaXRvcklubGluZU1ldGhvZHMuaAkod29ya2lu ZyBjb3B5KQpAQCAtNTYsMTAgKzU2LDggQEAgcHJpdmF0ZToKIAogaW5saW5lIGJvb2wgQ29weVZp c2l0b3I6OmNoZWNrSWZTaG91bGRDb3B5KHZvaWQqIG9sZFB0ciwgc2l6ZV90IGJ5dGVzKQogewot ICAgIGlmIChDb3BpZWRTcGFjZTo6aXNPdmVyc2l6ZShieXRlcykpIHsKLSAgICAgICAgQVNTRVJU KENvcGllZFNwYWNlOjpvdmVyc2l6ZUJsb2NrRm9yKG9sZFB0ciktPmlzUGlubmVkKCkpOworICAg IGlmIChDb3BpZWRTcGFjZTo6aXNPdmVyc2l6ZShieXRlcykpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKLSAgICB9CiAKICAgICBpZiAoQ29waWVkU3BhY2U6OmJsb2NrRm9yKG9sZFB0ciktPmlzUGlu bmVkKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK