99541 2012-10-16 22:31:12 -0700 [mac] Fix build break - processPath should be initialized. 2012-10-17 22:13:56 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dw.im dw.im ap beidson sam webkit.review.bot oldest_to_newest 743858 0 dw.im 2012-10-16 22:31:12 -0700 There is build error because processPath isn't initialized. 743860 1 169090 dw.im 2012-10-16 22:34:59 -0700 Created attachment 169090 Patch 743863 2 169090 abarth 2012-10-16 22:36:27 -0700 Comment on attachment 169090 Patch ok 743875 3 169090 webkit.review.bot 2012-10-16 22:56:57 -0700 Comment on attachment 169090 Patch Clearing flags on attachment: 169090 Committed r131551: <http://trac.webkit.org/changeset/131551> 743876 4 webkit.review.bot 2012-10-16 22:57:01 -0700 All reviewed patches have been landed. Closing bug. 744414 5 ap 2012-10-17 10:59:31 -0700 Which Mac build was broken? Unless I'm missing something, this code was added a week ago in bug 98543, and Mac build was not failing. 744421 6 beidson 2012-10-17 11:02:22 -0700 (In reply to comment #5) > Which Mac build was broken? Unless I'm missing something, this code was added a week ago in bug 98543, and Mac build was not failing. Indeed. Also, there was actually nothing wrong with the code before that a modern compiler couldn't figure out, as it wasn't possible to make it through the switch statement without initializing. Please include links to build breakage in cases like this. 744887 7 dw.im 2012-10-17 18:25:14 -0700 When I tried on my macbook pro,build error comes out. The reason was, the variable doesn't initialized, and build warning is treated as build error. If I meet build error next time, I will paste the error log as comment. 744978 8 beidson 2012-10-17 22:13:56 -0700 (In reply to comment #7) > When I tried on my macbook pro,build error comes out. > > The reason was, the variable doesn't initialized, > and build warning is treated as build error. > > If I meet build error next time, > I will paste the error log as comment. As Alexey mentioned the Mac builds clearly didn't have this problem. What is your tools environment like? Note that the reason the variable is actually *not* uninitialized is that it was impossible to make it through the switch statement without initializing it, as all cases were handled. 169090 2012-10-16 22:34:59 -0700 2012-10-16 22:56:57 -0700 Patch bug-99541-20121017143343.patch text/plain 1522 dw.im U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmQ4ZjhjZGVmZjljNmIy NWI3MWFmYTAxMGZlODY2ZWUxNjg0MmZjNi4uOTIzNTI5NGE0MTdmOTgwMzg5YmExNGE3ODU0ZWYw MTBjZDdmNmI3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTE2ICBEb25n d29vIEpvc2h1YSBJbSAgPGR3LmltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFttYWNdIEZpeCBi dWlsZCBicmVhayAtIHByb2Nlc3NQYXRoIHNob3VsZCBiZSBpbml0aWFsaXplZC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NTQxCisKKyAgICAgICAg VW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgSW5pdGlhbGl6ZSBwcm9jZXNzUGF0aCBh cyBuaWwuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hl ck1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6Y3JlYXRlUHJvY2Vzcyk6CisKIDIwMTItMTAtMTYg IENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAg ICBbRUZMXVtXSzJdIEFkZCBmYWN0b3J5IG1ldGhvZHMgZm9yIHJlZmNvdW50ZWQgRXdrIHR5cGVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nl c3NMYXVuY2hlck1hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMv UHJvY2Vzc0xhdW5jaGVyTWFjLm1tCmluZGV4IGRhZDgxNTU4ZGE3N2MzOWRiNTA1YjBjMDM0YTQ3 YjU1MDEwNTVmYTYuLmE5YzIwZGEzMjQyMWYyNjJkMjcxZTA1YjhkNDAxNGRhYmVjMTc2ZmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xh dW5jaGVyTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMv UHJvY2Vzc0xhdW5jaGVyTWFjLm1tCkBAIC0zNjcsNyArMzY3LDcgQEAgc3RhdGljIHZvaWQgY3Jl YXRlUHJvY2Vzcyhjb25zdCBQcm9jZXNzTGF1bmNoZXI6OkxhdW5jaE9wdGlvbnMmIGxhdW5jaE9w dGlvbnMsIGIKIAogICAgIE5TQnVuZGxlICp3ZWJLaXQyQnVuZGxlID0gW05TQnVuZGxlIGJ1bmRs ZVdpdGhJZGVudGlmaWVyOkAiY29tLmFwcGxlLldlYktpdDIiXTsKIAotICAgIE5TU3RyaW5nICpw cm9jZXNzUGF0aDsKKyAgICBOU1N0cmluZyAqcHJvY2Vzc1BhdGggPSBuaWw7CiAgICAgc3dpdGNo KGxhdW5jaE9wdGlvbnMucHJvY2Vzc1R5cGUpIHsKICAgICBjYXNlIFByb2Nlc3NMYXVuY2hlcjo6 V2ViUHJvY2VzczoKICAgICAgICAgcHJvY2Vzc1BhdGggPSBbd2ViS2l0MkJ1bmRsZSBwYXRoRm9y QXV4aWxpYXJ5RXhlY3V0YWJsZTpAIldlYlByb2Nlc3MuYXBwIl07Cg==