99540 2012-10-16 22:30:01 -0700 Web Inspector: NMI instrument ImageDecoder. It owns a buffer that could be quite big. 2012-10-17 07:26:19 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 743857 0 loislo 2012-10-16 22:30:01 -0700 EOM 743859 1 169089 loislo 2012-10-16 22:33:18 -0700 Created attachment 169089 Patch 743877 2 169089 buildbot 2012-10-16 22:59:18 -0700 Comment on attachment 169089 Patch Attachment 169089 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14387436 743882 3 169089 buildbot 2012-10-16 23:04:19 -0700 Comment on attachment 169089 Patch Attachment 169089 did not pass win-ews (win): Output: http://queues.webkit.org/results/14393466 743967 4 169089 yurys 2012-10-17 00:46:35 -0700 Comment on attachment 169089 Patch Can we add a test for this? Now that there is a framework for writing pure protocol inspector tests it should be quite easy. 744196 5 loislo 2012-10-17 05:58:23 -0700 (In reply to comment #4) > (From update of attachment 169089 [details]) > Can we add a test for this? Now that there is a framework for writing pure protocol inspector tests it should be quite easy. Looks like it is a tricky task because: a) we have only aggregated statistic and other patches could increase the reported size and thus hide the regression; b) it is not clear for me how I can reproduce the situation with cached bitmap in image decoder; c) a test with both, low and upper limit in LayoutTests will hurt other developers. 744231 6 loislo 2012-10-17 07:26:19 -0700 Committed r131593: <http://trac.webkit.org/changeset/131593> 169089 2012-10-16 22:33:18 -0700 2012-10-17 07:19:31 -0700 Patch bug-99540-20121017093205.patch text/plain 5849 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTM3NDM3ZmYzMWFhNzU0 NzhmYTZkMTJhYjA1MTZjMjQ2MjY5N2U1YS4uMWM2N2E4NDg1OTMyNWNmNjU0N2VkZGQzYjQ2NGVm Y2Y4OGRjMTE4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTEwLTE2ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBOTUkgaW5zdHJ1bWVudCBJbWFnZURlY29kZXIuIEl0IG93bnMgYSBidWZmZXIgdGhhdCBj b3VsZCBiZSBxdWl0ZSBiaWcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05OTU0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW1hZ2VTb3VyY2U6OnJlcG9ydE1lbW9yeVVzYWdlKToKKyAgICAgICAgKFdlYkNv cmUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmg6CisgICAgICAg IChJbWFnZVNvdXJjZSk6CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VE ZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRnJhbWU6OnJlcG9ydE1lbW9yeVVz YWdlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVy OjpyZXBvcnRNZW1vcnlVc2FnZSk6CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMv SW1hZ2VEZWNvZGVyLmg6CisgICAgICAgIChJbWFnZUZyYW1lKToKKyAgICAgICAgKEltYWdlRGVj b2Rlcik6CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvc2tpYS9JbWFnZURlY29k ZXJTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRnJhbWU6OnJlcG9ydE1lbW9yeVVz YWdlKToKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTEwLTE2ICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgUmVuZGVyT2JqZWN0IGRl c3RydWN0aW9uIGR1cmluZyBkZXRhY2ggYSB0b3AtZG93biBvcGVyYXRpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcAppbmRleCA5ODE2ZTYz NDFmZWIyMDc1MGUzMTYxMjdmNjBkZTVmODFmOWI2OTk2Li44MmRmZGUxYzlkZDgyZTMxNWJiZGQ5 ZWU4OWNkMDgyM2M5Y2M4ZTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9JbWFnZVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvSW1hZ2VTb3VyY2UuY3BwCkBAIC0zMyw2ICszMyw3IEBACiAKICNpbmNsdWRlICJJbWFn ZU9yaWVudGF0aW9uLmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKyNpbmNsdWRlICJQ bGF0Zm9ybU1lbW9yeUluc3RydW1lbnRhdGlvbi5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK QEAgLTIwNSw0ICsyMDYsMTAgQEAgdW5zaWduZWQgSW1hZ2VTb3VyY2U6OmZyYW1lQnl0ZXNBdElu ZGV4KHNpemVfdCBpbmRleCkgY29uc3QKICAgICByZXR1cm4gbV9kZWNvZGVyLT5mcmFtZUJ5dGVz QXRJbmRleChpbmRleCk7CiB9CiAKK3ZvaWQgSW1hZ2VTb3VyY2U6OnJlcG9ydE1lbW9yeVVzYWdl KE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0Cit7CisgICAgTWVtb3J5 Q2xhc3NJbmZvIGluZm8obWVtb3J5T2JqZWN0SW5mbywgdGhpcywgUGxhdGZvcm1NZW1vcnlUeXBl czo6SW1hZ2UpOworICAgIGluZm8uYWRkTWVtYmVyKG1fZGVjb2Rlcik7Cit9CisKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5oCmluZGV4IDY4Nzll ZGEwNTVhYjg3ZDI1NTYwMjFmM2U3ZjkwMmRlNTY2OWExNWIuLjBkOGEwMWUyNmE3MmNmZmYzOWFh NDY1NDM3NDE0NGEwYTE3OWFjMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ltYWdlU291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvSW1hZ2VTb3VyY2UuaApAQCAtMTU1LDYgKzE1NSw4IEBAIHB1YmxpYzoKICAgICBzdGF0 aWMgdm9pZCBzZXRNYXhQaXhlbHNQZXJEZWNvZGVkSW1hZ2UodW5zaWduZWQgbWF4UGl4ZWxzKSB7 IHNfbWF4UGl4ZWxzUGVyRGVjb2RlZEltYWdlID0gbWF4UGl4ZWxzOyB9CiAjZW5kaWYKIAorICAg IHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyopIGNvbnN0OworCiBwcml2 YXRlOgogICAgIE5hdGl2ZUltYWdlU291cmNlUHRyIG1fZGVjb2RlcjsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5jcHAK aW5kZXggMWVlMDNlZmM2YzFhNTZkYjI0ODZjMTZkMzA4N2M2YTE5N2VmY2EwNC4uNGY2NTI3NTdm Mzc0ODMyMDUyZTViMmM3ZDhkNjdhZjIzZWM5YmMxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9JbWFnZURlY29kZXIuY3BwCkBAIC0zMCw2 ICszMCw3IEBACiAjZW5kaWYKICNpbmNsdWRlICJKUEVHSW1hZ2VEZWNvZGVyLmgiCiAjaW5jbHVk ZSAiUE5HSW1hZ2VEZWNvZGVyLmgiCisjaW5jbHVkZSAiUGxhdGZvcm1NZW1vcnlJbnN0cnVtZW50 YXRpb24uaCIKICNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKICNpZiBVU0UoV0VCUCkKICNpbmNs dWRlICJXRUJQSW1hZ2VEZWNvZGVyLmgiCkBAIC0zNyw2ICszOCw3IEBACiAKICNpbmNsdWRlIDxh bGdvcml0aG0+CiAjaW5jbHVkZSA8Y21hdGg+CisjaW5jbHVkZSA8d3RmL01lbW9yeUluc3RydW1l bnRhdGlvblZlY3Rvci5oPgogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCkBAIC0yMzQsNiArMjM2 LDEyIEBAIGludCBJbWFnZUZyYW1lOjpoZWlnaHQoKSBjb25zdAogICAgIHJldHVybiBtX3NpemUu aGVpZ2h0KCk7CiB9CiAKK3ZvaWQgSW1hZ2VGcmFtZTo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5 T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbykgY29uc3QKK3sKKyAgICBNZW1vcnlDbGFzc0lu Zm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBQbGF0Zm9ybU1lbW9yeVR5cGVzOjpJbWFn ZSk7CisgICAgaW5mby5hZGRNZW1iZXIobV9iYWNraW5nU3RvcmUpOworfQorCiAjZW5kaWYKIAog bmFtZXNwYWNlIHsKQEAgLTMzNyw0ICszNDUsMTQgQEAgaW50IEltYWdlRGVjb2Rlcjo6c2NhbGVk WShpbnQgb3JpZ1ksIGludCBzZWFyY2hTdGFydCkKICAgICByZXR1cm4gZ2V0U2NhbGVkVmFsdWU8 RXhhY3Q+KG1fc2NhbGVkUm93cywgb3JpZ1ksIHNlYXJjaFN0YXJ0KTsKIH0KIAordm9pZCBJbWFn ZURlY29kZXI6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVj dEluZm8pIGNvbnN0Cit7CisgICAgTWVtb3J5Q2xhc3NJbmZvIGluZm8obWVtb3J5T2JqZWN0SW5m bywgdGhpcywgUGxhdGZvcm1NZW1vcnlUeXBlczo6SW1hZ2UpOworICAgIGluZm8uYWRkTWVtYmVy KG1fZGF0YSk7CisgICAgaW5mby5hZGRNZW1iZXIobV9mcmFtZUJ1ZmZlckNhY2hlKTsKKyAgICBp bmZvLmFkZE1lbWJlcihtX2NvbG9yUHJvZmlsZSk7CisgICAgaW5mby5hZGRNZW1iZXIobV9zY2Fs ZWRDb2x1bW5zKTsKKyAgICBpbmZvLmFkZE1lbWJlcihtX3NjYWxlZFJvd3MpOworfQorCiB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9JbWFnZURl Y29kZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVj b2Rlci5oCmluZGV4IGQwY2M1M2IxNDc1N2QxNzQ0MjJmNzY4Nzk4NDBlY2IzNWFmOTUyNDYuLmZj ODJhNWMyNWFkNzhlODc3ZGM5OTE4OGU5ZmRiMWU4NWIxYWQyN2MgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL0ltYWdlRGVjb2Rlci5oCkBAIC0x NDUsNiArMTQ1LDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgcmV0dXJuIG1f Ynl0ZXMgKyAoeSAqIHdpZHRoKCkpICsgeDsKICNlbmRpZgogICAgICAgICB9CisKKyAgICAgICAg dm9pZCByZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKikgY29uc3Q7CisKICAgICBw cml2YXRlOgogICAgICAgICBpbnQgd2lkdGgoKSBjb25zdDsKICAgICAgICAgaW50IGhlaWdodCgp IGNvbnN0OwpAQCAtMzU5LDYgKzM2Miw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAg dm9pZCBzZXRNYXhOdW1QaXhlbHMoaW50IG0pIHsgbV9tYXhOdW1QaXhlbHMgPSBtOyB9CiAjZW5k aWYKIAorICAgICAgICB2aXJ0dWFsIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0 SW5mbyopIGNvbnN0OworCiAgICAgcHJvdGVjdGVkOgogICAgICAgICB2b2lkIHByZXBhcmVTY2Fs ZURhdGFJZk5lY2Vzc2FyeSgpOwogICAgICAgICBpbnQgdXBwZXJCb3VuZFNjYWxlZFgoaW50IG9y aWdYLCBpbnQgc2VhcmNoU3RhcnQgPSAwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2ltYWdlLWRlY29kZXJzL3NraWEvSW1hZ2VEZWNvZGVyU2tpYS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3Bw CmluZGV4IDFmZTczNDhlZmYxNzBjZjI3MDllOTljNWUxYTIwZGNiMGY0M2IzNmIuLjE0YzExOWZi NDg2OGVlMGJmMjg0NDM5ZjhiNGE2MWQ4N2JhNDM1NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3NraWEvSW1hZ2VEZWNvZGVyU2tpYS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvc2tpYS9JbWFnZURlY29k ZXJTa2lhLmNwcApAQCAtMjcsNiArMjcsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1 ZGUgIkltYWdlRGVjb2Rlci5oIgogCisjaW5jbHVkZSAiUGxhdGZvcm1NZW1vcnlJbnN0cnVtZW50 YXRpb24uaCIKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBJbWFnZUZyYW1lOjpJbWFnZUZyYW1l KCkKQEAgLTE0NSw0ICsxNDcsMTAgQEAgaW50IEltYWdlRnJhbWU6OmhlaWdodCgpIGNvbnN0CiAg ICAgcmV0dXJuIG1fYml0bWFwLmJpdG1hcCgpLmhlaWdodCgpOwogfQogCit2b2lkIEltYWdlRnJh bWU6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8p IGNvbnN0Cit7CisgICAgTWVtb3J5Q2xhc3NJbmZvIGluZm8obWVtb3J5T2JqZWN0SW5mbywgdGhp cywgUGxhdGZvcm1NZW1vcnlUeXBlczo6SW1hZ2UpOworICAgIGluZm8uYWRkTWVtYmVyKG1fYml0 bWFwKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=