9954 2006-07-16 07:15:27 -0700 REGRESSION: document.dir should return empty string in <head> 2007-06-24 12:04:44 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 ddkilzer ddkilzer darin oldest_to_newest 50044 0 ddkilzer 2006-07-16 07:15:27 -0700 The patch for Bug 9911 caused a minor regression where document.dir should return an empty string in <head>. This matches what production Safari 2.0.4 (419.3) does. Note that Bug 9947 covers the "real" fix to document.dir, which can't be set in <head> and which is currently linked to body.dir (unlike Firefox and MSIE). 50057 1 9493 ddkilzer 2006-07-16 08:29:02 -0700 Created attachment 9493 Patch v1 Changes document.dir to return an empty string instead of undef in <head>. 50090 2 9493 darin 2006-07-16 15:27:55 -0700 Comment on attachment 9493 Patch v1 r=me 50118 3 ddkilzer 2006-07-16 21:15:17 -0700 Committed revision 15479. 6463 4 ddkilzer 2007-06-24 12:04:44 -0700 Mass removal of NeedsRadar keyword from my bugs that have already been RESOLVED. 9493 2006-07-16 08:29:02 -0700 2006-07-16 15:27:55 -0700 Patch v1 bug-9954-v1.diff text/plain 4461 ddkilzer SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NDY3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDctMTYgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGtpbHplci5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv d19idWcuY2dpP2lkPTk5NTQKKyAgICAgICAgICBSRUdSRVNTSU9OOiBkb2N1bWVudC5kaXIgc2hv dWxkIHJldHVybiBlbXB0eSBzdHJpbmcgaW4gPGhlYWQ+CisKKyAgICAgICAgKiBmYXN0L2RvbS9k b2N1bWVudC1kaXItcHJvcGVydHktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0 L2RvbS9kb2N1bWVudC1kaXItcHJvcGVydHkuaHRtbDogQWRkZWQuCisKIDIwMDYtMDctMTUgIERh cmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4g U3VsbGl2YW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb2N1bWVudC1kaXItcHJvcGVy dHktZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3Vt ZW50LWRpci1wcm9wZXJ0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2RvbS9kb2N1bWVudC1kaXItcHJvcGVydHktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDI4IEBACitUaGlzIHRlc3RzOgorQnVnIDk5NTQgUkVHUkVTU0lPTjogZG9j dW1lbnQuZGlyIHNob3VsZCByZXR1cm4gZW1wdHkgc3RyaW5nIGluIDxoZWFkPgoraHR0cDovL2J1 Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05OTU0CisKK09uIHN1Y2Nlc3Ms IHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJU RVNUIENPTVBMRVRFIi4KKworUmVhZCBkb2N1bWVudC5kaXIgaW4gaGVhZAorUEFTUyBoZWFkUmVh ZERvY3VtZW50RGlyIGlzICcnCisKK1dyaXRlIGRvY3VtZW50LmRpciBpbiBoZWFkCitQQVNTIGhl YWRXcml0ZURvY3VtZW50RGlyIGlzICcnCisKK1JlYWQgZG9jdW1lbnQuZGlyIGluIGJvZHkKK1BB U1MgZG9jdW1lbnQuZGlyIGlzICcnCisKK1JlYWQgZG9jdW1lbnQuYm9keS5kaXIgaW4gYm9keQor UEFTUyBkb2N1bWVudC5ib2R5LmRpciBpcyAnJworCitXcml0ZSBkb2N1bWVudC5kaXIgaW4gYm9k eQorUEFTUyBkb2N1bWVudC5kaXIgaXMgJ2x0cicKKworUmVhZCBkb2N1bWVudC5ib2R5LmRpciBp biBib2R5CitQQVNTIGRvY3VtZW50LmJvZHkuZGlyIGlzICdsdHInCisKK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2RvbS9kb2N1bWVudC1kaXItcHJvcGVydHkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9kb2N1bWVudC1kaXItcHJvcGVydHkuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LWRpci1wcm9wZXJ0eS5odG1sCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDQ4IEBACis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNo ZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdD4K K3ZhciBoZWFkUmVhZERvY3VtZW50RGlyID0gZG9jdW1lbnQuZGlyOworZG9jdW1lbnQuZGlyID0g InJ0bCI7Cit2YXIgaGVhZFdyaXRlRG9jdW1lbnREaXIgPSBkb2N1bWVudC5kaXI7Cis8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5PgorPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBp ZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qt cHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0czo8YnI+ IgorICAgICAgICAgICsgIkJ1ZyA5OTU0IFJFR1JFU1NJT046IGRvY3VtZW50LmRpciBzaG91bGQg cmV0dXJuIGVtcHR5IHN0cmluZyBpbiAmbHQ7aGVhZCZndDs8YnI+IgorICAgICAgICAgICsgIjxh IGhyZWY9XCJodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk5 NTRcIj5odHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk5NTQ8 L2E+PGJyPiIpOworCitkZWJ1ZygiUmVhZCBkb2N1bWVudC5kaXIgaW4gaGVhZCIpOworc2hvdWxk QmUoImhlYWRSZWFkRG9jdW1lbnREaXIiLCAiJyciKTsKK2RlYnVnKCIiKTsKKworZGVidWcoIldy aXRlIGRvY3VtZW50LmRpciBpbiBoZWFkIik7CitzaG91bGRCZSgiaGVhZFdyaXRlRG9jdW1lbnRE aXIiLCAiJyciKTsKK2RlYnVnKCIiKTsKKworZGVidWcoIlJlYWQgZG9jdW1lbnQuZGlyIGluIGJv ZHkiKTsKK3Nob3VsZEJlKCJkb2N1bWVudC5kaXIiLCAiJyciKTsKK2RlYnVnKCIiKTsKKworZGVi dWcoIlJlYWQgZG9jdW1lbnQuYm9keS5kaXIgaW4gYm9keSIpOworc2hvdWxkQmUoImRvY3VtZW50 LmJvZHkuZGlyIiwgIicnIik7CitkZWJ1ZygiIik7CisKK2RlYnVnKCJXcml0ZSBkb2N1bWVudC5k aXIgaW4gYm9keSIpOworZG9jdW1lbnQuZGlyID0gImx0ciI7CitzaG91bGRCZSgiZG9jdW1lbnQu ZGlyIiwgIidsdHInIik7CitkZWJ1ZygiIik7CisKK2RlYnVnKCJSZWFkIGRvY3VtZW50LmJvZHku ZGlyIGluIGJvZHkiKTsKK3Nob3VsZEJlKCJkb2N1bWVudC5ib2R5LmRpciIsICInbHRyJyIpOwor ZGVidWcoIiIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDY3KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwNi0wNy0xNiAgRGF2aWQgS2lsemVy ICA8ZGRraWx6ZXJAa2lsemVyLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAtIGZpeCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3Jn L3Nob3dfYnVnLmNnaT9pZD05OTU0CisgICAgICAgICAgUkVHUkVTU0lPTjogZG9jdW1lbnQuZGly IHNob3VsZCByZXR1cm4gZW1wdHkgc3RyaW5nIGluIDxoZWFkPgorCisgICAgICAgIFRlc3Q6IGZh c3QvZG9tL2RvY3VtZW50LWRpci1wcm9wZXJ0eS5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9ranNfaHRtbC5jcHA6CisgICAgICAgIChLSlM6OkpTSFRNTERvY3VtZW50OjpnZXRWYWx1ZVBy b3BlcnR5KTogUmV0dXJuIGFuIGVtcHR5IHN0cmluZyBpbnN0ZWFkIG9mIGFuCisgICAgICAgIHVu ZGVmaW5lZCB2YWx1ZSBmb3IgYW4gdW5zZXQgZG9jdW1lbnQuZGlyIHByb3BlcnR5LgorCiAyMDA2 LTA3LTE1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICAtIGZpeCBt aXN0YWtlIGZyb20gZml4IGZvciA4OTUyIHRoYXQgd2FzIGJyZWFraW5nIGxheW91dCB0ZXN0cwpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9ranNfaHRtbC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9iaW5kaW5ncy9qcy9ranNfaHRtbC5jcHAJKHJldmlzaW9uIDE1NDY2KQorKysgV2ViQ29y ZS9iaW5kaW5ncy9qcy9ranNfaHRtbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwMyw3ICszMDMs NyBAQCBKU1ZhbHVlICpKU0hUTUxEb2N1bWVudDo6Z2V0VmFsdWVQcm9wZXJ0CiAgICAgcmV0dXJu IGpzTnVtYmVyKHZpZXcgPyB2aWV3LT5jb250ZW50c1dpZHRoKCkgOiAwKTsKICAgY2FzZSBEaXI6 CiAgICAgaWYgKCFib2R5KQotICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CisgICAgICByZXR1 cm4ganNTdHJpbmcoIiIpOwogICAgIHJldHVybiBqc1N0cmluZyhib2R5LT5kaXIoKSk7CiAgIGNh c2UgRGVzaWduTW9kZToKICAgICByZXR1cm4ganNTdHJpbmcoZG9jLmluRGVzaWduTW9kZSgpID8g Im9uIiA6ICJvZmYiKTsK