99527 2012-10-16 17:03:57 -0700 IndexedDB: Stub out chromium success handlers for integers and undefined values 2012-10-16 18:30:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alecflett alecflett abarth dglazkov dgrogan fishd jamesr jsbell tkent+wkapi webkit.review.bot oldest_to_newest 743709 0 alecflett 2012-10-16 17:03:57 -0700 IndexedDB: Stub out chromium success handlers for integers and undefined values 743711 1 169060 alecflett 2012-10-16 17:04:37 -0700 Created attachment 169060 Patch 743716 2 alecflett 2012-10-16 17:06:03 -0700 jsbell/dgrogan - quick review? I'm adding: onSuccess(int64_t) - for the result of count(), previously calling onSuccess(SerializedScriptValue::numberValue(count)) onSuccess() - anytime we were calling onSuccess(SerializedScriptValue::undefinedValue()) This stubs these out so I can land chromium, then I'll have a webkit patch to follow 743717 3 webkit.review.bot 2012-10-16 17:07:03 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 743724 4 169060 jsbell 2012-10-16 17:15:21 -0700 Comment on attachment 169060 Patch LGTM. We may want to sort the lines so onSuccess() comes first. 743735 5 alecflett 2012-10-16 17:24:19 -0700 abarth@ - r? 743756 6 169060 abarth 2012-10-16 18:00:40 -0700 Comment on attachment 169060 Patch Ok. 743771 7 169060 webkit.review.bot 2012-10-16 18:30:19 -0700 Comment on attachment 169060 Patch Clearing flags on attachment: 169060 Committed r131540: <http://trac.webkit.org/changeset/131540> 743773 8 webkit.review.bot 2012-10-16 18:30:23 -0700 All reviewed patches have been landed. Closing bug. 169060 2012-10-16 17:04:37 -0700 2012-10-16 18:30:18 -0700 Patch bug-99527-20121016170325.patch text/plain 1879 alecflett U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGZiZTUwN2E4ZTViNjY5NmM5MDBhNmQzYTE3NmVlYTQ3YWZkYmQ4NzIuLmEzZmM2MGU2ODliM2E1 OGE5N2UxNzc3ZmFiNGUwYzJkZDI3NDExNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMTAtMTYgIEFsZWMgRmxldHQgIDxhbGVjZmxldHRAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogU3R1YiBvdXQgY2hyb21pdW0gc3VjY2VzcyBo YW5kbGVycyBmb3IgaW50ZWdlcnMgYW5kIHVuZGVmaW5lZCB2YWx1ZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NTI3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG9uU3VjY2VzcyBzdHVicyBzbyB0 aGF0IGNocm9taXVtIElQQyBnbHVlIGNhbiBsYW5kLgorCisgICAgICAgICogcHVibGljL1dlYklE QkNhbGxiYWNrcy5oOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJDYWxsYmFja3M6Om9uU3VjY2Vz cyk6CisKIDIwMTItMTAtMTUgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtDaHJvbWl1bV0gRW5hYmxlIEZBU1RfTU9CSUxFX1NDUk9MTElORyBmb3IgQW5k cm9pZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCQ2Fs bGJhY2tzLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3Mu aAppbmRleCAzNThiNzNiMTc1ZmNiNDgyZWFjMDk5ZDM5MWExNzI5MWYzMWIxMjY4Li5iOTFiMGY1 YTJmYTc1NWZhYjFhOThjMWY0MGVlNzllMDdjMTc3YWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJJREJDYWxsYmFja3MuaApAQCAtNTYsNiArNTYsOCBAQCBwdWJs aWM6CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2VzcyhXZWJJREJUcmFuc2FjdGlvbiopIHsgV0VC S0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhj b25zdCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUmKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNI RUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvblN1Y2Nlc3MoY29uc3QgV2ViU2VyaWFsaXplZFNj cmlwdFZhbHVlJiwgY29uc3QgV2ViSURCS2V5JiwgY29uc3QgV2ViSURCS2V5UGF0aCYpIHsgV0VC S0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CisgICAgdmlydHVhbCB2b2lkIG9uU3VjY2Vzcyhs b25nIGxvbmcpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CisgICAgdmlydHVhbCB2 b2lkIG9uU3VjY2VzcygpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAgICAgdmly dHVhbCB2b2lkIG9uU3VjY2Vzcyhjb25zdCBXZWJJREJLZXkmIGtleSwgY29uc3QgV2ViSURCS2V5 JiBwcmltYXJ5S2V5LCBjb25zdCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUmKSB7IFdFQktJVF9B U1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkJsb2NrZWQoKSB7IFdF QktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkJsb2NrZWQo bG9uZyBsb25nIG9sZFZlcnNpb24pIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9Cg==