99523 2012-10-16 16:23:40 -0700 HTMLSelectElement::optionSelectedByUser confuses listIndex and optionIndex 2012-10-16 17:47:03 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned darin joepeck mifenton tkent webkit.review.bot oldest_to_newest 743676 0 joepeck 2012-10-16 16:23:40 -0700 HTMLSelectElement::optionSelectedByUser confuses listIndex and optionIndex. This breaks the ObjC binding to select element which call that method directly: -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]. 743682 1 joepeck 2012-10-16 16:30:45 -0700 <rdar://problem/12363971> 743685 2 169054 joepeck 2012-10-16 16:32:03 -0700 Created attachment 169054 [PATCH] Proposed Fix Without the patch, the test fails with the following output: Select multiple indexes, with multi-select on, in a <select multiple> with <optgroup>s. ** change event fired ** ** change event fired ** FAIL - option 0 was not what we expected. FAIL - option 2 was not what we expected. 743728 3 darin 2012-10-16 17:18:01 -0700 Great fix! 743736 4 169054 webkit.review.bot 2012-10-16 17:24:25 -0700 Comment on attachment 169054 [PATCH] Proposed Fix Clearing flags on attachment: 169054 Committed r131534: <http://trac.webkit.org/changeset/131534> 743737 5 webkit.review.bot 2012-10-16 17:24:28 -0700 All reviewed patches have been landed. Closing bug. 743747 6 tkent 2012-10-16 17:47:03 -0700 We should give different types to optionIndex and listIndex. At least typedefs, ideally their own classes... 169054 2012-10-16 16:32:03 -0700 2012-10-16 17:24:25 -0700 [PATCH] Proposed Fix patch-1.patch text/plain 5062 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNmQ1MmMwLi5jMGM4NDdmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAt MTYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBIVE1M U2VsZWN0RWxlbWVudDo6b3B0aW9uU2VsZWN0ZWRCeVVzZXIgY29uZnVzZXMgbGlzdEluZGV4IGFu ZCBvcHRpb25JbmRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTk1MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBFeHRlbmQgdGhlIGRvbSBhY3RpdmF0ZSB0ZXN0IHRvIHRlc3QgY2FsbHMgb24gYSA8c2Vs ZWN0IG11bHRpcGxlPiB3aXRoCisgICAgICAgIDxvcHRncm91cD5zLiBUaGlzIHByZXZpb3VzbHkg dW50ZXN0ZWQgY2FzZSB3YXMgYnJva2VuLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3Qv b2JqYy9kb20taHRtbC1zZWxlY3QtYWN0aXZhdGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBs YXRmb3JtL21hYy9mYXN0L29iamMvZG9tLWh0bWwtc2VsZWN0LWFjdGl2YXRlLmh0bWw6CisKIDIw MTItMTAtMTYgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmViYXNlbGluZXMgZm9yIHIxMzE1MDMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9mYXN0L29iamMvZG9tLWh0bWwtc2VsZWN0LWFjdGl2YXRlLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L29iamMvZG9tLWh0bWwtc2VsZWN0LWFjdGl2YXRl LWV4cGVjdGVkLnR4dAppbmRleCBkNWFlMDFiLi5jNGQyNmZhIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9vYmpjL2RvbS1odG1sLXNlbGVjdC1hY3RpdmF0ZS1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3Qvb2JqYy9kb20taHRt bC1zZWxlY3QtYWN0aXZhdGUtZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEsNCBAQAotICAgICAgCisg ICAgICAgIAogVGhpcyB0ZXN0cyB0aGUgUHJpdmF0ZSBPYmplY3RpdmUtQyBET00gSFRNTCBCaW5k aW5ncyBBUEkgZm9yIHNlbGVjdGluZyBpbmRleGVzIG9mIGEgPHNlbGVjdD4gdGhhdCBhbHNvIGFj dGl2YXRlIHRoZSAiY2hhbmdlIiBldmVudC4KIAogU2VsZWN0IGEgc2luZ2xlIGluZGV4IGluIGEg bm9ybWFsIDxzZWxlY3Q+LgpAQCAtMTksMyArMTksOCBAQCBTZWxlY3QgbXVsdGlwbGUgaW5kZXhl cywgd2l0aCBtdWx0aS1zZWxlY3Qgb24sIGluIGEgPHNlbGVjdCBtdWx0aXBsZT4uCiAqKiBjaGFu Z2UgZXZlbnQgZmlyZWQgKioKIFBBU1MgLSBzZWxlY3RlZCBvcHRpb25zIHdlcmUgd2hhdCB3ZSBl eHBlY3RlZC4KIAorU2VsZWN0IG11bHRpcGxlIGluZGV4ZXMsIHdpdGggbXVsdGktc2VsZWN0IG9u LCBpbiBhIDxzZWxlY3QgbXVsdGlwbGU+IHdpdGggPG9wdGdyb3VwPnMuCisqKiBjaGFuZ2UgZXZl bnQgZmlyZWQgKioKKyoqIGNoYW5nZSBldmVudCBmaXJlZCAqKgorUEFTUyAtIHNlbGVjdGVkIG9w dGlvbnMgd2VyZSB3aGF0IHdlIGV4cGVjdGVkLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvZmFzdC9vYmpjL2RvbS1odG1sLXNlbGVjdC1hY3RpdmF0ZS5odG1sIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3Qvb2JqYy9kb20taHRtbC1zZWxlY3QtYWN0aXZhdGUu aHRtbAppbmRleCA0ZTM3NzUxLi5mMTM0NDc1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvZmFzdC9vYmpjL2RvbS1odG1sLXNlbGVjdC1hY3RpdmF0ZS5odG1sCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L29iamMvZG9tLWh0bWwtc2VsZWN0LWFjdGl2YXRl Lmh0bWwKQEAgLTI3LDYgKzI3LDE3IEBACiAgICAgICAgIDxvcHRpb24+Mjwvb3B0aW9uPgogICAg IDwvc2VsZWN0PgogCisgICAgPHNlbGVjdCBpZD0ibXVsdGlwbGUtMyIgbXVsdGlwbGU+CisgICAg ICAgIDxvcHRncm91cD4KKyAgICAgICAgICAgIDxvcHRpb24+MDwvb3B0aW9uPgorICAgICAgICAg ICAgPG9wdGlvbj4xPC9vcHRpb24+CisgICAgICAgIDwvb3B0Z3JvdXA+CisgICAgICAgIDxvcHRn cm91cD4KKyAgICAgICAgICAgIDxvcHRpb24+Mjwvb3B0aW9uPgorICAgICAgICAgICAgPG9wdGlv bj4zPC9vcHRpb24+CisgICAgICAgIDwvb3B0Z3JvdXA+CisgICAgPC9zZWxlY3Q+CisKICAgICA8 cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KIAogICAgIDxzY3JpcHQ+CkBAIC04MSw2ICs5Miw3IEBA CiAgICAgICAgIHdyYXBwZXIoIlNlbGVjdCBhIHNpbmdsZSBpbmRleCBpbiBhIHNpemVkIDxzZWxl Y3Q+LiIsICJzaXplZCIsIHRlc3RTaXplZCk7CiAgICAgICAgIHdyYXBwZXIoIlNlbGVjdCBtdWx0 aXBsZSBpbmRleGVzLCBpbiBhIDxzZWxlY3QgbXVsdGlwbGU+LiIsICJtdWx0aXBsZS0xIiwgdGVz dE11bHRpcGxlMSk7CiAgICAgICAgIHdyYXBwZXIoIlNlbGVjdCBtdWx0aXBsZSBpbmRleGVzLCB3 aXRoIG11bHRpLXNlbGVjdCBvbiwgaW4gYSA8c2VsZWN0IG11bHRpcGxlPi4iLCAibXVsdGlwbGUt MiIsIHRlc3RNdWx0aXBsZTIpOworICAgICAgICB3cmFwcGVyKCJTZWxlY3QgbXVsdGlwbGUgaW5k ZXhlcywgd2l0aCBtdWx0aS1zZWxlY3Qgb24sIGluIGEgPHNlbGVjdCBtdWx0aXBsZT4gd2l0aCA8 b3B0Z3JvdXA+cy4iLCAibXVsdGlwbGUtMyIsIHRlc3RNdWx0aXBsZTMpOwogICAgIH0KIAogICAg IGZ1bmN0aW9uIHdyYXBwZXIobXNnLCBpZCwgZnVuYykgewpAQCAtMTE1LDYgKzEyNywxMyBAQAog ICAgICAgICBhc3NlcnRTZWxlY3RlZEluZGV4ZXMoZWxlbSwgW2ZhbHNlLCB0cnVlLCB0cnVlXSk7 CiAgICAgfQogCisgICAgZnVuY3Rpb24gdGVzdE11bHRpcGxlMyhlbGVtKSB7CisgICAgICAgIC8v IFRyaWdnZXJzIHNlbGVjdGluZyBpbmRleCAxIHRoZW4gMiwgZXhwZWN0aW5nIHRoZSByZXN1bHQg dG8gYmUgYm90aCBhcmUgc2VsZWN0ZWQuCisgICAgICAgIG9iakNDb250cm9sbGVyLnNldFNlbGVj dEVsZW1lbnRTZWxlY3RlZEluZGV4QWxsb3dpbmdNdWx0aXBsZShlbGVtLCAxLCB0cnVlKTsKKyAg ICAgICAgb2JqQ0NvbnRyb2xsZXIuc2V0U2VsZWN0RWxlbWVudFNlbGVjdGVkSW5kZXhBbGxvd2lu Z011bHRpcGxlKGVsZW0sIDIsIHRydWUpOworICAgICAgICBhc3NlcnRTZWxlY3RlZEluZGV4ZXMo ZWxlbSwgW2ZhbHNlLCB0cnVlLCB0cnVlLCBmYWxzZV0pOworICAgIH0KKwogICAgIDwvc2NyaXB0 PgogPC9ib2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVlNzUxMTcuLjZhYzg1ZmQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMC0xNiAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50OjpvcHRpb25TZWxl Y3RlZEJ5VXNlciBjb25mdXNlcyBsaXN0SW5kZXggYW5kIG9wdGlvbkluZGV4CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTUyMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIHdhcyBhIGNhbGwgc2l0 ZSB3aGVyZSB0aGUgb3B0aW9uSW5kZXggd2FzIGJlaW5nIHBhc3NlZCB0byBhCisgICAgICAgIGZ1 bmN0aW9uIHRoYXQgZXhwZWN0ZWQgdGhlIGxpc3RJbmRleC4gQ29udmVydCBhcHByb3ByaWF0ZWx5 LgorCisgICAgICAgIEV4dGVuZHMgVGVzdDogcGxhdGZvcm0vbWFjL2Zhc3Qvb2JqYy9kb20taHRt bC1zZWxlY3QtYWN0aXZhdGUuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6b3B0aW9uU2VsZWN0 ZWRCeVVzZXIpOgorCiAyMDEyLTEwLTE2ICBOb2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFs QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjEzMTQ4NSk6IEl0IGJyb2tl IHRoZSBidWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxl bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAppbmRl eCAwNGU2MjRmLi45MzZiMWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxT ZWxlY3RFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVt ZW50LmNwcApAQCAtMTA2LDcgKzEwNiw3IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6Om9wdGlv blNlbGVjdGVkQnlVc2VyKGludCBvcHRpb25JbmRleCwgYm9vbCBmaXJlT25DaGFuZ2VOCiAgICAg Ly8gVXNlciBpbnRlcmFjdGlvbiBzdWNoIGFzIG1vdXNlZG93biBldmVudHMgY2FuIGNhdXNlIGxp c3QgYm94IHNlbGVjdCBlbGVtZW50cyB0byBzZW5kIGNoYW5nZSBldmVudHMuCiAgICAgLy8gVGhp cyBwcm9kdWNlcyB0aGF0IHNhbWUgYmVoYXZpb3IgZm9yIGNoYW5nZXMgdHJpZ2dlcmVkIGJ5IG90 aGVyIGNvZGUgcnVubmluZyBvbiBiZWhhbGYgb2YgdGhlIHVzZXIuCiAgICAgaWYgKCF1c2VzTWVu dUxpc3QoKSkgewotICAgICAgICB1cGRhdGVTZWxlY3RlZFN0YXRlKG9wdGlvbkluZGV4LCBhbGxv d011bHRpcGxlU2VsZWN0aW9uLCBmYWxzZSk7CisgICAgICAgIHVwZGF0ZVNlbGVjdGVkU3RhdGUo b3B0aW9uVG9MaXN0SW5kZXgob3B0aW9uSW5kZXgpLCBhbGxvd011bHRpcGxlU2VsZWN0aW9uLCBm YWxzZSk7CiAgICAgICAgIHNldE5lZWRzVmFsaWRpdHlDaGVjaygpOwogICAgICAgICBpZiAoZmly ZU9uQ2hhbmdlTm93KQogICAgICAgICAgICAgbGlzdEJveE9uQ2hhbmdlKCk7Cg==