<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>99507</bug_id>
          
          <creation_ts>2012-10-16 14:08:56 -0700</creation_ts>
          <short_desc>Commit queue tried to land the wrong patch</short_desc>
          <delta_ts>2012-10-16 14:50:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Emil A Eklund">eae</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>743543</commentid>
    <comment_count>0</comment_count>
    <who name="Emil A Eklund">eae</who>
    <bug_when>2012-10-16 14:08:56 -0700</bug_when>
    <thetext>In setting cq+ on bug 99376 the commit queue instead tried to land the patch for bug 99435. Luckily this resulted in a merge conflict preventing it from being landed.

See https://bugs.webkit.org/show_bug.cgi?id=99376 for details and output.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>743570</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-16 14:37:32 -0700</bug_when>
    <thetext>The bug is just that the two patches landed close to each other and the commit-queue didn&apos;t know how to resolve the conflict in the ChangeLog.  We used to have a merge-driver on the bots that knew how to fix these things, but it had other problems.  We just need to teach the bot that it shouldn&apos;t bother trying to resolve conflicts when landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>743578</commentid>
    <comment_count>2</comment_count>
    <who name="Emil A Eklund">eae</who>
    <bug_when>2012-10-16 14:40:57 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; The bug is just that the two patches landed close to each other and the commit-queue didn&apos;t know how to resolve the conflict in the ChangeLog.  We used to have a merge-driver on the bots that knew how to fix these things, but it had other problems.  We just need to teach the bot that it shouldn&apos;t bother trying to resolve conflicts when landing.

Are you sure? It looks a lot like it tried to grab the wrong patch as the file it is complaining about (Tools/ChangeLog) isn&apos;t even in the patch it should have applied.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>743587</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-16 14:48:38 -0700</bug_when>
    <thetext>&gt; Are you sure?

I&apos;m not sure.  I know we see that error message from time to time and it makes me sad.  I&apos;d like to fix it, but I haven&apos;t found the time.  :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>743589</commentid>
    <comment_count>4</comment_count>
    <who name="Emil A Eklund">eae</who>
    <bug_when>2012-10-16 14:50:48 -0700</bug_when>
    <thetext>Sadness :(

Thanks for looking.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>