99497 2012-10-16 13:42:01 -0700 [BlackBerry] calculateInRegionScrollableAreasForPoint should use a ReadOnly HitTest 2012-10-17 07:14:46 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mlattanzio webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 743499 0 mlattanzio 2012-10-16 13:42:01 -0700 void InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint(const WebCore::IntPoint& point) mistakenly passes a second parameter into m_webPage->m_mainFrame->eventHandler()->hitTestResultAtPoint that slows down its hit test by making it not ReadOnly. Since this happens on the hot path to event handling it is important to improve it. 743537 1 169020 mlattanzio 2012-10-16 14:04:38 -0700 Created attachment 169020 Patch 743593 2 169020 tonikitoo 2012-10-16 14:56:59 -0700 Comment on attachment 169020 Patch Doh! Someone changed the API and did not update our usage :/ 743612 3 169020 webkit.review.bot 2012-10-16 15:05:50 -0700 Comment on attachment 169020 Patch Clearing flags on attachment: 169020 Committed r131513: <http://trac.webkit.org/changeset/131513> 743613 4 webkit.review.bot 2012-10-16 15:05:54 -0700 All reviewed patches have been landed. Closing bug. 744225 5 169020 rwlbuis 2012-10-17 07:12:39 -0700 Comment on attachment 169020 Patch LGTM. 169020 2012-10-16 14:04:38 -0700 2012-10-17 07:14:46 -0700 Patch bug-99497-20121016170449.patch text/plain 1953 mlattanzio U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmNjZlMzEyNWIxM2JkNTNhODE2MTU1MmY4YjE2ODU4NGYzNzIzZGIxLi5kZDNjMzZiMzFj MTJlYmRmN2NkNDdjN2UzNGRjNDQ3MjQzM2YzZDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMC0xNiAgTWlrZSBMYXR0YW56aW8gIDxtbGF0 dGFuemlvQHJpbS5jb20+CisKKyAgICAgICAgMjAxMi0xMC0xNiAgTWlrZSBMYXR0YW56aW8gIDxt bGF0dGFuemlvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIGNhbGN1bGF0ZUluUmVn aW9uU2Nyb2xsYWJsZUFyZWFzRm9yUG9pbnQgc2hvdWxkIHVzZSBhIFJlYWRPbmx5IEhpdFRlc3QK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NDk3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNhbGN1 bGF0ZUluUmVnaW9uU2Nyb2xsYWJsZUFyZWFzRm9yUG9pbnQgdG8gdXNlIGEgUmVhZE9ubHkKKyAg ICAgICAgaGl0IHRlc3QgdG8gaW1wcm92ZSBpdHMgcGVyZm9ybWFuY2UuCisKKyAgICAgICAgKiBB cGkvSW5SZWdpb25TY3JvbGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6Oklu UmVnaW9uU2Nyb2xsZXJQcml2YXRlOjpjYWxjdWxhdGVJblJlZ2lvblNjcm9sbGFibGVBcmVhc0Zv clBvaW50KToKKwogMjAxMi0xMC0xNSAgUGV0ZXIgV2FuZyAgPHBldGVyLndhbmdAdG9yY2htb2Jp bGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBXZWIgSW5zcGVjdG9yOiBSZW1vdmUg dGhlIHVzZWxlc3MgcHJlZmVyZW5jZXMgaXRlbXMgaW4gImluc3BlY3RvckJCLmpzIgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyLmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAKaW5kZXgg MzUzMWNiYTBjNmE5MjUzZjcxZjYzZDFjMTc4MzczYjJiZTgxMWQxMC4uY2Q2OGM0Yzc2ZWZlNzE2 ZGRhMDUwY2M3M2EzOTlhMWRmNGMyOTI4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwCkBAIC0yMDIsNyArMjAyLDcgQEAgdm9pZCBJ blJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2FsY3VsYXRlSW5SZWdpb25TY3JvbGxhYmxlQXJlYXNG b3JQb2ludChjb25zdCBXZWIKICAgICBBU1NFUlQobV9hY3RpdmVJblJlZ2lvblNjcm9sbGFibGVB cmVhcy5lbXB0eSgpKTsKICAgICBtX25lZWRzQWN0aXZlU2Nyb2xsYWJsZUFyZWFDYWxjdWxhdGlv biA9IGZhbHNlOwogCi0gICAgSGl0VGVzdFJlc3VsdCByZXN1bHQgPSBtX3dlYlBhZ2UtPm1fbWFp bkZyYW1lLT5ldmVudEhhbmRsZXIoKS0+aGl0VGVzdFJlc3VsdEF0UG9pbnQobV93ZWJQYWdlLT5t YXBGcm9tVmlld3BvcnRUb0NvbnRlbnRzKHBvaW50KSwgZmFsc2UgLyphbGxvd1NoYWRvd0NvbnRl bnQqLyk7CisgICAgSGl0VGVzdFJlc3VsdCByZXN1bHQgPSBtX3dlYlBhZ2UtPm1fbWFpbkZyYW1l LT5ldmVudEhhbmRsZXIoKS0+aGl0VGVzdFJlc3VsdEF0UG9pbnQobV93ZWJQYWdlLT5tYXBGcm9t Vmlld3BvcnRUb0NvbnRlbnRzKHBvaW50KSk7CiAgICAgTm9kZSogbm9kZSA9IHJlc3VsdC5pbm5l ck5vblNoYXJlZE5vZGUoKTsKICAgICBpZiAoIW5vZGUgfHwgIW5vZGUtPnJlbmRlcmVyKCkpCiAg ICAgICAgIHJldHVybjsK