99496 2012-10-16 13:39:10 -0700 Crash in WebCore::Document::webkitExitFullscreen + 618 2014-01-23 20:24:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble eric webkit.review.bot oldest_to_newest 743491 0 jer.noble 2012-10-16 13:39:10 -0700 Crash in WebCore::Document::webkitExitFullscreen + 618 743492 1 jer.noble 2012-10-16 13:39:28 -0700 <rdar://problem/12081388> 743494 2 jer.noble 2012-10-16 13:40:38 -0700 Backtrace: Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00007fff8fd9271a WebCore::Document::webkitExitFullscreen() + 618 1 com.apple.WebCore 0x00007fff8fc101d4 WebCore::Document::webkitCancelFullScreen() + 404 2 com.apple.WebKit2 0x00007fff9432eef1 WebKit::WebConnectionToUIProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) + 179 3 com.apple.WebKit2 0x00007fff9429b715 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&) + 175 4 com.apple.WebKit2 0x00007fff942de403 CoreIPC::Connection::dispatchOneMessage() + 139 5 com.apple.WebCore 0x00007fff9021cc19 WebCore::RunLoop::performWork() + 201 6 com.apple.WebCore 0x00007fff9021d1f7 WebCore::RunLoop::performWork(void*) + 71 7 com.apple.CoreFoundation 0x00007fff8dfe8841 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 8 com.apple.CoreFoundation 0x00007fff8dfe8165 __CFRunLoopDoSources0 + 245 9 com.apple.CoreFoundation 0x00007fff8e00b4e5 __CFRunLoopRun + 789 10 com.apple.CoreFoundation 0x00007fff8e00add2 CFRunLoopRunSpecific + 290 11 com.apple.HIToolbox 0x00007fff8da3a774 RunCurrentEventLoopInMode + 209 12 com.apple.HIToolbox 0x00007fff8da3a512 ReceiveNextEventCommon + 356 13 com.apple.HIToolbox 0x00007fff8da3a3a3 BlockUntilNextEventMatchingListInMode + 62 14 com.apple.AppKit 0x00007fff8cd8efa3 _DPSNextEvent + 685 15 com.apple.AppKit 0x00007fff8cd8e862 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 128 16 com.apple.AppKit 0x00007fff8cd85c03 -[NSApplication run] + 517 17 com.apple.WebCore 0x00007fff9021d5cf WebCore::RunLoop::run() + 63 18 com.apple.WebKit2 0x00007fff943876d0 WebKit::WebProcessMain(WebKit::CommandLine const&) + 2586 19 com.apple.WebKit2 0x00007fff9434f275 WebKitMain + 285 20 com.apple.WebProcess 0x000000010a7dde7b 0x10a7dd000 + 3707 21 libdyld.dylib 0x00007fff969f97e1 start + 1 743501 3 169015 jer.noble 2012-10-16 13:43:01 -0700 Created attachment 169015 Patch 745451 4 169015 webkit.review.bot 2012-10-18 12:03:34 -0700 Comment on attachment 169015 Patch Clearing flags on attachment: 169015 Committed r131785: <http://trac.webkit.org/changeset/131785> 745452 5 webkit.review.bot 2012-10-18 12:03:37 -0700 All reviewed patches have been landed. Closing bug. 971483 6 eric 2014-01-23 20:24:31 -0800 A reproduction for this bug was found when we tried to remove this null-check in Chromium: 1. Go to engadget.com/videos 2. Tap on one of the videos 3. Tap the fullscreen icon 4. Tap the Back key I think this was the wrong fix. It doesn't make sense on the surface for an element to still be fullscreen at a time at which it's document or frame has been disconnected from the Page. Presumably the fullscreen should already have been canceled when the frame or document disconnect happened. We're likely to temporarily add back the null check in Blink code but then find a better way around this. 169015 2012-10-16 13:43:01 -0700 2012-10-18 12:03:33 -0700 Patch bug-99496-20121016134150.patch text/plain 1418 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM1NmIwNTg2MWVlMjU0 YzFlNTFjY2YwYzM5NzgxZGRiODg2MTNiYy4uNjUyZjg3YmMwZjQ2YjBhZWQ0ZjE4MGFiZjFhZDhm MzA1ZGRmNDMyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTE2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6 OkRvY3VtZW50Ojp3ZWJraXRFeGl0RnVsbHNjcmVlbiArIDYxOAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk0OTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9zcGVjdGl2ZSBmaXggZm9yIG51bGwtZGVy ZWZlcmVuY2UgY3Jhc2ggaW4gRG9jdW1lbnQ6OndlYmtpdEV4aXRGdWxsc2NyZWVuKCkuCisKKyAg ICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Ondl YmtpdEV4aXRGdWxsc2NyZWVuKTogTnVsbCBjaGVjayBwYWdlKCkgYmVmb3JlIGNhbGxpbmcgcGFn ZSgpLT5jaHJvbWUuCisKIDIwMTItMTAtMTYgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdv b2dsZS5jb20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBBZGQgdGhlIGNocm9taXVtIEFQ SSBmb3IgUlRDRGF0YUNoYW5uZWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGQxMGU4YWI1 ZTI0NDhiZWU5ZTZjYTg3MWU2ZjhhMzE1MDM2YjM3NTAuLmFmYWNjZDQ5YmIzMmZmNDk5YmQ2NDg1 MzNiMzg1YmUxMjBkZDQ4ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNTIzNCw2ICs1 MjM0LDkgQEAgdm9pZCBEb2N1bWVudDo6d2Via2l0RXhpdEZ1bGxzY3JlZW4oKQogICAgIC8vIDYu IFJldHVybiwgYW5kIHJ1biB0aGUgcmVtYWluaW5nIHN0ZXBzIGFzeW5jaHJvbm91c2x5LgogICAg IC8vIDcuIE9wdGlvbmFsbHksIHBlcmZvcm0gc29tZSBhbmltYXRpb24uCiAKKyAgICBpZiAoIXBh Z2UoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gT25seSBleGl0IG91dCBvZiBmdWxsIHNj cmVlbiB3aW5kb3cgbW9kZSBpZiB0aGVyZSBhcmUgbm8gcmVtYWluaW5nIGVsZW1lbnRzIGluIHRo ZSAKICAgICAvLyBmdWxsIHNjcmVlbiBzdGFjay4KICAgICBpZiAoIW5ld1RvcCkgewo=