99495 2012-10-16 13:25:19 -0700 html5-full-render.html test uses substring but meant substr 2012-10-17 16:49:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99657 1 esprehn esprehn eric jamesr kling rniwa tonyg webkit.review.bot oldest_to_newest 743475 0 esprehn 2012-10-16 13:25:19 -0700 html5-full-render.html test uses substring but meant substr 743476 1 169010 esprehn 2012-10-16 13:26:19 -0700 Created attachment 169010 Patch 743897 2 esprehn 2012-10-16 23:30:45 -0700 For context see: https://bugs.webkit.org/show_bug.cgi?id=95117#c59 743899 3 169010 abarth 2012-10-16 23:32:07 -0700 Comment on attachment 169010 Patch Really Eric should review this patch, but Elliott asked me to look at it and I think Eric is asleep. 743901 4 eric 2012-10-16 23:34:04 -0700 It looks fantastic to me. Aside from teh fact that JS has braindead apis. 743902 5 eric 2012-10-16 23:34:42 -0700 CCing folks who might see the perf bump and be surprised. :) 743906 6 esprehn 2012-10-16 23:42:59 -0700 This reduces the size of the HTML loaded in the test dramatically from 33.5m to 6.5m chars (and subsequently means tens of thousands of fewer DOM nodes) which should create a pretty big "perf win" in the graphs. 743911 7 169010 webkit.review.bot 2012-10-16 23:50:50 -0700 Comment on attachment 169010 Patch Clearing flags on attachment: 169010 Committed r131553: <http://trac.webkit.org/changeset/131553> 743912 8 webkit.review.bot 2012-10-16 23:50:54 -0700 All reviewed patches have been landed. Closing bug. 169010 2012-10-16 13:26:19 -0700 2012-10-16 23:50:50 -0700 Patch bug-99495-20121016132507.patch text/plain 1602 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzc3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ2MzZmNmMyYWZl YzM4YzExZGQ2YmU5OTUxMDg1YTZkMDdkMTEyNzYuLmRhMGJiZmJkNjYyZDk2OWQyZTA4YjUwOTdi ZmRiMjVmMTNjNTU3MzQgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAt MTYgIEVsbGlvdHQgU3ByZWhuICA8ZXNwcmVobkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaHRt bDUtZnVsbC1yZW5kZXIuaHRtbCB0ZXN0IHVzZXMgc3Vic3RyaW5nIGJ1dCBtZWFudCBzdWJzdHIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NDk1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0 IGludGVuZGVkIHRvIGNodW5rIHVwIHRoZSBIVE1MNSBzcGVjIGludG8gY2h1bmtzIG9mIDUwMGsg Y2hhcnMsIGJ1dCB1c2VkCisgICAgICAgIHN1YnN0cmluZyh0byxmcm9tKSBpbnN0ZWFkIG9mIHN1 YnN0cihmcm9tLGxlbmd0aCkgc28gaXQgYWN0dWFsbHkgbG9hZGVkIDV4IG1vcmUKKyAgICAgICAg Y29udGVudCB0aGFuIHdhcyBpbiB0aGUgSFRNTDUgc3BlYy4KKworICAgICAgICAqIFBhcnNlci9o dG1sNS1mdWxsLXJlbmRlci5odG1sOgorCiAyMDEyLTEwLTExICBKYW1lcyBTaW1vbnNlbiAgPHNp bW9uamFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICB1bnByZWZpeCB3aW5kb3cucGVyZm9ybWFu Y2Uud2Via2l0Tm93KCkKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvUGFyc2VyL2h0bWw1 LWZ1bGwtcmVuZGVyLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL1BhcnNlci9odG1sNS1mdWxsLXJl bmRlci5odG1sCmluZGV4IGI1OWU0NGMyNDBkMTE2MWUzZWVjN2Q4NWVlY2E3Y2EwZTBiZDczYmUu Ljk0MjYwNTc3OWZhYjg1ZGM1ZTI4MDAzYWE2OTNhZjc5OWEzYjAzNTEgMTAwNjQ0Ci0tLSBhL1Bl cmZvcm1hbmNlVGVzdHMvUGFyc2VyL2h0bWw1LWZ1bGwtcmVuZGVyLmh0bWwKKysrIGIvUGVyZm9y bWFuY2VUZXN0cy9QYXJzZXIvaHRtbDUtZnVsbC1yZW5kZXIuaHRtbApAQCAtMTMsNyArMTMsNyBA QCB2YXIgY2h1bmtzID0gW107CiB2YXIgY2h1bmtTaXplID0gNTAwMDAwOyAvLyA2LjA5bWIgLyA1 MDBrID0gYXBwcm94IDEzIGNodW5rcyAodGh1cyAxMyBmb3JjZWQgbGF5b3V0cy9zdHlsZSByZXNv bHZlcykuCiB2YXIgY2h1bmtDb3VudCA9IE1hdGguY2VpbChzcGVjLmxlbmd0aCAvIGNodW5rU2l6 ZSk7CiBmb3IgKHZhciBjaHVua0luZGV4ID0gMDsgY2h1bmtJbmRleCA8IGNodW5rQ291bnQ7IGNo dW5rSW5kZXgrKykgewotICAgIHZhciBjaHVuayA9IHNwZWMuc3Vic3RyaW5nKGNodW5rSW5kZXgg KiBjaHVua1NpemUsIGNodW5rU2l6ZSk7CisgICAgdmFyIGNodW5rID0gc3BlYy5zdWJzdHIoY2h1 bmtJbmRleCAqIGNodW5rU2l6ZSwgY2h1bmtTaXplKTsKICAgICBjaHVua3MucHVzaChjaHVuayk7 CiB9CiAK