99489 2012-10-16 12:30:28 -0700 Incorrect embedded SVG image sizing on first load 2012-10-22 07:10:31 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99481 1 fmalita fmalita eric krit pdr rwlbuis schenney webkit.review.bot zimmermann oldest_to_newest 743421 0 168997 fmalita 2012-10-16 12:30:28 -0700 Created attachment 168997 No red should be visible, only a large green rect. This seems to be timing sensitive, so it may take a few tries: when the attached test is first opened in a new tab/window, the embedded SVG image (data:image/svg+xml) is not scaled according to its container transform. 744415 1 fmalita 2012-10-17 10:59:37 -0700 Looks like a race between layout and the image loader: * SVGImageCache::lookupOrCreateBitmapImageForRenderer() needs a m_sizeAndScalesMap entry for the renderer * the only time this is set is from RenderSVGImage::layout() (via updateImageViewport() >> m_imageResource->setContainerSizeForRenderer() >> m_cachedImage->setContainerSizeForRenderer() >> m_svgImageCache->setRequestedSizeAndScales()) The problem is that for this to work, the cached image needs to be present/loaded when RenderSVGImage::layout() is called. If loading finishes after layout, setRequestedSizeAndScales() never gets called. Extending RenderSVGImage::imageChanged() to either force a relayout or just call setRequestedSizeAndScales() should cover this case. 744515 2 169237 fmalita 2012-10-17 12:52:25 -0700 Created attachment 169237 Patch 747096 3 169237 zimmermann 2012-10-21 07:52:52 -0700 Comment on attachment 169237 Patch Good catch! 747514 4 169237 webkit.review.bot 2012-10-22 07:10:28 -0700 Comment on attachment 169237 Patch Clearing flags on attachment: 169237 Committed r132069: <http://trac.webkit.org/changeset/132069> 747515 5 webkit.review.bot 2012-10-22 07:10:31 -0700 All reviewed patches have been landed. Closing bug. 168997 2012-10-16 12:30:28 -0700 2012-10-16 12:30:28 -0700 No red should be visible, only a large green rect. svg-image-size.html text/html 472 fmalita PGh0bWw+Cjxib2R5IHN0eWxlPSJib3JkZXI6IDBweDsgcGFkZGluZzogMHB4OyI+CjxzdmcgeG1s bnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53 My5vcmcvMTk5OS94bGluayIgdmVyc2lvbj0iMS4xIiB3aWR0aD0iNTgwIiBoZWlnaHQ9IjU4MCI+ CiAgPHJlY3Qgd2lkdGg9IjUwMCIgaGVpZ2h0PSI1MDAiIGZpbGw9InJlZCIvPgogIDxnIHRyYW5z Zm9ybT0ic2NhbGUoNSkiPgogICAgPGltYWdlIGlkPSJpbWciIHdpZHRoPSIxMDBweCIgaGVpZ2h0 PSIxMDBweCIgeGxpbms6aHJlZj0iZGF0YTppbWFnZS9zdmcreG1sLAogICAgPHN2ZyB4bWxucz0n aHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnPgogICAgICA8cmVjdCB3aWR0aD0nMTAwJyBoZWln aHQ9JzEwMCcgZmlsbD0nZ3JlZW4nLz4KICAgIDwvc3ZnPgogICAgIi8+CiAgPC9nPgo8L3N2Zz4K PC9ib2R5Pgo8L2h0bWw+Cg== 169237 2012-10-17 12:52:25 -0700 2012-10-22 07:10:28 -0700 Patch bug-99489-20121017155112.patch text/plain 4056 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGVkNTQ1MTQyYzEyYTlm ZTdjYmQxMmQ3OGE4NmU1MWMxYTc3NTgwZS4uODAzYTJlODY5YzhhN2YwZjY3ZDcwNTk4YjRkNzkz NTY4NGZiMGIxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTE3ICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5jb3JyZWN0IGVt YmVkZGVkIFNWRyBpbWFnZSBzaXppbmcgb24gZmlyc3QgbG9hZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk0ODkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJTVkdJbWFnZTo6dXBkYXRlSW1hZ2VW aWV3cG9ydCgpIG11c3QgYmUgY2FsbGVkIGFmdGVyIHRoZSBpbWFnZSBsb2FkZXIgaXMgZmluaXNo ZWQsCisgICAgICAgIHRvIGVuc3VyZSB0aGF0IGEgU1ZHSW1hZ2VDYWNoZTo6U2l6ZUFuZFNjYWxl c01hcCBlbnRyeSBpcyBjcmVhdGVkIGV2ZW4gaWYgbGF5b3V0IGhhcworICAgICAgICBhbHJlYWR5 IGJlZW4gcGVyZm9ybWVkLgorCisgICAgICAgIFRlc3Q6IHN2Zy9jdXN0b20vc3ZnLWltYWdlLWlu aXRpYWwtc2l6ZS5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0ltYWdl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR0ltYWdlOjppbWFnZUNoYW5nZWQpOgor CiAyMDEyLTEwLTE3ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IGRpc3BsYXkgImRpc2Nvbm5lY3RlZCIgbWVzc2FnZSB3aGVu IHJlbW90ZSBkZWJ1Z2dpbmcgdGVybWluYXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3ZnL1JlbmRlclNWR0ltYWdlLmNwcAppbmRleCA1NmJlNWNkNDE2YmNkZTI2ZTBhODU1YmUx YWRjZWEyYjQzZmMwYjk1Li4xMGNiNWRiYzY5ZjVlNWY0N2VmMGM2OGE1NjE0ZTdlNzBmNjBkYzA3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0ltYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0ltYWdlLmNw cApAQCAtMTc4LDYgKzE3OCwxMSBAQCB2b2lkIFJlbmRlclNWR0ltYWdlOjppbWFnZUNoYW5nZWQo V3JhcHBlZEltYWdlUHRyLCBjb25zdCBJbnRSZWN0KikKICAgICAvLyBFdmVudHVhbGx5IG5vdGlm eSBwYXJlbnQgcmVzb3VyY2VzLCB0aGF0IHdlJ3ZlIGNoYW5nZWQuCiAgICAgUmVuZGVyU1ZHUmVz b3VyY2U6Om1hcmtGb3JMYXlvdXRBbmRQYXJlbnRSZXNvdXJjZUludmFsaWRhdGlvbih0aGlzLCBm YWxzZSk7CiAKKyAgICAvLyBVcGRhdGUgdGhlIFNWR0ltYWdlQ2FjaGUgc2l6ZUFuZFNjYWxlcyBl bnRyeSBpbiBjYXNlIGltYWdlIGxvYWRpbmcgZmluaXNoZWQgYWZ0ZXIgbGF5b3V0LgorICAgIC8v IChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk0ODkpCisgICAgbV9v YmplY3RCb3VuZGluZ0JveCA9IEZsb2F0UmVjdCgpOworICAgIHVwZGF0ZUltYWdlVmlld3BvcnQo KTsKKwogICAgIHJlcGFpbnQoKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDU5YjZlNjRiYTY5MGQ0NDJjN2I4ODgz ZDQ0OWNjZGIyZTEyYzRmZTcuLjM4NjFiNWNkMWY4YmQ4NDRhMjI1MGQzMDM4YjBhMzRlNWQwZjcz YjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMC0xNyAgRmxvcmluIE1hbGl0YSAgPGZt YWxpdGFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEluY29ycmVjdCBlbWJlZGRlZCBTVkcgaW1h Z2Ugc2l6aW5nIG9uIGZpcnN0IGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk5NDg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzdmcvY3VzdG9tL3N2Zy1pbWFnZS1pbml0aWFsLXNpemUtZXhwZWN0 ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogc3ZnL2N1c3RvbS9zdmctaW1hZ2UtaW5pdGlhbC1z aXplLmh0bWw6IEFkZGVkLgorCiAyMDEyLTEwLTE3ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWto YWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFtXSzJdW1dUUl0gSW5qZWN0ZWRC dW5kbGVQYWdlOjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKCkgc2hvdWxkIHByaW50 IG9ubHkgZmlsZW5hbWUgcGFydCBvZiBsb2NhbCBVUkxzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9zdmcvY3VzdG9tL3N2Zy1pbWFnZS1pbml0aWFsLXNpemUtZXhwZWN0ZWQuaHRtbCBiL0xheW91 dFRlc3RzL3N2Zy9jdXN0b20vc3ZnLWltYWdlLWluaXRpYWwtc2l6ZS1leHBlY3RlZC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjczMDMwZjZmOWNjYzEwMWU1N2QwMDhjNDNiYjEzMjc5MzEyYTY5OGIKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N2Zy1pbWFnZS1pbml0aWFsLXNp emUtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDggQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+ CisgIDxib2R5IHN0eWxlPSJtYXJnaW46IDBweDsgcGFkZGluZzogMHB4OyI+CisgICAgPHN2ZyB4 bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3 LnczLm9yZy8xOTk5L3hsaW5rIiB2ZXJzaW9uPSIxLjEiIHdpZHRoPSI2MDAiIGhlaWdodD0iNjAw Ij4KKyAgICAgIDxyZWN0IHdpZHRoPSI1MDBweCIgaGVpZ2h0PSI1MDBweCIgZmlsbD0iZ3JlZW4i Lz4KKyAgICA8L3N2Zz4KKyAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvc3ZnL2N1c3RvbS9zdmctaW1hZ2UtaW5pdGlhbC1zaXplLmh0bWwgYi9MYXlvdXRUZXN0cy9z dmcvY3VzdG9tL3N2Zy1pbWFnZS1pbml0aWFsLXNpemUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yMDY3ODRm YThhYzE5MDQ4ZTkwMTg4NjUzZTNlMjA0NjI4OTI1ODU3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvc3ZnL2N1c3RvbS9zdmctaW1hZ2UtaW5pdGlhbC1zaXplLmh0bWwKQEAgLTAsMCAr MSwxNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgPCEtLSBUZXN0IGZvciBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk0ODkgLS0+CisgIDxib2R5IHN0eWxl PSJtYXJnaW46IDBweDsgcGFkZGluZzogMHB4OyI+CisgICAgPHN2ZyB4bWxucz0iaHR0cDovL3d3 dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hs aW5rIiB2ZXJzaW9uPSIxLjEiIHdpZHRoPSI2MDAiIGhlaWdodD0iNjAwIj4KKyAgICAgIDxnIHRy YW5zZm9ybT0ic2NhbGUoNSkiPgorICAgICAgICA8aW1hZ2UgaWQ9ImltZyIgd2lkdGg9IjEwMHB4 IiBoZWlnaHQ9IjEwMHB4IiB4bGluazpocmVmPSJkYXRhOmltYWdlL3N2Zyt4bWwsCisgICAgICAg ICAgPHN2ZyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnPgorICAgICAgICAgICAg PHJlY3Qgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAnIGZpbGw9J2dyZWVuJy8+CisgICAgICAgICAg PC9zdmc+CisgICAgICAgICAgIi8+CisgICAgICA8L2c+CisgICAgPC9zdmc+CisgIDwvYm9keT4K KzwvaHRtbD4K