99488 2012-10-16 12:22:12 -0700 [chromium] Fix a bug that we are using scaled damage rect for plugins inside an iframe 2012-10-16 15:08:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 qinmin webkit-unassigned abarth aelias webkit.review.bot oldest_to_newest 743414 0 qinmin 2012-10-16 12:22:12 -0700 Fix a bug that we are using scaled damage rect for plugins inside an iframe 743423 1 168998 qinmin 2012-10-16 12:33:29 -0700 Created attachment 168998 Patch 743427 2 169000 qinmin 2012-10-16 12:37:41 -0700 Created attachment 169000 Patch 743463 3 169000 abarth 2012-10-16 13:12:23 -0700 Comment on attachment 169000 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169000&action=review Can we write a test for this change? > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:142 > IntRect windowRect = > - IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect))); > + IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect).location()), enclosingIntRect(scaledDamageRect).size()); Can we change this to only call enclosingIntRect(scaledDamageRect) once? Also, there's no reason to have a line break after the = 743559 4 aelias 2012-10-16 14:27:58 -0700 This is for the "old" page scale path which we're planning to do away with as soon as feasible, so I'm not sure it's worth spending time on a test. 743574 5 169000 abarth 2012-10-16 14:38:18 -0700 Comment on attachment 169000 Patch Ok. 743616 6 169000 webkit.review.bot 2012-10-16 15:08:41 -0700 Comment on attachment 169000 Patch Clearing flags on attachment: 169000 Committed r131514: <http://trac.webkit.org/changeset/131514> 743617 7 webkit.review.bot 2012-10-16 15:08:45 -0700 All reviewed patches have been landed. Closing bug. 168998 2012-10-16 12:33:29 -0700 2012-10-16 12:37:39 -0700 Patch bug-99488-20121016123218.patch text/plain 2493 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDc2MjdhNGU0ODRlYTkwYTdjN2VhMTFjOTA3NzgzMDU3ZTA5MjZlZWMuLmRjNDlhYjcxOGJjZjNl MzJlY2Q5MzFiYzNjNDNkMjU4YzdhYjEyMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTAtMTYgIE1pbiBRaW4gIDxxaW5taW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIEZpeCBhIGJ1ZyB0aGF0IHdlIGFyZSB1c2luZyBzY2FsZWQgZGFtYWdlIHJl Y3QgZm9yIHBsdWdpbnMgaW5zaWRlIGFuIGlmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBhIGJ1ZyB3aXRoIGEgcHJldmlvdXMgd2Vi a2l0IHBhdGNoOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0NjgK KyAgICAgICAgSW4gdGhhdCBwYXRjaCwgd2UgaW5jb3JyZWN0bHkgYXBwbGllZCB0aGUgbWFpbiBm cmFtZSdzIHNjYWxlIGZhY3RvciB0byBpbm5lciBpZnJhbWVzLgorICAgICAgICBIb3dldmVyLCB0 aGUgZGFtYWdlUmVjdCBpcyBub3Qgc2NhbGVkIGluc2lkZSBhbiBpRnJhbWUuIFNvIGRvaW5nIHRo ZSBpbnRlcnNlY3Qgd2lsbCByZXRyaWV2ZSB3cm9uZyByZXN1bHQgaGVyZS4KKyAgICAgICAgSW4g V2ViUGx1Z2luQ29udGFpbmVySW1wbDo6Y2FsY3VsYXRlR2VvbWV0cnksIHRoZSB3aW5kb3dSZWN0 IGFsc28gZG9lcyBub3QgYXBwbHkgbWFpbiBmcmFtZSdzIHNjYWxlIGZhY3Rvci4KKworICAgICAg ICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGx1Z2luQ29udGFpbmVySW1wbDo6cGFpbnQpOgorCiAyMDEyLTEwLTE0ICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSBVc2VyU2NyaXB0IGFuZCBVc2VyU3R5bGVT aGVldCB2YWx1ZSBvYmplY3RzIHRoYXQgYXJlIGNvcHlhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IDY4OTE1 NDA1ODNhOGM0YWI5YjhjNjVlNTRhNDliY2Y5YTljZWZlYWUuLmFhOGE4OWU4NmJlMzJhOGQwZmY2 ODQwYjZjZWNlNDZjM2YyYjIxZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCkBAIC0xMTgsNyArMTE4LDcgQEAgdm9p ZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpwYWludChHcmFwaGljc0NvbnRleHQqIGdjLCBjb25z dCBJbnRSZWN0JiBkYW1hZ2VSZWMKICAgICAgICAgcmV0dXJuOwogCiAgICAgRmxvYXRSZWN0IHNj YWxlZERhbWFnZVJlY3QgPSBkYW1hZ2VSZWN0OwotICAgIGZsb2F0IGZyYW1lU2NhbGVGYWN0b3Ig PSBtX2VsZW1lbnQtPmRvY3VtZW50KCktPnBhZ2UoKS0+bWFpbkZyYW1lKCktPmZyYW1lU2NhbGVG YWN0b3IoKTsKKyAgICBmbG9hdCBmcmFtZVNjYWxlRmFjdG9yID0gbV9lbGVtZW50LT5kb2N1bWVu dCgpLT5wYWdlKCktPmZyYW1lKCktPmZyYW1lU2NhbGVGYWN0b3IoKTsKICAgICBzY2FsZWREYW1h Z2VSZWN0LnNjYWxlKGZyYW1lU2NhbGVGYWN0b3IpOwogICAgIHNjYWxlZERhbWFnZVJlY3QubW92 ZSgtZnJhbWVSZWN0KCkueCgpICogKGZyYW1lU2NhbGVGYWN0b3IgLSAxKSwgLWZyYW1lUmVjdCgp LnkoKSAqIChmcmFtZVNjYWxlRmFjdG9yIC0gMSkpOwogCkBAIC0xMzksNyArMTM5LDcgQEAgdm9p ZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpwYWludChHcmFwaGljc0NvbnRleHQqIGdjLCBjb25z dCBJbnRSZWN0JiBkYW1hZ2VSZWMKICAgICBXZWJDYW52YXMqIGNhbnZhcyA9IGdjLT5wbGF0Zm9y bUNvbnRleHQoKS0+Y2FudmFzKCk7CiAKICAgICBJbnRSZWN0IHdpbmRvd1JlY3QgPQotICAgICAg ICBJbnRSZWN0KHZpZXctPmNvbnRlbnRzVG9XaW5kb3coZW5jbG9zaW5nSW50UmVjdChzY2FsZWRE YW1hZ2VSZWN0KSkpOworICAgICAgICBJbnRSZWN0KHZpZXctPmNvbnRlbnRzVG9XaW5kb3coZW5j bG9zaW5nSW50UmVjdChzY2FsZWREYW1hZ2VSZWN0KS5sb2NhdGlvbigpKSwgZW5jbG9zaW5nSW50 UmVjdChzY2FsZWREYW1hZ2VSZWN0KS5zaXplKCkpOwogICAgIG1fd2ViUGx1Z2luLT5wYWludChj YW52YXMsIHdpbmRvd1JlY3QpOwogCiAgICAgZ2MtPnJlc3RvcmUoKTsK 169000 2012-10-16 12:37:41 -0700 2012-10-16 15:08:41 -0700 Patch bug-99488-20121016123630.patch text/plain 2485 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDc2MjdhNGU0ODRlYTkwYTdjN2VhMTFjOTA3NzgzMDU3ZTA5MjZlZWMuLmRjNDlhYjcxOGJjZjNl MzJlY2Q5MzFiYzNjNDNkMjU4YzdhYjEyMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTAtMTYgIE1pbiBRaW4gIDxxaW5taW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIEZpeCBhIGJ1ZyB0aGF0IHdlIGFyZSB1c2luZyBzY2FsZWQgZGFtYWdlIHJl Y3QgZm9yIHBsdWdpbnMgaW5zaWRlIGFuIGlmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBhIGJ1ZyB3aXRoIGEgcHJldmlvdXMgd2Vi a2l0IHBhdGNoOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0NjgK KyAgICAgICAgSW4gdGhhdCBwYXRjaCwgd2UgaW5jb3JyZWN0bHkgYXBwbGllZCB0aGUgbWFpbiBm cmFtZSdzIHNjYWxlIGZhY3RvciB0byBpbm5lciBpZnJhbWVzLgorICAgICAgICBIb3dldmVyLCB0 aGUgZGFtYWdlUmVjdCBpcyBub3Qgc2NhbGVkIGluc2lkZSBhbiBpRnJhbWUuIFNvIGRvaW5nIHRo ZSBpbnRlcnNlY3Qgd2lsbCByZXRyaWV2ZSB3cm9uZyByZXN1bHQgaGVyZS4KKyAgICAgICAgSW4g V2ViUGx1Z2luQ29udGFpbmVySW1wbDo6Y2FsY3VsYXRlR2VvbWV0cnksIHRoZSB3aW5kb3dSZWN0 IGFsc28gZG9lcyBub3QgYXBwbHkgbWFpbiBmcmFtZSdzIHNjYWxlIGZhY3Rvci4KKworICAgICAg ICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGx1Z2luQ29udGFpbmVySW1wbDo6cGFpbnQpOgorCiAyMDEyLTEwLTE0ICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFrZSBVc2VyU2NyaXB0IGFuZCBVc2VyU3R5bGVT aGVldCB2YWx1ZSBvYmplY3RzIHRoYXQgYXJlIGNvcHlhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCmluZGV4IDY4OTE1 NDA1ODNhOGM0YWI5YjhjNjVlNTRhNDliY2Y5YTljZWZlYWUuLmFmMjMwMTFmZmQ3ZWU0ZTI3YjEx MDc1M2Y1MDYyNmQ2YTA2YjI2NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwCkBAIC0xMTgsNyArMTE4LDcgQEAgdm9p ZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpwYWludChHcmFwaGljc0NvbnRleHQqIGdjLCBjb25z dCBJbnRSZWN0JiBkYW1hZ2VSZWMKICAgICAgICAgcmV0dXJuOwogCiAgICAgRmxvYXRSZWN0IHNj YWxlZERhbWFnZVJlY3QgPSBkYW1hZ2VSZWN0OwotICAgIGZsb2F0IGZyYW1lU2NhbGVGYWN0b3Ig PSBtX2VsZW1lbnQtPmRvY3VtZW50KCktPnBhZ2UoKS0+bWFpbkZyYW1lKCktPmZyYW1lU2NhbGVG YWN0b3IoKTsKKyAgICBmbG9hdCBmcmFtZVNjYWxlRmFjdG9yID0gbV9lbGVtZW50LT5kb2N1bWVu dCgpLT5mcmFtZSgpLT5mcmFtZVNjYWxlRmFjdG9yKCk7CiAgICAgc2NhbGVkRGFtYWdlUmVjdC5z Y2FsZShmcmFtZVNjYWxlRmFjdG9yKTsKICAgICBzY2FsZWREYW1hZ2VSZWN0Lm1vdmUoLWZyYW1l UmVjdCgpLngoKSAqIChmcmFtZVNjYWxlRmFjdG9yIC0gMSksIC1mcmFtZVJlY3QoKS55KCkgKiAo ZnJhbWVTY2FsZUZhY3RvciAtIDEpKTsKIApAQCAtMTM5LDcgKzEzOSw3IEBAIHZvaWQgV2ViUGx1 Z2luQ29udGFpbmVySW1wbDo6cGFpbnQoR3JhcGhpY3NDb250ZXh0KiBnYywgY29uc3QgSW50UmVj dCYgZGFtYWdlUmVjCiAgICAgV2ViQ2FudmFzKiBjYW52YXMgPSBnYy0+cGxhdGZvcm1Db250ZXh0 KCktPmNhbnZhcygpOwogCiAgICAgSW50UmVjdCB3aW5kb3dSZWN0ID0KLSAgICAgICAgSW50UmVj dCh2aWV3LT5jb250ZW50c1RvV2luZG93KGVuY2xvc2luZ0ludFJlY3Qoc2NhbGVkRGFtYWdlUmVj dCkpKTsKKyAgICAgICAgSW50UmVjdCh2aWV3LT5jb250ZW50c1RvV2luZG93KGVuY2xvc2luZ0lu dFJlY3Qoc2NhbGVkRGFtYWdlUmVjdCkubG9jYXRpb24oKSksIGVuY2xvc2luZ0ludFJlY3Qoc2Nh bGVkRGFtYWdlUmVjdCkuc2l6ZSgpKTsKICAgICBtX3dlYlBsdWdpbi0+cGFpbnQoY2FudmFzLCB3 aW5kb3dSZWN0KTsKIAogICAgIGdjLT5yZXN0b3JlKCk7Cg==