99484 2012-10-16 11:19:47 -0700 Change WTF_USE_8BIT_TEXTRUN to ENABLE_8BIT_TEXTRUN 2012-10-17 09:00:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin dbates eric leviw mjs webkit.review.bot oldest_to_newest 743337 0 msaboff 2012-10-16 11:19:47 -0700 In changeset <http://trac.webkit.org/changeset/131311>, the test macro WTF_USE_8BIT_TEXTRUN was used to control the use of 8 bit TextRuns. This macro should really be ENABLE_8BIT_TEXTRUN. 743361 1 168988 msaboff 2012-10-16 11:39:19 -0700 Created attachment 168988 Patch 743372 2 168988 eric 2012-10-16 11:46:18 -0700 Comment on attachment 168988 Patch SGTM. Levi should just be aware that he may have to re-base his chromium patch. I'm nto sure this one is so cut-and-dry an "ENABLE" instead of a USE. It isn't really a feature. It's platform-support, which is USE like you originally had it. :) Then again, I don't believe this matters. :) 743674 3 168988 webkit.review.bot 2012-10-16 16:23:15 -0700 Comment on attachment 168988 Patch Clearing flags on attachment: 168988 Committed r131526: <http://trac.webkit.org/changeset/131526> 743675 4 webkit.review.bot 2012-10-16 16:23:18 -0700 All reviewed patches have been landed. Closing bug. 743764 5 tkent 2012-10-16 18:25:01 -0700 Would you add a description of 8BIT_TEXTRUN to https://trac.webkit.org/wiki/FeatureFlags please? 744287 6 msaboff 2012-10-17 09:00:34 -0700 (In reply to comment #5) > Would you add a description of 8BIT_TEXTRUN to https://trac.webkit.org/wiki/FeatureFlags please? Done. 168988 2012-10-16 11:39:19 -0700 2012-10-16 16:23:14 -0700 Patch 99484.patch text/plain 6708 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzE0NzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTE2ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBXVEZfVVNFXzhCSVRfVEVYVFJVTiB0 byBFTkFCTEVfOEJJVF9URVhUUlVOCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05OTQ4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENoYW5nZWQgbWFjcm8gbmFtZSB0byBhbGlnbiB3aXRoIGl0J3MgcHVycG9z ZS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEyLTEwLTE1ICBBbmRyZWFzIEts aW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgV1RGOjpmYXN0RGVsZXRl QWxsVmFsdWVzKCkuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDEzMTQ3NykKKysrIFNvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwMjcsNyArMTAyNyw3IEBA CiAKIC8qQWRkIG90aGVyIHBsYXRmb3JtcyBhcyB0aGV5IHVwZGF0ZSB0aGVpciBwbGF0ZnJvbSBz cGVjaWZpYyBjb2RlIHRvIGhhbmRsZSBUZXh0UnVuJ3Mgd2l0aCA4IGJpdCBkYXRhLiAqLwogI2lm IFBMQVRGT1JNKE1BQykKLSNkZWZpbmUgV1RGX1VTRV84QklUX1RFWFRSVU4gMQorI2RlZmluZSBF TkFCTEVfOEJJVF9URVhUUlVOIDEKICNlbmRpZgogCiAvKiBVc2UgdGhlIFFYbWxTdHJlYW1SZWFk ZXIgaW1wbGVtZW50YXRpb24gZm9yIFhNTERvY3VtZW50UGFyc2VyICovCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMzE0NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMC0xNiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fi b2ZmQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgV1RGX1VTRV84QklUX1RFWFRSVU4gdG8g RU5BQkxFXzhCSVRfVEVYVFJVTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTk0ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDaGFuZ2VkIG1hY3JvIG5hbWUgdG8gYWxpZ24gd2l0aCBpdCdzIHB1cnBvc2Us IHRoZXJlZm9yZSBjaGFuZ2VkIFVTRSg4QklUX1RFWFRSVU4pIHRvIEVOQUJMRSg4QklUX1RFWFRS VU4pLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gIENoYW5nZWQgbWFjcm8gbmFtZSwgbm8gZnVu Y3Rpb25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9UZXh0UnVuLmg6 CisgICAgICAgIChXZWJDb3JlOjpUZXh0UnVuOjpUZXh0UnVuKToKKyAgICAgICAgKFdlYkNvcmU6 OlRleHRSdW46OnN1YlJ1bik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpjb25zdHJ1Y3RUZXh0UnVuKToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDoKKyAgICAgICAgKFJlbmRlckJsb2NrKToKKwog MjAxMi0xMC0xNiAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAg ICAgIFtHU3RyZWFtZXJdIEdzdEJ1ZmZlciByZWYgcmFjZSBpbiBXZWJLaXRXZWJBdWRpb1NyY0xv b3AKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RleHRSdW4uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UZXh0UnVuLmgJKHJl dmlzaW9uIDEzMTQ3NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RleHRS dW4uaAkod29ya2luZyBjb3B5KQpAQCAtNTksNyArNTksNyBAQCBwdWJsaWM6CiAKICAgICB0eXBl ZGVmIHVuc2lnbmVkIFJvdW5kaW5nSGFja3M7CiAKLSNpZiBVU0UoOEJJVF9URVhUUlVOKQorI2lm IEVOQUJMRSg4QklUX1RFWFRSVU4pCiAgICAgVGV4dFJ1bihjb25zdCBMQ2hhciogYywgdW5zaWdu ZWQgbGVuLCBmbG9hdCB4cG9zID0gMCwgZmxvYXQgZXhwYW5zaW9uID0gMCwgRXhwYW5zaW9uQmVo YXZpb3IgZXhwYW5zaW9uQmVoYXZpb3IgPSBBbGxvd1RyYWlsaW5nRXhwYW5zaW9uIHwgRm9yYmlk TGVhZGluZ0V4cGFuc2lvbiwgVGV4dERpcmVjdGlvbiBkaXJlY3Rpb24gPSBMVFIsIGJvb2wgZGly ZWN0aW9uYWxPdmVycmlkZSA9IGZhbHNlLCBib29sIGNoYXJhY3RlclNjYW5Gb3JDb2RlUGF0aCA9 IHRydWUsIFJvdW5kaW5nSGFja3Mgcm91bmRpbmdIYWNrcyA9IFJ1blJvdW5kaW5nIHwgV29yZFJv dW5kaW5nKQogICAgICAgICA6IG1fY2hhcmFjdGVyc0xlbmd0aChsZW4pCiAgICAgICAgICwgbV9s ZW4obGVuKQpAQCAtMTIzLDcgKzEyMyw3IEBAIHB1YmxpYzoKICAgICAgICAgLCBtX2Rpc2FibGVT cGFjaW5nKGZhbHNlKQogICAgICAgICAsIG1fdGFiU2l6ZSgwKQogICAgIHsKLSNpZiBVU0UoOEJJ VF9URVhUUlVOKQorI2lmIEVOQUJMRSg4QklUX1RFWFRSVU4pCiAgICAgICAgIGlmIChtX2NoYXJh Y3RlcnNMZW5ndGggJiYgcy5pczhCaXQoKSkgewogICAgICAgICAgICAgbV9kYXRhLmNoYXJhY3Rl cnM4ID0gcy5jaGFyYWN0ZXJzOCgpOwogICAgICAgICAgICAgbV9pczhCaXQgPSB0cnVlOwpAQCAt MTQzLDcgKzE0Myw3IEBAIHB1YmxpYzoKIAogICAgICAgICBUZXh0UnVuIHJlc3VsdCA9ICp0aGlz OwogCi0jaWYgVVNFKDhCSVRfVEVYVFJVTikKKyNpZiBFTkFCTEUoOEJJVF9URVhUUlVOKQogICAg ICAgICBpZiAoaXM4Qml0KCkpIHsKICAgICAgICAgICAgIHJlc3VsdC5zZXRUZXh0KGRhdGE4KHN0 YXJ0T2Zmc2V0KSwgbGVuZ3RoKTsKICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CkBAIC0xNjYs NyArMTY2LDcgQEAgcHVibGljOgogICAgIGludCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX2xl bjsgfQogICAgIGludCBjaGFyYWN0ZXJzTGVuZ3RoKCkgY29uc3QgeyByZXR1cm4gbV9jaGFyYWN0 ZXJzTGVuZ3RoOyB9CiAKLSNpZiBVU0UoOEJJVF9URVhUUlVOKQorI2lmIEVOQUJMRSg4QklUX1RF WFRSVU4pCiAgICAgdm9pZCBzZXRUZXh0KGNvbnN0IExDaGFyKiBjLCB1bnNpZ25lZCBsZW4pIHsg bV9kYXRhLmNoYXJhY3RlcnM4ID0gYzsgbV9sZW4gPSBsZW47IG1faXM4Qml0ID0gdHJ1ZTt9CiAj ZW5kaWYKICAgICB2b2lkIHNldFRleHQoY29uc3QgVUNoYXIqIGMsIHVuc2lnbmVkIGxlbikgeyBt X2RhdGEuY2hhcmFjdGVyczE2ID0gYzsgbV9sZW4gPSBsZW47IG1faXM4Qml0ID0gZmFsc2U7fQpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAx MzE0NzcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC03NTcxLDcgKzc1NzEsNyBAQCBzdGF0aWMgaW5saW5lIFRleHRSdW4gY29u c3RydWN0VGV4dFJ1bkluCiAgICAgcmV0dXJuIHJ1bjsKIH0KIAotI2lmIFVTRSg4QklUX1RFWFRS VU4pCisjaWYgRU5BQkxFKDhCSVRfVEVYVFJVTikKIFRleHRSdW4gUmVuZGVyQmxvY2s6OmNvbnN0 cnVjdFRleHRSdW4oUmVuZGVyT2JqZWN0KiBjb250ZXh0LCBjb25zdCBGb250JiBmb250LCBjb25z dCBMQ2hhciogY2hhcmFjdGVycywgaW50IGxlbmd0aCwgUmVuZGVyU3R5bGUqIHN0eWxlLCBUZXh0 UnVuOjpFeHBhbnNpb25CZWhhdmlvciBleHBhbnNpb24pCiB7CiAgICAgcmV0dXJuIGNvbnN0cnVj dFRleHRSdW5JbnRlcm5hbChjb250ZXh0LCBmb250LCBjaGFyYWN0ZXJzLCBsZW5ndGgsIHN0eWxl LCBleHBhbnNpb24pOwpAQCAtNzU4NSw3ICs3NTg1LDcgQEAgVGV4dFJ1biBSZW5kZXJCbG9jazo6 Y29uc3RydWN0VGV4dFJ1bihSZQogCiBUZXh0UnVuIFJlbmRlckJsb2NrOjpjb25zdHJ1Y3RUZXh0 UnVuKFJlbmRlck9iamVjdCogY29udGV4dCwgY29uc3QgRm9udCYgZm9udCwgY29uc3QgUmVuZGVy VGV4dCogdGV4dCwgUmVuZGVyU3R5bGUqIHN0eWxlLCBUZXh0UnVuOjpFeHBhbnNpb25CZWhhdmlv ciBleHBhbnNpb24pCiB7Ci0jaWYgVVNFKDhCSVRfVEVYVFJVTikKKyNpZiBFTkFCTEUoOEJJVF9U RVhUUlVOKQogICAgIGlmICh0ZXh0LT5pczhCaXQoKSkKICAgICAgICAgcmV0dXJuIGNvbnN0cnVj dFRleHRSdW5JbnRlcm5hbChjb250ZXh0LCBmb250LCB0ZXh0LT5jaGFyYWN0ZXJzOCgpLCB0ZXh0 LT50ZXh0TGVuZ3RoKCksIHN0eWxlLCBleHBhbnNpb24pOwogICAgIHJldHVybiBjb25zdHJ1Y3RU ZXh0UnVuSW50ZXJuYWwoY29udGV4dCwgZm9udCwgdGV4dC0+Y2hhcmFjdGVyczE2KCksIHRleHQt PnRleHRMZW5ndGgoKSwgc3R5bGUsIGV4cGFuc2lvbik7CkBAIC03NTk3LDcgKzc1OTcsNyBAQCBU ZXh0UnVuIFJlbmRlckJsb2NrOjpjb25zdHJ1Y3RUZXh0UnVuKFJlCiBUZXh0UnVuIFJlbmRlckJs b2NrOjpjb25zdHJ1Y3RUZXh0UnVuKFJlbmRlck9iamVjdCogY29udGV4dCwgY29uc3QgRm9udCYg Zm9udCwgY29uc3QgUmVuZGVyVGV4dCogdGV4dCwgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBs ZW5ndGgsIFJlbmRlclN0eWxlKiBzdHlsZSwgVGV4dFJ1bjo6RXhwYW5zaW9uQmVoYXZpb3IgZXhw YW5zaW9uKQogewogICAgIEFTU0VSVChvZmZzZXQgKyBsZW5ndGggPD0gdGV4dC0+dGV4dExlbmd0 aCgpKTsKLSNpZiBVU0UoOEJJVF9URVhUUlVOKQorI2lmIEVOQUJMRSg4QklUX1RFWFRSVU4pCiAg ICAgaWYgKHRleHQtPmlzOEJpdCgpKQogICAgICAgICByZXR1cm4gY29uc3RydWN0VGV4dFJ1bklu dGVybmFsKGNvbnRleHQsIGZvbnQsIHRleHQtPmNoYXJhY3RlcnM4KCkgKyBvZmZzZXQsIGxlbmd0 aCwgc3R5bGUsIGV4cGFuc2lvbik7CiAgICAgcmV0dXJuIGNvbnN0cnVjdFRleHRSdW5JbnRlcm5h bChjb250ZXh0LCBmb250LCB0ZXh0LT5jaGFyYWN0ZXJzMTYoKSArIG9mZnNldCwgbGVuZ3RoLCBz dHlsZSwgZXhwYW5zaW9uKTsKQEAgLTc2MTAsNyArNzYxMCw3IEBAIFRleHRSdW4gUmVuZGVyQmxv Y2s6OmNvbnN0cnVjdFRleHRSdW4oUmUKIHsKICAgICB1bnNpZ25lZCBsZW5ndGggPSBzdHJpbmcu bGVuZ3RoKCk7CiAKLSNpZiBVU0UoOEJJVF9URVhUUlVOKQorI2lmIEVOQUJMRSg4QklUX1RFWFRS VU4pCiAgICAgaWYgKGxlbmd0aCAmJiBzdHJpbmcuaXM4Qml0KCkpCiAgICAgICAgIHJldHVybiBj b25zdHJ1Y3RUZXh0UnVuSW50ZXJuYWwoY29udGV4dCwgZm9udCwgc3RyaW5nLmNoYXJhY3RlcnM4 KCksIGxlbmd0aCwgc3R5bGUsIGV4cGFuc2lvbiwgZmxhZ3MpOwogICAgIHJldHVybiBjb25zdHJ1 Y3RUZXh0UnVuSW50ZXJuYWwoY29udGV4dCwgZm9udCwgc3RyaW5nLmNoYXJhY3RlcnMoKSwgbGVu Z3RoLCBzdHlsZSwgZXhwYW5zaW9uLCBmbGFncyk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQmxvY2suaAkocmV2aXNpb24gMTMxNDc3KQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAgLTI3Nyw3ICsyNzcsNyBAQCBw dWJsaWM6CiAgICAgc3RhdGljIFRleHRSdW4gY29uc3RydWN0VGV4dFJ1bihSZW5kZXJPYmplY3Qq IGNvbnRleHQsIGNvbnN0IEZvbnQmIGZvbnQsIGNvbnN0IFJlbmRlclRleHQqIHRleHQsIHVuc2ln bmVkIG9mZnNldCwgUmVuZGVyU3R5bGUqIHN0eWxlLAogICAgICAgICBUZXh0UnVuOjpFeHBhbnNp b25CZWhhdmlvciA9IFRleHRSdW46OkFsbG93VHJhaWxpbmdFeHBhbnNpb24gfCBUZXh0UnVuOjpG b3JiaWRMZWFkaW5nRXhwYW5zaW9uKTsKIAotI2lmIFVTRSg4QklUX1RFWFRSVU4pCisjaWYgRU5B QkxFKDhCSVRfVEVYVFJVTikKICAgICBzdGF0aWMgVGV4dFJ1biBjb25zdHJ1Y3RUZXh0UnVuKFJl bmRlck9iamVjdCogY29udGV4dCwgY29uc3QgRm9udCYgZm9udCwgY29uc3QgTENoYXIqIGNoYXJh Y3RlcnMsIGludCBsZW5ndGgsIFJlbmRlclN0eWxlKiBzdHlsZSwKICAgICAgICAgVGV4dFJ1bjo6 RXhwYW5zaW9uQmVoYXZpb3IgPSBUZXh0UnVuOjpBbGxvd1RyYWlsaW5nRXhwYW5zaW9uIHwgVGV4 dFJ1bjo6Rm9yYmlkTGVhZGluZ0V4cGFuc2lvbik7CiAjZW5kaWYK