99482 2012-10-16 11:04:45 -0700 sendResourceLoadCallbacks() is poorly named 2012-10-16 12:45:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth ap webkit.review.bot oldest_to_newest 743318 0 japhet 2012-10-16 11:04:45 -0700 Per https://bugs.webkit.org/show_bug.cgi?id=99366#c5, the name implies that callbacks will be sent, but it is a simple getter. Rename it to shouldSendResourceLoadCallbacks(). 743320 1 168980 japhet 2012-10-16 11:06:57 -0700 Created attachment 168980 patch 743435 2 168980 webkit.review.bot 2012-10-16 12:45:50 -0700 Comment on attachment 168980 patch Clearing flags on attachment: 168980 Committed r131487: <http://trac.webkit.org/changeset/131487> 743436 3 webkit.review.bot 2012-10-16 12:45:53 -0700 All reviewed patches have been landed. Closing bug. 168980 2012-10-16 11:06:57 -0700 2012-10-16 12:45:49 -0700 patch ssrlc.txt text/plain 3078 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTQ3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTE2ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgc2VuZFJlc291cmNlTG9hZENh bGxiYWNrcygpIGlzIHBvb3JseSBuYW1lZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTk0ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbiBib3RoIENhY2hlZFJlc291cmNlIGFuZCBSZXNvdXJjZUxvYWRl ciwgcmVuYW1lIHNlbmRSZXNvdXJjZUxvYWRDYWxsYmFja3MoKQorICAgICAgICB0byBzaG91bGRT ZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCkgdG8gYmV0dGVyIGluZGljYXRlIHRoYXQgaXQgaXMg YSBzaW1wbGUgZ2V0dGVyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2ltcGxlIHJlbmFtaW5n LgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZyYW1lTG9hZGVyOjpsb2FkZWRSZXNvdXJjZUZyb21NZW1vcnlDYWNoZSk6CisgICAgICAgICog bG9hZGVyL1Jlc291cmNlTG9hZGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUxvYWRl cjo6c2hvdWxkU2VuZFJlc291cmNlTG9hZENhbGxiYWNrcyk6CisgICAgICAgICogbG9hZGVyL2Nh Y2hlL0NhY2hlZFJlc291cmNlLmg6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZTo6 c2hvdWxkU2VuZFJlc291cmNlTG9hZENhbGxiYWNrcyk6CisKIDIwMTItMTAtMTYgIFJhcGhhZWwg S3VibyBkYSBDb3N0YSAgPHJhcGhhZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAg ICAgSW1wbGVtZW50IHRlc3RSdW5uZXIuZHVtcFNlbGVjdGlvblJlY3QoKSBpbiBXZWJLaXRUZXN0 UnVubmVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9u IDEzMTQ3MykKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI4OTEsNyArMjg5MSw3IEBACiAgICAgaWYgKCFwYWdlKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBpZiAoIXJlc291cmNlLT5zZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCkg fHwgbV9kb2N1bWVudExvYWRlci0+aGF2ZVRvbGRDbGllbnRBYm91dExvYWQocmVzb3VyY2UtPnVy bCgpKSkKKyAgICBpZiAoIXJlc291cmNlLT5zaG91bGRTZW5kUmVzb3VyY2VMb2FkQ2FsbGJhY2tz KCkgfHwgbV9kb2N1bWVudExvYWRlci0+aGF2ZVRvbGRDbGllbnRBYm91dExvYWQocmVzb3VyY2Ut PnVybCgpKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKCFwYWdlLT5hcmVNZW1vcnlDYWNo ZUNsaWVudENhbGxzRW5hYmxlZCgpKSB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2Fj aGUvQ2FjaGVkUmVzb3VyY2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv Y2FjaGUvQ2FjaGVkUmVzb3VyY2UuaAkocmV2aXNpb24gMTMxNDczKQorKysgU291cmNlL1dlYkNv cmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxMCw3 ICsyMTAsNyBAQAogICAgIGJvb2wgZXJyb3JPY2N1cnJlZCgpIGNvbnN0IHsgcmV0dXJuIChtX3N0 YXR1cyA9PSBMb2FkRXJyb3IgfHwgbV9zdGF0dXMgPT0gRGVjb2RlRXJyb3IpOyB9CiAgICAgYm9v bCBsb2FkRmFpbGVkT3JDYW5jZWxlZCgpIHsgcmV0dXJuIG1fc3RhdHVzID09IENhbmNlbGVkIHx8 IG1fc3RhdHVzID09IExvYWRFcnJvcjsgfQogCi0gICAgYm9vbCBzZW5kUmVzb3VyY2VMb2FkQ2Fs bGJhY2tzKCkgY29uc3QgeyByZXR1cm4gbV9vcHRpb25zLnNlbmRMb2FkQ2FsbGJhY2tzID09IFNl bmRDYWxsYmFja3M7IH0KKyAgICBib29sIHNob3VsZFNlbmRSZXNvdXJjZUxvYWRDYWxsYmFja3Mo KSBjb25zdCB7IHJldHVybiBtX29wdGlvbnMuc2VuZExvYWRDYWxsYmFja3MgPT0gU2VuZENhbGxi YWNrczsgfQogICAgIAogICAgIHZpcnR1YWwgdm9pZCBkZXN0cm95RGVjb2RlZERhdGEoKSB7IH0K IApJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmgJKHJldmlzaW9uIDEz MTQ3MykKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5oCSh3b3JraW5n IGNvcHkpCkBAIC0xMzksNyArMTM5LDcgQEAKIAogICAgICAgICBjb25zdCBLVVJMJiB1cmwoKSBj b25zdCB7IHJldHVybiBtX3JlcXVlc3QudXJsKCk7IH0gCiAgICAgICAgIFJlc291cmNlSGFuZGxl KiBoYW5kbGUoKSBjb25zdCB7IHJldHVybiBtX2hhbmRsZS5nZXQoKTsgfQotICAgICAgICBib29s IHNlbmRSZXNvdXJjZUxvYWRDYWxsYmFja3MoKSBjb25zdCB7IHJldHVybiBtX29wdGlvbnMuc2Vu ZExvYWRDYWxsYmFja3MgPT0gU2VuZENhbGxiYWNrczsgfQorICAgICAgICBib29sIHNob3VsZFNl bmRSZXNvdXJjZUxvYWRDYWxsYmFja3MoKSBjb25zdCB7IHJldHVybiBtX29wdGlvbnMuc2VuZExv YWRDYWxsYmFja3MgPT0gU2VuZENhbGxiYWNrczsgfQogCiAgICAgICAgIGJvb2wgcmVhY2hlZFRl cm1pbmFsU3RhdGUoKSBjb25zdCB7IHJldHVybiBtX3JlYWNoZWRUZXJtaW5hbFN0YXRlOyB9CiAK