99426 2012-10-16 00:27:37 -0700 Web Inspector: NMI Instrument InspectorOverlay. It costs us ~9Mb because it creates page size canvas. 2012-10-16 00:57:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo alph apavlov bweinstein caseq keishi loislo pfeldman pmuellr vsevik yurys oldest_to_newest 742889 0 loislo 2012-10-16 00:27:37 -0700 We also need to fix InspectorOverlay in a separate patch. The canvas has to be created on demand and released when it is not required. 742894 1 168876 loislo 2012-10-16 00:31:28 -0700 Created attachment 168876 Patch 742907 2 168876 yurys 2012-10-16 00:47:02 -0700 Comment on attachment 168876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168876&action=review > Source/WebCore/ChangeLog:8 > + We also need to fix InspectorOverlay in a separate patch. Please describe here what was instrumented not only what has to be done. 742913 3 loislo 2012-10-16 00:57:48 -0700 Committed r131423: <http://trac.webkit.org/changeset/131423> 168876 2012-10-16 00:31:28 -0700 2012-10-16 00:47:02 -0700 Patch bug-99426-20121016113017.patch text/plain 4477 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM3YmQ4NTQ0NTFiZDhl OTZmOWRmZmI3MDNlOWZjYWRlNzA5MjVjYy4uZjkwYTRiZGMyYjU5MDc3YTJhOGJmMzdlYWRlODc1 YjExOTE0YWNhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTE2ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBOTUkgSW5zdHJ1bWVudCBJbnNwZWN0b3JPdmVybGF5LiBJdCBjb3N0cyB1cyB+OU1iIGJl Y2F1c2UgaXQgY3JlYXRlcyBwYWdlIHNpemUgY2FudmFzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTk0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhbHNvIG5lZWQgdG8gZml4IEluc3BlY3Rvck92 ZXJsYXkgaW4gYSBzZXBhcmF0ZSBwYXRjaC4KKworICAgICAgICAqIGRvbS9XZWJDb3JlTWVtb3J5 SW5zdHJ1bWVudGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGRvbS9X ZWJDb3JlTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmg6CisgICAgICAgIChXZWJDb3JlTWVtb3J5VHlw ZXMpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OnJlcG9ydE1lbW9yeVVzYWdlKToKKyAgICAgICAg KFdlYkNvcmUpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5Lmg6CisgICAg ICAgIChJbnNwZWN0b3JPdmVybGF5KToKKwogMjAxMi0xMC0xNSAgWXVyeSBTZW1pa2hhdHNreSAg PHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZXN0b3JlIHdh dGNoIGV4cHJlc3Npb24gZXhwYW5zaW9uIHN0YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vV2ViQ29yZU1lbW9yeUluc3RydW1lbnRhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9k b20vV2ViQ29yZU1lbW9yeUluc3RydW1lbnRhdGlvbi5jcHAKaW5kZXggY2Q0Njk4MDcwNGRmYTdk ZTk0MGJmYWMzNmVhNDY2NmYwZWI4MzYwOS4uYzVjYmJjZGI0NDdhZGQyMjJkNjhlODlkNjg0MzY1 YTMyMjI4MTMwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1dlYkNvcmVNZW1vcnlJ bnN0cnVtZW50YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJDb3JlTWVtb3J5 SW5zdHJ1bWVudGF0aW9uLmNwcApAQCAtNTcsNiArNTcsNyBAQCBNZW1vcnlPYmplY3RUeXBlIFdl YkNvcmVNZW1vcnlUeXBlczo6SW5zcGVjdG9yQ29udHJvbGxlciA9ICJXZWJJbnNwZWN0b3IuQ29u dHJvbAogTWVtb3J5T2JqZWN0VHlwZSBXZWJDb3JlTWVtb3J5VHlwZXM6Okluc3BlY3Rvck1lbW9y eUFnZW50ID0gIldlYkluc3BlY3Rvci5NZW1vcnlBZ2VudCI7CiBNZW1vcnlPYmplY3RUeXBlIFdl YkNvcmVNZW1vcnlUeXBlczo6SW5zcGVjdG9yRE9NU3RvcmFnZUFnZW50ID0gIldlYkluc3BlY3Rv ci5ET01TdG9yYWdlQWdlbnQiOwogTWVtb3J5T2JqZWN0VHlwZSBXZWJDb3JlTWVtb3J5VHlwZXM6 Okluc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZXMgPSAiV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VB Z2VudC5SZXNvdXJjZXMiOworTWVtb3J5T2JqZWN0VHlwZSBXZWJDb3JlTWVtb3J5VHlwZXM6Oklu c3BlY3Rvck92ZXJsYXkgPSAiV2ViSW5zcGVjdG9yLk92ZXJsYXkiOwogTWVtb3J5T2JqZWN0VHlw ZSBXZWJDb3JlTWVtb3J5VHlwZXM6Okluc3BlY3RvclByb2ZpbGVyQWdlbnQgPSAiV2ViSW5zcGVj dG9yLlByb2ZpbGVyQWdlbnQiOwogCiBNZW1vcnlPYmplY3RUeXBlIFdlYkNvcmVNZW1vcnlUeXBl czo6SlNIZWFwVXNlZCA9ICJKU0hlYXAuVXNlZCI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vV2ViQ29yZU1lbW9yeUluc3RydW1lbnRhdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvZG9t L1dlYkNvcmVNZW1vcnlJbnN0cnVtZW50YXRpb24uaAppbmRleCA4MGQzY2FiZGI2NzJjNDEwNDRk YTFiMWFiYmRlMDU0MmY5NmI5OWE3Li4wOGFiYmU5NzViZGU5M2FiNDU3MTk5YWJjODZhOTQ3MzU2 NmQ5YzAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vV2ViQ29yZU1lbW9yeUluc3Ry dW1lbnRhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9XZWJDb3JlTWVtb3J5SW5zdHJ1 bWVudGF0aW9uLmgKQEAgLTY1LDYgKzY1LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBNZW1vcnlP YmplY3RUeXBlIEluc3BlY3Rvck1lbW9yeUFnZW50OwogICAgIHN0YXRpYyBNZW1vcnlPYmplY3RU eXBlIEluc3BlY3RvckRPTVN0b3JhZ2VBZ2VudDsKICAgICBzdGF0aWMgTWVtb3J5T2JqZWN0VHlw ZSBJbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2VzOworICAgIHN0YXRpYyBNZW1vcnlPYmplY3RU eXBlIEluc3BlY3Rvck92ZXJsYXk7CiAgICAgc3RhdGljIE1lbW9yeU9iamVjdFR5cGUgSW5zcGVj dG9yUHJvZmlsZXJBZ2VudDsKIAogICAgIHN0YXRpYyBNZW1vcnlPYmplY3RUeXBlIEpTSGVhcFVz ZWQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3Zlcmxh eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKaW5k ZXggNzA2ODE0MTNjMmIwMjVhMTFhNjVjODdkYzRhOWU3ZThkNzhiNzViZS4uYjE0MWExNjA0YTI2 MTYzMzkwNmE0NjY4MmI3NjhlMjcwYmRjZDdmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcApAQCAtNTAsNiArNTAsNyBAQAogI2luY2x1ZGUgIlNj cmlwdFZhbHVlLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJTdHlsZWRFbGVt ZW50LmgiCisjaW5jbHVkZSAiV2ViQ29yZU1lbW9yeUluc3RydW1lbnRhdGlvbi5oIgogI2luY2x1 ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAt NDk5LDYgKzUwMCwyMCBAQCB2b2lkIEluc3BlY3Rvck92ZXJsYXk6OmV2YWx1YXRlSW5PdmVybGF5 KGNvbnN0IFN0cmluZyYgbWV0aG9kLCBQYXNzUmVmUHRyPEluc3BlYwogICAgIG92ZXJsYXlQYWdl KCktPm1haW5GcmFtZSgpLT5zY3JpcHQoKS0+ZXZhbHVhdGUoU2NyaXB0U291cmNlQ29kZShtYWtl U3RyaW5nKCJkaXNwYXRjaCgiLCBjb21tYW5kLT50b0pTT05TdHJpbmcoKSwgIikiKSkpOwogfQog Cit2b2lkIEluc3BlY3Rvck92ZXJsYXk6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdElu Zm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0Cit7CisgICAgTWVtb3J5Q2xhc3NJbmZvIGluZm8o bWVtb3J5T2JqZWN0SW5mbywgdGhpcywgV2ViQ29yZU1lbW9yeVR5cGVzOjpJbnNwZWN0b3JPdmVy bGF5KTsKKyAgICBpbmZvLmFkZE1lbWJlcihtX3BhZ2UpOworICAgIGluZm8uYWRkTWVtYmVyKG1f Y2xpZW50KTsKKyAgICBpbmZvLmFkZE1lbWJlcihtX3BhdXNlZEluRGVidWdnZXJNZXNzYWdlKTsK KyAgICBpbmZvLmFkZE1lbWJlcihtX2hpZ2hsaWdodE5vZGUpOworICAgIGluZm8uYWRkTWVtYmVy KG1fbm9kZUhpZ2hsaWdodENvbmZpZyk7CisgICAgaW5mby5hZGRNZW1iZXIobV9oaWdobGlnaHRS ZWN0KTsKKyAgICBpbmZvLmFkZE1lbWJlcihtX292ZXJsYXlQYWdlKTsKKyAgICBpbmZvLmFkZE1l bWJlcihtX3JlY3RIaWdobGlnaHRDb25maWcpOworICAgIGluZm8uYWRkTWVtYmVyKG1fc2l6ZSk7 Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShJTlNQRUNU T1IpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3Zlcmxh eS5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuaAppbmRleCA1 NmY4M2JiN2JiNTE4YjA1NDk2Y2E5MDgwMzQzZWEzYjkzNGU2NGNjLi5iMzUxZjllMWUxNzYwMTc5 NDY4ZTFhMTIyZjhhMmI5ZTliMmJmZmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JPdmVybGF5LmgKQEAgLTExMCw2ICsxMTAsOCBAQCBwdWJsaWM6CiAKICAgICBOb2Rl KiBoaWdobGlnaHRlZE5vZGUoKSBjb25zdDsKIAorICAgIHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2Uo TWVtb3J5T2JqZWN0SW5mbyopIGNvbnN0OworCiBwcml2YXRlOgogICAgIEluc3BlY3Rvck92ZXJs YXkoUGFnZSosIEluc3BlY3RvckNsaWVudCopOwogCg==