99425 2012-10-16 00:12:27 -0700 Remove unused functions in Locale* classes 2012-10-16 00:30:01 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent yutak oldest_to_newest 742881 0 tkent 2012-10-16 00:12:27 -0700 Remove unused functions in Locale* classes 742883 1 168874 tkent 2012-10-16 00:15:44 -0700 Created attachment 168874 Patch 742887 2 168874 yutak 2012-10-16 00:23:04 -0700 Comment on attachment 168874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168874&action=review Looks fine except for a typo. > Source/WebCore/ChangeLog:11 > + No new tests. This shouldn't change any bahevior. nit: bahevior -> behavior 742888 3 168874 tkent 2012-10-16 00:24:47 -0700 Comment on attachment 168874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168874&action=review >> Source/WebCore/ChangeLog:11 >> + No new tests. This shouldn't change any bahevior. > > nit: bahevior -> behavior oops. will fix. 742893 4 tkent 2012-10-16 00:30:01 -0700 Committed r131422: <http://trac.webkit.org/changeset/131422> 168874 2012-10-16 00:15:44 -0700 2012-10-16 00:24:47 -0700 Patch bug-99425-20121016161433.patch text/plain 5520 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjJjYzkxOWQ3M2M5ZDU3 YmExOGVkZmM2OWExNDMwYmQxZjJkYjgyYi4uODMwNWIxYWYxNGJmODk0MTdmMjdlNmNkNTIyODVj NDc1ZGFiZWI3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTE2ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGZ1 bmN0aW9ucyBpbiBMb2NhbGUqIGNsYXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk5NDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTG9jYWxlKjo6Y3VycmVudExvY2FsZSBoYXMgYmVlbiB1bnVzZWQg c2luY2UgTG9jYWxpemVkRGF0ZSogYW5kCisgICAgICAgIExvY2FsaXplZE51bWJlciogd2VyZSBy ZW1vdmVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBzaG91bGRuJ3QgY2hhbmdlIGFu eSBiYWhldmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcDogUmVt b3ZlIGNyZWF0ZUZvckN1cnJlbnRMb2NhbGUgYW5kIGN1cnJlbnRMb2NhbGUuCisgICAgICAgICog cGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuaDogRGl0dG8uCisgICAgICAgICogcGxhdGZvcm0vdGV4 dC9Mb2NhbGVXaW4uY3BwOiBSZW1vdmUgY3VycmVudExvY2FsZS4KKyAgICAgICAgKiBwbGF0Zm9y bS90ZXh0L0xvY2FsZVdpbi5oOiBEaXR0by4KKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L21hYy9M b2NhbGVNYWMuaDogUmVtb3ZlIGN1cnJlbnRMb2NhbGUuCisgICAgICAgICogcGxhdGZvcm0vdGV4 dC9tYWMvTG9jYWxlTWFjLm1tOiBEaXR0by4KKwogMjAxMi0xMC0xNSAgS2VudCBUYW11cmEgIDx0 a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHNvbWUgYXBwZWFyYW5jZSBnbGl0Y2hl cyBvZiBtdWx0aXBsZSBmaWVsZHMgaW5wdXQgZWxlbWVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvTG9jYWxlSUNVLmNwcAppbmRleCA0ODMzODdhNTQ5YTZmMWYxZDA1ZWJkNWIxYjA0 MDA3YjFkZDc5NDE1Li4yODZmMmYxOWI2ZTllZTk1OWMwNDAzYmJhMTA4MmExM2ZkYzE4MDBiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuY3BwCkBAIC04MCwxNyAr ODAsNiBAQCBQYXNzT3duUHRyPExvY2FsZUlDVT4gTG9jYWxlSUNVOjpjcmVhdGUoY29uc3QgY2hh ciogbG9jYWxlU3RyaW5nKQogICAgIHJldHVybiBhZG9wdFB0cihuZXcgTG9jYWxlSUNVKGxvY2Fs ZVN0cmluZykpOwogfQogCi1QYXNzT3duUHRyPExvY2FsZUlDVT4gTG9jYWxlSUNVOjpjcmVhdGVG b3JDdXJyZW50TG9jYWxlKCkKLXsKLSAgICByZXR1cm4gYWRvcHRQdHIobmV3IExvY2FsZUlDVSgw KSk7Ci19Ci0KLUxvY2FsZUlDVSogTG9jYWxlSUNVOjpjdXJyZW50TG9jYWxlKCkKLXsKLSAgICBz dGF0aWMgTG9jYWxlSUNVKiBjdXJyZW50TG9jYWxlID0gTG9jYWxlSUNVOjpjcmVhdGVGb3JDdXJy ZW50TG9jYWxlKCkubGVha1B0cigpOwotICAgIHJldHVybiBjdXJyZW50TG9jYWxlOwotfQotCiBT dHJpbmcgTG9jYWxlSUNVOjpkZWNpbWFsU3ltYm9sKFVOdW1iZXJGb3JtYXRTeW1ib2wgc3ltYm9s KQogewogICAgIFVFcnJvckNvZGUgc3RhdHVzID0gVV9aRVJPX0VSUk9SOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmgKaW5kZXggOTA4MjU2NzZjNGI5MjAwMTlhZWVmMTYw ZGY1ODNmNGU1MTFiZjVhNi4uYjYwNzM0ZDQxNGFmMDk2MTczZTgzMDg2MjhjZTQyN2QxZjczMTRm YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5oCkBAIC00Nyw3ICs0 Nyw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIExvY2FsZUlDVSA6IHB1YmxpYyBMb2Nh bGl6ZXIgewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzT3duUHRyPExvY2FsZUlDVT4gY3JlYXRl KGNvbnN0IGNoYXIqIGxvY2FsZVN0cmluZyk7Ci0gICAgc3RhdGljIExvY2FsZUlDVSogY3VycmVu dExvY2FsZSgpOwogICAgIHZpcnR1YWwgfkxvY2FsZUlDVSgpOwogCiAgICAgLy8gRm9yIExvY2Fs aXplZERhdGUKQEAgLTcwLDcgKzY5LDYgQEAgcHVibGljOgogI2VuZGlmCiAKIHByaXZhdGU6Ci0g ICAgc3RhdGljIFBhc3NPd25QdHI8TG9jYWxlSUNVPiBjcmVhdGVGb3JDdXJyZW50TG9jYWxlKCk7 CiAgICAgZXhwbGljaXQgTG9jYWxlSUNVKGNvbnN0IGNoYXIqKTsKICAgICBTdHJpbmcgZGVjaW1h bFN5bWJvbChVTnVtYmVyRm9ybWF0U3ltYm9sKTsKICAgICBTdHJpbmcgZGVjaW1hbFRleHRBdHRy aWJ1dGUoVU51bWJlckZvcm1hdFRleHRBdHRyaWJ1dGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVXaW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9Mb2NhbGVXaW4uY3BwCmluZGV4IDgwYWExZTg1ZjU2NWMwYTc4ZjI4MDBlNjFhNjcx YzUzZTA4ZDM2MWYuLjQ0NGUxNTZhNDg5ZmY5ODk5ZWQyYjI5N2M5YWRhYjc5ZjFkZmEzNzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlV2luLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZVdpbi5jcHAKQEAgLTExOSwxMiAr MTE5LDYgQEAgUGFzc093blB0cjxMb2NhbGVXaW4+IExvY2FsZVdpbjo6Y3JlYXRlKExDSUQgbGNp ZCkKICAgICByZXR1cm4gYWRvcHRQdHIobmV3IExvY2FsZVdpbihsY2lkKSk7CiB9CiAKLUxvY2Fs ZVdpbiogTG9jYWxlV2luOjpjdXJyZW50TG9jYWxlKCkKLXsKLSAgICBzdGF0aWMgTG9jYWxlV2lu KiBjdXJyZW50TG9jYWxlID0gTG9jYWxlV2luOjpjcmVhdGUoTENJREZyb21Mb2NhbGUoZGVmYXVs dExhbmd1YWdlKCkpKS5sZWFrUHRyKCk7Ci0gICAgcmV0dXJuIGN1cnJlbnRMb2NhbGU7Ci19Ci0K IExvY2FsZVdpbjo6fkxvY2FsZVdpbigpCiB7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZVdpbi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9Mb2NhbGVXaW4uaAppbmRleCBlYzIxODA3YzU2NGZhMzE1ZTRjNzlkMmZiYTc4YjMxMzNhNzRk ZWYyLi5lZDA0MjYyYWI5NWMzMmFlYzEwOGExMzU1YmZmNzg4YTE1MTdhMTRhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZVdpbi5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlV2luLmgKQEAgLTQ1LDcgKzQ1LDYgQEAgc3RydWN0 IERhdGVGb3JtYXRUb2tlbjsKIGNsYXNzIExvY2FsZVdpbiA6IHB1YmxpYyBMb2NhbGl6ZXIgewog cHVibGljOgogICAgIHN0YXRpYyBQYXNzT3duUHRyPExvY2FsZVdpbj4gY3JlYXRlKExDSUQpOwot ICAgIHN0YXRpYyBMb2NhbGVXaW4qIGN1cnJlbnRMb2NhbGUoKTsKICAgICB+TG9jYWxlV2luKCk7 CiAgICAgdmlydHVhbCBkb3VibGUgcGFyc2VEYXRlVGltZShjb25zdCBTdHJpbmcmLCBEYXRlQ29t cG9uZW50czo6VHlwZSkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBTdHJpbmcgZm9ybWF0RGF0ZVRp bWUoY29uc3QgRGF0ZUNvbXBvbmVudHMmLCBGb3JtYXRUeXBlID0gRm9ybWF0VHlwZVVuc3BlY2lm aWVkKSBPVkVSUklERTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv bWFjL0xvY2FsZU1hYy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxl TWFjLmgKaW5kZXggZTY1MDBjZjQyOWFlNDJiNjk2NjZkNmExOGZhMDEwOTk4MWM4MWM4ZC4uOWU2 MGQwMDRhZmVmODU2ODE0OWY4MDg4OWNhN2IxZTBkYTE4OWM1OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vdGV4dC9tYWMvTG9jYWxlTWFjLmgKQEAgLTQ5LDcgKzQ5LDYgQEAgY2xhc3Mg TG9jYWxlTWFjIDogcHVibGljIExvY2FsaXplciB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NP d25QdHI8TG9jYWxlTWFjPiBjcmVhdGUoY29uc3QgU3RyaW5nJik7CiAgICAgc3RhdGljIFBhc3NP d25QdHI8TG9jYWxlTWFjPiBjcmVhdGUoTlNMb2NhbGUqKTsKLSAgICBzdGF0aWMgTG9jYWxlTWFj KiBjdXJyZW50TG9jYWxlKCk7CiAgICAgfkxvY2FsZU1hYygpOwogICAgIHZpcnR1YWwgZG91Ymxl IHBhcnNlRGF0ZVRpbWUoY29uc3QgU3RyaW5nJiwgRGF0ZUNvbXBvbmVudHM6OlR5cGUpIE9WRVJS SURFOwogICAgIHZpcnR1YWwgU3RyaW5nIGZvcm1hdERhdGVUaW1lKGNvbnN0IERhdGVDb21wb25l bnRzJiwgRm9ybWF0VHlwZSA9IEZvcm1hdFR5cGVVbnNwZWNpZmllZCkgT1ZFUlJJREU7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMubW0KaW5kZXggYzg1ZDgx ZWQ3OWFhZTgyNTU4MWRiNmJkZjc1ZmNlODhjYTQxOWQ5YS4uOGJkYTk3ZjdiNGRjYTg4NzkzYjUz N2UxZTA5NjdmNTZlOGU0YmQ5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v dGV4dC9tYWMvTG9jYWxlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv bWFjL0xvY2FsZU1hYy5tbQpAQCAtMTA4LDEyICsxMDgsNiBAQCBQYXNzT3duUHRyPExvY2FsZU1h Yz4gTG9jYWxlTWFjOjpjcmVhdGUoTlNMb2NhbGUqIGxvY2FsZSkKICAgICByZXR1cm4gYWRvcHRQ dHIobmV3IExvY2FsZU1hYyhsb2NhbGUpKTsKIH0KIAotTG9jYWxlTWFjKiBMb2NhbGVNYWM6OmN1 cnJlbnRMb2NhbGUoKQotewotICAgIHN0YXRpYyBMb2NhbGVNYWMqIGN1cnJlbnRMb2NhbGUgPSBu ZXcgTG9jYWxlTWFjKGRldGVybWluZUxvY2FsZShkZWZhdWx0TGFuZ3VhZ2UoKSkpOwotICAgIHJl dHVybiBjdXJyZW50TG9jYWxlOwotfQotCiBSZXRhaW5QdHI8TlNEYXRlRm9ybWF0dGVyPiBMb2Nh bGVNYWM6OnNob3J0RGF0ZUZvcm1hdHRlcigpCiB7CiAgICAgcmV0dXJuIGNyZWF0ZURhdGVUaW1l Rm9ybWF0dGVyKG1fbG9jYWxlLmdldCgpLCBtX2dyZWdvcmlhbkNhbGVuZGFyLmdldCgpLCBOU0Rh dGVGb3JtYXR0ZXJTaG9ydFN0eWxlLCBOU0RhdGVGb3JtYXR0ZXJOb1N0eWxlKTsK